Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 06/17] drm/i915/gem: Merge GGTT vma flush into a single loop
Date: Tue, 19 Nov 2019 12:48:22 +0200	[thread overview]
Message-ID: <874kz0xhu1.fsf@gaia.fi.intel.com> (raw)
In-Reply-To: <20191119100929.2628356-6-chris@chris-wilson.co.uk>

Chris Wilson <chris@chris-wilson.co.uk> writes:

> We only need the one loop to find the dirty vma flush them, and their
> chipset.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> ---
>  drivers/gpu/drm/i915/gem/i915_gem_object.c | 12 +++---------
>  1 file changed, 3 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_object.c b/drivers/gpu/drm/i915/gem/i915_gem_object.c
> index db103d3c8760..63bd3ff84f5e 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_object.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_object.c
> @@ -279,18 +279,12 @@ i915_gem_object_flush_write_domain(struct drm_i915_gem_object *obj,
>  
>  	switch (obj->write_domain) {
>  	case I915_GEM_DOMAIN_GTT:
> -		for_each_ggtt_vma(vma, obj)
> -			intel_gt_flush_ggtt_writes(vma->vm->gt);
> -
> -		intel_frontbuffer_flush(obj->frontbuffer, ORIGIN_CPU);
> -
>  		for_each_ggtt_vma(vma, obj) {
> -			if (vma->iomap)
> -				continue;
> -

Is the story with iomap to just avoid fragility and
go with the same path, even if the flushes would be
superfluous?

-Mika

> -			i915_vma_unset_ggtt_write(vma);
> +			if (i915_vma_unset_ggtt_write(vma))
> +				intel_gt_flush_ggtt_writes(vma->vm->gt);
>  		}
>  
> +		intel_frontbuffer_flush(obj->frontbuffer, ORIGIN_CPU);
>  		break;
>  
>  	case I915_GEM_DOMAIN_WC:
> -- 
> 2.24.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

WARNING: multiple messages have this Message-ID (diff)
From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 06/17] drm/i915/gem: Merge GGTT vma flush into a single loop
Date: Tue, 19 Nov 2019 12:48:22 +0200	[thread overview]
Message-ID: <874kz0xhu1.fsf@gaia.fi.intel.com> (raw)
Message-ID: <20191119104822.U9ojGmv5uvlc7KVS0Ac5l3uhzgJCAKZTK-kMHwdZR7I@z> (raw)
In-Reply-To: <20191119100929.2628356-6-chris@chris-wilson.co.uk>

Chris Wilson <chris@chris-wilson.co.uk> writes:

> We only need the one loop to find the dirty vma flush them, and their
> chipset.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> ---
>  drivers/gpu/drm/i915/gem/i915_gem_object.c | 12 +++---------
>  1 file changed, 3 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_object.c b/drivers/gpu/drm/i915/gem/i915_gem_object.c
> index db103d3c8760..63bd3ff84f5e 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_object.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_object.c
> @@ -279,18 +279,12 @@ i915_gem_object_flush_write_domain(struct drm_i915_gem_object *obj,
>  
>  	switch (obj->write_domain) {
>  	case I915_GEM_DOMAIN_GTT:
> -		for_each_ggtt_vma(vma, obj)
> -			intel_gt_flush_ggtt_writes(vma->vm->gt);
> -
> -		intel_frontbuffer_flush(obj->frontbuffer, ORIGIN_CPU);
> -
>  		for_each_ggtt_vma(vma, obj) {
> -			if (vma->iomap)
> -				continue;
> -

Is the story with iomap to just avoid fragility and
go with the same path, even if the flushes would be
superfluous?

-Mika

> -			i915_vma_unset_ggtt_write(vma);
> +			if (i915_vma_unset_ggtt_write(vma))
> +				intel_gt_flush_ggtt_writes(vma->vm->gt);
>  		}
>  
> +		intel_frontbuffer_flush(obj->frontbuffer, ORIGIN_CPU);
>  		break;
>  
>  	case I915_GEM_DOMAIN_WC:
> -- 
> 2.24.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2019-11-19 10:48 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-19 10:09 [PATCH 01/17] drm/i915/gem: Manually dump the debug trace on GEM_BUG_ON Chris Wilson
2019-11-19 10:09 ` [Intel-gfx] " Chris Wilson
2019-11-19 10:09 ` [PATCH 02/17] drm/i915/gt: Close race between engine_park and intel_gt_retire_requests Chris Wilson
2019-11-19 10:09   ` [Intel-gfx] " Chris Wilson
2019-11-19 10:09 ` [PATCH 03/17] drm/i915/gt: Unlock engine-pm after queuing the kernel context switch Chris Wilson
2019-11-19 10:09   ` [Intel-gfx] " Chris Wilson
2019-11-19 10:09 ` [PATCH 04/17] drm/i915/gt: Make intel_ring_unpin() safe for concurrent pint Chris Wilson
2019-11-19 10:09   ` [Intel-gfx] " Chris Wilson
2019-11-19 16:46   ` Mika Kuoppala
2019-11-19 16:46     ` [Intel-gfx] " Mika Kuoppala
2019-11-19 10:09 ` [PATCH 05/17] drm/i915: Mark up the calling context for intel_wakeref_put() Chris Wilson
2019-11-19 10:09   ` [Intel-gfx] " Chris Wilson
2019-11-19 10:09 ` [PATCH 06/17] drm/i915/gem: Merge GGTT vma flush into a single loop Chris Wilson
2019-11-19 10:09   ` [Intel-gfx] " Chris Wilson
2019-11-19 10:48   ` Mika Kuoppala [this message]
2019-11-19 10:48     ` Mika Kuoppala
2019-11-19 11:17     ` Chris Wilson
2019-11-19 11:17       ` [Intel-gfx] " Chris Wilson
2019-11-19 10:09 ` [PATCH 07/17] drm/i915/gt: Only wait for register chipset flush if active Chris Wilson
2019-11-19 10:09   ` [Intel-gfx] " Chris Wilson
2019-11-19 10:36   ` Mika Kuoppala
2019-11-19 10:36     ` [Intel-gfx] " Mika Kuoppala
2019-11-19 10:09 ` [PATCH 08/17] drm/i915: Protect the obj->vma.list during iteration Chris Wilson
2019-11-19 10:09   ` [Intel-gfx] " Chris Wilson
2019-11-19 10:36   ` Mika Kuoppala
2019-11-19 10:36     ` [Intel-gfx] " Mika Kuoppala
2019-11-19 10:09 ` [PATCH 09/17] drm/i915: Wait until the intel_wakeref idle callback is complete Chris Wilson
2019-11-19 10:09   ` [Intel-gfx] " Chris Wilson
2019-11-19 16:12   ` Mika Kuoppala
2019-11-19 16:12     ` [Intel-gfx] " Mika Kuoppala
2019-11-19 16:35     ` Chris Wilson
2019-11-19 16:35       ` [Intel-gfx] " Chris Wilson
2019-11-19 10:09 ` [PATCH 10/17] drm/i915/gt: Declare timeline.lock to be irq-free Chris Wilson
2019-11-19 10:09   ` [Intel-gfx] " Chris Wilson
2019-11-19 10:09 ` [PATCH 11/17] drm/i915/gt: Move new timelines to the end of active_list Chris Wilson
2019-11-19 10:09   ` [Intel-gfx] " Chris Wilson
2019-11-19 10:09 ` [PATCH 12/17] drm/i915/gt: Schedule next retirement worker first Chris Wilson
2019-11-19 10:09   ` [Intel-gfx] " Chris Wilson
2019-11-19 10:09 ` [PATCH 13/17] drm/i915/gt: Flush the requests after wedging on suspend Chris Wilson
2019-11-19 10:09   ` [Intel-gfx] " Chris Wilson
2019-11-19 10:09 ` [PATCH 14/17] drm/i915/selftests: Force bonded submission to overlap Chris Wilson
2019-11-19 10:09   ` [Intel-gfx] " Chris Wilson
2019-11-19 10:09 ` [PATCH 15/17] drm/i915/selftests: Flush the active callbacks Chris Wilson
2019-11-19 10:09   ` [Intel-gfx] " Chris Wilson
2019-11-19 10:09 ` [PATCH 16/17] drm/i915/selftests: Be explicit in ERR_PTR handling Chris Wilson
2019-11-19 10:09   ` [Intel-gfx] " Chris Wilson
2019-11-19 10:09 ` [PATCH 17/17] drm/i915/selftests: Exercise rc6 handling Chris Wilson
2019-11-19 10:09   ` [Intel-gfx] " Chris Wilson
2019-11-19 15:24   ` Andi Shyti
2019-11-19 15:24     ` [Intel-gfx] " Andi Shyti
2019-11-19 15:27     ` Chris Wilson
2019-11-19 15:27       ` [Intel-gfx] " Chris Wilson
2019-11-19 10:51 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/17] drm/i915/gem: Manually dump the debug trace on GEM_BUG_ON Patchwork
2019-11-19 10:51   ` [Intel-gfx] " Patchwork
2019-11-19 11:35 ` ✓ Fi.CI.BAT: success " Patchwork
2019-11-19 11:35   ` [Intel-gfx] " Patchwork
2019-11-19 14:48 ` ✓ Fi.CI.IGT: " Patchwork
2019-11-19 14:48   ` [Intel-gfx] " Patchwork
2019-11-19 16:23 ` [PATCH 01/17] " Mika Kuoppala
2019-11-19 16:23   ` [Intel-gfx] " Mika Kuoppala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874kz0xhu1.fsf@gaia.fi.intel.com \
    --to=mika.kuoppala@linux.intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox