From: Eric Anholt <eric@anholt.net>
To: Jesse Barnes <jbarnes@virtuousgeek.org>,
Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: clarify IS_GEN vs IS_<product> usage
Date: Tue, 10 May 2011 11:45:54 -0700 [thread overview]
Message-ID: <874o52xul9.fsf@pollan.anholt.net> (raw)
In-Reply-To: <20110509114213.34816211@jbarnes-desktop>
[-- Attachment #1.1: Type: text/plain, Size: 1353 bytes --]
On Mon, 9 May 2011 11:42:13 -0700, Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> On Thu, 05 May 2011 23:57:56 +0100
> Chris Wilson <chris@chris-wilson.co.uk> wrote:
>
> > On Thu, 5 May 2011 15:16:45 -0700, Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> > > We generally use the gen number to indicate the generation of the render
> > > portion of the chip. In some cases this isn't the same as the display
> > > generation (as in the case of G33 and GMA500). So codify the de facto
> > > usage by converting some IS_GEN checks into product specific checks for
> > > display related differences. (Note this makes me wonder about our G33
> > > watermark handling; shouldn't it be like 965 not 945? I don't have one
> > > to test with...).
> >
> > As far as I've been able to tell, the current code works... So it can't
> > be too far wrong, and I don't recall any mention of deviations in the gen3
> > docs.
>
> The gen4 docs mention DevBLC in the FW* reg section though, and
> indicate that it has the same programming interface as Cantiga.
> Unfortunately I don't have one to test with or I'd check whether the
> GM45 code works on G33 as well.
This feels like a lot of churn to me, for the pre-gen4 chipsets at
least. gen2 is always is_830_display (which is overly specific), and
gen3 is always is_i915_display.
[-- Attachment #1.2: Type: application/pgp-signature, Size: 197 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2011-05-10 18:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-05 22:16 [PATCH] drm/i915: clarify IS_GEN vs IS_<product> usage Jesse Barnes
2011-05-05 22:57 ` Chris Wilson
2011-05-09 18:42 ` Jesse Barnes
2011-05-09 19:09 ` Chris Wilson
2011-05-10 18:45 ` Eric Anholt [this message]
2011-05-10 21:24 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874o52xul9.fsf@pollan.anholt.net \
--to=eric@anholt.net \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jbarnes@virtuousgeek.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox