Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Intel-gfx] [PATCH] drm/i915/guc: fix compile issue of guc_klvs_abi.h
@ 2023-08-25  5:00 Linyu Yuan
  2023-08-25  5:37 ` Jani Nikula
                   ` (3 more replies)
  0 siblings, 4 replies; 9+ messages in thread
From: Linyu Yuan @ 2023-08-25  5:00 UTC (permalink / raw)
  To: Jani Nikula, Joonas Lahtinen, Rodrigo Vivi, Tvrtko Ursulin
  Cc: intel-gfx, Linyu Yuan

GCC report GUC_KLV_0_KEY and GUC_KLV_0_LEN is not constant when do
preprocessing.

Change to use GENMASK() to avoid the issue.

Signed-off-by: Linyu Yuan <quic_linyyuan@quicinc.com>
---
 drivers/gpu/drm/i915/gt/uc/abi/guc_klvs_abi.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/gt/uc/abi/guc_klvs_abi.h b/drivers/gpu/drm/i915/gt/uc/abi/guc_klvs_abi.h
index 58012edd4eb0..fd3c16695e5f 100644
--- a/drivers/gpu/drm/i915/gt/uc/abi/guc_klvs_abi.h
+++ b/drivers/gpu/drm/i915/gt/uc/abi/guc_klvs_abi.h
@@ -29,8 +29,8 @@
  */
 
 #define GUC_KLV_LEN_MIN				1u
-#define GUC_KLV_0_KEY				(0xffff << 16)
-#define GUC_KLV_0_LEN				(0xffff << 0)
+#define GUC_KLV_0_KEY				GENMASK(31, 16)
+#define GUC_KLV_0_LEN				GENMASK(15, 0)
 #define GUC_KLV_n_VALUE				(0xffffffff << 0)
 
 /**
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* Re: [Intel-gfx] [PATCH] drm/i915/guc: fix compile issue of guc_klvs_abi.h
  2023-08-25  5:00 [Intel-gfx] [PATCH] drm/i915/guc: fix compile issue of guc_klvs_abi.h Linyu Yuan
@ 2023-08-25  5:37 ` Jani Nikula
  2023-08-25  5:50   ` Linyu Yuan
  2023-08-28 13:37 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for " Patchwork
                   ` (2 subsequent siblings)
  3 siblings, 1 reply; 9+ messages in thread
From: Jani Nikula @ 2023-08-25  5:37 UTC (permalink / raw)
  To: Linyu Yuan, Joonas Lahtinen, Rodrigo Vivi, Tvrtko Ursulin
  Cc: intel-gfx, Linyu Yuan

On Fri, 25 Aug 2023, Linyu Yuan <quic_linyyuan@quicinc.com> wrote:
> GCC report GUC_KLV_0_KEY and GUC_KLV_0_LEN is not constant when do
> preprocessing.

Please paste the actual compiler warning.

BR,
Jani.



>
> Change to use GENMASK() to avoid the issue.
>
> Signed-off-by: Linyu Yuan <quic_linyyuan@quicinc.com>
> ---
>  drivers/gpu/drm/i915/gt/uc/abi/guc_klvs_abi.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/uc/abi/guc_klvs_abi.h b/drivers/gpu/drm/i915/gt/uc/abi/guc_klvs_abi.h
> index 58012edd4eb0..fd3c16695e5f 100644
> --- a/drivers/gpu/drm/i915/gt/uc/abi/guc_klvs_abi.h
> +++ b/drivers/gpu/drm/i915/gt/uc/abi/guc_klvs_abi.h
> @@ -29,8 +29,8 @@
>   */
>  
>  #define GUC_KLV_LEN_MIN				1u
> -#define GUC_KLV_0_KEY				(0xffff << 16)
> -#define GUC_KLV_0_LEN				(0xffff << 0)
> +#define GUC_KLV_0_KEY				GENMASK(31, 16)
> +#define GUC_KLV_0_LEN				GENMASK(15, 0)
>  #define GUC_KLV_n_VALUE				(0xffffffff << 0)
>  
>  /**

-- 
Jani Nikula, Intel Open Source Graphics Center

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [Intel-gfx] [PATCH] drm/i915/guc: fix compile issue of guc_klvs_abi.h
  2023-08-25  5:37 ` Jani Nikula
@ 2023-08-25  5:50   ` Linyu Yuan
  2023-08-28 21:42     ` Michal Wajdeczko
  0 siblings, 1 reply; 9+ messages in thread
From: Linyu Yuan @ 2023-08-25  5:50 UTC (permalink / raw)
  To: Jani Nikula, Joonas Lahtinen, Rodrigo Vivi, Tvrtko Ursulin; +Cc: intel-gfx


On 8/25/2023 1:37 PM, Jani Nikula wrote:
> On Fri, 25 Aug 2023, Linyu Yuan <quic_linyyuan@quicinc.com> wrote:
>> GCC report GUC_KLV_0_KEY and GUC_KLV_0_LEN is not constant when do
>> preprocessing.
> Please paste the actual compiler warning.


   CC      drivers/gpu/drm/i915/gt/uc/intel_guc_submission.o
In file included from <command-line>:0:0:
In function ‘__guc_context_policy_add_priority.isra.47’,
     inlined from ‘__guc_context_set_prio.isra.48’ at 
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:3332:3,
     inlined from ‘guc_context_set_prio’ at 
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:3360:2:
././include/linux/compiler_types.h:397:38: error: call to 
‘__compiletime_assert_1803’ declared with attribute error: FIELD_PREP: 
mask is not constant
   _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
                                       ^
././include/linux/compiler_types.h:378:4: note: in definition of macro 
‘__compiletime_assert’
     prefix ## suffix();    \
     ^~~~~~
././include/linux/compiler_types.h:397:2: note: in expansion of macro 
‘_compiletime_assert’
   _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
   ^~~~~~~~~~~~~~~~~~~
./include/linux/build_bug.h:39:37: note: in expansion of macro 
‘compiletime_assert’
  #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
                                      ^~~~~~~~~~~~~~~~~~
./include/linux/bitfield.h:65:3: note: in expansion of macro 
‘BUILD_BUG_ON_MSG’
    BUILD_BUG_ON_MSG(!__builtin_constant_p(_mask),  \
    ^~~~~~~~~~~~~~~~
./include/linux/bitfield.h:114:3: note: in expansion of macro 
‘__BF_FIELD_CHECK’
    __BF_FIELD_CHECK(_mask, 0ULL, _val, "FIELD_PREP: "); \
    ^~~~~~~~~~~~~~~~
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:2461:3: note: in 
expansion of macro ‘FIELD_PREP’
    FIELD_PREP(GUC_KLV_0_KEY, GUC_CONTEXT_POLICIES_KLV_ID_##id) | \
    ^~~~~~~~~~
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:2469:1: note: in 
expansion of macro ‘MAKE_CONTEXT_POLICY_ADD’
  MAKE_CONTEXT_POLICY_ADD(priority, SCHEDULING_PRIORITY)
  ^~~~~~~~~~~~~~~~~~~~~~~
In function ‘__guc_context_policy_add_preemption_timeout.isra.51’,
     inlined from ‘__guc_context_set_preemption_timeout’ at 
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:3005:3:
././include/linux/compiler_types.h:397:38: error: call to 
‘__compiletime_assert_1793’ declared with attribute error: FIELD_PREP: 
mask is not constant
   _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
                                       ^
././include/linux/compiler_types.h:378:4: note: in definition of macro 
‘__compiletime_assert’
     prefix ## suffix();    \
     ^~~~~~
././include/linux/compiler_types.h:397:2: note: in expansion of macro 
‘_compiletime_assert’
   _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
   ^~~~~~~~~~~~~~~~~~~
./include/linux/build_bug.h:39:37: note: in expansion of macro 
‘compiletime_assert’
  #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
                                      ^~~~~~~~~~~~~~~~~~
./include/linux/bitfield.h:65:3: note: in expansion of macro 
‘BUILD_BUG_ON_MSG’
    BUILD_BUG_ON_MSG(!__builtin_constant_p(_mask),  \
    ^~~~~~~~~~~~~~~~
./include/linux/bitfield.h:114:3: note: in expansion of macro 
‘__BF_FIELD_CHECK’
    __BF_FIELD_CHECK(_mask, 0ULL, _val, "FIELD_PREP: "); \
    ^~~~~~~~~~~~~~~~
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:2461:3: note: in 
expansion of macro ‘FIELD_PREP’
    FIELD_PREP(GUC_KLV_0_KEY, GUC_CONTEXT_POLICIES_KLV_ID_##id) | \
    ^~~~~~~~~~
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:2468:1: note: in 
expansion of macro ‘MAKE_CONTEXT_POLICY_ADD’
  MAKE_CONTEXT_POLICY_ADD(preemption_timeout, PREEMPTION_TIMEOUT)
  ^~~~~~~~~~~~~~~~~~~~~~~
In function ‘__guc_context_policy_add_priority.isra.47’,
     inlined from ‘__guc_add_request’ at 
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:2503:2:
././include/linux/compiler_types.h:397:38: error: call to 
‘__compiletime_assert_1803’ declared with attribute error: FIELD_PREP: 
mask is not constant
   _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
                                       ^
././include/linux/compiler_types.h:378:4: note: in definition of macro 
‘__compiletime_assert’
     prefix ## suffix();    \
     ^~~~~~
././include/linux/compiler_types.h:397:2: note: in expansion of macro 
‘_compiletime_assert’
   _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
   ^~~~~~~~~~~~~~~~~~~
./include/linux/build_bug.h:39:37: note: in expansion of macro 
‘compiletime_assert’
  #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
                                      ^~~~~~~~~~~~~~~~~~
./include/linux/bitfield.h:65:3: note: in expansion of macro 
‘BUILD_BUG_ON_MSG’
    BUILD_BUG_ON_MSG(!__builtin_constant_p(_mask),  \
    ^~~~~~~~~~~~~~~~
./include/linux/bitfield.h:114:3: note: in expansion of macro 
‘__BF_FIELD_CHECK’
    __BF_FIELD_CHECK(_mask, 0ULL, _val, "FIELD_PREP: "); \
    ^~~~~~~~~~~~~~~~
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:2461:3: note: in 
expansion of macro ‘FIELD_PREP’
    FIELD_PREP(GUC_KLV_0_KEY, GUC_CONTEXT_POLICIES_KLV_ID_##id) | \
    ^~~~~~~~~~
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:2469:1: note: in 
expansion of macro ‘MAKE_CONTEXT_POLICY_ADD’
  MAKE_CONTEXT_POLICY_ADD(priority, SCHEDULING_PRIORITY)
  ^~~~~~~~~~~~~~~~~~~~~~~
In function ‘__guc_context_policy_add_priority.isra.47’,
     inlined from ‘register_context’ at 
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:2503:2:
././include/linux/compiler_types.h:397:38: error: call to 
‘__compiletime_assert_1803’ declared with attribute error: FIELD_PREP: 
mask is not constant
   _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
                                       ^
././include/linux/compiler_types.h:378:4: note: in definition of macro 
‘__compiletime_assert’
     prefix ## suffix();    \
     ^~~~~~
././include/linux/compiler_types.h:397:2: note: in expansion of macro 
‘_compiletime_assert’
   _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
   ^~~~~~~~~~~~~~~~~~~
./include/linux/build_bug.h:39:37: note: in expansion of macro 
‘compiletime_assert’
  #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
                                      ^~~~~~~~~~~~~~~~~~
./include/linux/bitfield.h:65:3: note: in expansion of macro 
‘BUILD_BUG_ON_MSG’
    BUILD_BUG_ON_MSG(!__builtin_constant_p(_mask),  \
    ^~~~~~~~~~~~~~~~
./include/linux/bitfield.h:114:3: note: in expansion of macro 
‘__BF_FIELD_CHECK’
    __BF_FIELD_CHECK(_mask, 0ULL, _val, "FIELD_PREP: "); \
    ^~~~~~~~~~~~~~~~
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:2461:3: note: in 
expansion of macro ‘FIELD_PREP’
    FIELD_PREP(GUC_KLV_0_KEY, GUC_CONTEXT_POLICIES_KLV_ID_##id) | \
    ^~~~~~~~~~
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:2469:1: note: in 
expansion of macro ‘MAKE_CONTEXT_POLICY_ADD’
  MAKE_CONTEXT_POLICY_ADD(priority, SCHEDULING_PRIORITY)
  ^~~~~~~~~~~~~~~~~~~~~~~
In function ‘__guc_scheduling_policy_add_klv.isra.56’,
     inlined from ‘guc_init_global_schedule_policy’ at 
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:4449:3,
     inlined from ‘intel_guc_submission_enable’ at 
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:4490:6:
././include/linux/compiler_types.h:397:38: error: call to 
‘__compiletime_assert_1882’ declared with attribute error: FIELD_PREP: 
mask is not constant
   _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
                                       ^
././include/linux/compiler_types.h:378:4: note: in definition of macro 
‘__compiletime_assert’
     prefix ## suffix();    \
     ^~~~~~
././include/linux/compiler_types.h:397:2: note: in expansion of macro 
‘_compiletime_assert’
   _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
   ^~~~~~~~~~~~~~~~~~~
./include/linux/build_bug.h:39:37: note: in expansion of macro 
‘compiletime_assert’
  #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
                                      ^~~~~~~~~~~~~~~~~~
./include/linux/bitfield.h:65:3: note: in expansion of macro 
‘BUILD_BUG_ON_MSG’
    BUILD_BUG_ON_MSG(!__builtin_constant_p(_mask),  \
    ^~~~~~~~~~~~~~~~
./include/linux/bitfield.h:114:3: note: in expansion of macro 
‘__BF_FIELD_CHECK’
    __BF_FIELD_CHECK(_mask, 0ULL, _val, "FIELD_PREP: "); \
    ^~~~~~~~~~~~~~~~
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:4401:17: note: in 
expansion of macro ‘FIELD_PREP’
   *(klv_ptr++) = FIELD_PREP(GUC_KLV_0_KEY, action) |
                  ^~~~~~~~~~
scripts/Makefile.build:243: recipe for target 
'drivers/gpu/drm/i915/gt/uc/intel_guc_submission.o' failed


>
> BR,
> Jani.
>
>
>
>> Change to use GENMASK() to avoid the issue.
>>
>> Signed-off-by: Linyu Yuan <quic_linyyuan@quicinc.com>
>> ---
>>   drivers/gpu/drm/i915/gt/uc/abi/guc_klvs_abi.h | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/gt/uc/abi/guc_klvs_abi.h b/drivers/gpu/drm/i915/gt/uc/abi/guc_klvs_abi.h
>> index 58012edd4eb0..fd3c16695e5f 100644
>> --- a/drivers/gpu/drm/i915/gt/uc/abi/guc_klvs_abi.h
>> +++ b/drivers/gpu/drm/i915/gt/uc/abi/guc_klvs_abi.h
>> @@ -29,8 +29,8 @@
>>    */
>>   
>>   #define GUC_KLV_LEN_MIN				1u
>> -#define GUC_KLV_0_KEY				(0xffff << 16)
>> -#define GUC_KLV_0_LEN				(0xffff << 0)
>> +#define GUC_KLV_0_KEY				GENMASK(31, 16)
>> +#define GUC_KLV_0_LEN				GENMASK(15, 0)
>>   #define GUC_KLV_n_VALUE				(0xffffffff << 0)
>>   
>>   /**

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/guc: fix compile issue of guc_klvs_abi.h
  2023-08-25  5:00 [Intel-gfx] [PATCH] drm/i915/guc: fix compile issue of guc_klvs_abi.h Linyu Yuan
  2023-08-25  5:37 ` Jani Nikula
@ 2023-08-28 13:37 ` Patchwork
  2023-08-28 13:53 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
  2023-08-28 15:49 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
  3 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2023-08-28 13:37 UTC (permalink / raw)
  To: Linyu Yuan; +Cc: intel-gfx

== Series Details ==

Series: drm/i915/guc: fix compile issue of guc_klvs_abi.h
URL   : https://patchwork.freedesktop.org/series/122971/
State : warning

== Summary ==

Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.



^ permalink raw reply	[flat|nested] 9+ messages in thread

* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/guc: fix compile issue of guc_klvs_abi.h
  2023-08-25  5:00 [Intel-gfx] [PATCH] drm/i915/guc: fix compile issue of guc_klvs_abi.h Linyu Yuan
  2023-08-25  5:37 ` Jani Nikula
  2023-08-28 13:37 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for " Patchwork
@ 2023-08-28 13:53 ` Patchwork
  2023-08-28 15:49 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
  3 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2023-08-28 13:53 UTC (permalink / raw)
  To: Linyu Yuan; +Cc: intel-gfx

[-- Attachment #1: Type: text/plain, Size: 4495 bytes --]

== Series Details ==

Series: drm/i915/guc: fix compile issue of guc_klvs_abi.h
URL   : https://patchwork.freedesktop.org/series/122971/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_13571 -> Patchwork_122971v1
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/index.html

Participating hosts (38 -> 27)
------------------------------

  Missing    (11): fi-kbl-7567u bat-adls-5 bat-adlp-9 bat-dg2-9 fi-cfl-8700k fi-apl-guc fi-snb-2520m fi-cfl-guc fi-ivb-3770 fi-elk-e7500 bat-mtlp-8 

Known issues
------------

  Here are the changes found in Patchwork_122971v1 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@i915_selftest@live@gt_heartbeat:
    - fi-kbl-soraka:      [PASS][1] -> [DMESG-FAIL][2] ([i915#5334] / [i915#7872])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13571/fi-kbl-soraka/igt@i915_selftest@live@gt_heartbeat.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/fi-kbl-soraka/igt@i915_selftest@live@gt_heartbeat.html
    - bat-jsl-1:          [PASS][3] -> [DMESG-FAIL][4] ([i915#5334])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13571/bat-jsl-1/igt@i915_selftest@live@gt_heartbeat.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/bat-jsl-1/igt@i915_selftest@live@gt_heartbeat.html

  * igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence:
    - bat-dg2-11:         NOTRUN -> [SKIP][5] ([i915#1845]) +3 similar issues
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/bat-dg2-11/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence.html

  * igt@kms_psr@primary_mmap_gtt:
    - bat-rplp-1:         NOTRUN -> [SKIP][6] ([i915#1072]) +2 similar issues
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/bat-rplp-1/igt@kms_psr@primary_mmap_gtt.html

  * igt@kms_psr@primary_page_flip:
    - bat-adlp-6:         NOTRUN -> [ABORT][7] ([i915#8442] / [i915#8668])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/bat-adlp-6/igt@kms_psr@primary_page_flip.html

  * igt@kms_setmode@basic-clone-single-crtc:
    - bat-rplp-1:         NOTRUN -> [ABORT][8] ([i915#8260] / [i915#8668])
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/bat-rplp-1/igt@kms_setmode@basic-clone-single-crtc.html

  
#### Possible fixes ####

  * igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-a-edp-1:
    - bat-adlp-6:         [ABORT][9] ([i915#7977] / [i915#8469] / [i915#8668]) -> [PASS][10]
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13571/bat-adlp-6/igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-a-edp-1.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/bat-adlp-6/igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-a-edp-1.html

  
#### Warnings ####

  * igt@kms_psr@primary_page_flip:
    - bat-rplp-1:         [ABORT][11] ([i915#8442] / [i915#8668] / [i915#8860]) -> [SKIP][12] ([i915#1072])
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13571/bat-rplp-1/igt@kms_psr@primary_page_flip.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/bat-rplp-1/igt@kms_psr@primary_page_flip.html

  
  [i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
  [i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
  [i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
  [i915#7872]: https://gitlab.freedesktop.org/drm/intel/issues/7872
  [i915#7977]: https://gitlab.freedesktop.org/drm/intel/issues/7977
  [i915#8260]: https://gitlab.freedesktop.org/drm/intel/issues/8260
  [i915#8442]: https://gitlab.freedesktop.org/drm/intel/issues/8442
  [i915#8469]: https://gitlab.freedesktop.org/drm/intel/issues/8469
  [i915#8668]: https://gitlab.freedesktop.org/drm/intel/issues/8668
  [i915#8860]: https://gitlab.freedesktop.org/drm/intel/issues/8860


Build changes
-------------

  * Linux: CI_DRM_13571 -> Patchwork_122971v1

  CI-20190529: 20190529
  CI_DRM_13571: d3f0e020609215d9097f1b1fad5a13ea0b37548e @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_7454: 7454
  Patchwork_122971v1: d3f0e020609215d9097f1b1fad5a13ea0b37548e @ git://anongit.freedesktop.org/gfx-ci/linux


### Linux commits

6a7147fc198e drm/i915/guc: fix compile issue of guc_klvs_abi.h

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/index.html

[-- Attachment #2: Type: text/html, Size: 5664 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/guc: fix compile issue of guc_klvs_abi.h
  2023-08-25  5:00 [Intel-gfx] [PATCH] drm/i915/guc: fix compile issue of guc_klvs_abi.h Linyu Yuan
                   ` (2 preceding siblings ...)
  2023-08-28 13:53 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
@ 2023-08-28 15:49 ` Patchwork
  3 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2023-08-28 15:49 UTC (permalink / raw)
  To: Linyu Yuan; +Cc: intel-gfx

[-- Attachment #1: Type: text/plain, Size: 46435 bytes --]

== Series Details ==

Series: drm/i915/guc: fix compile issue of guc_klvs_abi.h
URL   : https://patchwork.freedesktop.org/series/122971/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_13571_full -> Patchwork_122971v1_full
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with Patchwork_122971v1_full absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_122971v1_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  

Participating hosts (9 -> 9)
------------------------------

  No changes in participating hosts

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in Patchwork_122971v1_full:

### IGT changes ###

#### Possible regressions ####

  * igt@gem_ctx_shared@detached-shared-gtt:
    - shard-mtlp:         [PASS][1] -> [ABORT][2]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13571/shard-mtlp-2/igt@gem_ctx_shared@detached-shared-gtt.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-mtlp-1/igt@gem_ctx_shared@detached-shared-gtt.html

  
Known issues
------------

  Here are the changes found in Patchwork_122971v1_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@drm_fdinfo@most-busy-idle-check-all@rcs0:
    - shard-rkl:          [PASS][3] -> [FAIL][4] ([i915#7742])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13571/shard-rkl-4/igt@drm_fdinfo@most-busy-idle-check-all@rcs0.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-rkl-1/igt@drm_fdinfo@most-busy-idle-check-all@rcs0.html

  * igt@gem_busy@close-race:
    - shard-glk:          [PASS][5] -> [ABORT][6] ([i915#6016])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13571/shard-glk7/igt@gem_busy@close-race.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-glk1/igt@gem_busy@close-race.html

  * igt@gem_ctx_exec@basic-nohangcheck:
    - shard-rkl:          [PASS][7] -> [FAIL][8] ([i915#6268])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13571/shard-rkl-4/igt@gem_ctx_exec@basic-nohangcheck.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-rkl-4/igt@gem_ctx_exec@basic-nohangcheck.html

  * igt@gem_ctx_sseu@invalid-sseu:
    - shard-dg2:          NOTRUN -> [SKIP][9] ([i915#280]) +1 similar issue
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-dg2-8/igt@gem_ctx_sseu@invalid-sseu.html

  * igt@gem_eio@reset-stress:
    - shard-dg1:          [PASS][10] -> [FAIL][11] ([i915#5784]) +1 similar issue
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13571/shard-dg1-13/igt@gem_eio@reset-stress.html
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-dg1-19/igt@gem_eio@reset-stress.html

  * igt@gem_exec_balancer@bonded-semaphore:
    - shard-dg2:          NOTRUN -> [SKIP][12] ([i915#4812])
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-dg2-8/igt@gem_exec_balancer@bonded-semaphore.html

  * igt@gem_exec_balancer@bonded-sync:
    - shard-mtlp:         NOTRUN -> [SKIP][13] ([i915#4771])
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-mtlp-7/igt@gem_exec_balancer@bonded-sync.html

  * igt@gem_exec_capture@pi@ccs0:
    - shard-mtlp:         [PASS][14] -> [FAIL][15] ([i915#7765])
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13571/shard-mtlp-8/igt@gem_exec_capture@pi@ccs0.html
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-mtlp-5/igt@gem_exec_capture@pi@ccs0.html

  * igt@gem_exec_capture@pi@rcs0:
    - shard-mtlp:         [PASS][16] -> [FAIL][17] ([i915#4475])
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13571/shard-mtlp-8/igt@gem_exec_capture@pi@rcs0.html
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-mtlp-5/igt@gem_exec_capture@pi@rcs0.html

  * igt@gem_exec_flush@basic-wb-ro-before-default:
    - shard-dg2:          NOTRUN -> [SKIP][18] ([i915#3539] / [i915#4852])
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-dg2-8/igt@gem_exec_flush@basic-wb-ro-before-default.html

  * igt@gem_exec_reloc@basic-cpu-gtt-active:
    - shard-dg2:          NOTRUN -> [SKIP][19] ([i915#3281]) +4 similar issues
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-dg2-8/igt@gem_exec_reloc@basic-cpu-gtt-active.html

  * igt@gem_exec_suspend@basic-s4-devices@smem:
    - shard-tglu:         [PASS][20] -> [ABORT][21] ([i915#7975] / [i915#8213])
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13571/shard-tglu-4/igt@gem_exec_suspend@basic-s4-devices@smem.html
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-tglu-10/igt@gem_exec_suspend@basic-s4-devices@smem.html

  * igt@gem_gtt_cpu_tlb:
    - shard-mtlp:         NOTRUN -> [SKIP][22] ([i915#4077]) +1 similar issue
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-mtlp-7/igt@gem_gtt_cpu_tlb.html

  * igt@gem_lmem_swapping@parallel-random:
    - shard-mtlp:         NOTRUN -> [SKIP][23] ([i915#4613])
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-mtlp-7/igt@gem_lmem_swapping@parallel-random.html

  * igt@gem_lmem_swapping@verify-random:
    - shard-apl:          NOTRUN -> [SKIP][24] ([fdo#109271] / [i915#4613])
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-apl1/igt@gem_lmem_swapping@verify-random.html

  * igt@gem_media_fill@media-fill:
    - shard-dg2:          NOTRUN -> [SKIP][25] ([i915#8289])
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-dg2-8/igt@gem_media_fill@media-fill.html

  * igt@gem_mmap_gtt@basic-read-write-distinct:
    - shard-dg2:          NOTRUN -> [SKIP][26] ([i915#4077]) +3 similar issues
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-dg2-8/igt@gem_mmap_gtt@basic-read-write-distinct.html

  * igt@gem_mmap_wc@bad-offset:
    - shard-dg2:          NOTRUN -> [SKIP][27] ([i915#4083]) +1 similar issue
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-dg2-11/igt@gem_mmap_wc@bad-offset.html

  * igt@gem_mmap_wc@read:
    - shard-mtlp:         NOTRUN -> [SKIP][28] ([i915#4083])
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-mtlp-7/igt@gem_mmap_wc@read.html

  * igt@gem_partial_pwrite_pread@reads:
    - shard-dg2:          NOTRUN -> [SKIP][29] ([i915#3282]) +2 similar issues
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-dg2-11/igt@gem_partial_pwrite_pread@reads.html

  * igt@gem_partial_pwrite_pread@write-uncached:
    - shard-mtlp:         NOTRUN -> [SKIP][30] ([i915#3282])
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-mtlp-8/igt@gem_partial_pwrite_pread@write-uncached.html

  * igt@gem_pxp@create-regular-buffer:
    - shard-dg2:          NOTRUN -> [SKIP][31] ([i915#4270]) +1 similar issue
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-dg2-11/igt@gem_pxp@create-regular-buffer.html

  * igt@gem_pxp@create-regular-context-2:
    - shard-apl:          NOTRUN -> [SKIP][32] ([fdo#109271]) +51 similar issues
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-apl1/igt@gem_pxp@create-regular-context-2.html

  * igt@gem_render_copy@y-tiled-ccs-to-y-tiled-mc-ccs:
    - shard-mtlp:         NOTRUN -> [SKIP][33] ([i915#8428])
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-mtlp-7/igt@gem_render_copy@y-tiled-ccs-to-y-tiled-mc-ccs.html

  * igt@gem_spin_batch@user-each:
    - shard-mtlp:         [PASS][34] -> [DMESG-FAIL][35] ([i915#8962] / [i915#9121])
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13571/shard-mtlp-5/igt@gem_spin_batch@user-each.html
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-mtlp-4/igt@gem_spin_batch@user-each.html

  * igt@gem_userptr_blits@create-destroy-unsync:
    - shard-dg2:          NOTRUN -> [SKIP][36] ([i915#3297]) +1 similar issue
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-dg2-8/igt@gem_userptr_blits@create-destroy-unsync.html

  * igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy:
    - shard-mtlp:         NOTRUN -> [SKIP][37] ([i915#3297])
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-mtlp-4/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy.html

  * igt@gen9_exec_parse@bb-secure:
    - shard-dg2:          NOTRUN -> [SKIP][38] ([i915#2856])
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-dg2-11/igt@gen9_exec_parse@bb-secure.html

  * igt@gen9_exec_parse@unaligned-jump:
    - shard-mtlp:         NOTRUN -> [SKIP][39] ([i915#2856])
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-mtlp-7/igt@gen9_exec_parse@unaligned-jump.html

  * igt@i915_module_load@reload-with-fault-injection:
    - shard-dg2:          [PASS][40] -> [DMESG-WARN][41] ([i915#7061] / [i915#8617])
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13571/shard-dg2-8/igt@i915_module_load@reload-with-fault-injection.html
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-dg2-2/igt@i915_module_load@reload-with-fault-injection.html
    - shard-mtlp:         [PASS][42] -> [ABORT][43] ([i915#8489] / [i915#8668])
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13571/shard-mtlp-5/igt@i915_module_load@reload-with-fault-injection.html
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-mtlp-2/igt@i915_module_load@reload-with-fault-injection.html

  * igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a:
    - shard-dg1:          [PASS][44] -> [SKIP][45] ([i915#1937])
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13571/shard-dg1-19/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a.html
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-dg1-13/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a.html

  * igt@i915_pm_rc6_residency@rc6-idle@rcs0:
    - shard-dg1:          [PASS][46] -> [FAIL][47] ([i915#3591]) +1 similar issue
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13571/shard-dg1-18/igt@i915_pm_rc6_residency@rc6-idle@rcs0.html
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-dg1-19/igt@i915_pm_rc6_residency@rc6-idle@rcs0.html

  * igt@i915_pm_rpm@modeset-non-lpsp:
    - shard-dg2:          [PASS][48] -> [SKIP][49] ([i915#1397])
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13571/shard-dg2-11/igt@i915_pm_rpm@modeset-non-lpsp.html
   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-dg2-10/igt@i915_pm_rpm@modeset-non-lpsp.html
    - shard-dg1:          [PASS][50] -> [SKIP][51] ([i915#1397])
   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13571/shard-dg1-14/igt@i915_pm_rpm@modeset-non-lpsp.html
   [51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-dg1-19/igt@i915_pm_rpm@modeset-non-lpsp.html

  * igt@i915_pm_rpm@modeset-non-lpsp-stress-no-wait:
    - shard-rkl:          [PASS][52] -> [SKIP][53] ([i915#1397]) +1 similar issue
   [52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13571/shard-rkl-6/igt@i915_pm_rpm@modeset-non-lpsp-stress-no-wait.html
   [53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-rkl-7/igt@i915_pm_rpm@modeset-non-lpsp-stress-no-wait.html

  * igt@i915_pm_rps@reset:
    - shard-snb:          [PASS][54] -> [INCOMPLETE][55] ([i915#7790])
   [54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13571/shard-snb4/igt@i915_pm_rps@reset.html
   [55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-snb6/igt@i915_pm_rps@reset.html

  * igt@i915_pm_sseu@full-enable:
    - shard-dg2:          NOTRUN -> [SKIP][56] ([i915#4387])
   [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-dg2-8/igt@i915_pm_sseu@full-enable.html

  * igt@kms_addfb_basic@clobberred-modifier:
    - shard-dg2:          NOTRUN -> [SKIP][57] ([i915#4212])
   [57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-dg2-11/igt@kms_addfb_basic@clobberred-modifier.html

  * igt@kms_async_flips@async-flip-with-page-flip-events@pipe-c-hdmi-a-1-4-rc_ccs-cc:
    - shard-dg2:          NOTRUN -> [SKIP][58] ([i915#8502] / [i915#8709]) +11 similar issues
   [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-dg2-10/igt@kms_async_flips@async-flip-with-page-flip-events@pipe-c-hdmi-a-1-4-rc_ccs-cc.html

  * igt@kms_async_flips@async-flip-with-page-flip-events@pipe-d-hdmi-a-1-y-rc_ccs:
    - shard-dg1:          NOTRUN -> [SKIP][59] ([i915#8502]) +7 similar issues
   [59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-dg1-19/igt@kms_async_flips@async-flip-with-page-flip-events@pipe-d-hdmi-a-1-y-rc_ccs.html

  * igt@kms_async_flips@crc@pipe-a-hdmi-a-2:
    - shard-dg2:          NOTRUN -> [FAIL][60] ([i915#8247]) +3 similar issues
   [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-dg2-2/igt@kms_async_flips@crc@pipe-a-hdmi-a-2.html

  * igt@kms_async_flips@invalid-async-flip:
    - shard-mtlp:         NOTRUN -> [SKIP][61] ([i915#6228])
   [61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-mtlp-7/igt@kms_async_flips@invalid-async-flip.html

  * igt@kms_atomic_transition@plane-all-modeset-transition-fencing-internal-panels:
    - shard-dg2:          NOTRUN -> [SKIP][62] ([i915#1769] / [i915#3555])
   [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-dg2-8/igt@kms_atomic_transition@plane-all-modeset-transition-fencing-internal-panels.html

  * igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip:
    - shard-mtlp:         [PASS][63] -> [FAIL][64] ([i915#3743])
   [63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13571/shard-mtlp-7/igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip.html
   [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-mtlp-3/igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip.html

  * igt@kms_big_fb@x-tiled-16bpp-rotate-90:
    - shard-mtlp:         NOTRUN -> [SKIP][65] ([fdo#111614])
   [65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-mtlp-7/igt@kms_big_fb@x-tiled-16bpp-rotate-90.html

  * igt@kms_big_fb@y-tiled-64bpp-rotate-90:
    - shard-dg2:          NOTRUN -> [SKIP][66] ([i915#5190]) +6 similar issues
   [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-dg2-11/igt@kms_big_fb@y-tiled-64bpp-rotate-90.html

  * igt@kms_big_fb@yf-tiled-8bpp-rotate-0:
    - shard-dg2:          NOTRUN -> [SKIP][67] ([i915#4538] / [i915#5190]) +3 similar issues
   [67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-dg2-11/igt@kms_big_fb@yf-tiled-8bpp-rotate-0.html

  * igt@kms_big_joiner@invalid-modeset:
    - shard-dg2:          NOTRUN -> [SKIP][68] ([i915#2705])
   [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-dg2-8/igt@kms_big_joiner@invalid-modeset.html

  * igt@kms_ccs@pipe-b-missing-ccs-buffer-y_tiled_ccs:
    - shard-mtlp:         NOTRUN -> [SKIP][69] ([i915#6095]) +9 similar issues
   [69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-mtlp-7/igt@kms_ccs@pipe-b-missing-ccs-buffer-y_tiled_ccs.html

  * igt@kms_ccs@pipe-c-bad-rotation-90-y_tiled_gen12_mc_ccs:
    - shard-apl:          NOTRUN -> [SKIP][70] ([fdo#109271] / [i915#3886]) +1 similar issue
   [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-apl1/igt@kms_ccs@pipe-c-bad-rotation-90-y_tiled_gen12_mc_ccs.html

  * igt@kms_ccs@pipe-c-crc-primary-rotation-180-y_tiled_gen12_mc_ccs:
    - shard-dg2:          NOTRUN -> [SKIP][71] ([i915#3689] / [i915#3886] / [i915#5354]) +5 similar issues
   [71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-dg2-8/igt@kms_ccs@pipe-c-crc-primary-rotation-180-y_tiled_gen12_mc_ccs.html

  * igt@kms_ccs@pipe-d-bad-aux-stride-y_tiled_gen12_mc_ccs:
    - shard-dg2:          NOTRUN -> [SKIP][72] ([i915#3689] / [i915#5354]) +6 similar issues
   [72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-dg2-11/igt@kms_ccs@pipe-d-bad-aux-stride-y_tiled_gen12_mc_ccs.html

  * igt@kms_cdclk@plane-scaling@pipe-d-hdmi-a-1:
    - shard-dg2:          NOTRUN -> [SKIP][73] ([i915#4087]) +3 similar issues
   [73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-dg2-10/igt@kms_cdclk@plane-scaling@pipe-d-hdmi-a-1.html

  * igt@kms_chamelium_color@ctm-0-25:
    - shard-dg2:          NOTRUN -> [SKIP][74] ([fdo#111827])
   [74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-dg2-8/igt@kms_chamelium_color@ctm-0-25.html

  * igt@kms_chamelium_frames@hdmi-crc-multiple:
    - shard-dg2:          NOTRUN -> [SKIP][75] ([i915#7828]) +3 similar issues
   [75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-dg2-11/igt@kms_chamelium_frames@hdmi-crc-multiple.html

  * igt@kms_chamelium_hpd@dp-hpd-for-each-pipe:
    - shard-mtlp:         NOTRUN -> [SKIP][76] ([i915#7828]) +2 similar issues
   [76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-mtlp-7/igt@kms_chamelium_hpd@dp-hpd-for-each-pipe.html

  * igt@kms_content_protection@legacy@pipe-a-dp-2:
    - shard-dg2:          NOTRUN -> [TIMEOUT][77] ([i915#7173])
   [77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-dg2-12/igt@kms_content_protection@legacy@pipe-a-dp-2.html

  * igt@kms_content_protection@srm:
    - shard-dg2:          NOTRUN -> [SKIP][78] ([i915#7118]) +1 similar issue
   [78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-dg2-10/igt@kms_content_protection@srm.html

  * igt@kms_content_protection@uevent@pipe-a-dp-4:
    - shard-dg2:          NOTRUN -> [FAIL][79] ([i915#1339])
   [79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-dg2-11/igt@kms_content_protection@uevent@pipe-a-dp-4.html

  * igt@kms_cursor_crc@cursor-rapid-movement-512x512:
    - shard-mtlp:         NOTRUN -> [SKIP][80] ([i915#3359]) +1 similar issue
   [80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-mtlp-7/igt@kms_cursor_crc@cursor-rapid-movement-512x512.html

  * igt@kms_cursor_legacy@2x-flip-vs-cursor-atomic:
    - shard-apl:          NOTRUN -> [SKIP][81] ([fdo#109271] / [fdo#111767])
   [81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-apl1/igt@kms_cursor_legacy@2x-flip-vs-cursor-atomic.html

  * igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
    - shard-dg2:          NOTRUN -> [SKIP][82] ([i915#4103] / [i915#4213])
   [82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-dg2-11/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html

  * igt@kms_cursor_legacy@cursorb-vs-flipb-legacy:
    - shard-dg2:          NOTRUN -> [SKIP][83] ([fdo#109274] / [i915#5354]) +3 similar issues
   [83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-dg2-11/igt@kms_cursor_legacy@cursorb-vs-flipb-legacy.html

  * igt@kms_cursor_legacy@cursorb-vs-flipb-varying-size:
    - shard-mtlp:         NOTRUN -> [SKIP][84] ([i915#3546])
   [84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-mtlp-7/igt@kms_cursor_legacy@cursorb-vs-flipb-varying-size.html

  * igt@kms_display_modes@extended-mode-basic:
    - shard-mtlp:         NOTRUN -> [SKIP][85] ([i915#8827])
   [85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-mtlp-7/igt@kms_display_modes@extended-mode-basic.html

  * igt@kms_dsc@dsc-basic:
    - shard-dg2:          NOTRUN -> [SKIP][86] ([i915#3555] / [i915#3840])
   [86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-dg2-11/igt@kms_dsc@dsc-basic.html

  * igt@kms_flip@2x-flip-vs-suspend-interruptible@ab-vga1-hdmi-a1:
    - shard-snb:          NOTRUN -> [DMESG-WARN][87] ([i915#8841])
   [87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-snb1/igt@kms_flip@2x-flip-vs-suspend-interruptible@ab-vga1-hdmi-a1.html

  * igt@kms_flip@2x-plain-flip-interruptible:
    - shard-mtlp:         NOTRUN -> [SKIP][88] ([i915#3637])
   [88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-mtlp-7/igt@kms_flip@2x-plain-flip-interruptible.html

  * igt@kms_flip@2x-wf_vblank-ts-check-interruptible:
    - shard-dg2:          NOTRUN -> [SKIP][89] ([fdo#109274]) +4 similar issues
   [89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-dg2-11/igt@kms_flip@2x-wf_vblank-ts-check-interruptible.html

  * igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-64bpp-yftile-downscaling@pipe-a-valid-mode:
    - shard-dg2:          NOTRUN -> [SKIP][90] ([i915#2672]) +1 similar issue
   [90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-dg2-8/igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-64bpp-yftile-downscaling@pipe-a-valid-mode.html

  * igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilercccs-downscaling@pipe-a-default-mode:
    - shard-mtlp:         NOTRUN -> [SKIP][91] ([i915#2672])
   [91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-mtlp-7/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilercccs-downscaling@pipe-a-default-mode.html

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-wc:
    - shard-dg2:          NOTRUN -> [SKIP][92] ([i915#8708]) +8 similar issues
   [92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-dg2-11/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-wc.html

  * igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-indfb-draw-mmap-gtt:
    - shard-mtlp:         NOTRUN -> [SKIP][93] ([i915#8708])
   [93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-mtlp-7/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-indfb-draw-mmap-gtt.html

  * igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-indfb-draw-pwrite:
    - shard-mtlp:         NOTRUN -> [SKIP][94] ([i915#1825]) +4 similar issues
   [94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-mtlp-7/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-indfb-draw-pwrite.html

  * igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-render:
    - shard-dg2:          NOTRUN -> [SKIP][95] ([i915#3458]) +8 similar issues
   [95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-dg2-8/igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-render.html

  * igt@kms_frontbuffer_tracking@psr-2p-primscrn-pri-shrfb-draw-render:
    - shard-dg2:          NOTRUN -> [SKIP][96] ([i915#5354]) +17 similar issues
   [96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-dg2-8/igt@kms_frontbuffer_tracking@psr-2p-primscrn-pri-shrfb-draw-render.html

  * igt@kms_plane_scaling@plane-downscale-with-modifiers-factor-0-25@pipe-b-hdmi-a-1:
    - shard-dg2:          NOTRUN -> [SKIP][97] ([i915#5176]) +11 similar issues
   [97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-dg2-10/igt@kms_plane_scaling@plane-downscale-with-modifiers-factor-0-25@pipe-b-hdmi-a-1.html

  * igt@kms_plane_scaling@plane-downscale-with-rotation-factor-0-5@pipe-a-hdmi-a-1:
    - shard-rkl:          NOTRUN -> [SKIP][98] ([i915#5176]) +5 similar issues
   [98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-rkl-7/igt@kms_plane_scaling@plane-downscale-with-rotation-factor-0-5@pipe-a-hdmi-a-1.html

  * igt@kms_plane_scaling@plane-downscale-with-rotation-factor-0-75@pipe-b-hdmi-a-3:
    - shard-dg1:          NOTRUN -> [SKIP][99] ([i915#5176]) +3 similar issues
   [99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-dg1-13/igt@kms_plane_scaling@plane-downscale-with-rotation-factor-0-75@pipe-b-hdmi-a-3.html

  * igt@kms_plane_scaling@plane-scaler-with-pixel-format-unity-scaling@pipe-b-edp-1:
    - shard-mtlp:         [PASS][100] -> [DMESG-WARN][101] ([i915#1982])
   [100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13571/shard-mtlp-3/igt@kms_plane_scaling@plane-scaler-with-pixel-format-unity-scaling@pipe-b-edp-1.html
   [101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-mtlp-6/igt@kms_plane_scaling@plane-scaler-with-pixel-format-unity-scaling@pipe-b-edp-1.html

  * igt@kms_plane_scaling@plane-upscale-with-modifiers-factor-0-25@pipe-b-hdmi-a-1:
    - shard-snb:          NOTRUN -> [SKIP][102] ([fdo#109271]) +14 similar issues
   [102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-snb1/igt@kms_plane_scaling@plane-upscale-with-modifiers-factor-0-25@pipe-b-hdmi-a-1.html

  * igt@kms_plane_scaling@planes-downscale-factor-0-25@pipe-c-dp-4:
    - shard-dg2:          NOTRUN -> [SKIP][103] ([i915#5235]) +15 similar issues
   [103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-dg2-11/igt@kms_plane_scaling@planes-downscale-factor-0-25@pipe-c-dp-4.html

  * igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-25@pipe-b-hdmi-a-2:
    - shard-rkl:          NOTRUN -> [SKIP][104] ([i915#5235]) +1 similar issue
   [104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-rkl-6/igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-25@pipe-b-hdmi-a-2.html

  * igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-25@pipe-d-hdmi-a-1:
    - shard-dg1:          NOTRUN -> [SKIP][105] ([i915#5235]) +19 similar issues
   [105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-dg1-19/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-25@pipe-d-hdmi-a-1.html

  * igt@kms_prime@d3hot:
    - shard-dg2:          NOTRUN -> [SKIP][106] ([i915#6524] / [i915#6805])
   [106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-dg2-11/igt@kms_prime@d3hot.html

  * igt@kms_psr2_su@page_flip-nv12:
    - shard-dg2:          NOTRUN -> [SKIP][107] ([i915#658]) +1 similar issue
   [107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-dg2-8/igt@kms_psr2_su@page_flip-nv12.html

  * igt@kms_psr2_su@page_flip-xrgb8888:
    - shard-apl:          NOTRUN -> [SKIP][108] ([fdo#109271] / [i915#658])
   [108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-apl1/igt@kms_psr2_su@page_flip-xrgb8888.html

  * igt@kms_psr@cursor_mmap_cpu:
    - shard-dg2:          NOTRUN -> [SKIP][109] ([i915#1072]) +2 similar issues
   [109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-dg2-11/igt@kms_psr@cursor_mmap_cpu.html

  * igt@kms_rotation_crc@primary-y-tiled-reflect-x-270:
    - shard-dg2:          NOTRUN -> [SKIP][110] ([i915#4235] / [i915#5190])
   [110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-dg2-8/igt@kms_rotation_crc@primary-y-tiled-reflect-x-270.html

  * igt@kms_rotation_crc@sprite-rotation-90-pos-100-0:
    - shard-mtlp:         NOTRUN -> [SKIP][111] ([i915#4235])
   [111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-mtlp-7/igt@kms_rotation_crc@sprite-rotation-90-pos-100-0.html

  * igt@kms_scaling_modes@scaling-mode-full:
    - shard-dg2:          NOTRUN -> [SKIP][112] ([i915#3555])
   [112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-dg2-11/igt@kms_scaling_modes@scaling-mode-full.html

  * igt@kms_selftest@drm_plane:
    - shard-dg2:          NOTRUN -> [SKIP][113] ([i915#8661]) +1 similar issue
   [113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-dg2-8/igt@kms_selftest@drm_plane.html

  * igt@kms_setmode@basic@pipe-a-vga-1:
    - shard-snb:          NOTRUN -> [FAIL][114] ([i915#5465]) +1 similar issue
   [114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-snb5/igt@kms_setmode@basic@pipe-a-vga-1.html

  * igt@kms_tiled_display@basic-test-pattern:
    - shard-dg2:          NOTRUN -> [SKIP][115] ([i915#8623])
   [115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-dg2-11/igt@kms_tiled_display@basic-test-pattern.html

  * igt@kms_writeback@writeback-fb-id:
    - shard-dg2:          NOTRUN -> [SKIP][116] ([i915#2437])
   [116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-dg2-11/igt@kms_writeback@writeback-fb-id.html

  * igt@perf@non-zero-reason@0-rcs0:
    - shard-dg2:          NOTRUN -> [FAIL][117] ([i915#7484])
   [117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-dg2-11/igt@perf@non-zero-reason@0-rcs0.html

  * igt@perf_pmu@render-node-busy-idle@vcs1:
    - shard-dg2:          NOTRUN -> [FAIL][118] ([i915#4349]) +6 similar issues
   [118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-dg2-11/igt@perf_pmu@render-node-busy-idle@vcs1.html

  * igt@v3d/v3d_job_submission@array-job-submission:
    - shard-dg2:          NOTRUN -> [SKIP][119] ([i915#2575]) +5 similar issues
   [119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-dg2-8/igt@v3d/v3d_job_submission@array-job-submission.html

  * igt@v3d/v3d_submit_cl@simple-flush-cache:
    - shard-mtlp:         NOTRUN -> [SKIP][120] ([i915#2575]) +2 similar issues
   [120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-mtlp-7/igt@v3d/v3d_submit_cl@simple-flush-cache.html

  * igt@vc4/vc4_perfmon@create-single-perfmon:
    - shard-mtlp:         NOTRUN -> [SKIP][121] ([i915#7711])
   [121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-mtlp-7/igt@vc4/vc4_perfmon@create-single-perfmon.html

  * igt@vc4/vc4_purgeable_bo@free-purged-bo:
    - shard-dg2:          NOTRUN -> [SKIP][122] ([i915#7711]) +1 similar issue
   [122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-dg2-11/igt@vc4/vc4_purgeable_bo@free-purged-bo.html

  
#### Possible fixes ####

  * igt@gem_ctx_isolation@preservation-s3@bcs0:
    - shard-dg2:          [INCOMPLETE][123] -> [PASS][124]
   [123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13571/shard-dg2-5/igt@gem_ctx_isolation@preservation-s3@bcs0.html
   [124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-dg2-11/igt@gem_ctx_isolation@preservation-s3@bcs0.html

  * igt@gem_eio@in-flight-contexts-immediate:
    - shard-mtlp:         [ABORT][125] ([i915#8503]) -> [PASS][126]
   [125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13571/shard-mtlp-2/igt@gem_eio@in-flight-contexts-immediate.html
   [126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-mtlp-7/igt@gem_eio@in-flight-contexts-immediate.html

  * igt@gem_exec_capture@pi@vcs0:
    - shard-mtlp:         [FAIL][127] ([i915#4475]) -> [PASS][128]
   [127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13571/shard-mtlp-8/igt@gem_exec_capture@pi@vcs0.html
   [128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-mtlp-5/igt@gem_exec_capture@pi@vcs0.html

  * igt@gem_exec_capture@pi@vcs1:
    - shard-mtlp:         [FAIL][129] ([i915#4475] / [i915#7765]) -> [PASS][130]
   [129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13571/shard-mtlp-8/igt@gem_exec_capture@pi@vcs1.html
   [130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-mtlp-5/igt@gem_exec_capture@pi@vcs1.html

  * igt@gem_exec_fair@basic-deadline:
    - shard-glk:          [FAIL][131] ([i915#2846]) -> [PASS][132]
   [131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13571/shard-glk3/igt@gem_exec_fair@basic-deadline.html
   [132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-glk9/igt@gem_exec_fair@basic-deadline.html

  * igt@gem_exec_fair@basic-none@bcs0:
    - shard-rkl:          [FAIL][133] ([i915#2842]) -> [PASS][134] +3 similar issues
   [133]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13571/shard-rkl-6/igt@gem_exec_fair@basic-none@bcs0.html
   [134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-rkl-7/igt@gem_exec_fair@basic-none@bcs0.html

  * igt@gem_exec_fair@basic-pace-share@rcs0:
    - shard-glk:          [FAIL][135] ([i915#2842]) -> [PASS][136] +1 similar issue
   [135]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13571/shard-glk3/igt@gem_exec_fair@basic-pace-share@rcs0.html
   [136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-glk9/igt@gem_exec_fair@basic-pace-share@rcs0.html

  * igt@gem_lmem_swapping@smem-oom@lmem0:
    - shard-dg2:          [DMESG-WARN][137] ([i915#4936] / [i915#5493]) -> [PASS][138]
   [137]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13571/shard-dg2-3/igt@gem_lmem_swapping@smem-oom@lmem0.html
   [138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-dg2-6/igt@gem_lmem_swapping@smem-oom@lmem0.html

  * igt@gem_mmap_offset@clear@smem0:
    - shard-dg1:          [FAIL][139] ([i915#7962]) -> [PASS][140]
   [139]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13571/shard-dg1-14/igt@gem_mmap_offset@clear@smem0.html
   [140]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-dg1-14/igt@gem_mmap_offset@clear@smem0.html

  * igt@i915_pm_rpm@dpms-mode-unset-non-lpsp:
    - shard-dg2:          [SKIP][141] ([i915#1397]) -> [PASS][142] +1 similar issue
   [141]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13571/shard-dg2-10/igt@i915_pm_rpm@dpms-mode-unset-non-lpsp.html
   [142]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-dg2-3/igt@i915_pm_rpm@dpms-mode-unset-non-lpsp.html
    - shard-rkl:          [SKIP][143] ([i915#1397]) -> [PASS][144]
   [143]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13571/shard-rkl-7/igt@i915_pm_rpm@dpms-mode-unset-non-lpsp.html
   [144]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-rkl-6/igt@i915_pm_rpm@dpms-mode-unset-non-lpsp.html

  * igt@i915_pm_rpm@modeset-non-lpsp-stress:
    - shard-dg1:          [SKIP][145] ([i915#1397]) -> [PASS][146] +2 similar issues
   [145]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13571/shard-dg1-19/igt@i915_pm_rpm@modeset-non-lpsp-stress.html
   [146]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-dg1-18/igt@i915_pm_rpm@modeset-non-lpsp-stress.html

  * igt@kms_async_flips@alternate-sync-async-flip@pipe-a-edp-1:
    - shard-mtlp:         [FAIL][147] ([i915#2521]) -> [PASS][148]
   [147]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13571/shard-mtlp-6/igt@kms_async_flips@alternate-sync-async-flip@pipe-a-edp-1.html
   [148]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-mtlp-3/igt@kms_async_flips@alternate-sync-async-flip@pipe-a-edp-1.html

  * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
    - shard-apl:          [FAIL][149] ([i915#2346]) -> [PASS][150]
   [149]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13571/shard-apl4/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
   [150]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-apl1/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html

  * igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite:
    - shard-dg2:          [FAIL][151] ([i915#6880]) -> [PASS][152]
   [151]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13571/shard-dg2-10/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite.html
   [152]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-dg2-3/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite.html

  * igt@kms_plane@pixel-format-source-clamping@pipe-b-planes:
    - shard-mtlp:         [FAIL][153] ([i915#1623]) -> [PASS][154] +1 similar issue
   [153]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13571/shard-mtlp-6/igt@kms_plane@pixel-format-source-clamping@pipe-b-planes.html
   [154]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-mtlp-3/igt@kms_plane@pixel-format-source-clamping@pipe-b-planes.html

  * igt@kms_properties@connector-properties-legacy:
    - shard-dg2:          [FAIL][155] -> [PASS][156]
   [155]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13571/shard-dg2-11/igt@kms_properties@connector-properties-legacy.html
   [156]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-dg2-11/igt@kms_properties@connector-properties-legacy.html

  
#### Warnings ####

  * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
    - shard-mtlp:         [FAIL][157] ([i915#2346]) -> [DMESG-FAIL][158] ([i915#1982] / [i915#2017] / [i915#5954])
   [157]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13571/shard-mtlp-4/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
   [158]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-mtlp-5/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html

  * igt@kms_fbcon_fbt@psr-suspend:
    - shard-rkl:          [SKIP][159] ([i915#3955]) -> [SKIP][160] ([fdo#110189] / [i915#3955]) +1 similar issue
   [159]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13571/shard-rkl-7/igt@kms_fbcon_fbt@psr-suspend.html
   [160]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-rkl-2/igt@kms_fbcon_fbt@psr-suspend.html

  * igt@kms_multipipe_modeset@basic-max-pipe-crc-check:
    - shard-rkl:          [SKIP][161] ([i915#4816]) -> [SKIP][162] ([i915#4070] / [i915#4816])
   [161]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13571/shard-rkl-4/igt@kms_multipipe_modeset@basic-max-pipe-crc-check.html
   [162]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-rkl-2/igt@kms_multipipe_modeset@basic-max-pipe-crc-check.html

  * igt@kms_pipe_crc_basic@suspend-read-crc@pipe-a-vga-1:
    - shard-snb:          [DMESG-WARN][163] ([i915#8841]) -> [DMESG-WARN][164] ([i915#5090] / [i915#8841])
   [163]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13571/shard-snb6/igt@kms_pipe_crc_basic@suspend-read-crc@pipe-a-vga-1.html
   [164]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-snb5/igt@kms_pipe_crc_basic@suspend-read-crc@pipe-a-vga-1.html

  * igt@kms_psr@primary_page_flip:
    - shard-dg1:          [SKIP][165] ([i915#1072]) -> [SKIP][166] ([i915#1072] / [i915#4078])
   [165]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13571/shard-dg1-17/igt@kms_psr@primary_page_flip.html
   [166]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-dg1-13/igt@kms_psr@primary_page_flip.html

  * igt@kms_psr@sprite_plane_onoff:
    - shard-dg1:          [SKIP][167] ([i915#1072] / [i915#4078]) -> [SKIP][168] ([i915#1072])
   [167]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13571/shard-dg1-18/igt@kms_psr@sprite_plane_onoff.html
   [168]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/shard-dg1-17/igt@kms_psr@sprite_plane_onoff.html

  
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
  [fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
  [fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
  [fdo#111767]: https://bugs.freedesktop.org/show_bug.cgi?id=111767
  [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
  [i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
  [i915#1339]: https://gitlab.freedesktop.org/drm/intel/issues/1339
  [i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
  [i915#1623]: https://gitlab.freedesktop.org/drm/intel/issues/1623
  [i915#1769]: https://gitlab.freedesktop.org/drm/intel/issues/1769
  [i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
  [i915#1937]: https://gitlab.freedesktop.org/drm/intel/issues/1937
  [i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
  [i915#2017]: https://gitlab.freedesktop.org/drm/intel/issues/2017
  [i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
  [i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
  [i915#2521]: https://gitlab.freedesktop.org/drm/intel/issues/2521
  [i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
  [i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
  [i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
  [i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
  [i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
  [i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
  [i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
  [i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
  [i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
  [i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
  [i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
  [i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
  [i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
  [i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
  [i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
  [i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
  [i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
  [i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
  [i915#3743]: https://gitlab.freedesktop.org/drm/intel/issues/3743
  [i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840
  [i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
  [i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
  [i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
  [i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
  [i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
  [i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
  [i915#4087]: https://gitlab.freedesktop.org/drm/intel/issues/4087
  [i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
  [i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
  [i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
  [i915#4235]: https://gitlab.freedesktop.org/drm/intel/issues/4235
  [i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
  [i915#4349]: https://gitlab.freedesktop.org/drm/intel/issues/4349
  [i915#4387]: https://gitlab.freedesktop.org/drm/intel/issues/4387
  [i915#4475]: https://gitlab.freedesktop.org/drm/intel/issues/4475
  [i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
  [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
  [i915#4771]: https://gitlab.freedesktop.org/drm/intel/issues/4771
  [i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
  [i915#4816]: https://gitlab.freedesktop.org/drm/intel/issues/4816
  [i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
  [i915#4936]: https://gitlab.freedesktop.org/drm/intel/issues/4936
  [i915#5090]: https://gitlab.freedesktop.org/drm/intel/issues/5090
  [i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
  [i915#5190]: https://gitlab.freedesktop.org/drm/intel/issues/5190
  [i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
  [i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
  [i915#5465]: https://gitlab.freedesktop.org/drm/intel/issues/5465
  [i915#5493]: https://gitlab.freedesktop.org/drm/intel/issues/5493
  [i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
  [i915#5954]: https://gitlab.freedesktop.org/drm/intel/issues/5954
  [i915#6016]: https://gitlab.freedesktop.org/drm/intel/issues/6016
  [i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
  [i915#6228]: https://gitlab.freedesktop.org/drm/intel/issues/6228
  [i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
  [i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
  [i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
  [i915#6805]: https://gitlab.freedesktop.org/drm/intel/issues/6805
  [i915#6880]: https://gitlab.freedesktop.org/drm/intel/issues/6880
  [i915#7061]: https://gitlab.freedesktop.org/drm/intel/issues/7061
  [i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
  [i915#7173]: https://gitlab.freedesktop.org/drm/intel/issues/7173
  [i915#7484]: https://gitlab.freedesktop.org/drm/intel/issues/7484
  [i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
  [i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
  [i915#7765]: https://gitlab.freedesktop.org/drm/intel/issues/7765
  [i915#7790]: https://gitlab.freedesktop.org/drm/intel/issues/7790
  [i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
  [i915#7962]: https://gitlab.freedesktop.org/drm/intel/issues/7962
  [i915#7975]: https://gitlab.freedesktop.org/drm/intel/issues/7975
  [i915#8213]: https://gitlab.freedesktop.org/drm/intel/issues/8213
  [i915#8247]: https://gitlab.freedesktop.org/drm/intel/issues/8247
  [i915#8289]: https://gitlab.freedesktop.org/drm/intel/issues/8289
  [i915#8428]: https://gitlab.freedesktop.org/drm/intel/issues/8428
  [i915#8489]: https://gitlab.freedesktop.org/drm/intel/issues/8489
  [i915#8502]: https://gitlab.freedesktop.org/drm/intel/issues/8502
  [i915#8503]: https://gitlab.freedesktop.org/drm/intel/issues/8503
  [i915#8617]: https://gitlab.freedesktop.org/drm/intel/issues/8617
  [i915#8623]: https://gitlab.freedesktop.org/drm/intel/issues/8623
  [i915#8661]: https://gitlab.freedesktop.org/drm/intel/issues/8661
  [i915#8668]: https://gitlab.freedesktop.org/drm/intel/issues/8668
  [i915#8708]: https://gitlab.freedesktop.org/drm/intel/issues/8708
  [i915#8709]: https://gitlab.freedesktop.org/drm/intel/issues/8709
  [i915#8827]: https://gitlab.freedesktop.org/drm/intel/issues/8827
  [i915#8841]: https://gitlab.freedesktop.org/drm/intel/issues/8841
  [i915#8962]: https://gitlab.freedesktop.org/drm/intel/issues/8962
  [i915#9121]: https://gitlab.freedesktop.org/drm/intel/issues/9121


Build changes
-------------

  * Linux: CI_DRM_13571 -> Patchwork_122971v1

  CI-20190529: 20190529
  CI_DRM_13571: d3f0e020609215d9097f1b1fad5a13ea0b37548e @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_7454: 7454
  Patchwork_122971v1: d3f0e020609215d9097f1b1fad5a13ea0b37548e @ git://anongit.freedesktop.org/gfx-ci/linux
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122971v1/index.html

[-- Attachment #2: Type: text/html, Size: 53613 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [Intel-gfx] [PATCH] drm/i915/guc: fix compile issue of guc_klvs_abi.h
  2023-08-25  5:50   ` Linyu Yuan
@ 2023-08-28 21:42     ` Michal Wajdeczko
  2023-08-30  2:01       ` Linyu Yuan
  2023-08-30  2:05       ` Linyu Yuan
  0 siblings, 2 replies; 9+ messages in thread
From: Michal Wajdeczko @ 2023-08-28 21:42 UTC (permalink / raw)
  To: Linyu Yuan, Jani Nikula, Joonas Lahtinen, Rodrigo Vivi,
	Tvrtko Ursulin
  Cc: intel-gfx



On 25.08.2023 07:50, Linyu Yuan wrote:
> 
> On 8/25/2023 1:37 PM, Jani Nikula wrote:
>> On Fri, 25 Aug 2023, Linyu Yuan <quic_linyyuan@quicinc.com> wrote:
>>> GCC report GUC_KLV_0_KEY and GUC_KLV_0_LEN is not constant when do
>>> preprocessing.
>> Please paste the actual compiler warning.
> 
> 
>   CC      drivers/gpu/drm/i915/gt/uc/intel_guc_submission.o
> In file included from <command-line>:0:0:
> In function ‘__guc_context_policy_add_priority.isra.47’,
>     inlined from ‘__guc_context_set_prio.isra.48’ at
> drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:3332:3,
>     inlined from ‘guc_context_set_prio’ at
> drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:3360:2:
> ././include/linux/compiler_types.h:397:38: error: call to
> ‘__compiletime_assert_1803’ declared with attribute error: FIELD_PREP:
> mask is not constant
>   _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
>                                       ^
> ././include/linux/compiler_types.h:378:4: note: in definition of macro
> ‘__compiletime_assert’
>     prefix ## suffix();    \
>     ^~~~~~
> ././include/linux/compiler_types.h:397:2: note: in expansion of macro
> ‘_compiletime_assert’
>   _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
>   ^~~~~~~~~~~~~~~~~~~
> ./include/linux/build_bug.h:39:37: note: in expansion of macro
> ‘compiletime_assert’
>  #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
>                                      ^~~~~~~~~~~~~~~~~~
> ./include/linux/bitfield.h:65:3: note: in expansion of macro
> ‘BUILD_BUG_ON_MSG’
>    BUILD_BUG_ON_MSG(!__builtin_constant_p(_mask),  \
>    ^~~~~~~~~~~~~~~~
> ./include/linux/bitfield.h:114:3: note: in expansion of macro
> ‘__BF_FIELD_CHECK’
>    __BF_FIELD_CHECK(_mask, 0ULL, _val, "FIELD_PREP: "); \
>    ^~~~~~~~~~~~~~~~
> drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:2461:3: note: in
> expansion of macro ‘FIELD_PREP’
>    FIELD_PREP(GUC_KLV_0_KEY, GUC_CONTEXT_POLICIES_KLV_ID_##id) | \
>    ^~~~~~~~~~
> drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:2469:1: note: in
> expansion of macro ‘MAKE_CONTEXT_POLICY_ADD’
>  MAKE_CONTEXT_POLICY_ADD(priority, SCHEDULING_PRIORITY)
>  ^~~~~~~~~~~~~~~~~~~~~~~
> In function ‘__guc_context_policy_add_preemption_timeout.isra.51’,
>     inlined from ‘__guc_context_set_preemption_timeout’ at
> drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:3005:3:
> ././include/linux/compiler_types.h:397:38: error: call to
> ‘__compiletime_assert_1793’ declared with attribute error: FIELD_PREP:
> mask is not constant
>   _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
>                                       ^
> ././include/linux/compiler_types.h:378:4: note: in definition of macro
> ‘__compiletime_assert’
>     prefix ## suffix();    \
>     ^~~~~~
> ././include/linux/compiler_types.h:397:2: note: in expansion of macro
> ‘_compiletime_assert’
>   _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
>   ^~~~~~~~~~~~~~~~~~~
> ./include/linux/build_bug.h:39:37: note: in expansion of macro
> ‘compiletime_assert’
>  #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
>                                      ^~~~~~~~~~~~~~~~~~
> ./include/linux/bitfield.h:65:3: note: in expansion of macro
> ‘BUILD_BUG_ON_MSG’
>    BUILD_BUG_ON_MSG(!__builtin_constant_p(_mask),  \
>    ^~~~~~~~~~~~~~~~
> ./include/linux/bitfield.h:114:3: note: in expansion of macro
> ‘__BF_FIELD_CHECK’
>    __BF_FIELD_CHECK(_mask, 0ULL, _val, "FIELD_PREP: "); \
>    ^~~~~~~~~~~~~~~~
> drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:2461:3: note: in
> expansion of macro ‘FIELD_PREP’
>    FIELD_PREP(GUC_KLV_0_KEY, GUC_CONTEXT_POLICIES_KLV_ID_##id) | \
>    ^~~~~~~~~~
> drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:2468:1: note: in
> expansion of macro ‘MAKE_CONTEXT_POLICY_ADD’
>  MAKE_CONTEXT_POLICY_ADD(preemption_timeout, PREEMPTION_TIMEOUT)
>  ^~~~~~~~~~~~~~~~~~~~~~~
> In function ‘__guc_context_policy_add_priority.isra.47’,
>     inlined from ‘__guc_add_request’ at
> drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:2503:2:
> ././include/linux/compiler_types.h:397:38: error: call to
> ‘__compiletime_assert_1803’ declared with attribute error: FIELD_PREP:
> mask is not constant
>   _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
>                                       ^
> ././include/linux/compiler_types.h:378:4: note: in definition of macro
> ‘__compiletime_assert’
>     prefix ## suffix();    \
>     ^~~~~~
> ././include/linux/compiler_types.h:397:2: note: in expansion of macro
> ‘_compiletime_assert’
>   _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
>   ^~~~~~~~~~~~~~~~~~~
> ./include/linux/build_bug.h:39:37: note: in expansion of macro
> ‘compiletime_assert’
>  #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
>                                      ^~~~~~~~~~~~~~~~~~
> ./include/linux/bitfield.h:65:3: note: in expansion of macro
> ‘BUILD_BUG_ON_MSG’
>    BUILD_BUG_ON_MSG(!__builtin_constant_p(_mask),  \
>    ^~~~~~~~~~~~~~~~
> ./include/linux/bitfield.h:114:3: note: in expansion of macro
> ‘__BF_FIELD_CHECK’
>    __BF_FIELD_CHECK(_mask, 0ULL, _val, "FIELD_PREP: "); \
>    ^~~~~~~~~~~~~~~~
> drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:2461:3: note: in
> expansion of macro ‘FIELD_PREP’
>    FIELD_PREP(GUC_KLV_0_KEY, GUC_CONTEXT_POLICIES_KLV_ID_##id) | \
>    ^~~~~~~~~~
> drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:2469:1: note: in
> expansion of macro ‘MAKE_CONTEXT_POLICY_ADD’
>  MAKE_CONTEXT_POLICY_ADD(priority, SCHEDULING_PRIORITY)
>  ^~~~~~~~~~~~~~~~~~~~~~~
> In function ‘__guc_context_policy_add_priority.isra.47’,
>     inlined from ‘register_context’ at
> drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:2503:2:
> ././include/linux/compiler_types.h:397:38: error: call to
> ‘__compiletime_assert_1803’ declared with attribute error: FIELD_PREP:
> mask is not constant
>   _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
>                                       ^
> ././include/linux/compiler_types.h:378:4: note: in definition of macro
> ‘__compiletime_assert’
>     prefix ## suffix();    \
>     ^~~~~~
> ././include/linux/compiler_types.h:397:2: note: in expansion of macro
> ‘_compiletime_assert’
>   _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
>   ^~~~~~~~~~~~~~~~~~~
> ./include/linux/build_bug.h:39:37: note: in expansion of macro
> ‘compiletime_assert’
>  #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
>                                      ^~~~~~~~~~~~~~~~~~
> ./include/linux/bitfield.h:65:3: note: in expansion of macro
> ‘BUILD_BUG_ON_MSG’
>    BUILD_BUG_ON_MSG(!__builtin_constant_p(_mask),  \
>    ^~~~~~~~~~~~~~~~
> ./include/linux/bitfield.h:114:3: note: in expansion of macro
> ‘__BF_FIELD_CHECK’
>    __BF_FIELD_CHECK(_mask, 0ULL, _val, "FIELD_PREP: "); \
>    ^~~~~~~~~~~~~~~~
> drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:2461:3: note: in
> expansion of macro ‘FIELD_PREP’
>    FIELD_PREP(GUC_KLV_0_KEY, GUC_CONTEXT_POLICIES_KLV_ID_##id) | \
>    ^~~~~~~~~~
> drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:2469:1: note: in
> expansion of macro ‘MAKE_CONTEXT_POLICY_ADD’
>  MAKE_CONTEXT_POLICY_ADD(priority, SCHEDULING_PRIORITY)
>  ^~~~~~~~~~~~~~~~~~~~~~~
> In function ‘__guc_scheduling_policy_add_klv.isra.56’,
>     inlined from ‘guc_init_global_schedule_policy’ at
> drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:4449:3,
>     inlined from ‘intel_guc_submission_enable’ at
> drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:4490:6:
> ././include/linux/compiler_types.h:397:38: error: call to
> ‘__compiletime_assert_1882’ declared with attribute error: FIELD_PREP:
> mask is not constant
>   _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
>                                       ^
> ././include/linux/compiler_types.h:378:4: note: in definition of macro
> ‘__compiletime_assert’
>     prefix ## suffix();    \
>     ^~~~~~
> ././include/linux/compiler_types.h:397:2: note: in expansion of macro
> ‘_compiletime_assert’
>   _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
>   ^~~~~~~~~~~~~~~~~~~
> ./include/linux/build_bug.h:39:37: note: in expansion of macro
> ‘compiletime_assert’
>  #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
>                                      ^~~~~~~~~~~~~~~~~~
> ./include/linux/bitfield.h:65:3: note: in expansion of macro
> ‘BUILD_BUG_ON_MSG’
>    BUILD_BUG_ON_MSG(!__builtin_constant_p(_mask),  \
>    ^~~~~~~~~~~~~~~~
> ./include/linux/bitfield.h:114:3: note: in expansion of macro
> ‘__BF_FIELD_CHECK’
>    __BF_FIELD_CHECK(_mask, 0ULL, _val, "FIELD_PREP: "); \
>    ^~~~~~~~~~~~~~~~
> drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:4401:17: note: in
> expansion of macro ‘FIELD_PREP’
>   *(klv_ptr++) = FIELD_PREP(GUC_KLV_0_KEY, action) |
>                  ^~~~~~~~~~
> scripts/Makefile.build:243: recipe for target
> 'drivers/gpu/drm/i915/gt/uc/intel_guc_submission.o' failed
> 

What GCC/.config was it?

In the meantime, can you try simpler fix below (we want to avoid
external dependencies in GuC ABI headers)

-#define GUC_KLV_0_KEY                          (0xffff << 16)
+#define GUC_KLV_0_KEY                          (0xffffu << 16)

Michal

> 
>>
>> BR,
>> Jani.
>>
>>
>>
>>> Change to use GENMASK() to avoid the issue.
>>>
>>> Signed-off-by: Linyu Yuan <quic_linyyuan@quicinc.com>
>>> ---
>>>   drivers/gpu/drm/i915/gt/uc/abi/guc_klvs_abi.h | 4 ++--
>>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/i915/gt/uc/abi/guc_klvs_abi.h
>>> b/drivers/gpu/drm/i915/gt/uc/abi/guc_klvs_abi.h
>>> index 58012edd4eb0..fd3c16695e5f 100644
>>> --- a/drivers/gpu/drm/i915/gt/uc/abi/guc_klvs_abi.h
>>> +++ b/drivers/gpu/drm/i915/gt/uc/abi/guc_klvs_abi.h
>>> @@ -29,8 +29,8 @@
>>>    */
>>>     #define GUC_KLV_LEN_MIN                1u
>>> -#define GUC_KLV_0_KEY                (0xffff << 16)
>>> -#define GUC_KLV_0_LEN                (0xffff << 0)
>>> +#define GUC_KLV_0_KEY                GENMASK(31, 16)
>>> +#define GUC_KLV_0_LEN                GENMASK(15, 0)
>>>   #define GUC_KLV_n_VALUE                (0xffffffff << 0)
>>>     /**

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [Intel-gfx] [PATCH] drm/i915/guc: fix compile issue of guc_klvs_abi.h
  2023-08-28 21:42     ` Michal Wajdeczko
@ 2023-08-30  2:01       ` Linyu Yuan
  2023-08-30  2:05       ` Linyu Yuan
  1 sibling, 0 replies; 9+ messages in thread
From: Linyu Yuan @ 2023-08-30  2:01 UTC (permalink / raw)
  To: Michal Wajdeczko, Jani Nikula, Joonas Lahtinen, Rodrigo Vivi,
	Tvrtko Ursulin
  Cc: intel-gfx


On 8/29/2023 5:42 AM, Michal Wajdeczko wrote:
>
> On 25.08.2023 07:50, Linyu Yuan wrote:
>> On 8/25/2023 1:37 PM, Jani Nikula wrote:
>>> On Fri, 25 Aug 2023, Linyu Yuan <quic_linyyuan@quicinc.com> wrote:
>>>> GCC report GUC_KLV_0_KEY and GUC_KLV_0_LEN is not constant when do
>>>> preprocessing.
>>> Please paste the actual compiler warning.
>>
>>    CC      drivers/gpu/drm/i915/gt/uc/intel_guc_submission.o
>> In file included from <command-line>:0:0:
>> In function ‘__guc_context_policy_add_priority.isra.47’,
>>      inlined from ‘__guc_context_set_prio.isra.48’ at
>> drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:3332:3,
>>      inlined from ‘guc_context_set_prio’ at
>> drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:3360:2:
>> ././include/linux/compiler_types.h:397:38: error: call to
>> ‘__compiletime_assert_1803’ declared with attribute error: FIELD_PREP:
>> mask is not constant
>>    _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
>>                                        ^
>> ././include/linux/compiler_types.h:378:4: note: in definition of macro
>> ‘__compiletime_assert’
>>      prefix ## suffix();    \
>>      ^~~~~~
>> ././include/linux/compiler_types.h:397:2: note: in expansion of macro
>> ‘_compiletime_assert’
>>    _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
>>    ^~~~~~~~~~~~~~~~~~~
>> ./include/linux/build_bug.h:39:37: note: in expansion of macro
>> ‘compiletime_assert’
>>   #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
>>                                       ^~~~~~~~~~~~~~~~~~
>> ./include/linux/bitfield.h:65:3: note: in expansion of macro
>> ‘BUILD_BUG_ON_MSG’
>>     BUILD_BUG_ON_MSG(!__builtin_constant_p(_mask),  \
>>     ^~~~~~~~~~~~~~~~
>> ./include/linux/bitfield.h:114:3: note: in expansion of macro
>> ‘__BF_FIELD_CHECK’
>>     __BF_FIELD_CHECK(_mask, 0ULL, _val, "FIELD_PREP: "); \
>>     ^~~~~~~~~~~~~~~~
>> drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:2461:3: note: in
>> expansion of macro ‘FIELD_PREP’
>>     FIELD_PREP(GUC_KLV_0_KEY, GUC_CONTEXT_POLICIES_KLV_ID_##id) | \
>>     ^~~~~~~~~~
>> drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:2469:1: note: in
>> expansion of macro ‘MAKE_CONTEXT_POLICY_ADD’
>>   MAKE_CONTEXT_POLICY_ADD(priority, SCHEDULING_PRIORITY)
>>   ^~~~~~~~~~~~~~~~~~~~~~~
>> In function ‘__guc_context_policy_add_preemption_timeout.isra.51’,
>>      inlined from ‘__guc_context_set_preemption_timeout’ at
>> drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:3005:3:
>> ././include/linux/compiler_types.h:397:38: error: call to
>> ‘__compiletime_assert_1793’ declared with attribute error: FIELD_PREP:
>> mask is not constant
>>    _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
>>                                        ^
>> ././include/linux/compiler_types.h:378:4: note: in definition of macro
>> ‘__compiletime_assert’
>>      prefix ## suffix();    \
>>      ^~~~~~
>> ././include/linux/compiler_types.h:397:2: note: in expansion of macro
>> ‘_compiletime_assert’
>>    _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
>>    ^~~~~~~~~~~~~~~~~~~
>> ./include/linux/build_bug.h:39:37: note: in expansion of macro
>> ‘compiletime_assert’
>>   #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
>>                                       ^~~~~~~~~~~~~~~~~~
>> ./include/linux/bitfield.h:65:3: note: in expansion of macro
>> ‘BUILD_BUG_ON_MSG’
>>     BUILD_BUG_ON_MSG(!__builtin_constant_p(_mask),  \
>>     ^~~~~~~~~~~~~~~~
>> ./include/linux/bitfield.h:114:3: note: in expansion of macro
>> ‘__BF_FIELD_CHECK’
>>     __BF_FIELD_CHECK(_mask, 0ULL, _val, "FIELD_PREP: "); \
>>     ^~~~~~~~~~~~~~~~
>> drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:2461:3: note: in
>> expansion of macro ‘FIELD_PREP’
>>     FIELD_PREP(GUC_KLV_0_KEY, GUC_CONTEXT_POLICIES_KLV_ID_##id) | \
>>     ^~~~~~~~~~
>> drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:2468:1: note: in
>> expansion of macro ‘MAKE_CONTEXT_POLICY_ADD’
>>   MAKE_CONTEXT_POLICY_ADD(preemption_timeout, PREEMPTION_TIMEOUT)
>>   ^~~~~~~~~~~~~~~~~~~~~~~
>> In function ‘__guc_context_policy_add_priority.isra.47’,
>>      inlined from ‘__guc_add_request’ at
>> drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:2503:2:
>> ././include/linux/compiler_types.h:397:38: error: call to
>> ‘__compiletime_assert_1803’ declared with attribute error: FIELD_PREP:
>> mask is not constant
>>    _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
>>                                        ^
>> ././include/linux/compiler_types.h:378:4: note: in definition of macro
>> ‘__compiletime_assert’
>>      prefix ## suffix();    \
>>      ^~~~~~
>> ././include/linux/compiler_types.h:397:2: note: in expansion of macro
>> ‘_compiletime_assert’
>>    _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
>>    ^~~~~~~~~~~~~~~~~~~
>> ./include/linux/build_bug.h:39:37: note: in expansion of macro
>> ‘compiletime_assert’
>>   #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
>>                                       ^~~~~~~~~~~~~~~~~~
>> ./include/linux/bitfield.h:65:3: note: in expansion of macro
>> ‘BUILD_BUG_ON_MSG’
>>     BUILD_BUG_ON_MSG(!__builtin_constant_p(_mask),  \
>>     ^~~~~~~~~~~~~~~~
>> ./include/linux/bitfield.h:114:3: note: in expansion of macro
>> ‘__BF_FIELD_CHECK’
>>     __BF_FIELD_CHECK(_mask, 0ULL, _val, "FIELD_PREP: "); \
>>     ^~~~~~~~~~~~~~~~
>> drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:2461:3: note: in
>> expansion of macro ‘FIELD_PREP’
>>     FIELD_PREP(GUC_KLV_0_KEY, GUC_CONTEXT_POLICIES_KLV_ID_##id) | \
>>     ^~~~~~~~~~
>> drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:2469:1: note: in
>> expansion of macro ‘MAKE_CONTEXT_POLICY_ADD’
>>   MAKE_CONTEXT_POLICY_ADD(priority, SCHEDULING_PRIORITY)
>>   ^~~~~~~~~~~~~~~~~~~~~~~
>> In function ‘__guc_context_policy_add_priority.isra.47’,
>>      inlined from ‘register_context’ at
>> drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:2503:2:
>> ././include/linux/compiler_types.h:397:38: error: call to
>> ‘__compiletime_assert_1803’ declared with attribute error: FIELD_PREP:
>> mask is not constant
>>    _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
>>                                        ^
>> ././include/linux/compiler_types.h:378:4: note: in definition of macro
>> ‘__compiletime_assert’
>>      prefix ## suffix();    \
>>      ^~~~~~
>> ././include/linux/compiler_types.h:397:2: note: in expansion of macro
>> ‘_compiletime_assert’
>>    _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
>>    ^~~~~~~~~~~~~~~~~~~
>> ./include/linux/build_bug.h:39:37: note: in expansion of macro
>> ‘compiletime_assert’
>>   #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
>>                                       ^~~~~~~~~~~~~~~~~~
>> ./include/linux/bitfield.h:65:3: note: in expansion of macro
>> ‘BUILD_BUG_ON_MSG’
>>     BUILD_BUG_ON_MSG(!__builtin_constant_p(_mask),  \
>>     ^~~~~~~~~~~~~~~~
>> ./include/linux/bitfield.h:114:3: note: in expansion of macro
>> ‘__BF_FIELD_CHECK’
>>     __BF_FIELD_CHECK(_mask, 0ULL, _val, "FIELD_PREP: "); \
>>     ^~~~~~~~~~~~~~~~
>> drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:2461:3: note: in
>> expansion of macro ‘FIELD_PREP’
>>     FIELD_PREP(GUC_KLV_0_KEY, GUC_CONTEXT_POLICIES_KLV_ID_##id) | \
>>     ^~~~~~~~~~
>> drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:2469:1: note: in
>> expansion of macro ‘MAKE_CONTEXT_POLICY_ADD’
>>   MAKE_CONTEXT_POLICY_ADD(priority, SCHEDULING_PRIORITY)
>>   ^~~~~~~~~~~~~~~~~~~~~~~
>> In function ‘__guc_scheduling_policy_add_klv.isra.56’,
>>      inlined from ‘guc_init_global_schedule_policy’ at
>> drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:4449:3,
>>      inlined from ‘intel_guc_submission_enable’ at
>> drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:4490:6:
>> ././include/linux/compiler_types.h:397:38: error: call to
>> ‘__compiletime_assert_1882’ declared with attribute error: FIELD_PREP:
>> mask is not constant
>>    _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
>>                                        ^
>> ././include/linux/compiler_types.h:378:4: note: in definition of macro
>> ‘__compiletime_assert’
>>      prefix ## suffix();    \
>>      ^~~~~~
>> ././include/linux/compiler_types.h:397:2: note: in expansion of macro
>> ‘_compiletime_assert’
>>    _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
>>    ^~~~~~~~~~~~~~~~~~~
>> ./include/linux/build_bug.h:39:37: note: in expansion of macro
>> ‘compiletime_assert’
>>   #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
>>                                       ^~~~~~~~~~~~~~~~~~
>> ./include/linux/bitfield.h:65:3: note: in expansion of macro
>> ‘BUILD_BUG_ON_MSG’
>>     BUILD_BUG_ON_MSG(!__builtin_constant_p(_mask),  \
>>     ^~~~~~~~~~~~~~~~
>> ./include/linux/bitfield.h:114:3: note: in expansion of macro
>> ‘__BF_FIELD_CHECK’
>>     __BF_FIELD_CHECK(_mask, 0ULL, _val, "FIELD_PREP: "); \
>>     ^~~~~~~~~~~~~~~~
>> drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:4401:17: note: in
>> expansion of macro ‘FIELD_PREP’
>>    *(klv_ptr++) = FIELD_PREP(GUC_KLV_0_KEY, action) |
>>                   ^~~~~~~~~~
>> scripts/Makefile.build:243: recipe for target
>> 'drivers/gpu/drm/i915/gt/uc/intel_guc_submission.o' failed
>>
> What GCC/.config was it?
>
> In the meantime, can you try simpler fix below (we want to avoid
> external dependencies in GuC ABI headers)
>
> -#define GUC_KLV_0_KEY                          (0xffff << 16)
> +#define GUC_KLV_0_KEY                          (0xffffu << 16)


i test it, this change can solve the issue, please submit a change.


> Michal
>
>>> BR,
>>> Jani.
>>>
>>>
>>>
>>>> Change to use GENMASK() to avoid the issue.
>>>>
>>>> Signed-off-by: Linyu Yuan <quic_linyyuan@quicinc.com>
>>>> ---
>>>>    drivers/gpu/drm/i915/gt/uc/abi/guc_klvs_abi.h | 4 ++--
>>>>    1 file changed, 2 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/drivers/gpu/drm/i915/gt/uc/abi/guc_klvs_abi.h
>>>> b/drivers/gpu/drm/i915/gt/uc/abi/guc_klvs_abi.h
>>>> index 58012edd4eb0..fd3c16695e5f 100644
>>>> --- a/drivers/gpu/drm/i915/gt/uc/abi/guc_klvs_abi.h
>>>> +++ b/drivers/gpu/drm/i915/gt/uc/abi/guc_klvs_abi.h
>>>> @@ -29,8 +29,8 @@
>>>>     */
>>>>      #define GUC_KLV_LEN_MIN                1u
>>>> -#define GUC_KLV_0_KEY                (0xffff << 16)
>>>> -#define GUC_KLV_0_LEN                (0xffff << 0)
>>>> +#define GUC_KLV_0_KEY                GENMASK(31, 16)
>>>> +#define GUC_KLV_0_LEN                GENMASK(15, 0)
>>>>    #define GUC_KLV_n_VALUE                (0xffffffff << 0)
>>>>      /**

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [Intel-gfx] [PATCH] drm/i915/guc: fix compile issue of guc_klvs_abi.h
  2023-08-28 21:42     ` Michal Wajdeczko
  2023-08-30  2:01       ` Linyu Yuan
@ 2023-08-30  2:05       ` Linyu Yuan
  1 sibling, 0 replies; 9+ messages in thread
From: Linyu Yuan @ 2023-08-30  2:05 UTC (permalink / raw)
  To: Michal Wajdeczko, Jani Nikula, Joonas Lahtinen, Rodrigo Vivi,
	Tvrtko Ursulin
  Cc: intel-gfx


On 8/29/2023 5:42 AM, Michal Wajdeczko wrote:
>
> On 25.08.2023 07:50, Linyu Yuan wrote:
>> On 8/25/2023 1:37 PM, Jani Nikula wrote:
>>> On Fri, 25 Aug 2023, Linyu Yuan <quic_linyyuan@quicinc.com> wrote:
>>>> GCC report GUC_KLV_0_KEY and GUC_KLV_0_LEN is not constant when do
>>>> preprocessing.
>>> Please paste the actual compiler warning.
>>
>>    CC      drivers/gpu/drm/i915/gt/uc/intel_guc_submission.o
>> In file included from <command-line>:0:0:
>> In function ‘__guc_context_policy_add_priority.isra.47’,
>>      inlined from ‘__guc_context_set_prio.isra.48’ at
>> drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:3332:3,
>>      inlined from ‘guc_context_set_prio’ at
>> drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:3360:2:
>> ././include/linux/compiler_types.h:397:38: error: call to
>> ‘__compiletime_assert_1803’ declared with attribute error: FIELD_PREP:
>> mask is not constant
>>    _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
>>                                        ^
>> ././include/linux/compiler_types.h:378:4: note: in definition of macro
>> ‘__compiletime_assert’
>>      prefix ## suffix();    \
>>      ^~~~~~
>> ././include/linux/compiler_types.h:397:2: note: in expansion of macro
>> ‘_compiletime_assert’
>>    _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
>>    ^~~~~~~~~~~~~~~~~~~
>> ./include/linux/build_bug.h:39:37: note: in expansion of macro
>> ‘compiletime_assert’
>>   #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
>>                                       ^~~~~~~~~~~~~~~~~~
>> ./include/linux/bitfield.h:65:3: note: in expansion of macro
>> ‘BUILD_BUG_ON_MSG’
>>     BUILD_BUG_ON_MSG(!__builtin_constant_p(_mask),  \
>>     ^~~~~~~~~~~~~~~~
>> ./include/linux/bitfield.h:114:3: note: in expansion of macro
>> ‘__BF_FIELD_CHECK’
>>     __BF_FIELD_CHECK(_mask, 0ULL, _val, "FIELD_PREP: "); \
>>     ^~~~~~~~~~~~~~~~
>> drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:2461:3: note: in
>> expansion of macro ‘FIELD_PREP’
>>     FIELD_PREP(GUC_KLV_0_KEY, GUC_CONTEXT_POLICIES_KLV_ID_##id) | \
>>     ^~~~~~~~~~
>> drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:2469:1: note: in
>> expansion of macro ‘MAKE_CONTEXT_POLICY_ADD’
>>   MAKE_CONTEXT_POLICY_ADD(priority, SCHEDULING_PRIORITY)
>>   ^~~~~~~~~~~~~~~~~~~~~~~
>> In function ‘__guc_context_policy_add_preemption_timeout.isra.51’,
>>      inlined from ‘__guc_context_set_preemption_timeout’ at
>> drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:3005:3:
>> ././include/linux/compiler_types.h:397:38: error: call to
>> ‘__compiletime_assert_1793’ declared with attribute error: FIELD_PREP:
>> mask is not constant
>>    _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
>>                                        ^
>> ././include/linux/compiler_types.h:378:4: note: in definition of macro
>> ‘__compiletime_assert’
>>      prefix ## suffix();    \
>>      ^~~~~~
>> ././include/linux/compiler_types.h:397:2: note: in expansion of macro
>> ‘_compiletime_assert’
>>    _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
>>    ^~~~~~~~~~~~~~~~~~~
>> ./include/linux/build_bug.h:39:37: note: in expansion of macro
>> ‘compiletime_assert’
>>   #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
>>                                       ^~~~~~~~~~~~~~~~~~
>> ./include/linux/bitfield.h:65:3: note: in expansion of macro
>> ‘BUILD_BUG_ON_MSG’
>>     BUILD_BUG_ON_MSG(!__builtin_constant_p(_mask),  \
>>     ^~~~~~~~~~~~~~~~
>> ./include/linux/bitfield.h:114:3: note: in expansion of macro
>> ‘__BF_FIELD_CHECK’
>>     __BF_FIELD_CHECK(_mask, 0ULL, _val, "FIELD_PREP: "); \
>>     ^~~~~~~~~~~~~~~~
>> drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:2461:3: note: in
>> expansion of macro ‘FIELD_PREP’
>>     FIELD_PREP(GUC_KLV_0_KEY, GUC_CONTEXT_POLICIES_KLV_ID_##id) | \
>>     ^~~~~~~~~~
>> drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:2468:1: note: in
>> expansion of macro ‘MAKE_CONTEXT_POLICY_ADD’
>>   MAKE_CONTEXT_POLICY_ADD(preemption_timeout, PREEMPTION_TIMEOUT)
>>   ^~~~~~~~~~~~~~~~~~~~~~~
>> In function ‘__guc_context_policy_add_priority.isra.47’,
>>      inlined from ‘__guc_add_request’ at
>> drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:2503:2:
>> ././include/linux/compiler_types.h:397:38: error: call to
>> ‘__compiletime_assert_1803’ declared with attribute error: FIELD_PREP:
>> mask is not constant
>>    _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
>>                                        ^
>> ././include/linux/compiler_types.h:378:4: note: in definition of macro
>> ‘__compiletime_assert’
>>      prefix ## suffix();    \
>>      ^~~~~~
>> ././include/linux/compiler_types.h:397:2: note: in expansion of macro
>> ‘_compiletime_assert’
>>    _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
>>    ^~~~~~~~~~~~~~~~~~~
>> ./include/linux/build_bug.h:39:37: note: in expansion of macro
>> ‘compiletime_assert’
>>   #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
>>                                       ^~~~~~~~~~~~~~~~~~
>> ./include/linux/bitfield.h:65:3: note: in expansion of macro
>> ‘BUILD_BUG_ON_MSG’
>>     BUILD_BUG_ON_MSG(!__builtin_constant_p(_mask),  \
>>     ^~~~~~~~~~~~~~~~
>> ./include/linux/bitfield.h:114:3: note: in expansion of macro
>> ‘__BF_FIELD_CHECK’
>>     __BF_FIELD_CHECK(_mask, 0ULL, _val, "FIELD_PREP: "); \
>>     ^~~~~~~~~~~~~~~~
>> drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:2461:3: note: in
>> expansion of macro ‘FIELD_PREP’
>>     FIELD_PREP(GUC_KLV_0_KEY, GUC_CONTEXT_POLICIES_KLV_ID_##id) | \
>>     ^~~~~~~~~~
>> drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:2469:1: note: in
>> expansion of macro ‘MAKE_CONTEXT_POLICY_ADD’
>>   MAKE_CONTEXT_POLICY_ADD(priority, SCHEDULING_PRIORITY)
>>   ^~~~~~~~~~~~~~~~~~~~~~~
>> In function ‘__guc_context_policy_add_priority.isra.47’,
>>      inlined from ‘register_context’ at
>> drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:2503:2:
>> ././include/linux/compiler_types.h:397:38: error: call to
>> ‘__compiletime_assert_1803’ declared with attribute error: FIELD_PREP:
>> mask is not constant
>>    _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
>>                                        ^
>> ././include/linux/compiler_types.h:378:4: note: in definition of macro
>> ‘__compiletime_assert’
>>      prefix ## suffix();    \
>>      ^~~~~~
>> ././include/linux/compiler_types.h:397:2: note: in expansion of macro
>> ‘_compiletime_assert’
>>    _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
>>    ^~~~~~~~~~~~~~~~~~~
>> ./include/linux/build_bug.h:39:37: note: in expansion of macro
>> ‘compiletime_assert’
>>   #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
>>                                       ^~~~~~~~~~~~~~~~~~
>> ./include/linux/bitfield.h:65:3: note: in expansion of macro
>> ‘BUILD_BUG_ON_MSG’
>>     BUILD_BUG_ON_MSG(!__builtin_constant_p(_mask),  \
>>     ^~~~~~~~~~~~~~~~
>> ./include/linux/bitfield.h:114:3: note: in expansion of macro
>> ‘__BF_FIELD_CHECK’
>>     __BF_FIELD_CHECK(_mask, 0ULL, _val, "FIELD_PREP: "); \
>>     ^~~~~~~~~~~~~~~~
>> drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:2461:3: note: in
>> expansion of macro ‘FIELD_PREP’
>>     FIELD_PREP(GUC_KLV_0_KEY, GUC_CONTEXT_POLICIES_KLV_ID_##id) | \
>>     ^~~~~~~~~~
>> drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:2469:1: note: in
>> expansion of macro ‘MAKE_CONTEXT_POLICY_ADD’
>>   MAKE_CONTEXT_POLICY_ADD(priority, SCHEDULING_PRIORITY)
>>   ^~~~~~~~~~~~~~~~~~~~~~~
>> In function ‘__guc_scheduling_policy_add_klv.isra.56’,
>>      inlined from ‘guc_init_global_schedule_policy’ at
>> drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:4449:3,
>>      inlined from ‘intel_guc_submission_enable’ at
>> drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:4490:6:
>> ././include/linux/compiler_types.h:397:38: error: call to
>> ‘__compiletime_assert_1882’ declared with attribute error: FIELD_PREP:
>> mask is not constant
>>    _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
>>                                        ^
>> ././include/linux/compiler_types.h:378:4: note: in definition of macro
>> ‘__compiletime_assert’
>>      prefix ## suffix();    \
>>      ^~~~~~
>> ././include/linux/compiler_types.h:397:2: note: in expansion of macro
>> ‘_compiletime_assert’
>>    _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
>>    ^~~~~~~~~~~~~~~~~~~
>> ./include/linux/build_bug.h:39:37: note: in expansion of macro
>> ‘compiletime_assert’
>>   #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
>>                                       ^~~~~~~~~~~~~~~~~~
>> ./include/linux/bitfield.h:65:3: note: in expansion of macro
>> ‘BUILD_BUG_ON_MSG’
>>     BUILD_BUG_ON_MSG(!__builtin_constant_p(_mask),  \
>>     ^~~~~~~~~~~~~~~~
>> ./include/linux/bitfield.h:114:3: note: in expansion of macro
>> ‘__BF_FIELD_CHECK’
>>     __BF_FIELD_CHECK(_mask, 0ULL, _val, "FIELD_PREP: "); \
>>     ^~~~~~~~~~~~~~~~
>> drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:4401:17: note: in
>> expansion of macro ‘FIELD_PREP’
>>    *(klv_ptr++) = FIELD_PREP(GUC_KLV_0_KEY, action) |
>>                   ^~~~~~~~~~
>> scripts/Makefile.build:243: recipe for target
>> 'drivers/gpu/drm/i915/gt/uc/intel_guc_submission.o' failed
>>
> What GCC/.config was it?


gcc (Ubuntu 7.5.0-3ubuntu1~18.04) 7.5.0


make ARCH=x86 allyesconfig


>
> In the meantime, can you try simpler fix below (we want to avoid
> external dependencies in GuC ABI headers)
>
> -#define GUC_KLV_0_KEY                          (0xffff << 16)
> +#define GUC_KLV_0_KEY                          (0xffffu << 16)
>
> Michal
>
>>> BR,
>>> Jani.
>>>
>>>
>>>
>>>> Change to use GENMASK() to avoid the issue.
>>>>
>>>> Signed-off-by: Linyu Yuan <quic_linyyuan@quicinc.com>
>>>> ---
>>>>    drivers/gpu/drm/i915/gt/uc/abi/guc_klvs_abi.h | 4 ++--
>>>>    1 file changed, 2 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/drivers/gpu/drm/i915/gt/uc/abi/guc_klvs_abi.h
>>>> b/drivers/gpu/drm/i915/gt/uc/abi/guc_klvs_abi.h
>>>> index 58012edd4eb0..fd3c16695e5f 100644
>>>> --- a/drivers/gpu/drm/i915/gt/uc/abi/guc_klvs_abi.h
>>>> +++ b/drivers/gpu/drm/i915/gt/uc/abi/guc_klvs_abi.h
>>>> @@ -29,8 +29,8 @@
>>>>     */
>>>>      #define GUC_KLV_LEN_MIN                1u
>>>> -#define GUC_KLV_0_KEY                (0xffff << 16)
>>>> -#define GUC_KLV_0_LEN                (0xffff << 0)
>>>> +#define GUC_KLV_0_KEY                GENMASK(31, 16)
>>>> +#define GUC_KLV_0_LEN                GENMASK(15, 0)
>>>>    #define GUC_KLV_n_VALUE                (0xffffffff << 0)
>>>>      /**

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2023-08-31 21:34 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-25  5:00 [Intel-gfx] [PATCH] drm/i915/guc: fix compile issue of guc_klvs_abi.h Linyu Yuan
2023-08-25  5:37 ` Jani Nikula
2023-08-25  5:50   ` Linyu Yuan
2023-08-28 21:42     ` Michal Wajdeczko
2023-08-30  2:01       ` Linyu Yuan
2023-08-30  2:05       ` Linyu Yuan
2023-08-28 13:37 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for " Patchwork
2023-08-28 13:53 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-08-28 15:49 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox