* [Intel-gfx] [PATCH] drm/i915/ddi: Ensure that the value assigned to ddi_clk_needed is a bool
@ 2020-01-29 22:05 Vivek Kasireddy
2020-01-30 3:09 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
2020-01-30 9:41 ` [Intel-gfx] [PATCH] " Jani Nikula
0 siblings, 2 replies; 3+ messages in thread
From: Vivek Kasireddy @ 2020-01-29 22:05 UTC (permalink / raw)
To: intel-gfx; +Cc: Jani Nikula
Currently, the value assigned to the bool variable ddi_clk_needed
is a pointer -- which appears to have happened inadvertently. Therefore,
add a "!!" before the expression on the right to ensure that it results
in a bool.
Cc: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Vivek Kasireddy <vivek.kasireddy@intel.com>
---
drivers/gpu/drm/i915/display/intel_ddi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
index c96f629cddc3..6df485289bc6 100644
--- a/drivers/gpu/drm/i915/display/intel_ddi.c
+++ b/drivers/gpu/drm/i915/display/intel_ddi.c
@@ -3109,7 +3109,7 @@ void icl_sanitize_encoder_pll_mapping(struct intel_encoder *encoder)
}
port_mask = BIT(encoder->port);
- ddi_clk_needed = encoder->base.crtc;
+ ddi_clk_needed = !!encoder->base.crtc;
if (encoder->type == INTEL_OUTPUT_DSI) {
struct intel_encoder *other_encoder;
--
2.21.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/ddi: Ensure that the value assigned to ddi_clk_needed is a bool
2020-01-29 22:05 [Intel-gfx] [PATCH] drm/i915/ddi: Ensure that the value assigned to ddi_clk_needed is a bool Vivek Kasireddy
@ 2020-01-30 3:09 ` Patchwork
2020-01-30 9:41 ` [Intel-gfx] [PATCH] " Jani Nikula
1 sibling, 0 replies; 3+ messages in thread
From: Patchwork @ 2020-01-30 3:09 UTC (permalink / raw)
To: Vivek Kasireddy; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/ddi: Ensure that the value assigned to ddi_clk_needed is a bool
URL : https://patchwork.freedesktop.org/series/72743/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_7839 -> Patchwork_16321
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_16321 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_16321, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16321/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_16321:
### IGT changes ###
#### Possible regressions ####
* igt@runner@aborted:
- fi-bsw-kefka: NOTRUN -> [FAIL][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16321/fi-bsw-kefka/igt@runner@aborted.html
Known issues
------------
Here are the changes found in Patchwork_16321 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_close_race@basic-threads:
- fi-byt-j1900: [PASS][2] -> [TIMEOUT][3] ([fdo#112271] / [i915#816])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7839/fi-byt-j1900/igt@gem_close_race@basic-threads.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16321/fi-byt-j1900/igt@gem_close_race@basic-threads.html
* igt@i915_selftest@live_blt:
- fi-hsw-4770r: [PASS][4] -> [DMESG-FAIL][5] ([i915#563])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7839/fi-hsw-4770r/igt@i915_selftest@live_blt.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16321/fi-hsw-4770r/igt@i915_selftest@live_blt.html
- fi-ivb-3770: [PASS][6] -> [DMESG-FAIL][7] ([i915#563])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7839/fi-ivb-3770/igt@i915_selftest@live_blt.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16321/fi-ivb-3770/igt@i915_selftest@live_blt.html
* igt@i915_selftest@live_gtt:
- fi-kbl-7500u: [PASS][8] -> [TIMEOUT][9] ([fdo#112271])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7839/fi-kbl-7500u/igt@i915_selftest@live_gtt.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16321/fi-kbl-7500u/igt@i915_selftest@live_gtt.html
- fi-skl-6600u: [PASS][10] -> [TIMEOUT][11] ([fdo#111732] / [fdo#112271])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7839/fi-skl-6600u/igt@i915_selftest@live_gtt.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16321/fi-skl-6600u/igt@i915_selftest@live_gtt.html
#### Possible fixes ####
* igt@gem_exec_parallel@contexts:
- fi-byt-n2820: [TIMEOUT][12] ([fdo#112271]) -> [PASS][13]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7839/fi-byt-n2820/igt@gem_exec_parallel@contexts.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16321/fi-byt-n2820/igt@gem_exec_parallel@contexts.html
[fdo#111732]: https://bugs.freedesktop.org/show_bug.cgi?id=111732
[fdo#112271]: https://bugs.freedesktop.org/show_bug.cgi?id=112271
[i915#563]: https://gitlab.freedesktop.org/drm/intel/issues/563
[i915#816]: https://gitlab.freedesktop.org/drm/intel/issues/816
Participating hosts (47 -> 45)
------------------------------
Additional (3): fi-hsw-peppy fi-bsw-kefka fi-kbl-r
Missing (5): fi-hsw-4200u fi-skl-6770hq fi-byt-squawks fi-bsw-cyan fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7839 -> Patchwork_16321
CI-20190529: 20190529
CI_DRM_7839: 41a9319a45aaf77e220c8101d6ce76ec66036ffc @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5406: 786c79af483a9f6e4688811f74116030c734ca1f @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_16321: ddc00521ad241d85f6799314408ea6a55c43882e @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
ddc00521ad24 drm/i915/ddi: Ensure that the value assigned to ddi_clk_needed is a bool
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16321/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/ddi: Ensure that the value assigned to ddi_clk_needed is a bool
2020-01-29 22:05 [Intel-gfx] [PATCH] drm/i915/ddi: Ensure that the value assigned to ddi_clk_needed is a bool Vivek Kasireddy
2020-01-30 3:09 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
@ 2020-01-30 9:41 ` Jani Nikula
1 sibling, 0 replies; 3+ messages in thread
From: Jani Nikula @ 2020-01-30 9:41 UTC (permalink / raw)
To: Vivek Kasireddy, intel-gfx
On Wed, 29 Jan 2020, Vivek Kasireddy <vivek.kasireddy@intel.com> wrote:
> Currently, the value assigned to the bool variable ddi_clk_needed
> is a pointer -- which appears to have happened inadvertently. Therefore,
> add a "!!" before the expression on the right to ensure that it results
> in a bool.
Please don't do this.
The !! is only needed for compressing the value to 0 or 1 when the left
operand is not a bool. It was customary in the days of yore when bool
was just a typedeffed int.
For standard bools, "When any scalar value is converted to _Bool, the
result is 0 if the value compares equal to 0; otherwise, the result is
1."
BR,
Jani.
>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Signed-off-by: Vivek Kasireddy <vivek.kasireddy@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_ddi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
> index c96f629cddc3..6df485289bc6 100644
> --- a/drivers/gpu/drm/i915/display/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/display/intel_ddi.c
> @@ -3109,7 +3109,7 @@ void icl_sanitize_encoder_pll_mapping(struct intel_encoder *encoder)
> }
>
> port_mask = BIT(encoder->port);
> - ddi_clk_needed = encoder->base.crtc;
> + ddi_clk_needed = !!encoder->base.crtc;
>
> if (encoder->type == INTEL_OUTPUT_DSI) {
> struct intel_encoder *other_encoder;
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-01-30 9:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-01-29 22:05 [Intel-gfx] [PATCH] drm/i915/ddi: Ensure that the value assigned to ddi_clk_needed is a bool Vivek Kasireddy
2020-01-30 3:09 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
2020-01-30 9:41 ` [Intel-gfx] [PATCH] " Jani Nikula
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox