public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
* [Intel-gfx] [RESEND] drm/i915/syncmap: squelch a sparse warning
@ 2023-11-29 17:35 Jani Nikula
  2023-11-29 19:21 ` Rodrigo Vivi
                   ` (5 more replies)
  0 siblings, 6 replies; 9+ messages in thread
From: Jani Nikula @ 2023-11-29 17:35 UTC (permalink / raw)
  To: intel-gfx; +Cc: jani.nikula

The code is fine, really, but tweak it to get rid of the sparse warning:

drivers/gpu/drm/i915/selftests/i915_syncmap.c:80:54: warning: dubious: x | !y

Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/selftests/i915_syncmap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/selftests/i915_syncmap.c b/drivers/gpu/drm/i915/selftests/i915_syncmap.c
index 47f4ae18a1ef..88fa845e9f4a 100644
--- a/drivers/gpu/drm/i915/selftests/i915_syncmap.c
+++ b/drivers/gpu/drm/i915/selftests/i915_syncmap.c
@@ -77,7 +77,7 @@ __sync_print(struct i915_syncmap *p,
 		for_each_set_bit(i, (unsigned long *)&p->bitmap, KSYNCMAP) {
 			buf = __sync_print(__sync_child(p)[i], buf, sz,
 					   depth + 1,
-					   last << 1 | !!(p->bitmap >> (i + 1)),
+					   last << 1 | ((p->bitmap >> (i + 1)) ? 1 : 0),
 					   i);
 		}
 	}
-- 
2.39.2


^ permalink raw reply related	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2023-12-04 10:12 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-29 17:35 [Intel-gfx] [RESEND] drm/i915/syncmap: squelch a sparse warning Jani Nikula
2023-11-29 19:21 ` Rodrigo Vivi
2023-12-04 10:12   ` Jani Nikula
2023-11-30  5:23 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/syncmap: squelch a sparse warning (rev2) Patchwork
2023-11-30  5:42 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2023-11-30  8:06   ` Jani Nikula
2023-12-01 19:45 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/syncmap: squelch a sparse warning (rev3) Patchwork
2023-12-01 20:26 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-12-03  3:21 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox