From: Jani Nikula <jani.nikula@linux.intel.com>
To: Ville Syrjala <ville.syrjala@linux.intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 1/2] drm/i915/bios: Fix VBT ACPI DPMS bit polarity
Date: Mon, 12 Sep 2022 16:06:20 +0300 [thread overview]
Message-ID: <877d2868tv.fsf@intel.com> (raw)
In-Reply-To: <20220907093534.29004-1-ville.syrjala@linux.intel.com>
On Wed, 07 Sep 2022, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> We have the ACPI vs. not ACPI DPMS bit polarity the
> wrong way around. Fix it.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
For both patches,
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_vbt_defs.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_vbt_defs.h b/drivers/gpu/drm/i915/display/intel_vbt_defs.h
> index d06b35f17c6a..6119fb035357 100644
> --- a/drivers/gpu/drm/i915/display/intel_vbt_defs.h
> +++ b/drivers/gpu/drm/i915/display/intel_vbt_defs.h
> @@ -491,7 +491,7 @@ struct bdb_general_definitions {
> u8 crt_ddc_gmbus_pin;
>
> /* DPMS bits */
> - u8 dpms_acpi:1;
> + u8 dpms_non_acpi:1;
> u8 skip_boot_crt_detect:1;
> u8 dpms_aim:1;
> u8 rsvd1:5; /* finish byte */
--
Jani Nikula, Intel Open Source Graphics Center
prev parent reply other threads:[~2022-09-12 13:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-07 9:35 [Intel-gfx] [PATCH 1/2] drm/i915/bios: Fix VBT ACPI DPMS bit polarity Ville Syrjala
2022-09-07 9:35 ` [Intel-gfx] [PATCH 2/2] drm/i915/bios: Add the "Disable compression for the Display Port/HDMI external display" bit Ville Syrjala
2022-09-07 12:57 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915/bios: Fix VBT ACPI DPMS bit polarity Patchwork
2022-09-12 13:06 ` Jani Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877d2868tv.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox