[Intel-gfx] [PATCH 1/2] drm/i915/bios: Fix VBT ACPI DPMS bit polarity

[Intel-gfx] [PATCH 1/2] drm/i915/bios: Fix VBT ACPI DPMS bit polarity

[Ville Syrjala]

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

We have the ACPI vs. not ACPI DPMS bit polarity the
wrong way around. Fix it.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_vbt_defs.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/intel_vbt_defs.h b/drivers/gpu/drm/i915/display/intel_vbt_defs.h
index d06b35f17c6a..6119fb035357 100644
--- a/drivers/gpu/drm/i915/display/intel_vbt_defs.h
+++ b/drivers/gpu/drm/i915/display/intel_vbt_defs.h
@@ -491,7 +491,7 @@ struct bdb_general_definitions {
 	u8 crt_ddc_gmbus_pin;
 
 	/* DPMS bits */
-	u8 dpms_acpi:1;
+	u8 dpms_non_acpi:1;
 	u8 skip_boot_crt_detect:1;
 	u8 dpms_aim:1;
 	u8 rsvd1:5; /* finish byte */
-- 
2.35.1

[Intel-gfx] [PATCH 2/2] drm/i915/bios: Add the "Disable compression for the Display Port/HDMI external display" bit

[Ville Syrjala]

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

The child device block has gained a new bit for disabling
compression for external displays. Seems stupid, but there it is.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_vbt_defs.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/intel_vbt_defs.h b/drivers/gpu/drm/i915/display/intel_vbt_defs.h
index 6119fb035357..a9f44abfc9fc 100644
--- a/drivers/gpu/drm/i915/display/intel_vbt_defs.h
+++ b/drivers/gpu/drm/i915/display/intel_vbt_defs.h
@@ -418,7 +418,8 @@ struct child_device_config {
 			u8 compression_method_cps:1;		/* 198+ */
 			u8 ganged_edp:1;			/* 202+ */
 			u8 lttpr_non_transparent:1;		/* 235+ */
-			u8 reserved2:3;
+			u8 disable_compression_for_ext_disp:1;	/* 251+ */
+			u8 reserved2:2;
 			u8 compression_structure_index:4;	/* 198+ */
 			u8 reserved3:4;
 			u8 hdmi_max_frl_rate:4;			/* 237+ */
-- 
2.35.1

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915/bios: Fix VBT ACPI DPMS bit polarity

[Patchwork]

[-- Attachment #1: Type: text/plain, Size: 4542 bytes --]

== Series Details ==

Series: series starting with [1/2] drm/i915/bios: Fix VBT ACPI DPMS bit polarity
URL   : https://patchwork.freedesktop.org/series/108227/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_12087 -> Patchwork_108227v1
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with Patchwork_108227v1 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_108227v1, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108227v1/index.html

Participating hosts (43 -> 42)
------------------------------

  Missing    (1): fi-bdw-samus 

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in Patchwork_108227v1:

### IGT changes ###

#### Possible regressions ####

  * igt@i915_pm_rpm@module-reload:
    - fi-skl-6600u:       [PASS][1] -> [FAIL][2]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12087/fi-skl-6600u/igt@i915_pm_rpm@module-reload.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108227v1/fi-skl-6600u/igt@i915_pm_rpm@module-reload.html

  
#### Suppressed ####

  The following results come from untrusted machines, tests, or statuses.
  They do not affect the overall result.

  * igt@i915_selftest@live@gt_lrc:
    - {bat-adln-1}:       [PASS][3] -> [INCOMPLETE][4]
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12087/bat-adln-1/igt@i915_selftest@live@gt_lrc.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108227v1/bat-adln-1/igt@i915_selftest@live@gt_lrc.html

  
Known issues
------------

  Here are the changes found in Patchwork_108227v1 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@i915_selftest@live@hangcheck:
    - fi-hsw-4770:        [PASS][5] -> [INCOMPLETE][6] ([i915#4785])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12087/fi-hsw-4770/igt@i915_selftest@live@hangcheck.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108227v1/fi-hsw-4770/igt@i915_selftest@live@hangcheck.html

  * igt@kms_chamelium@common-hpd-after-suspend:
    - fi-bsw-kefka:       NOTRUN -> [SKIP][7] ([fdo#109271] / [fdo#111827])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108227v1/fi-bsw-kefka/igt@kms_chamelium@common-hpd-after-suspend.html

  * igt@runner@aborted:
    - fi-hsw-4770:        NOTRUN -> [FAIL][8] ([fdo#109271] / [i915#4312] / [i915#5594] / [i915#6246])
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108227v1/fi-hsw-4770/igt@runner@aborted.html

  
#### Possible fixes ####

  * igt@i915_selftest@live@execlists:
    - fi-bsw-kefka:       [INCOMPLETE][9] -> [PASS][10]
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12087/fi-bsw-kefka/igt@i915_selftest@live@execlists.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108227v1/fi-bsw-kefka/igt@i915_selftest@live@execlists.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
  [i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
  [i915#4785]: https://gitlab.freedesktop.org/drm/intel/issues/4785
  [i915#5594]: https://gitlab.freedesktop.org/drm/intel/issues/5594
  [i915#6246]: https://gitlab.freedesktop.org/drm/intel/issues/6246
  [i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
  [i915#6690]: https://gitlab.freedesktop.org/drm/intel/issues/6690


Build changes
-------------

  * Linux: CI_DRM_12087 -> Patchwork_108227v1

  CI-20190529: 20190529
  CI_DRM_12087: 8bdb74fa246bca022b7a5c814ce5a93fe4614402 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_6647: 0bf58300f0287d2f83ac02d1201b0d0a229b637c @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
  Patchwork_108227v1: 8bdb74fa246bca022b7a5c814ce5a93fe4614402 @ git://anongit.freedesktop.org/gfx-ci/linux


### Linux commits

3b4df1611965 drm/i915/bios: Add the "Disable compression for the Display Port/HDMI external display" bit
a1624e4eadab drm/i915/bios: Fix VBT ACPI DPMS bit polarity

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108227v1/index.html

[-- Attachment #2: Type: text/html, Size: 5242 bytes --]

Re: [Intel-gfx] [PATCH 1/2] drm/i915/bios: Fix VBT ACPI DPMS bit polarity

[Jani Nikula]

On Wed, 07 Sep 2022, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> We have the ACPI vs. not ACPI DPMS bit polarity the
> wrong way around. Fix it.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

For both patches,

Reviewed-by: Jani Nikula <jani.nikula@intel.com>


> ---
>  drivers/gpu/drm/i915/display/intel_vbt_defs.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_vbt_defs.h b/drivers/gpu/drm/i915/display/intel_vbt_defs.h
> index d06b35f17c6a..6119fb035357 100644
> --- a/drivers/gpu/drm/i915/display/intel_vbt_defs.h
> +++ b/drivers/gpu/drm/i915/display/intel_vbt_defs.h
> @@ -491,7 +491,7 @@ struct bdb_general_definitions {
>  	u8 crt_ddc_gmbus_pin;
>  
>  	/* DPMS bits */
> -	u8 dpms_acpi:1;
> +	u8 dpms_non_acpi:1;
>  	u8 skip_boot_crt_detect:1;
>  	u8 dpms_aim:1;
>  	u8 rsvd1:5; /* finish byte */

-- 
Jani Nikula, Intel Open Source Graphics Center