* [Intel-gfx] [PATCH] drm/i915/dp: fix integer overflow in 128b/132b data rate calculation
@ 2021-10-26 8:42 Jani Nikula
2021-10-26 9:13 ` Ville Syrjälä
` (6 more replies)
0 siblings, 7 replies; 10+ messages in thread
From: Jani Nikula @ 2021-10-26 8:42 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula, Manasi Navare, Ville Syrjälä
The intermediate value 1000000 * 10 * 9671 overflows 32 bits, so force
promotion to a bigger type.
From the logs:
[drm:intel_dp_compute_config [i915]] DP link rate required 3657063 available -580783288
Fixes: 48efd014f0ea ("drm/i915/dp: add max data rate calculation for UHBR rates")
Cc: Manasi Navare <manasi.d.navare@intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/display/intel_dp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index f5dc2126d140..9a0cd2e1ebea 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -352,7 +352,7 @@ intel_dp_max_data_rate(int max_link_rate, int max_lanes)
*/
int max_link_rate_kbps = max_link_rate * 10;
- max_link_rate_kbps = DIV_ROUND_CLOSEST_ULL(max_link_rate_kbps * 9671, 10000);
+ max_link_rate_kbps = DIV_ROUND_CLOSEST_ULL(max_link_rate_kbps * 9671UL, 10000UL);
max_link_rate = max_link_rate_kbps / 8;
}
--
2.30.2
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/dp: fix integer overflow in 128b/132b data rate calculation
2021-10-26 8:42 [Intel-gfx] [PATCH] drm/i915/dp: fix integer overflow in 128b/132b data rate calculation Jani Nikula
@ 2021-10-26 9:13 ` Ville Syrjälä
2021-10-26 9:34 ` [Intel-gfx] [PATCH v2] " Jani Nikula
` (5 subsequent siblings)
6 siblings, 0 replies; 10+ messages in thread
From: Ville Syrjälä @ 2021-10-26 9:13 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx, Manasi Navare
On Tue, Oct 26, 2021 at 11:42:07AM +0300, Jani Nikula wrote:
> The intermediate value 1000000 * 10 * 9671 overflows 32 bits, so force
> promotion to a bigger type.
>
> >From the logs:
>
> [drm:intel_dp_compute_config [i915]] DP link rate required 3657063 available -580783288
>
> Fixes: 48efd014f0ea ("drm/i915/dp: add max data rate calculation for UHBR rates")
> Cc: Manasi Navare <manasi.d.navare@intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_dp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> index f5dc2126d140..9a0cd2e1ebea 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -352,7 +352,7 @@ intel_dp_max_data_rate(int max_link_rate, int max_lanes)
> */
> int max_link_rate_kbps = max_link_rate * 10;
>
> - max_link_rate_kbps = DIV_ROUND_CLOSEST_ULL(max_link_rate_kbps * 9671, 10000);
> + max_link_rate_kbps = DIV_ROUND_CLOSEST_ULL(max_link_rate_kbps * 9671UL, 10000UL);
UL is not 64bit on 32bit architectures. Also having a 64bit divisor
would be wasteful.
DIV_ROUND_CLOSEST_ULL(mul_u32_u32(...), 10000);
> max_link_rate = max_link_rate_kbps / 8;
> }
>
> --
> 2.30.2
--
Ville Syrjälä
Intel
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Intel-gfx] [PATCH v2] drm/i915/dp: fix integer overflow in 128b/132b data rate calculation
2021-10-26 8:42 [Intel-gfx] [PATCH] drm/i915/dp: fix integer overflow in 128b/132b data rate calculation Jani Nikula
2021-10-26 9:13 ` Ville Syrjälä
@ 2021-10-26 9:34 ` Jani Nikula
2021-10-26 9:38 ` Ville Syrjälä
2021-10-26 9:56 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dp: fix integer overflow in 128b/132b data rate calculation (rev2) Patchwork
` (4 subsequent siblings)
6 siblings, 1 reply; 10+ messages in thread
From: Jani Nikula @ 2021-10-26 9:34 UTC (permalink / raw)
To: Jani Nikula, intel-gfx; +Cc: Manasi Navare, Ville Syrjälä
The intermediate value 1000000 * 10 * 9671 overflows 32 bits, so force
promotion to a bigger type.
From the logs:
[drm:intel_dp_compute_config [i915]] DP link rate required 3657063 available -580783288
v2: Use mul_u32_u32() (Ville)
Fixes: 48efd014f0ea ("drm/i915/dp: add max data rate calculation for UHBR rates")
Cc: Manasi Navare <manasi.d.navare@intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/display/intel_dp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index f5dc2126d140..537c689a1528 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -352,7 +352,7 @@ intel_dp_max_data_rate(int max_link_rate, int max_lanes)
*/
int max_link_rate_kbps = max_link_rate * 10;
- max_link_rate_kbps = DIV_ROUND_CLOSEST_ULL(max_link_rate_kbps * 9671, 10000);
+ max_link_rate_kbps = DIV_ROUND_CLOSEST_ULL(mul_u32_u32(max_link_rate_kbps, 9671), 10000);
max_link_rate = max_link_rate_kbps / 8;
}
--
2.30.2
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [Intel-gfx] [PATCH v2] drm/i915/dp: fix integer overflow in 128b/132b data rate calculation
2021-10-26 9:34 ` [Intel-gfx] [PATCH v2] " Jani Nikula
@ 2021-10-26 9:38 ` Ville Syrjälä
2021-10-26 16:05 ` Jani Nikula
0 siblings, 1 reply; 10+ messages in thread
From: Ville Syrjälä @ 2021-10-26 9:38 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx, Manasi Navare
On Tue, Oct 26, 2021 at 12:34:07PM +0300, Jani Nikula wrote:
> The intermediate value 1000000 * 10 * 9671 overflows 32 bits, so force
> promotion to a bigger type.
>
> >From the logs:
>
> [drm:intel_dp_compute_config [i915]] DP link rate required 3657063 available -580783288
>
> v2: Use mul_u32_u32() (Ville)
>
> Fixes: 48efd014f0ea ("drm/i915/dp: add max data rate calculation for UHBR rates")
> Cc: Manasi Navare <manasi.d.navare@intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_dp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> index f5dc2126d140..537c689a1528 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -352,7 +352,7 @@ intel_dp_max_data_rate(int max_link_rate, int max_lanes)
> */
> int max_link_rate_kbps = max_link_rate * 10;
>
> - max_link_rate_kbps = DIV_ROUND_CLOSEST_ULL(max_link_rate_kbps * 9671, 10000);
> + max_link_rate_kbps = DIV_ROUND_CLOSEST_ULL(mul_u32_u32(max_link_rate_kbps, 9671), 10000);
> max_link_rate = max_link_rate_kbps / 8;
> }
>
> --
> 2.30.2
--
Ville Syrjälä
Intel
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dp: fix integer overflow in 128b/132b data rate calculation (rev2)
2021-10-26 8:42 [Intel-gfx] [PATCH] drm/i915/dp: fix integer overflow in 128b/132b data rate calculation Jani Nikula
2021-10-26 9:13 ` Ville Syrjälä
2021-10-26 9:34 ` [Intel-gfx] [PATCH v2] " Jani Nikula
@ 2021-10-26 9:56 ` Patchwork
2021-10-26 10:30 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
` (3 subsequent siblings)
6 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2021-10-26 9:56 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/dp: fix integer overflow in 128b/132b data rate calculation (rev2)
URL : https://patchwork.freedesktop.org/series/96289/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
5c2b81fc498b drm/i915/dp: fix integer overflow in 128b/132b data rate calculation
-:15: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#15:
[drm:intel_dp_compute_config [i915]] DP link rate required 3657063 available -580783288
-:34: WARNING:LONG_LINE: line length of 105 exceeds 100 columns
#34: FILE: drivers/gpu/drm/i915/display/intel_dp.c:355:
+ max_link_rate_kbps = DIV_ROUND_CLOSEST_ULL(mul_u32_u32(max_link_rate_kbps, 9671), 10000);
total: 0 errors, 2 warnings, 0 checks, 8 lines checked
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/dp: fix integer overflow in 128b/132b data rate calculation (rev2)
2021-10-26 8:42 [Intel-gfx] [PATCH] drm/i915/dp: fix integer overflow in 128b/132b data rate calculation Jani Nikula
` (2 preceding siblings ...)
2021-10-26 9:56 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dp: fix integer overflow in 128b/132b data rate calculation (rev2) Patchwork
@ 2021-10-26 10:30 ` Patchwork
2021-10-26 11:53 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dp: fix integer overflow in 128b/132b data rate calculation (rev3) Patchwork
` (2 subsequent siblings)
6 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2021-10-26 10:30 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 4133 bytes --]
== Series Details ==
Series: drm/i915/dp: fix integer overflow in 128b/132b data rate calculation (rev2)
URL : https://patchwork.freedesktop.org/series/96289/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_10788 -> Patchwork_21444
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_21444 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_21444, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21444/index.html
Participating hosts (39 -> 33)
------------------------------
Missing (6): fi-cml-u2 bat-dg1-6 fi-bsw-cyan bat-adlp-4 fi-ctg-p8600 fi-bsw-kefka
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_21444:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live@gtt:
- fi-icl-u2: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10788/fi-icl-u2/igt@i915_selftest@live@gtt.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21444/fi-icl-u2/igt@i915_selftest@live@gtt.html
Known issues
------------
Here are the changes found in Patchwork_21444 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live@execlists:
- fi-bsw-n3050: [PASS][3] -> [INCOMPLETE][4] ([i915#2940])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10788/fi-bsw-n3050/igt@i915_selftest@live@execlists.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21444/fi-bsw-n3050/igt@i915_selftest@live@execlists.html
* igt@runner@aborted:
- fi-icl-u2: NOTRUN -> [FAIL][5] ([i915#2722] / [i915#3363] / [i915#4006] / [i915#4312])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21444/fi-icl-u2/igt@runner@aborted.html
- fi-bdw-5557u: NOTRUN -> [FAIL][6] ([i915#1602] / [i915#2426] / [i915#4312])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21444/fi-bdw-5557u/igt@runner@aborted.html
- fi-bsw-n3050: NOTRUN -> [FAIL][7] ([fdo#109271] / [i915#1436] / [i915#3428] / [i915#4312])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21444/fi-bsw-n3050/igt@runner@aborted.html
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s3:
- fi-bdw-5557u: [INCOMPLETE][8] -> [PASS][9]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10788/fi-bdw-5557u/igt@gem_exec_suspend@basic-s3.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21444/fi-bdw-5557u/igt@gem_exec_suspend@basic-s3.html
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#1602]: https://gitlab.freedesktop.org/drm/intel/issues/1602
[i915#2426]: https://gitlab.freedesktop.org/drm/intel/issues/2426
[i915#2722]: https://gitlab.freedesktop.org/drm/intel/issues/2722
[i915#2940]: https://gitlab.freedesktop.org/drm/intel/issues/2940
[i915#3363]: https://gitlab.freedesktop.org/drm/intel/issues/3363
[i915#3428]: https://gitlab.freedesktop.org/drm/intel/issues/3428
[i915#4006]: https://gitlab.freedesktop.org/drm/intel/issues/4006
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
Build changes
-------------
* Linux: CI_DRM_10788 -> Patchwork_21444
CI-20190529: 20190529
CI_DRM_10788: e5d0af998bc3f676208222233aa9a6acb06b3e01 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6261: 0433f0d6063d8450af1e8518047d3679b9e5a6c1 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_21444: 5c2b81fc498b98363081b42bdc32ceddefad1975 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
5c2b81fc498b drm/i915/dp: fix integer overflow in 128b/132b data rate calculation
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21444/index.html
[-- Attachment #2: Type: text/html, Size: 4979 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dp: fix integer overflow in 128b/132b data rate calculation (rev3)
2021-10-26 8:42 [Intel-gfx] [PATCH] drm/i915/dp: fix integer overflow in 128b/132b data rate calculation Jani Nikula
` (3 preceding siblings ...)
2021-10-26 10:30 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
@ 2021-10-26 11:53 ` Patchwork
2021-10-26 12:27 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-10-26 14:10 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
6 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2021-10-26 11:53 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/dp: fix integer overflow in 128b/132b data rate calculation (rev3)
URL : https://patchwork.freedesktop.org/series/96289/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
4759ea7118a7 drm/i915/dp: fix integer overflow in 128b/132b data rate calculation
-:15: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#15:
[drm:intel_dp_compute_config [i915]] DP link rate required 3657063 available -580783288
-:34: WARNING:LONG_LINE: line length of 105 exceeds 100 columns
#34: FILE: drivers/gpu/drm/i915/display/intel_dp.c:355:
+ max_link_rate_kbps = DIV_ROUND_CLOSEST_ULL(mul_u32_u32(max_link_rate_kbps, 9671), 10000);
total: 0 errors, 2 warnings, 0 checks, 8 lines checked
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dp: fix integer overflow in 128b/132b data rate calculation (rev3)
2021-10-26 8:42 [Intel-gfx] [PATCH] drm/i915/dp: fix integer overflow in 128b/132b data rate calculation Jani Nikula
` (4 preceding siblings ...)
2021-10-26 11:53 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dp: fix integer overflow in 128b/132b data rate calculation (rev3) Patchwork
@ 2021-10-26 12:27 ` Patchwork
2021-10-26 14:10 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
6 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2021-10-26 12:27 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 7343 bytes --]
== Series Details ==
Series: drm/i915/dp: fix integer overflow in 128b/132b data rate calculation (rev3)
URL : https://patchwork.freedesktop.org/series/96289/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10789 -> Patchwork_21445
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/index.html
Participating hosts (39 -> 35)
------------------------------
Additional (2): fi-skl-guc fi-pnv-d510
Missing (6): bat-dg1-6 bat-dg1-5 fi-bsw-cyan fi-icl-u2 bat-adlp-4 fi-ctg-p8600
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_21445:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@i915_selftest@live@reset:
- {fi-tgl-dsi}: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10789/fi-tgl-dsi/igt@i915_selftest@live@reset.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/fi-tgl-dsi/igt@i915_selftest@live@reset.html
Known issues
------------
Here are the changes found in Patchwork_21445 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_basic@semaphore:
- fi-bsw-nick: NOTRUN -> [SKIP][3] ([fdo#109271]) +17 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/fi-bsw-nick/igt@amdgpu/amd_basic@semaphore.html
* igt@amdgpu/amd_cs_nop@sync-gfx0:
- fi-bsw-n3050: NOTRUN -> [SKIP][4] ([fdo#109271]) +17 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/fi-bsw-n3050/igt@amdgpu/amd_cs_nop@sync-gfx0.html
* igt@gem_exec_suspend@basic-s0:
- fi-tgl-1115g4: [PASS][5] -> [FAIL][6] ([i915#1888])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10789/fi-tgl-1115g4/igt@gem_exec_suspend@basic-s0.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/fi-tgl-1115g4/igt@gem_exec_suspend@basic-s0.html
* igt@kms_chamelium@dp-crc-fast:
- fi-skl-guc: NOTRUN -> [SKIP][7] ([fdo#109271] / [fdo#111827]) +8 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/fi-skl-guc/igt@kms_chamelium@dp-crc-fast.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- fi-skl-guc: NOTRUN -> [SKIP][8] ([fdo#109271]) +28 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/fi-skl-guc/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
* igt@kms_flip@basic-plain-flip@c-dp1:
- fi-cfl-8109u: [PASS][9] -> [FAIL][10] ([i915#4165])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10789/fi-cfl-8109u/igt@kms_flip@basic-plain-flip@c-dp1.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/fi-cfl-8109u/igt@kms_flip@basic-plain-flip@c-dp1.html
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-b:
- fi-cfl-8109u: [PASS][11] -> [DMESG-WARN][12] ([i915#295]) +13 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10789/fi-cfl-8109u/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-b.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/fi-cfl-8109u/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-b.html
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
- fi-skl-guc: NOTRUN -> [SKIP][13] ([fdo#109271] / [i915#533])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/fi-skl-guc/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html
* igt@prime_vgem@basic-userptr:
- fi-pnv-d510: NOTRUN -> [SKIP][14] ([fdo#109271]) +53 similar issues
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/fi-pnv-d510/igt@prime_vgem@basic-userptr.html
#### Possible fixes ####
* igt@i915_selftest@live@execlists:
- fi-bsw-nick: [INCOMPLETE][15] ([i915#2940]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10789/fi-bsw-nick/igt@i915_selftest@live@execlists.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/fi-bsw-nick/igt@i915_selftest@live@execlists.html
- fi-bsw-n3050: [INCOMPLETE][17] ([i915#2940]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10789/fi-bsw-n3050/igt@i915_selftest@live@execlists.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/fi-bsw-n3050/igt@i915_selftest@live@execlists.html
* igt@i915_selftest@live@hangcheck:
- {fi-hsw-gt1}: [DMESG-WARN][19] ([i915#3303]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10789/fi-hsw-gt1/igt@i915_selftest@live@hangcheck.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/fi-hsw-gt1/igt@i915_selftest@live@hangcheck.html
* igt@kms_frontbuffer_tracking@basic:
- {fi-hsw-gt1}: [DMESG-WARN][21] ([i915#4290]) -> [PASS][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10789/fi-hsw-gt1/igt@kms_frontbuffer_tracking@basic.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/fi-hsw-gt1/igt@kms_frontbuffer_tracking@basic.html
#### Warnings ####
* igt@kms_frontbuffer_tracking@basic:
- fi-cfl-8109u: [FAIL][23] ([i915#2546]) -> [DMESG-WARN][24] ([i915#295])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10789/fi-cfl-8109u/igt@kms_frontbuffer_tracking@basic.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/fi-cfl-8109u/igt@kms_frontbuffer_tracking@basic.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#2546]: https://gitlab.freedesktop.org/drm/intel/issues/2546
[i915#2940]: https://gitlab.freedesktop.org/drm/intel/issues/2940
[i915#295]: https://gitlab.freedesktop.org/drm/intel/issues/295
[i915#2966]: https://gitlab.freedesktop.org/drm/intel/issues/2966
[i915#3303]: https://gitlab.freedesktop.org/drm/intel/issues/3303
[i915#4165]: https://gitlab.freedesktop.org/drm/intel/issues/4165
[i915#4290]: https://gitlab.freedesktop.org/drm/intel/issues/4290
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
Build changes
-------------
* Linux: CI_DRM_10789 -> Patchwork_21445
CI-20190529: 20190529
CI_DRM_10789: c9cf776e7278dc219848456094f4501ebcb3412e @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6261: 0433f0d6063d8450af1e8518047d3679b9e5a6c1 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_21445: 4759ea7118a7caa8ef465c2fe7dca45011010f48 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
4759ea7118a7 drm/i915/dp: fix integer overflow in 128b/132b data rate calculation
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/index.html
[-- Attachment #2: Type: text/html, Size: 8587 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/dp: fix integer overflow in 128b/132b data rate calculation (rev3)
2021-10-26 8:42 [Intel-gfx] [PATCH] drm/i915/dp: fix integer overflow in 128b/132b data rate calculation Jani Nikula
` (5 preceding siblings ...)
2021-10-26 12:27 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
@ 2021-10-26 14:10 ` Patchwork
6 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2021-10-26 14:10 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 30298 bytes --]
== Series Details ==
Series: drm/i915/dp: fix integer overflow in 128b/132b data rate calculation (rev3)
URL : https://patchwork.freedesktop.org/series/96289/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_10789_full -> Patchwork_21445_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_21445_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_21445_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_21445_full:
### CI changes ###
#### Possible regressions ####
* boot:
- shard-glk: ([PASS][1], [PASS][2], [PASS][3], [PASS][4], [PASS][5], [PASS][6], [PASS][7], [PASS][8], [PASS][9], [PASS][10], [PASS][11], [PASS][12], [PASS][13], [PASS][14], [PASS][15], [PASS][16], [PASS][17], [PASS][18], [PASS][19], [PASS][20], [PASS][21], [PASS][22], [PASS][23], [PASS][24], [PASS][25]) -> ([PASS][26], [PASS][27], [PASS][28], [PASS][29], [PASS][30], [PASS][31], [PASS][32], [PASS][33], [PASS][34], [PASS][35], [PASS][36], [PASS][37], [PASS][38], [PASS][39], [PASS][40], [PASS][41], [PASS][42], [PASS][43], [PASS][44], [PASS][45], [PASS][46], [PASS][47], [PASS][48], [PASS][49], [FAIL][50])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10789/shard-glk9/boot.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10789/shard-glk9/boot.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10789/shard-glk9/boot.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10789/shard-glk8/boot.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10789/shard-glk8/boot.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10789/shard-glk8/boot.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10789/shard-glk7/boot.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10789/shard-glk7/boot.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10789/shard-glk7/boot.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10789/shard-glk6/boot.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10789/shard-glk6/boot.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10789/shard-glk6/boot.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10789/shard-glk5/boot.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10789/shard-glk5/boot.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10789/shard-glk4/boot.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10789/shard-glk4/boot.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10789/shard-glk4/boot.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10789/shard-glk3/boot.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10789/shard-glk3/boot.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10789/shard-glk2/boot.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10789/shard-glk2/boot.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10789/shard-glk2/boot.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10789/shard-glk1/boot.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10789/shard-glk1/boot.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10789/shard-glk1/boot.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-glk9/boot.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-glk9/boot.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-glk9/boot.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-glk8/boot.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-glk8/boot.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-glk8/boot.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-glk7/boot.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-glk7/boot.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-glk6/boot.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-glk6/boot.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-glk6/boot.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-glk5/boot.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-glk5/boot.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-glk4/boot.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-glk4/boot.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-glk4/boot.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-glk3/boot.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-glk3/boot.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-glk3/boot.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-glk2/boot.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-glk2/boot.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-glk1/boot.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-glk1/boot.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-glk1/boot.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-glk1/boot.html
Known issues
------------
Here are the changes found in Patchwork_21445_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@feature_discovery@chamelium:
- shard-tglb: NOTRUN -> [SKIP][51] ([fdo#111827])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-tglb2/igt@feature_discovery@chamelium.html
* igt@gem_create@create-massive:
- shard-apl: NOTRUN -> [DMESG-WARN][52] ([i915#3002])
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-apl6/igt@gem_create@create-massive.html
* igt@gem_ctx_sseu@mmap-args:
- shard-tglb: NOTRUN -> [SKIP][53] ([i915#280])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-tglb2/igt@gem_ctx_sseu@mmap-args.html
* igt@gem_eio@unwedge-stress:
- shard-iclb: [PASS][54] -> [TIMEOUT][55] ([i915#2369] / [i915#2481] / [i915#3070])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10789/shard-iclb3/igt@gem_eio@unwedge-stress.html
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-iclb5/igt@gem_eio@unwedge-stress.html
* igt@gem_exec_balancer@full-pulse:
- shard-skl: [PASS][56] -> [DMESG-WARN][57] ([i915#1982])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10789/shard-skl8/igt@gem_exec_balancer@full-pulse.html
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-skl9/igt@gem_exec_balancer@full-pulse.html
* igt@gem_exec_fair@basic-deadline:
- shard-skl: NOTRUN -> [FAIL][58] ([i915#2846])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-skl8/igt@gem_exec_fair@basic-deadline.html
* igt@gem_exec_fair@basic-flow@rcs0:
- shard-skl: NOTRUN -> [SKIP][59] ([fdo#109271]) +211 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-skl9/igt@gem_exec_fair@basic-flow@rcs0.html
* igt@gem_exec_fair@basic-none-vip@rcs0:
- shard-kbl: NOTRUN -> [FAIL][60] ([i915#2842]) +1 similar issue
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-kbl3/igt@gem_exec_fair@basic-none-vip@rcs0.html
* igt@gem_huc_copy@huc-copy:
- shard-tglb: [PASS][61] -> [SKIP][62] ([i915#2190])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10789/shard-tglb5/igt@gem_huc_copy@huc-copy.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-tglb6/igt@gem_huc_copy@huc-copy.html
* igt@gem_pwrite@basic-exhaustion:
- shard-skl: NOTRUN -> [WARN][63] ([i915#2658])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-skl3/igt@gem_pwrite@basic-exhaustion.html
* igt@gem_render_copy@x-tiled-to-vebox-yf-tiled:
- shard-iclb: NOTRUN -> [SKIP][64] ([i915#768])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-iclb6/igt@gem_render_copy@x-tiled-to-vebox-yf-tiled.html
* igt@gem_userptr_blits@dmabuf-sync:
- shard-skl: NOTRUN -> [SKIP][65] ([fdo#109271] / [i915#3323])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-skl7/igt@gem_userptr_blits@dmabuf-sync.html
* igt@gem_userptr_blits@readonly-pwrite-unsync:
- shard-tglb: NOTRUN -> [SKIP][66] ([i915#3297])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-tglb2/igt@gem_userptr_blits@readonly-pwrite-unsync.html
* igt@gem_userptr_blits@vma-merge:
- shard-tglb: NOTRUN -> [FAIL][67] ([i915#3318])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-tglb2/igt@gem_userptr_blits@vma-merge.html
* igt@gen9_exec_parse@allowed-single:
- shard-iclb: NOTRUN -> [SKIP][68] ([i915#2856])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-iclb6/igt@gen9_exec_parse@allowed-single.html
* igt@gen9_exec_parse@bb-large:
- shard-tglb: NOTRUN -> [SKIP][69] ([i915#2856])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-tglb2/igt@gen9_exec_parse@bb-large.html
* igt@i915_selftest@live@hangcheck:
- shard-snb: [PASS][70] -> [INCOMPLETE][71] ([i915#3921])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10789/shard-snb4/igt@i915_selftest@live@hangcheck.html
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-snb2/igt@i915_selftest@live@hangcheck.html
* igt@kms_big_fb@linear-8bpp-rotate-90:
- shard-tglb: NOTRUN -> [SKIP][72] ([fdo#111614])
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-tglb2/igt@kms_big_fb@linear-8bpp-rotate-90.html
* igt@kms_big_fb@x-tiled-32bpp-rotate-180:
- shard-glk: [PASS][73] -> [DMESG-WARN][74] ([i915#118])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10789/shard-glk7/igt@kms_big_fb@x-tiled-32bpp-rotate-180.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-glk4/igt@kms_big_fb@x-tiled-32bpp-rotate-180.html
* igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-0-hflip:
- shard-skl: NOTRUN -> [SKIP][75] ([fdo#109271] / [i915#3777]) +1 similar issue
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-skl7/igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-0-hflip.html
* igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-async-flip:
- shard-skl: NOTRUN -> [FAIL][76] ([i915#3743])
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-skl1/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-async-flip.html
* igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-hflip:
- shard-kbl: NOTRUN -> [SKIP][77] ([fdo#109271] / [i915#3777]) +1 similar issue
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-kbl3/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-hflip.html
* igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-0-async-flip:
- shard-skl: NOTRUN -> [FAIL][78] ([i915#3763])
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-skl3/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-0-async-flip.html
* igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-180:
- shard-tglb: NOTRUN -> [SKIP][79] ([fdo#111615]) +1 similar issue
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-tglb2/igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-180.html
* igt@kms_ccs@pipe-a-bad-rotation-90-y_tiled_gen12_rc_ccs_cc:
- shard-kbl: NOTRUN -> [SKIP][80] ([fdo#109271] / [i915#3886]) +4 similar issues
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-kbl1/igt@kms_ccs@pipe-a-bad-rotation-90-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-b-bad-pixel-format-y_tiled_gen12_mc_ccs:
- shard-tglb: NOTRUN -> [SKIP][81] ([i915#3689] / [i915#3886])
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-tglb2/igt@kms_ccs@pipe-b-bad-pixel-format-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-b-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc:
- shard-apl: NOTRUN -> [SKIP][82] ([fdo#109271] / [i915#3886])
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-apl6/igt@kms_ccs@pipe-b-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-b-crc-primary-basic-yf_tiled_ccs:
- shard-tglb: NOTRUN -> [SKIP][83] ([i915#3689]) +2 similar issues
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-tglb2/igt@kms_ccs@pipe-b-crc-primary-basic-yf_tiled_ccs.html
* igt@kms_ccs@pipe-b-crc-primary-rotation-180-y_tiled_gen12_rc_ccs_cc:
- shard-skl: NOTRUN -> [SKIP][84] ([fdo#109271] / [i915#3886]) +12 similar issues
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-skl7/igt@kms_ccs@pipe-b-crc-primary-rotation-180-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-c-crc-primary-basic-y_tiled_gen12_rc_ccs:
- shard-iclb: NOTRUN -> [SKIP][85] ([fdo#109278]) +1 similar issue
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-iclb6/igt@kms_ccs@pipe-c-crc-primary-basic-y_tiled_gen12_rc_ccs.html
* igt@kms_ccs@pipe-c-crc-primary-basic-y_tiled_gen12_rc_ccs_cc:
- shard-iclb: NOTRUN -> [SKIP][86] ([fdo#109278] / [i915#3886])
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-iclb6/igt@kms_ccs@pipe-c-crc-primary-basic-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_chamelium@dp-hpd-after-suspend:
- shard-tglb: NOTRUN -> [SKIP][87] ([fdo#109284] / [fdo#111827]) +2 similar issues
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-tglb2/igt@kms_chamelium@dp-hpd-after-suspend.html
* igt@kms_chamelium@dp-mode-timings:
- shard-apl: NOTRUN -> [SKIP][88] ([fdo#109271] / [fdo#111827]) +1 similar issue
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-apl6/igt@kms_chamelium@dp-mode-timings.html
* igt@kms_chamelium@hdmi-frame-dump:
- shard-iclb: NOTRUN -> [SKIP][89] ([fdo#109284] / [fdo#111827])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-iclb6/igt@kms_chamelium@hdmi-frame-dump.html
* igt@kms_chamelium@hdmi-hpd-storm-disable:
- shard-skl: NOTRUN -> [SKIP][90] ([fdo#109271] / [fdo#111827]) +16 similar issues
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-skl8/igt@kms_chamelium@hdmi-hpd-storm-disable.html
* igt@kms_chamelium@hdmi-mode-timings:
- shard-kbl: NOTRUN -> [SKIP][91] ([fdo#109271] / [fdo#111827]) +10 similar issues
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-kbl3/igt@kms_chamelium@hdmi-mode-timings.html
* igt@kms_content_protection@legacy:
- shard-kbl: NOTRUN -> [TIMEOUT][92] ([i915#1319])
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-kbl3/igt@kms_content_protection@legacy.html
* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-kbl: [PASS][93] -> [DMESG-WARN][94] ([i915#180]) +4 similar issues
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10789/shard-kbl1/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-kbl4/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
* igt@kms_cursor_crc@pipe-b-cursor-max-size-onscreen:
- shard-tglb: NOTRUN -> [SKIP][95] ([i915#3359]) +1 similar issue
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-tglb2/igt@kms_cursor_crc@pipe-b-cursor-max-size-onscreen.html
* igt@kms_cursor_crc@pipe-d-cursor-512x170-random:
- shard-tglb: NOTRUN -> [SKIP][96] ([fdo#109279] / [i915#3359]) +3 similar issues
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-tglb2/igt@kms_cursor_crc@pipe-d-cursor-512x170-random.html
* igt@kms_cursor_edge_walk@pipe-d-64x64-left-edge:
- shard-kbl: NOTRUN -> [SKIP][97] ([fdo#109271]) +125 similar issues
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-kbl3/igt@kms_cursor_edge_walk@pipe-d-64x64-left-edge.html
* igt@kms_cursor_legacy@cursorb-vs-flipb-varying-size:
- shard-tglb: NOTRUN -> [SKIP][98] ([fdo#111825]) +9 similar issues
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-tglb2/igt@kms_cursor_legacy@cursorb-vs-flipb-varying-size.html
* igt@kms_fbcon_fbt@fbc-suspend:
- shard-apl: [PASS][99] -> [INCOMPLETE][100] ([i915#180])
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10789/shard-apl3/igt@kms_fbcon_fbt@fbc-suspend.html
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-apl4/igt@kms_fbcon_fbt@fbc-suspend.html
* igt@kms_flip@basic-flip-vs-wf_vblank@c-edp1:
- shard-skl: [PASS][101] -> [FAIL][102] ([i915#2122])
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10789/shard-skl2/igt@kms_flip@basic-flip-vs-wf_vblank@c-edp1.html
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-skl3/igt@kms_flip@basic-flip-vs-wf_vblank@c-edp1.html
* igt@kms_flip@flip-vs-absolute-wf_vblank@b-edp1:
- shard-skl: NOTRUN -> [FAIL][103] ([i915#2122])
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-skl3/igt@kms_flip@flip-vs-absolute-wf_vblank@b-edp1.html
* igt@kms_flip@flip-vs-suspend-interruptible@a-dp1:
- shard-kbl: NOTRUN -> [DMESG-WARN][104] ([i915#180]) +2 similar issues
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-kbl4/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile:
- shard-iclb: [PASS][105] -> [SKIP][106] ([i915#3701])
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10789/shard-iclb3/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile.html
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-spr-indfb-draw-pwrite:
- shard-iclb: NOTRUN -> [SKIP][107] ([fdo#109280]) +1 similar issue
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-iclb6/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-spr-indfb-draw-pwrite.html
* igt@kms_pipe_crc_basic@read-crc-pipe-d-frame-sequence:
- shard-skl: NOTRUN -> [SKIP][108] ([fdo#109271] / [i915#533])
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-skl7/igt@kms_pipe_crc_basic@read-crc-pipe-d-frame-sequence.html
* igt@kms_plane@plane-panning-bottom-right-suspend@pipe-a-planes:
- shard-tglb: [PASS][109] -> [INCOMPLETE][110] ([i915#4182])
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10789/shard-tglb1/igt@kms_plane@plane-panning-bottom-right-suspend@pipe-a-planes.html
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-tglb7/igt@kms_plane@plane-panning-bottom-right-suspend@pipe-a-planes.html
* igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb:
- shard-kbl: NOTRUN -> [FAIL][111] ([fdo#108145] / [i915#265])
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-kbl1/igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb.html
* igt@kms_plane_alpha_blend@pipe-a-coverage-7efc:
- shard-skl: NOTRUN -> [FAIL][112] ([fdo#108145] / [i915#265]) +1 similar issue
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-skl10/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html
* igt@kms_plane_alpha_blend@pipe-c-alpha-basic:
- shard-apl: NOTRUN -> [FAIL][113] ([fdo#108145] / [i915#265]) +1 similar issue
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-apl4/igt@kms_plane_alpha_blend@pipe-c-alpha-basic.html
* igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-c-scaler-with-clipping-clamping:
- shard-skl: NOTRUN -> [SKIP][114] ([fdo#109271] / [i915#2733])
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-skl3/igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-c-scaler-with-clipping-clamping.html
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-3:
- shard-kbl: NOTRUN -> [SKIP][115] ([fdo#109271] / [i915#658]) +3 similar issues
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-kbl1/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-3.html
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-4:
- shard-apl: NOTRUN -> [SKIP][116] ([fdo#109271] / [i915#658])
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-apl6/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-4.html
* igt@kms_psr2_sf@plane-move-sf-dmg-area-2:
- shard-iclb: NOTRUN -> [SKIP][117] ([i915#658])
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-iclb6/igt@kms_psr2_sf@plane-move-sf-dmg-area-2.html
* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-1:
- shard-skl: NOTRUN -> [SKIP][118] ([fdo#109271] / [i915#658]) +2 similar issues
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-skl7/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-1.html
* igt@kms_psr2_su@page_flip:
- shard-tglb: NOTRUN -> [SKIP][119] ([i915#1911])
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-tglb2/igt@kms_psr2_su@page_flip.html
* igt@kms_psr@psr2_primary_mmap_cpu:
- shard-iclb: [PASS][120] -> [SKIP][121] ([fdo#109441]) +2 similar issues
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10789/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-iclb3/igt@kms_psr@psr2_primary_mmap_cpu.html
* igt@kms_psr@psr2_primary_page_flip:
- shard-tglb: NOTRUN -> [FAIL][122] ([i915#132] / [i915#3467])
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-tglb2/igt@kms_psr@psr2_primary_page_flip.html
* igt@kms_psr@psr2_suspend:
- shard-iclb: NOTRUN -> [SKIP][123] ([fdo#109441])
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-iclb6/igt@kms_psr@psr2_suspend.html
* igt@kms_writeback@writeback-fb-id:
- shard-kbl: NOTRUN -> [SKIP][124] ([fdo#109271] / [i915#2437])
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-kbl3/igt@kms_writeback@writeback-fb-id.html
* igt@kms_writeback@writeback-pixel-formats:
- shard-skl: NOTRUN -> [SKIP][125] ([fdo#109271] / [i915#2437])
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-skl8/igt@kms_writeback@writeback-pixel-formats.html
* igt@nouveau_crc@pipe-b-ctx-flip-skip-current-frame:
- shard-apl: NOTRUN -> [SKIP][126] ([fdo#109271]) +38 similar issues
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-apl4/igt@nouveau_crc@pipe-b-ctx-flip-skip-current-frame.html
* igt@nouveau_crc@pipe-c-ctx-flip-skip-current-frame:
- shard-tglb: NOTRUN -> [SKIP][127] ([i915#2530])
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-tglb2/igt@nouveau_crc@pipe-c-ctx-flip-skip-current-frame.html
* igt@sysfs_clients@fair-7:
- shard-iclb: NOTRUN -> [SKIP][128] ([i915#2994])
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-iclb6/igt@sysfs_clients@fair-7.html
* igt@sysfs_clients@sema-10:
- shard-tglb: NOTRUN -> [SKIP][129] ([i915#2994])
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-tglb2/igt@sysfs_clients@sema-10.html
* igt@sysfs_clients@split-10:
- shard-skl: NOTRUN -> [SKIP][130] ([fdo#109271] / [i915#2994]) +1 similar issue
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-skl3/igt@sysfs_clients@split-10.html
* igt@sysfs_clients@split-25:
- shard-kbl: NOTRUN -> [SKIP][131] ([fdo#109271] / [i915#2994]) +1 similar issue
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-kbl3/igt@sysfs_clients@split-25.html
#### Possible fixes ####
* igt@gem_eio@in-flight-suspend:
- shard-kbl: [INCOMPLETE][132] -> [PASS][133]
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10789/shard-kbl4/igt@gem_eio@in-flight-suspend.html
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-kbl6/igt@gem_eio@in-flight-suspend.html
- shard-apl: [DMESG-WARN][134] ([i915#180]) -> [PASS][135] +2 similar issues
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10789/shard-apl2/igt@gem_eio@in-flight-suspend.html
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-apl6/igt@gem_eio@in-flight-suspend.html
* igt@gem_eio@unwedge-stress:
- shard-tglb: [TIMEOUT][136] ([i915#2369] / [i915#3063] / [i915#3648]) -> [PASS][137]
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10789/shard-tglb6/igt@gem_eio@unwedge-stress.html
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-tglb1/igt@gem_eio@unwedge-stress.html
* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-tglb: [FAIL][138] ([i915#2842]) -> [PASS][139]
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10789/shard-tglb6/igt@gem_exec_fair@basic-none-share@rcs0.html
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-tglb1/igt@gem_exec_fair@basic-none-share@rcs0.html
- shard-apl: [SKIP][140] ([fdo#109271]) -> [PASS][141]
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10789/shard-apl3/igt@gem_exec_fair@basic-none-share@rcs0.html
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-apl4/igt@gem_exec_fair@basic-none-share@rcs0.html
* igt@gem_exec_fair@basic-none@vecs0:
- shard-apl: [FAIL][142] ([i915#2842] / [i915#3468]) -> [PASS][143]
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10789/shard-apl4/igt@gem_exec_fair@basic-none@vecs0.html
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-apl8/igt@gem_exec_fair@basic-none@vecs0.html
* igt@gem_ppgtt@flink-and-close-vma-leak:
- shard-glk: [FAIL][144] ([i915#644]) -> [PASS][145]
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10789/shard-glk2/igt@gem_ppgtt@flink-and-close-vma-leak.html
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-glk1/igt@gem_ppgtt@flink-and-close-vma-leak.html
* igt@kms_async_flips@alternate-sync-async-flip:
- shard-skl: [FAIL][146] ([i915#2521]) -> [PASS][147]
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10789/shard-skl7/igt@kms_async_flips@alternate-sync-async-flip.html
[147]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-skl10/igt@kms_async_flips@alternate-sync-async-flip.html
* igt@kms_big_fb@y-tiled-32bpp-rotate-0:
- shard-glk: [DMESG-WARN][148] ([i915#118]) -> [PASS][149]
[148]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10789/shard-glk3/igt@kms_big_fb@y-tiled-32bpp-rotate-0.html
[149]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-glk2/igt@kms_big_fb@y-tiled-32bpp-rotate-0.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile:
- shard-iclb: [SKIP][150] ([i915#3701]) -> [PASS][151] +1 similar issue
[150]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10789/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile.html
[151]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-iclb8/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile.html
* igt@kms_frontbuffer_tracking@psr-suspend:
- shard-tglb: [INCOMPLETE][152] ([i915#456]) -> [PASS][153]
[152]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10789/shard-tglb7/igt@kms_frontbuffer_tracking@psr-suspend.html
[153]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-tglb2/igt@kms_frontbuffer_tracking@psr-suspend.html
* igt@kms_hdr@bpc-switch-dpms:
- shard-skl: [FAIL][154] ([i915#1188]) -> [PASS][155]
[154]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10789/shard-skl7/igt@kms_hdr@bpc-switch-dpms.html
[155]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-skl10/igt@kms_hdr@bpc-switch-dpms.html
* igt@kms_hdr@bpc-switch-suspend:
- shard-kbl: [DMESG-WARN][156] ([i915#180]) -> [PASS][157] +7 similar issues
[156]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10789/shard-kbl7/igt@kms_hdr@bpc-switch-suspend.html
[157]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-kbl4/igt@kms_hdr@bpc-switch-suspend.html
* igt@kms_psr2_su@frontbuffer:
- shard-iclb: [SKIP][158] ([fdo#109642] / [fdo#111068] / [i915#658]) -> [PASS][159]
[158]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10789/shard-iclb1/igt@kms_psr2_su@frontbuffer.html
[159]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/shard-iclb2/igt@kms_psr2_su@frontbuffer.html
* igt@kms_psr@psr2_cursor_mmap_cpu:
- shard-iclb: [SKIP][160] ([fdo#109441]) -> [PASS][161] +3 similar issues
[160]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10789/shard-iclb6/igt@kms_psr@psr2_cursor_mmap_cpu.html
[161]: https://intel-gf
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21445/index.html
[-- Attachment #2: Type: text/html, Size: 33703 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Intel-gfx] [PATCH v2] drm/i915/dp: fix integer overflow in 128b/132b data rate calculation
2021-10-26 9:38 ` Ville Syrjälä
@ 2021-10-26 16:05 ` Jani Nikula
0 siblings, 0 replies; 10+ messages in thread
From: Jani Nikula @ 2021-10-26 16:05 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: intel-gfx, Manasi Navare
On Tue, 26 Oct 2021, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> On Tue, Oct 26, 2021 at 12:34:07PM +0300, Jani Nikula wrote:
>> The intermediate value 1000000 * 10 * 9671 overflows 32 bits, so force
>> promotion to a bigger type.
>>
>> >From the logs:
>>
>> [drm:intel_dp_compute_config [i915]] DP link rate required 3657063 available -580783288
>>
>> v2: Use mul_u32_u32() (Ville)
>>
>> Fixes: 48efd014f0ea ("drm/i915/dp: add max data rate calculation for UHBR rates")
>> Cc: Manasi Navare <manasi.d.navare@intel.com>
>> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Thanks, pushed.
BR,
Jani.
>
>> ---
>> drivers/gpu/drm/i915/display/intel_dp.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
>> index f5dc2126d140..537c689a1528 100644
>> --- a/drivers/gpu/drm/i915/display/intel_dp.c
>> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
>> @@ -352,7 +352,7 @@ intel_dp_max_data_rate(int max_link_rate, int max_lanes)
>> */
>> int max_link_rate_kbps = max_link_rate * 10;
>>
>> - max_link_rate_kbps = DIV_ROUND_CLOSEST_ULL(max_link_rate_kbps * 9671, 10000);
>> + max_link_rate_kbps = DIV_ROUND_CLOSEST_ULL(mul_u32_u32(max_link_rate_kbps, 9671), 10000);
>> max_link_rate = max_link_rate_kbps / 8;
>> }
>>
>> --
>> 2.30.2
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2021-10-26 17:07 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-10-26 8:42 [Intel-gfx] [PATCH] drm/i915/dp: fix integer overflow in 128b/132b data rate calculation Jani Nikula
2021-10-26 9:13 ` Ville Syrjälä
2021-10-26 9:34 ` [Intel-gfx] [PATCH v2] " Jani Nikula
2021-10-26 9:38 ` Ville Syrjälä
2021-10-26 16:05 ` Jani Nikula
2021-10-26 9:56 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dp: fix integer overflow in 128b/132b data rate calculation (rev2) Patchwork
2021-10-26 10:30 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2021-10-26 11:53 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dp: fix integer overflow in 128b/132b data rate calculation (rev3) Patchwork
2021-10-26 12:27 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-10-26 14:10 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox