Re: [Intel-gfx] i915 build issue

[Jani Nikula <jani.nikula@linux.intel.com>]

On Tue, 11 Jul 2023, John Garry <john.g.garry@oracle.com> wrote:
> Hi guys,
>
> Did anyone else notice this build issue on v6.5-rc1:
>
> drivers/gpu/drm/i915/i915_pci.c:143:15: error: expected expression
> before ‘,’ token
>    GEN3_FEATURES,
>                 ^
> drivers/gpu/drm/i915/i915_pci.c:151:15: error: expected expression
> before ‘,’ token
>    GEN3_FEATURES,
>                 ^
> drivers/gpu/drm/i915/i915_pci.c:159:15: error: expected expression
> before ‘,’ token
>    GEN3_FEATURES,
>                 ^
> drivers/gpu/drm/i915/i915_pci.c:166:15: error: expected expression
> before ‘,’ token
>    GEN3_FEATURES,
>                 ^
> drivers/gpu/drm/i915/i915_pci.c:174:15: error: expected expression
> before ‘,’ token
>    GEN3_FEATURES,
>                 ^
> drivers/gpu/drm/i915/i915_pci.c:180:15: error: expected expression
> before ‘,’ token
>    GEN3_FEATURES,
>                 ^
> drivers/gpu/drm/i915/i915_pci.c:186:15: error: expected expression
> before ‘,’ token
>    GEN3_FEATURES,
>                 ^
> drivers/gpu/drm/i915/i915_pci.c:209:15: error: initialized field
> overwritten [-Werror=override-init]
>    .has_snoop = false,
>                 ^~~~~
> ...
>
> I'm using following gcc:
>
> john@localhost:~/mnt_sda4/john/linux> gcc --version
> gcc (SUSE Linux) 7.5.0
> Copyright (C) 2017 Free Software Foundation, Inc.
> This is free software; see the source for copying conditions.  There is NO
> warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
>
> I didn't notice anything on dri-devel mailing list about this.

I presume you're using CONFIG_WERROR=y or W=e.

See [1] and [2]. I'm undecided how we should treat this.


BR,
Jani.


[1] https://lore.kernel.org/r/87wmzezns4.fsf@intel.com
[2] https://gitlab.freedesktop.org/drm/intel/-/issues/8768


-- 
Jani Nikula, Intel Open Source Graphics Center