* [Intel-gfx] i915 build issue
@ 2023-07-11 8:35 John Garry
2023-07-11 9:58 ` Jani Nikula
0 siblings, 1 reply; 4+ messages in thread
From: John Garry @ 2023-07-11 8:35 UTC (permalink / raw)
To: dri-devel, intel-gfx, jani.nikula, joonas.lahtinen, rodrigo.vivi,
tvrtko.ursulin
Hi guys,
Did anyone else notice this build issue on v6.5-rc1:
drivers/gpu/drm/i915/i915_pci.c:143:15: error: expected expression
before ‘,’ token
GEN3_FEATURES,
^
drivers/gpu/drm/i915/i915_pci.c:151:15: error: expected expression
before ‘,’ token
GEN3_FEATURES,
^
drivers/gpu/drm/i915/i915_pci.c:159:15: error: expected expression
before ‘,’ token
GEN3_FEATURES,
^
drivers/gpu/drm/i915/i915_pci.c:166:15: error: expected expression
before ‘,’ token
GEN3_FEATURES,
^
drivers/gpu/drm/i915/i915_pci.c:174:15: error: expected expression
before ‘,’ token
GEN3_FEATURES,
^
drivers/gpu/drm/i915/i915_pci.c:180:15: error: expected expression
before ‘,’ token
GEN3_FEATURES,
^
drivers/gpu/drm/i915/i915_pci.c:186:15: error: expected expression
before ‘,’ token
GEN3_FEATURES,
^
drivers/gpu/drm/i915/i915_pci.c:209:15: error: initialized field
overwritten [-Werror=override-init]
.has_snoop = false,
^~~~~
...
I'm using following gcc:
john@localhost:~/mnt_sda4/john/linux> gcc --version
gcc (SUSE Linux) 7.5.0
Copyright (C) 2017 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
I didn't notice anything on dri-devel mailing list about this.
Cheers,
John
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Intel-gfx] i915 build issue
2023-07-11 8:35 [Intel-gfx] i915 build issue John Garry
@ 2023-07-11 9:58 ` Jani Nikula
2023-07-11 10:08 ` John Garry
0 siblings, 1 reply; 4+ messages in thread
From: Jani Nikula @ 2023-07-11 9:58 UTC (permalink / raw)
To: John Garry, dri-devel, intel-gfx, joonas.lahtinen, rodrigo.vivi,
tvrtko.ursulin
On Tue, 11 Jul 2023, John Garry <john.g.garry@oracle.com> wrote:
> Hi guys,
>
> Did anyone else notice this build issue on v6.5-rc1:
>
> drivers/gpu/drm/i915/i915_pci.c:143:15: error: expected expression
> before ‘,’ token
> GEN3_FEATURES,
> ^
> drivers/gpu/drm/i915/i915_pci.c:151:15: error: expected expression
> before ‘,’ token
> GEN3_FEATURES,
> ^
> drivers/gpu/drm/i915/i915_pci.c:159:15: error: expected expression
> before ‘,’ token
> GEN3_FEATURES,
> ^
> drivers/gpu/drm/i915/i915_pci.c:166:15: error: expected expression
> before ‘,’ token
> GEN3_FEATURES,
> ^
> drivers/gpu/drm/i915/i915_pci.c:174:15: error: expected expression
> before ‘,’ token
> GEN3_FEATURES,
> ^
> drivers/gpu/drm/i915/i915_pci.c:180:15: error: expected expression
> before ‘,’ token
> GEN3_FEATURES,
> ^
> drivers/gpu/drm/i915/i915_pci.c:186:15: error: expected expression
> before ‘,’ token
> GEN3_FEATURES,
> ^
> drivers/gpu/drm/i915/i915_pci.c:209:15: error: initialized field
> overwritten [-Werror=override-init]
> .has_snoop = false,
> ^~~~~
> ...
>
> I'm using following gcc:
>
> john@localhost:~/mnt_sda4/john/linux> gcc --version
> gcc (SUSE Linux) 7.5.0
> Copyright (C) 2017 Free Software Foundation, Inc.
> This is free software; see the source for copying conditions. There is NO
> warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
>
> I didn't notice anything on dri-devel mailing list about this.
I presume you're using CONFIG_WERROR=y or W=e.
See [1] and [2]. I'm undecided how we should treat this.
BR,
Jani.
[1] https://lore.kernel.org/r/87wmzezns4.fsf@intel.com
[2] https://gitlab.freedesktop.org/drm/intel/-/issues/8768
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Intel-gfx] i915 build issue
2023-07-11 9:58 ` Jani Nikula
@ 2023-07-11 10:08 ` John Garry
2023-07-11 11:05 ` Jani Nikula
0 siblings, 1 reply; 4+ messages in thread
From: John Garry @ 2023-07-11 10:08 UTC (permalink / raw)
To: Jani Nikula, dri-devel, intel-gfx, joonas.lahtinen, rodrigo.vivi,
tvrtko.ursulin
On 11/07/2023 10:58, Jani Nikula wrote:
>> I didn't notice anything on dri-devel mailing list about this.
> I presume you're using CONFIG_WERROR=y or W=e.
I'm just using whatever vanilla x86_64_defconfig gives.
>
> See [1] and [2]. I'm undecided how we should treat this.
Ok.
Thanks,
John
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Intel-gfx] i915 build issue
2023-07-11 10:08 ` John Garry
@ 2023-07-11 11:05 ` Jani Nikula
0 siblings, 0 replies; 4+ messages in thread
From: Jani Nikula @ 2023-07-11 11:05 UTC (permalink / raw)
To: John Garry, dri-devel, intel-gfx, joonas.lahtinen, rodrigo.vivi,
tvrtko.ursulin
On Tue, 11 Jul 2023, John Garry <john.g.garry@oracle.com> wrote:
> On 11/07/2023 10:58, Jani Nikula wrote:
>>> I didn't notice anything on dri-devel mailing list about this.
>> I presume you're using CONFIG_WERROR=y or W=e.
>
> I'm just using whatever vanilla x86_64_defconfig gives.
>
>>
>> See [1] and [2]. I'm undecided how we should treat this.
Seeing that the x86 defconfigs enable CONFIG_WERROR=y, we're probably
going to have to roll this back.
https://patchwork.freedesktop.org/patch/msgid/20230711110214.25093-1-jani.nikula@intel.com
BR,
Jani.
>
> Ok.
>
> Thanks,
> John
>
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-07-11 11:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-11 8:35 [Intel-gfx] i915 build issue John Garry
2023-07-11 9:58 ` Jani Nikula
2023-07-11 10:08 ` John Garry
2023-07-11 11:05 ` Jani Nikula
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox