* [Intel-gfx] [PATCH 3/3] i915-pmu: Add extra check NULL
@ 2022-08-16 9:25 Denis Arefev
2022-08-16 10:03 ` Jani Nikula
0 siblings, 1 reply; 2+ messages in thread
From: Denis Arefev @ 2022-08-16 9:25 UTC (permalink / raw)
To: Jani Nikula
Cc: ldv-project, trufanov, David Airlie, intel-gfx, linux-kernel,
dri-devel, vfh, Daniel Vetter, Rodrigo Vivi
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Signed-off-by: Denis Arefev <arefev@swemel.ru>
---
drivers/gpu/drm/i915/i915_pmu.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_pmu.c b/drivers/gpu/drm/i915/i915_pmu.c
index 34a7f0ef1f67..33db49ffac3d 100644
--- a/drivers/gpu/drm/i915/i915_pmu.c
+++ b/drivers/gpu/drm/i915/i915_pmu.c
@@ -704,8 +704,7 @@ static void i915_pmu_disable(struct perf_event *event)
* Decrement the reference count and clear the enabled
* bitmask when the last listener on an event goes away.
*/
- if(engine != NULL)
- {
+ if (engine != NULL) {
if (--engine->pmu.enable_count[sample] == 0)
engine->pmu.enable &= ~BIT(sample);
}
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Intel-gfx] [PATCH 3/3] i915-pmu: Add extra check NULL
2022-08-16 9:25 [Intel-gfx] [PATCH 3/3] i915-pmu: Add extra check NULL Denis Arefev
@ 2022-08-16 10:03 ` Jani Nikula
0 siblings, 0 replies; 2+ messages in thread
From: Jani Nikula @ 2022-08-16 10:03 UTC (permalink / raw)
To: Denis Arefev
Cc: ldv-project, trufanov, David Airlie, intel-gfx, linux-kernel,
dri-devel, vfh, Daniel Vetter, Rodrigo Vivi
On Tue, 16 Aug 2022, Denis Arefev <arefev@swemel.ru> wrote:
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
The subject prefix should be something along the lines of
"drm/i915/pmu".
The subject is misleading; there are no functional changes here, just
whitespace changes. I'm guessing you intended to send something else?
Finally, the commit message is primarily for describing why the change
is being made, not to advertize organizations or tools.
BR,
Jani.
>
> Signed-off-by: Denis Arefev <arefev@swemel.ru>
> ---
> drivers/gpu/drm/i915/i915_pmu.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_pmu.c b/drivers/gpu/drm/i915/i915_pmu.c
> index 34a7f0ef1f67..33db49ffac3d 100644
> --- a/drivers/gpu/drm/i915/i915_pmu.c
> +++ b/drivers/gpu/drm/i915/i915_pmu.c
> @@ -704,8 +704,7 @@ static void i915_pmu_disable(struct perf_event *event)
> * Decrement the reference count and clear the enabled
> * bitmask when the last listener on an event goes away.
> */
> - if(engine != NULL)
> - {
> + if (engine != NULL) {
> if (--engine->pmu.enable_count[sample] == 0)
> engine->pmu.enable &= ~BIT(sample);
> }
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-08-16 13:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-16 9:25 [Intel-gfx] [PATCH 3/3] i915-pmu: Add extra check NULL Denis Arefev
2022-08-16 10:03 ` Jani Nikula
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox