Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Intel-gfx] [PATCH] drm/i915: Set correct domains values at _i915_vma_move_to_active
@ 2022-09-07 17:26 Nirmoy Das
  2022-09-07 18:36 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
                   ` (3 more replies)
  0 siblings, 4 replies; 9+ messages in thread
From: Nirmoy Das @ 2022-09-07 17:26 UTC (permalink / raw)
  To: intel-gfx; +Cc: andrzej.hajda, matthew.auld, chris.p.wilson

Fix regression introduced by commit:
"drm/i915: Individualize fences before adding to dma_resv obj"
which sets obj->read_domains to 0 for both read and write paths.
Also set obj->write_domain to 0 on read path which was removed by
the commit.

References: https://gitlab.freedesktop.org/drm/intel/-/issues/6639
Fixes: 842d9346b2fd ("drm/i915: Individualize fences before adding to dma_resv obj")
Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
Cc: <stable@vger.kernel.org> # v5.16+
Cc: Matthew Auld <matthew.auld@intel.com>
Cc: Andrzej Hajda <andrzej.hajda@intel.com>
---
 drivers/gpu/drm/i915/i915_vma.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/i915_vma.c b/drivers/gpu/drm/i915/i915_vma.c
index 260371716490..373582cfd8f3 100644
--- a/drivers/gpu/drm/i915/i915_vma.c
+++ b/drivers/gpu/drm/i915/i915_vma.c
@@ -1882,12 +1882,13 @@ int _i915_vma_move_to_active(struct i915_vma *vma,
 		enum dma_resv_usage usage;
 		int idx;
 
-		obj->read_domains = 0;
 		if (flags & EXEC_OBJECT_WRITE) {
 			usage = DMA_RESV_USAGE_WRITE;
 			obj->write_domain = I915_GEM_DOMAIN_RENDER;
+			obj->read_domains = 0;
 		} else {
 			usage = DMA_RESV_USAGE_READ;
+			obj->write_domain = 0;
 		}
 
 		dma_fence_array_for_each(curr, idx, fence)
-- 
2.37.3


^ permalink raw reply related	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2022-09-08 10:16 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-07 17:26 [Intel-gfx] [PATCH] drm/i915: Set correct domains values at _i915_vma_move_to_active Nirmoy Das
2022-09-07 18:36 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2022-09-07 19:57 ` [Intel-gfx] [PATCH] " Andrzej Hajda
2022-09-08  1:01 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for " Patchwork
2022-09-08  9:55   ` Das, Nirmoy
2022-09-08  9:40 ` [Intel-gfx] [PATCH] " Matthew Auld
2022-09-08  9:46   ` Das, Nirmoy
2022-09-08 10:13     ` Matthew Auld
2022-09-08 10:15       ` Das, Nirmoy

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox