Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: Imre Deak <imre.deak@intel.com>,
	intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: Mika Kahola <mika.kahola@intel.com>
Subject: Re: [PATCH v2 00/11] drm/i915/ddi: Fix/simplify port enabling/disabling
Date: Fri, 14 Feb 2025 17:37:30 +0200	[thread overview]
Message-ID: <87a5aown9h.fsf@intel.com> (raw)
In-Reply-To: <20250214142001.552916-1-imre.deak@intel.com>

On Fri, 14 Feb 2025, Imre Deak <imre.deak@intel.com> wrote:
> This v2 of [1], addressing the review comments from Jani and adding Rbs.
> This version contains only the first half of the patchset, leaving the
> rest for a follow-up, since programming DDI_BUF_CTL via RMW contained in
> the latter part needs more thought.

Good stuff, Rb's stand, and it's good to get the ready stuff merged
before this starts conflicting.

Thanks,
Jani.

>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Mika Kahola <mika.kahola@intel.com>
>
> [1] https://patchwork.freedesktop.org/series/144122
>
> Imre Deak (11):
>   drm/i915/dsi: Use TRANS_DDI_FUNC_CTL's own port width macro
>   drm/i915/ddi: Fix HDMI port width programming in DDI_BUF_CTL
>   drm/i915/ddi: Make all the PORT_WIDTH macros work the same way
>   drm/i915/ddi: Set missing TC DP PHY lane stagger delay in DDI_BUF_CTL
>   drm/i915/ddi: Simplify the port enabling via DDI_BUF_CTL
>   drm/i915/ddi: Simplify the port disabling via DDI_BUF_CTL
>   drm/i915/ddi: Simplify waiting for a port to get active/idle via
>     DDI_BUF_CTL
>   drm/i915/ddi: Move platform checks within
>     mtl_ddi_enable/disable_d2d_link()
>   drm/i915/ddi: Unify the platform specific functions disabling a port
>   drm/i915/ddi: Add a helper to enable a port
>   drm/i915/ddi: Sanitize DDI_BUF_CTL register definitions
>
>  drivers/gpu/drm/i915/display/icl_dsi.c        |   4 +-
>  .../gpu/drm/i915/display/intel_cx0_phy_regs.h |   3 +-
>  drivers/gpu/drm/i915/display/intel_ddi.c      | 256 +++++++-----------
>  drivers/gpu/drm/i915/i915_reg.h               |  25 +-
>  4 files changed, 123 insertions(+), 165 deletions(-)

-- 
Jani Nikula, Intel

  parent reply	other threads:[~2025-02-14 15:37 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-14 14:19 [PATCH v2 00/11] drm/i915/ddi: Fix/simplify port enabling/disabling Imre Deak
2025-02-14 14:19 ` [PATCH v2 01/11] drm/i915/dsi: Use TRANS_DDI_FUNC_CTL's own port width macro Imre Deak
2025-02-14 14:19 ` [PATCH v2 02/11] drm/i915/ddi: Fix HDMI port width programming in DDI_BUF_CTL Imre Deak
2025-02-14 14:19 ` [PATCH v2 03/11] drm/i915/ddi: Make all the PORT_WIDTH macros work the same way Imre Deak
2025-02-14 14:19 ` [PATCH v2 04/11] drm/i915/ddi: Set missing TC DP PHY lane stagger delay in DDI_BUF_CTL Imre Deak
2025-02-14 14:19 ` [PATCH v2 05/11] drm/i915/ddi: Simplify the port enabling via DDI_BUF_CTL Imre Deak
2025-02-14 14:19 ` [PATCH v2 06/11] drm/i915/ddi: Simplify the port disabling " Imre Deak
2025-02-14 14:19 ` [PATCH v2 07/11] drm/i915/ddi: Simplify waiting for a port to get active/idle " Imre Deak
2025-02-14 14:19 ` [PATCH v2 08/11] drm/i915/ddi: Move platform checks within mtl_ddi_enable/disable_d2d_link() Imre Deak
2025-02-14 14:19 ` [PATCH v2 09/11] drm/i915/ddi: Unify the platform specific functions disabling a port Imre Deak
2025-02-14 14:20 ` [PATCH v2 10/11] drm/i915/ddi: Add a helper to enable " Imre Deak
2025-02-14 14:20 ` [PATCH v2 11/11] drm/i915/ddi: Sanitize DDI_BUF_CTL register definitions Imre Deak
2025-02-14 15:14 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915/ddi: Fix/simplify port enabling/disabling (rev2) Patchwork
2025-02-14 15:14 ` ✗ Fi.CI.SPARSE: " Patchwork
2025-02-14 15:33 ` ✓ i915.CI.BAT: success " Patchwork
2025-02-14 15:37 ` Jani Nikula [this message]
2025-02-14 17:18 ` ✗ i915.CI.Full: failure " Patchwork
2025-02-14 20:15   ` Imre Deak
2025-02-14 20:22     ` Imre Deak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a5aown9h.fsf@intel.com \
    --to=jani.nikula@intel.com \
    --cc=imre.deak@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=mika.kahola@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox