From: Jani Nikula <jani.nikula@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 19/21] drm/i915: move some leftovers to intel_pm.h from i915_drv.h
Date: Mon, 29 Apr 2019 16:03:33 +0300 [thread overview]
Message-ID: <87a7g9rmje.fsf@intel.com> (raw)
In-Reply-To: <155654191148.27886.16635270994402996173@skylake-alporthouse-com>
On Mon, 29 Apr 2019, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> Quoting Jani Nikula (2019-04-29 13:29:37)
>> Commit 696173b064c6 ("drm/i915: extract intel_pm.h from intel_drv.h")
>> missed the declarations in i915_drv.h.
>
> Fwiw, I want to pull these along with gt powermanagement and rps into
> gt/intel_gt_pm.c and a few friends.
>
> Doesn't make much difference for this patch; just planned obsolescence.
I'm fine either way, via this patch or directly.
In general I like how it's easier to look at the new headers and wonder
why on earth some functions are in the files they are, and try to come
up with better division into files.
---
I'm also trying to probe feedback on some style guidelines I might like
to enforce in the future:
1) A file and the non-static functions in it should have the same
prefix, i.e. intel_foo.c has functions prefixed intel_foo_*.
2) No file should have platform specific non-static functions, i.e. all
the non-static functions should be intel_foo_* and this should
internally split to platform_foo_* instead of leaving the if ladders
or function pointer initializations to the callers.
So, thoughts on naming the functions intel_gt_pm_* upon moving them?
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-04-29 13:01 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-29 12:29 [PATCH 00/21] drm/i915: the great header refactoring, part two Jani Nikula
2019-04-29 12:29 ` [PATCH 01/21] drm/i915: ensure more headers remain self-contained Jani Nikula
2019-04-29 12:29 ` [PATCH 02/21] drm/i915: make intel_bios.h self-contained Jani Nikula
2019-04-29 12:29 ` [PATCH 03/21] drm/i915/dvo: rename dvo.h to intel_dvo_dev.h and make self-contained Jani Nikula
2019-04-29 12:29 ` [PATCH 04/21] drm/i915: make intel_dpll_mgr.h self-contained Jani Nikula
2019-04-29 12:29 ` [PATCH 05/21] drm/i915: move dsi init functions to intel_dsi.h Jani Nikula
2019-04-29 12:29 ` [PATCH 06/21] drm/i915: extract intel_fifo_underrun.h from intel_drv.h Jani Nikula
2019-04-29 12:29 ` [PATCH 07/21] drm/i915: extract intel_dp_link_training.h " Jani Nikula
2019-04-29 12:29 ` [PATCH 08/21] drm/i915: extract intel_dp_aux_backlight.h " Jani Nikula
2019-04-29 12:29 ` [PATCH 09/21] drm/i915: extract i915_irq.h from intel_drv.h and i915_drv.h Jani Nikula
2019-04-29 12:29 ` [PATCH 10/21] drm/i915: extract intel_hotplug.h " Jani Nikula
2019-04-29 12:50 ` [PATCH v2] " Jani Nikula
2019-04-29 12:29 ` [PATCH 11/21] drm/i915: extract intel_bios.h functions from i915_drv.h Jani Nikula
2019-04-29 12:29 ` [PATCH 12/21] drm/i915: extract intel_quirks.h from intel_drv.h Jani Nikula
2019-04-29 12:29 ` [PATCH 13/21] drm/i915: extract intel_overlay.h from intel_drv.h and i915_drv.h Jani Nikula
2019-04-29 12:29 ` [PATCH 14/21] drm/i915: extract intel_vdsc.h " Jani Nikula
2019-04-29 12:29 ` [PATCH 15/21] drm/i915: extract intel_dp_mst.h from intel_drv.h Jani Nikula
2019-04-29 12:29 ` [PATCH 16/21] drm/i915: extract intel_dsi_dcs_backlight.h " Jani Nikula
2019-04-29 12:29 ` [PATCH 17/21] drm/i915: extract intel_atomic.h " Jani Nikula
2019-04-29 12:53 ` [PATCH v2] " Jani Nikula
2019-04-29 12:29 ` [PATCH 18/21] drm/i915: extract intel_runtime_pm.h " Jani Nikula
2019-05-21 18:38 ` [18/21] " Nathan Chancellor
2019-05-22 10:38 ` Jani Nikula
2019-05-22 19:58 ` Nathan Chancellor
2019-04-29 12:29 ` [PATCH 19/21] drm/i915: move some leftovers to intel_pm.h from i915_drv.h Jani Nikula
2019-04-29 12:45 ` Chris Wilson
2019-04-29 13:03 ` Jani Nikula [this message]
2019-04-30 7:24 ` Joonas Lahtinen
2019-04-30 9:55 ` Chris Wilson
2019-04-29 12:29 ` [PATCH 20/21] drm/i915: extract intel_combo_phy.h " Jani Nikula
2019-04-29 12:29 ` [PATCH 21/21] drm/i915: add single combo phy init/unit functions Jani Nikula
2019-04-29 12:55 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915: the great header refactoring, part two (rev2) Patchwork
2019-04-29 13:05 ` ✗ Fi.CI.SPARSE: " Patchwork
2019-04-29 13:23 ` ✓ Fi.CI.BAT: success " Patchwork
2019-04-29 13:26 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915: the great header refactoring, part two (rev3) Patchwork
2019-04-29 13:37 ` ✗ Fi.CI.SPARSE: " Patchwork
2019-04-29 13:54 ` ✓ Fi.CI.BAT: success " Patchwork
2019-04-29 17:29 ` ✗ Fi.CI.IGT: failure " Patchwork
2019-04-30 9:56 ` [PATCH 00/21] drm/i915: the great header refactoring, part two Chris Wilson
2019-04-30 12:28 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a7g9rmje.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox