From: Jani Nikula <jani.nikula@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: jani.nikula@intel.com
Subject: [PATCH 15/21] drm/i915: extract intel_dp_mst.h from intel_drv.h
Date: Mon, 29 Apr 2019 15:29:33 +0300 [thread overview]
Message-ID: <b2fd1b2b968aa0ce010d17e2811bc275cf9ca251.1556540890.git.jani.nikula@intel.com> (raw)
In-Reply-To: <cover.1556540889.git.jani.nikula@intel.com>
It used to be handy that we only had a couple of headers, but over time
intel_drv.h has become unwieldy. Extract declarations to a separate
header file corresponding to the implementation module, clarifying the
modularity of the driver.
Ensure the new header is self-contained, and do so with minimal further
includes, using forward declarations as needed. Include the new header
only where needed, and sort the modified include directives while at it
and as needed.
No functional changes.
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
| 1 +
drivers/gpu/drm/i915/intel_dp.c | 1 +
drivers/gpu/drm/i915/intel_dp_mst.c | 1 +
drivers/gpu/drm/i915/intel_dp_mst.h | 14 ++++++++++++++
drivers/gpu/drm/i915/intel_drv.h | 4 ----
5 files changed, 17 insertions(+), 4 deletions(-)
create mode 100644 drivers/gpu/drm/i915/intel_dp_mst.h
diff --git a/drivers/gpu/drm/i915/Makefile.header-test b/drivers/gpu/drm/i915/Makefile.header-test
index 3c7637..226c43 100644
--- a/drivers/gpu/drm/i915/Makefile.header-test
+++ b/drivers/gpu/drm/i915/Makefile.header-test
@@ -25,6 +25,7 @@ header_test := \
intel_dp.h \
intel_dp_aux_backlight.h \
intel_dp_link_training.h \
+ intel_dp_mst.h \
intel_dpll_mgr.h \
intel_drv.h \
intel_dsi.h \
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index 4279f97..58f6d0 100644
--- a/drivers/gpu/drm/i915/intel_dp.c
+++ b/drivers/gpu/drm/i915/intel_dp.c
@@ -48,6 +48,7 @@
#include "intel_ddi.h"
#include "intel_dp.h"
#include "intel_dp_link_training.h"
+#include "intel_dp_mst.h"
#include "intel_drv.h"
#include "intel_fifo_underrun.h"
#include "intel_hdcp.h"
diff --git a/drivers/gpu/drm/i915/intel_dp_mst.c b/drivers/gpu/drm/i915/intel_dp_mst.c
index 8839ea..46e8831 100644
--- a/drivers/gpu/drm/i915/intel_dp_mst.c
+++ b/drivers/gpu/drm/i915/intel_dp_mst.c
@@ -32,6 +32,7 @@
#include "intel_connector.h"
#include "intel_ddi.h"
#include "intel_dp.h"
+#include "intel_dp_mst.h"
#include "intel_drv.h"
static int intel_dp_mst_compute_link_config(struct intel_encoder *encoder,
diff --git a/drivers/gpu/drm/i915/intel_dp_mst.h b/drivers/gpu/drm/i915/intel_dp_mst.h
new file mode 100644
index 000000..1470c6
--- /dev/null
+++ b/drivers/gpu/drm/i915/intel_dp_mst.h
@@ -0,0 +1,14 @@
+/* SPDX-License-Identifier: MIT */
+/*
+ * Copyright © 2019 Intel Corporation
+ */
+
+#ifndef __INTEL_DP_MST_H__
+#define __INTEL_DP_MST_H__
+
+struct intel_digital_port;
+
+int intel_dp_mst_encoder_init(struct intel_digital_port *intel_dig_port, int conn_id);
+void intel_dp_mst_encoder_cleanup(struct intel_digital_port *intel_dig_port);
+
+#endif /* __INTEL_DP_MST_H__ */
diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h
index 0854c17..91474a 100644
--- a/drivers/gpu/drm/i915/intel_drv.h
+++ b/drivers/gpu/drm/i915/intel_drv.h
@@ -1766,10 +1766,6 @@ unsigned int i9xx_plane_max_stride(struct intel_plane *plane,
u32 pixel_format, u64 modifier,
unsigned int rotation);
-/* intel_dp_mst.c */
-int intel_dp_mst_encoder_init(struct intel_digital_port *intel_dig_port, int conn_id);
-void intel_dp_mst_encoder_cleanup(struct intel_digital_port *intel_dig_port);
-
/* intel_dsi_dcs_backlight.c */
int intel_dsi_dcs_init_backlight_funcs(struct intel_connector *intel_connector);
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-04-29 12:28 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-29 12:29 [PATCH 00/21] drm/i915: the great header refactoring, part two Jani Nikula
2019-04-29 12:29 ` [PATCH 01/21] drm/i915: ensure more headers remain self-contained Jani Nikula
2019-04-29 12:29 ` [PATCH 02/21] drm/i915: make intel_bios.h self-contained Jani Nikula
2019-04-29 12:29 ` [PATCH 03/21] drm/i915/dvo: rename dvo.h to intel_dvo_dev.h and make self-contained Jani Nikula
2019-04-29 12:29 ` [PATCH 04/21] drm/i915: make intel_dpll_mgr.h self-contained Jani Nikula
2019-04-29 12:29 ` [PATCH 05/21] drm/i915: move dsi init functions to intel_dsi.h Jani Nikula
2019-04-29 12:29 ` [PATCH 06/21] drm/i915: extract intel_fifo_underrun.h from intel_drv.h Jani Nikula
2019-04-29 12:29 ` [PATCH 07/21] drm/i915: extract intel_dp_link_training.h " Jani Nikula
2019-04-29 12:29 ` [PATCH 08/21] drm/i915: extract intel_dp_aux_backlight.h " Jani Nikula
2019-04-29 12:29 ` [PATCH 09/21] drm/i915: extract i915_irq.h from intel_drv.h and i915_drv.h Jani Nikula
2019-04-29 12:29 ` [PATCH 10/21] drm/i915: extract intel_hotplug.h " Jani Nikula
2019-04-29 12:50 ` [PATCH v2] " Jani Nikula
2019-04-29 12:29 ` [PATCH 11/21] drm/i915: extract intel_bios.h functions from i915_drv.h Jani Nikula
2019-04-29 12:29 ` [PATCH 12/21] drm/i915: extract intel_quirks.h from intel_drv.h Jani Nikula
2019-04-29 12:29 ` [PATCH 13/21] drm/i915: extract intel_overlay.h from intel_drv.h and i915_drv.h Jani Nikula
2019-04-29 12:29 ` [PATCH 14/21] drm/i915: extract intel_vdsc.h " Jani Nikula
2019-04-29 12:29 ` Jani Nikula [this message]
2019-04-29 12:29 ` [PATCH 16/21] drm/i915: extract intel_dsi_dcs_backlight.h from intel_drv.h Jani Nikula
2019-04-29 12:29 ` [PATCH 17/21] drm/i915: extract intel_atomic.h " Jani Nikula
2019-04-29 12:53 ` [PATCH v2] " Jani Nikula
2019-04-29 12:29 ` [PATCH 18/21] drm/i915: extract intel_runtime_pm.h " Jani Nikula
2019-05-21 18:38 ` [18/21] " Nathan Chancellor
2019-05-22 10:38 ` Jani Nikula
2019-05-22 19:58 ` Nathan Chancellor
2019-04-29 12:29 ` [PATCH 19/21] drm/i915: move some leftovers to intel_pm.h from i915_drv.h Jani Nikula
2019-04-29 12:45 ` Chris Wilson
2019-04-29 13:03 ` Jani Nikula
2019-04-30 7:24 ` Joonas Lahtinen
2019-04-30 9:55 ` Chris Wilson
2019-04-29 12:29 ` [PATCH 20/21] drm/i915: extract intel_combo_phy.h " Jani Nikula
2019-04-29 12:29 ` [PATCH 21/21] drm/i915: add single combo phy init/unit functions Jani Nikula
2019-04-29 12:55 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915: the great header refactoring, part two (rev2) Patchwork
2019-04-29 13:05 ` ✗ Fi.CI.SPARSE: " Patchwork
2019-04-29 13:23 ` ✓ Fi.CI.BAT: success " Patchwork
2019-04-29 13:26 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915: the great header refactoring, part two (rev3) Patchwork
2019-04-29 13:37 ` ✗ Fi.CI.SPARSE: " Patchwork
2019-04-29 13:54 ` ✓ Fi.CI.BAT: success " Patchwork
2019-04-29 17:29 ` ✗ Fi.CI.IGT: failure " Patchwork
2019-04-30 9:56 ` [PATCH 00/21] drm/i915: the great header refactoring, part two Chris Wilson
2019-04-30 12:28 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b2fd1b2b968aa0ce010d17e2811bc275cf9ca251.1556540890.git.jani.nikula@intel.com \
--to=jani.nikula@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox