From: Jani Nikula <jani.nikula@linux.intel.com>
To: Siva Chandra <sivachandra@google.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Add a DRM property "psr"
Date: Thu, 20 Mar 2014 15:25:51 +0200 [thread overview]
Message-ID: <87a9cl2e8w.fsf@intel.com> (raw)
In-Reply-To: <CAGyQ6gymV9m7KL4ect++psOY3_tqRwGoGxknDP5bBU06fmp80g@mail.gmail.com>
On Thu, 20 Mar 2014, Siva Chandra <sivachandra@google.com> wrote:
> On Thu, Mar 20, 2014 at 3:52 AM, Jani Nikula
> <jani.nikula@linux.intel.com> wrote:
>> If this is for testing only, and the module parameter does not quite cut
>> it, please add it to debugfs. That we can pretty much change at will.
>
> If I understand correctly, you are suggesting that the on/off knob
> live in debugfs. So, should the module param in sysfs mirror this
> debugfs knob?
I guess the simplest thing to move forward would be something to update
psr state after the module parameter has been changed, although it's
perhaps a bit clumsy to use.
Jani.
--
Jani Nikula, Intel Open Source Technology Center
next prev parent reply other threads:[~2014-03-20 13:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-18 19:51 [PATCH] drm/i915: Add a DRM property "psr" Siva Chandra
2014-03-18 20:06 ` Jesse Barnes
2014-03-18 20:53 ` Siva Chandra
2014-03-19 8:44 ` Daniel Vetter
2014-03-19 15:03 ` Damien Lespiau
2014-03-19 17:04 ` Siva Chandra
2014-03-20 10:52 ` Jani Nikula
2014-03-20 13:17 ` Siva Chandra
2014-03-20 13:25 ` Jani Nikula [this message]
2014-03-20 13:31 ` Siva Chandra
2014-03-20 14:49 ` Jani Nikula
2014-03-20 15:16 ` Ville Syrjälä
2014-03-21 21:10 ` Siva Chandra
2014-03-19 15:32 ` Jani Nikula
2014-03-19 16:59 ` Siva Chandra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a9cl2e8w.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=sivachandra@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox