Re: [Intel-gfx] [PATCH dii-client v6 1/5] drm/i915: Add GuC TLB Invalidation pci flags

[Jani Nikula <jani.nikula@linux.intel.com>]

On Thu, 05 Oct 2023, Michal Wajdeczko <michal.wajdeczko@intel.com> wrote:
> On 05.10.2023 00:07, Jonathan Cavitt wrote:
>> Add pci (device info) flags for if GuC TLB Invalidation is enabled.
>
> nit: maybe avoid using "PCI flag" term here (and in the title) as this
> could be little misleading - better stick to "device info flag"
>
>> 
>> Signed-off-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
>> ---
>>  drivers/gpu/drm/i915/i915_drv.h          | 1 +
>>  drivers/gpu/drm/i915/intel_device_info.h | 3 ++-
>>  2 files changed, 3 insertions(+), 1 deletion(-)
>> 
>> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
>> index cb60fc9cf8737..c53c5586c40c8 100644
>> --- a/drivers/gpu/drm/i915/i915_drv.h
>> +++ b/drivers/gpu/drm/i915/i915_drv.h
>> @@ -801,4 +801,5 @@ IS_SUBPLATFORM(const struct drm_i915_private *i915,
>>  #define HAS_LMEMBAR_SMEM_STOLEN(i915) (!HAS_LMEM(i915) && \
>>  				       GRAPHICS_VER_FULL(i915) >= IP_VER(12, 70))
>>  
>> +#define HAS_GUC_TLB_INVALIDATION(i915)	(INTEL_INFO(i915)->has_guc_tlb_invalidation)
>>  #endif
>> diff --git a/drivers/gpu/drm/i915/intel_device_info.h b/drivers/gpu/drm/i915/intel_device_info.h
>> index 39817490b13fd..ad54db0a22470 100644
>> --- a/drivers/gpu/drm/i915/intel_device_info.h
>> +++ b/drivers/gpu/drm/i915/intel_device_info.h
>> @@ -173,7 +173,8 @@ enum intel_ppgtt_type {
>>  	func(has_coherent_ggtt); \
>>  	func(tuning_thread_rr_after_dep); \
>>  	func(unfenced_needs_alignment); \
>> -	func(hws_needs_physical);
>> +	func(hws_needs_physical); \
>> +	func(has_guc_tlb_invalidation);
>
> nit: there is already another "has_guc_deprivilege" flag so maybe we
> want to keep all GuC flags together ?

	/* Keep has_* in alphabetical order */ \

>
>>  
>>  struct intel_ip_version {
>>  	u8 ver;

-- 
Jani Nikula, Intel