Re: [Intel-gfx] [PATCH 0/3] drm/i915: Add HWMON support

["Dixit, Ashutosh" <ashutosh.dixit@intel.com>]

On Mon, 23 May 2022 04:08:38 -0700, Badal Nilawar wrote:
>
> This series adds the HWMON support for DG1, DG2
>
> Dale B Stimson (2):
>   drm/i915/hwmon: Add HWMON power sensor support
>   drm/i915/hwmon: Add HWMON energy support

I would suggest a slight reorganization of the series. I think the first
patch should just add the HWMON infrastrusture into i915. Subsequent
patches should add the various hwmon features exposed in sysfs, mostly one
patch per feature.

So at least for now I'd add a first patch adding the HWMON infra to
i915. And follow on with the feature patches. Thanks.

> Riana Tauro (1):
>   drm/i915/hwmon: Add HWMON current voltage support
>
>  .../ABI/testing/sysfs-driver-intel-i915-hwmon |  43 ++
>  drivers/gpu/drm/i915/Kconfig                  |   1 +
>  drivers/gpu/drm/i915/Makefile                 |   1 +
>  drivers/gpu/drm/i915/gt/intel_gt_regs.h       |   4 +
>  drivers/gpu/drm/i915/i915_driver.c            |   5 +
>  drivers/gpu/drm/i915/i915_drv.h               |   2 +
>  drivers/gpu/drm/i915/i915_hwmon.c             | 620 ++++++++++++++++++
>  drivers/gpu/drm/i915/i915_hwmon.h             |  56 ++
>  drivers/gpu/drm/i915/i915_reg.h               |  15 +
>  drivers/gpu/drm/i915/intel_mchbar_regs.h      |  11 +
>  10 files changed, 758 insertions(+)
>  create mode 100644 Documentation/ABI/testing/sysfs-driver-intel-i915-hwmon
>  create mode 100644 drivers/gpu/drm/i915/i915_hwmon.c
>  create mode 100644 drivers/gpu/drm/i915/i915_hwmon.h
>
> --
> 2.25.1
>