[PATCH topic/core-for-CI] Revert "libata: Downgrade unsupported feature warnings to notifications"

[PATCH topic/core-for-CI] Revert "libata: Downgrade unsupported feature warnings to notifications"

[Lucas De Marchi]

This reverts commit 3f412047c54e28ecd50c10bdcec698f166c861e8.

Tentative removal from topic/core-for-CI.

Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
 drivers/ata/libata-core.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index 14bed90d83367..773799cfd4430 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -2178,7 +2178,7 @@ static bool ata_identify_page_supported(struct ata_device *dev, u8 page)
 		 * for drives which implement this ATA level or above.
 		 */
 		if (ata_id_major_version(dev->id) >= 10)
-			ata_dev_notice(dev,
+			ata_dev_warn(dev,
 				"ATA Identify Device Log not supported\n");
 		dev->quirks |= ATA_QUIRK_NO_ID_DEV_LOG;
 		return false;
@@ -2249,7 +2249,7 @@ static void ata_dev_config_ncq_send_recv(struct ata_device *dev)
 	unsigned int err_mask;
 
 	if (!ata_log_supported(dev, ATA_LOG_NCQ_SEND_RECV)) {
-		ata_dev_notice(dev, "NCQ Send/Recv Log not supported\n");
+		ata_dev_warn(dev, "NCQ Send/Recv Log not supported\n");
 		return;
 	}
 	err_mask = ata_read_log_page(dev, ATA_LOG_NCQ_SEND_RECV,
@@ -2273,8 +2273,8 @@ static void ata_dev_config_ncq_non_data(struct ata_device *dev)
 	unsigned int err_mask;
 
 	if (!ata_log_supported(dev, ATA_LOG_NCQ_NON_DATA)) {
-		ata_dev_notice(dev,
-			       "NCQ Non-Data Log not supported\n");
+		ata_dev_warn(dev,
+			     "NCQ Non-Data Log not supported\n");
 		return;
 	}
 	err_mask = ata_read_log_page(dev, ATA_LOG_NCQ_NON_DATA,
@@ -2937,14 +2937,14 @@ int ata_dev_configure(struct ata_device *dev)
 		if (ata_id_is_cfa(id)) {
 			/* CPRM may make this media unusable */
 			if (id[ATA_ID_CFA_KEY_MGMT] & 1)
-				ata_dev_notice(dev,
+				ata_dev_warn(dev,
 	"supports DRM functions and may not be fully accessible\n");
 			snprintf(revbuf, 7, "CFA");
 		} else {
 			snprintf(revbuf, 7, "ATA-%d", ata_id_major_version(id));
 			/* Warn the user if the device has TPM extensions */
 			if (ata_id_has_tpm(id))
-				ata_dev_notice(dev,
+				ata_dev_warn(dev,
 	"supports DRM functions and may not be fully accessible\n");
 		}
 
@@ -3100,8 +3100,8 @@ int ata_dev_configure(struct ata_device *dev)
 	}
 
 	if ((dev->quirks & ATA_QUIRK_FIRMWARE_WARN) && print_info) {
-		ata_dev_notice(dev, "WARNING: device requires firmware update to be fully functional\n");
-		ata_dev_notice(dev, "         contact the vendor or visit http://ata.wiki.kernel.org\n");
+		ata_dev_warn(dev, "WARNING: device requires firmware update to be fully functional\n");
+		ata_dev_warn(dev, "         contact the vendor or visit http://ata.wiki.kernel.org\n");
 	}
 
 	return 0;
-- 
2.49.0

✗ Fi.CI.CHECKPATCH: warning for Revert "libata: Downgrade unsupported feature warnings to notifications"

[Patchwork]

== Series Details ==

Series: Revert "libata: Downgrade unsupported feature warnings to notifications"
URL   : https://patchwork.freedesktop.org/series/147429/
State : warning

== Summary ==

Error: dim checkpatch failed
66efc191cb7b Revert "libata: Downgrade unsupported feature warnings to notifications"
-:23: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#23: FILE: drivers/ata/libata-core.c:2182:
+			ata_dev_warn(dev,
 				"ATA Identify Device Log not supported\n");

-:52: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#52: FILE: drivers/ata/libata-core.c:2941:
+				ata_dev_warn(dev,
 	"supports DRM functions and may not be fully accessible\n");

-:60: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#60: FILE: drivers/ata/libata-core.c:2948:
+				ata_dev_warn(dev,
 	"supports DRM functions and may not be fully accessible\n");

total: 0 errors, 0 warnings, 3 checks, 52 lines checked

✗ i915.CI.BAT: failure for Revert "libata: Downgrade unsupported feature warnings to notifications"

[Patchwork]

[-- Attachment #1: Type: text/plain, Size: 3622 bytes --]

== Series Details ==

Series: Revert "libata: Downgrade unsupported feature warnings to notifications"
URL   : https://patchwork.freedesktop.org/series/147429/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_16386 -> Patchwork_147429v1
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with Patchwork_147429v1 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_147429v1, please notify your bug team (I915-ci-infra@lists.freedesktop.org) to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_147429v1/index.html

Participating hosts (44 -> 43)
------------------------------

  Missing    (1): fi-snb-2520m 

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in Patchwork_147429v1:

### IGT changes ###

#### Possible regressions ####

  * igt@i915_selftest@live:
    - bat-arlh-2:         [PASS][1] -> [INCOMPLETE][2] +1 other test incomplete
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16386/bat-arlh-2/igt@i915_selftest@live.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_147429v1/bat-arlh-2/igt@i915_selftest@live.html

  
Known issues
------------

  Here are the changes found in Patchwork_147429v1 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@dmabuf@all-tests@dma_fence_chain:
    - fi-bsw-nick:        [PASS][3] -> [INCOMPLETE][4] ([i915#12904]) +1 other test incomplete
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16386/fi-bsw-nick/igt@dmabuf@all-tests@dma_fence_chain.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_147429v1/fi-bsw-nick/igt@dmabuf@all-tests@dma_fence_chain.html

  
#### Possible fixes ####

  * igt@i915_selftest@live:
    - bat-twl-1:          [ABORT][5] -> [PASS][6] +1 other test pass
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16386/bat-twl-1/igt@i915_selftest@live.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_147429v1/bat-twl-1/igt@i915_selftest@live.html

  * igt@i915_selftest@live@workarounds:
    - bat-arlh-3:         [DMESG-FAIL][7] ([i915#12061]) -> [PASS][8] +1 other test pass
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16386/bat-arlh-3/igt@i915_selftest@live@workarounds.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_147429v1/bat-arlh-3/igt@i915_selftest@live@workarounds.html
    - bat-arls-6:         [DMESG-FAIL][9] ([i915#12061]) -> [PASS][10] +1 other test pass
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16386/bat-arls-6/igt@i915_selftest@live@workarounds.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_147429v1/bat-arls-6/igt@i915_selftest@live@workarounds.html

  
  [i915#12061]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12061
  [i915#12904]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12904


Build changes
-------------

  * Linux: CI_DRM_16386 -> Patchwork_147429v1

  CI-20190529: 20190529
  CI_DRM_16386: 1951437999630d299a063863fb92d235dd8dc3d1 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_8311: 851a9c1cb1a690d8c527f26c49c250ec583af65e @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
  Patchwork_147429v1: 1951437999630d299a063863fb92d235dd8dc3d1 @ git://anongit.freedesktop.org/gfx-ci/linux

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_147429v1/index.html

[-- Attachment #2: Type: text/html, Size: 4404 bytes --]

✗ Fi.CI.CHECKPATCH: warning for Revert "libata: Downgrade unsupported feature warnings to notifications" (rev2)

[Patchwork]

== Series Details ==

Series: Revert "libata: Downgrade unsupported feature warnings to notifications" (rev2)
URL   : https://patchwork.freedesktop.org/series/147429/
State : warning

== Summary ==

Error: dim checkpatch failed
e453541810f2 Revert "libata: Downgrade unsupported feature warnings to notifications"
-:23: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#23: FILE: drivers/ata/libata-core.c:2182:
+			ata_dev_warn(dev,
 				"ATA Identify Device Log not supported\n");

-:52: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#52: FILE: drivers/ata/libata-core.c:2941:
+				ata_dev_warn(dev,
 	"supports DRM functions and may not be fully accessible\n");

-:60: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#60: FILE: drivers/ata/libata-core.c:2948:
+				ata_dev_warn(dev,
 	"supports DRM functions and may not be fully accessible\n");

total: 0 errors, 0 warnings, 3 checks, 52 lines checked

✓ i915.CI.BAT: success for Revert "libata: Downgrade unsupported feature warnings to notifications" (rev2)

[Patchwork]

[-- Attachment #1: Type: text/plain, Size: 3231 bytes --]

== Series Details ==

Series: Revert "libata: Downgrade unsupported feature warnings to notifications" (rev2)
URL   : https://patchwork.freedesktop.org/series/147429/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_16387 -> Patchwork_147429v2
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_147429v2/index.html

Participating hosts (44 -> 42)
------------------------------

  Missing    (2): fi-snb-2520m fi-skl-6600u 

Known issues
------------

  Here are the changes found in Patchwork_147429v2 that come from known issues:

### IGT changes ###

#### Possible fixes ####

  * igt@i915_selftest@live@late_gt_pm:
    - fi-cfl-8109u:       [DMESG-WARN][1] ([i915#13735]) -> [PASS][2] +82 other tests pass
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16387/fi-cfl-8109u/igt@i915_selftest@live@late_gt_pm.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_147429v2/fi-cfl-8109u/igt@i915_selftest@live@late_gt_pm.html

  * igt@i915_selftest@live@workarounds:
    - bat-arlh-3:         [DMESG-FAIL][3] ([i915#12061]) -> [PASS][4] +1 other test pass
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16387/bat-arlh-3/igt@i915_selftest@live@workarounds.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_147429v2/bat-arlh-3/igt@i915_selftest@live@workarounds.html
    - bat-mtlp-6:         [DMESG-FAIL][5] ([i915#12061]) -> [PASS][6] +1 other test pass
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16387/bat-mtlp-6/igt@i915_selftest@live@workarounds.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_147429v2/bat-mtlp-6/igt@i915_selftest@live@workarounds.html
    - bat-mtlp-9:         [DMESG-FAIL][7] ([i915#12061]) -> [PASS][8] +1 other test pass
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16387/bat-mtlp-9/igt@i915_selftest@live@workarounds.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_147429v2/bat-mtlp-9/igt@i915_selftest@live@workarounds.html

  * igt@kms_pipe_crc_basic@read-crc:
    - fi-cfl-8109u:       [DMESG-WARN][9] ([i915#13735] / [i915#13890]) -> [PASS][10] +49 other tests pass
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16387/fi-cfl-8109u/igt@kms_pipe_crc_basic@read-crc.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_147429v2/fi-cfl-8109u/igt@kms_pipe_crc_basic@read-crc.html

  
  [i915#12061]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12061
  [i915#13735]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13735
  [i915#13890]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13890


Build changes
-------------

  * Linux: CI_DRM_16387 -> Patchwork_147429v2

  CI-20190529: 20190529
  CI_DRM_16387: a49a4787e6bc70296204f4a6e1b0fed3759938cd @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_8311: 851a9c1cb1a690d8c527f26c49c250ec583af65e @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
  Patchwork_147429v2: a49a4787e6bc70296204f4a6e1b0fed3759938cd @ git://anongit.freedesktop.org/gfx-ci/linux

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_147429v2/index.html

[-- Attachment #2: Type: text/html, Size: 4127 bytes --]

Re: [PATCH topic/core-for-CI] Revert "libata: Downgrade unsupported feature warnings to notifications"

[Jani Nikula]

On Tue, 08 Apr 2025, Lucas De Marchi <lucas.demarchi@intel.com> wrote:
> This reverts commit 3f412047c54e28ecd50c10bdcec698f166c861e8.
>
> Tentative removal from topic/core-for-CI.
>
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>

Acked-by: Jani Nikula <jani.nikula@intel.com>

> ---
>  drivers/ata/libata-core.c | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
> index 14bed90d83367..773799cfd4430 100644
> --- a/drivers/ata/libata-core.c
> +++ b/drivers/ata/libata-core.c
> @@ -2178,7 +2178,7 @@ static bool ata_identify_page_supported(struct ata_device *dev, u8 page)
>  		 * for drives which implement this ATA level or above.
>  		 */
>  		if (ata_id_major_version(dev->id) >= 10)
> -			ata_dev_notice(dev,
> +			ata_dev_warn(dev,
>  				"ATA Identify Device Log not supported\n");
>  		dev->quirks |= ATA_QUIRK_NO_ID_DEV_LOG;
>  		return false;
> @@ -2249,7 +2249,7 @@ static void ata_dev_config_ncq_send_recv(struct ata_device *dev)
>  	unsigned int err_mask;
>  
>  	if (!ata_log_supported(dev, ATA_LOG_NCQ_SEND_RECV)) {
> -		ata_dev_notice(dev, "NCQ Send/Recv Log not supported\n");
> +		ata_dev_warn(dev, "NCQ Send/Recv Log not supported\n");
>  		return;
>  	}
>  	err_mask = ata_read_log_page(dev, ATA_LOG_NCQ_SEND_RECV,
> @@ -2273,8 +2273,8 @@ static void ata_dev_config_ncq_non_data(struct ata_device *dev)
>  	unsigned int err_mask;
>  
>  	if (!ata_log_supported(dev, ATA_LOG_NCQ_NON_DATA)) {
> -		ata_dev_notice(dev,
> -			       "NCQ Non-Data Log not supported\n");
> +		ata_dev_warn(dev,
> +			     "NCQ Non-Data Log not supported\n");
>  		return;
>  	}
>  	err_mask = ata_read_log_page(dev, ATA_LOG_NCQ_NON_DATA,
> @@ -2937,14 +2937,14 @@ int ata_dev_configure(struct ata_device *dev)
>  		if (ata_id_is_cfa(id)) {
>  			/* CPRM may make this media unusable */
>  			if (id[ATA_ID_CFA_KEY_MGMT] & 1)
> -				ata_dev_notice(dev,
> +				ata_dev_warn(dev,
>  	"supports DRM functions and may not be fully accessible\n");
>  			snprintf(revbuf, 7, "CFA");
>  		} else {
>  			snprintf(revbuf, 7, "ATA-%d", ata_id_major_version(id));
>  			/* Warn the user if the device has TPM extensions */
>  			if (ata_id_has_tpm(id))
> -				ata_dev_notice(dev,
> +				ata_dev_warn(dev,
>  	"supports DRM functions and may not be fully accessible\n");
>  		}
>  
> @@ -3100,8 +3100,8 @@ int ata_dev_configure(struct ata_device *dev)
>  	}
>  
>  	if ((dev->quirks & ATA_QUIRK_FIRMWARE_WARN) && print_info) {
> -		ata_dev_notice(dev, "WARNING: device requires firmware update to be fully functional\n");
> -		ata_dev_notice(dev, "         contact the vendor or visit http://ata.wiki.kernel.org\n");
> +		ata_dev_warn(dev, "WARNING: device requires firmware update to be fully functional\n");
> +		ata_dev_warn(dev, "         contact the vendor or visit http://ata.wiki.kernel.org\n");
>  	}
>  
>  	return 0;

-- 
Jani Nikula, Intel