Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Intel-gfx] [PATCH i-g-t] gem_ctx_freq: Remove reference to non-existent sysfs entry
@ 2023-03-09 19:48 Vinay Belgaumkar
  2023-03-09 20:04 ` [Intel-gfx] [igt-dev] " Dixit, Ashutosh
  0 siblings, 1 reply; 2+ messages in thread
From: Vinay Belgaumkar @ 2023-03-09 19:48 UTC (permalink / raw)
  To: intel-gfx, igt-dev

The entry for gt_idle_freq_mhz does not exist.

Fixes: d1ea62b3f759 (igt: Add gem_ctx_freq to exercise requesting freq via sysfs)

Cc: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
Signed-off-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
---
 tests/i915/gem_ctx_freq.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/tests/i915/gem_ctx_freq.c b/tests/i915/gem_ctx_freq.c
index a29fe68b..18e736c7 100644
--- a/tests/i915/gem_ctx_freq.c
+++ b/tests/i915/gem_ctx_freq.c
@@ -174,10 +174,8 @@ static void restore_sysfs_freq(int sig)
 {
 	char buf[256];
 
-	if (igt_sysfs_read(sysfs, "gt_RPn_freq_mhz", buf, sizeof(buf)) > 0) {
-		igt_sysfs_set(sysfs, "gt_idle_freq_mhz", buf);
+	if (igt_sysfs_read(sysfs, "gt_RPn_freq_mhz", buf, sizeof(buf)) > 0)
 		igt_sysfs_set(sysfs, "gt_min_freq_mhz", buf);
-	}
 
 	if (igt_sysfs_read(sysfs, "gt_RP0_freq_mhz", buf, sizeof(buf)) > 0) {
 		igt_sysfs_set(sysfs, "gt_max_freq_mhz", buf);
-- 
2.38.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] gem_ctx_freq: Remove reference to non-existent sysfs entry
  2023-03-09 19:48 [Intel-gfx] [PATCH i-g-t] gem_ctx_freq: Remove reference to non-existent sysfs entry Vinay Belgaumkar
@ 2023-03-09 20:04 ` Dixit, Ashutosh
  0 siblings, 0 replies; 2+ messages in thread
From: Dixit, Ashutosh @ 2023-03-09 20:04 UTC (permalink / raw)
  To: Vinay Belgaumkar; +Cc: igt-dev, intel-gfx

On Thu, 09 Mar 2023 11:48:41 -0800, Vinay Belgaumkar wrote:
>
> The entry for gt_idle_freq_mhz does not exist.
>
> Fixes: d1ea62b3f759 (igt: Add gem_ctx_freq to exercise requesting freq via sysfs)

Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>

>
> Cc: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
> Signed-off-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
> ---
>  tests/i915/gem_ctx_freq.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/tests/i915/gem_ctx_freq.c b/tests/i915/gem_ctx_freq.c
> index a29fe68b..18e736c7 100644
> --- a/tests/i915/gem_ctx_freq.c
> +++ b/tests/i915/gem_ctx_freq.c
> @@ -174,10 +174,8 @@ static void restore_sysfs_freq(int sig)
>  {
>	char buf[256];
>
> -	if (igt_sysfs_read(sysfs, "gt_RPn_freq_mhz", buf, sizeof(buf)) > 0) {
> -		igt_sysfs_set(sysfs, "gt_idle_freq_mhz", buf);
> +	if (igt_sysfs_read(sysfs, "gt_RPn_freq_mhz", buf, sizeof(buf)) > 0)
>		igt_sysfs_set(sysfs, "gt_min_freq_mhz", buf);
> -	}
>
>	if (igt_sysfs_read(sysfs, "gt_RP0_freq_mhz", buf, sizeof(buf)) > 0) {
>		igt_sysfs_set(sysfs, "gt_max_freq_mhz", buf);
> --
> 2.38.1
>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-03-09 20:04 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-09 19:48 [Intel-gfx] [PATCH i-g-t] gem_ctx_freq: Remove reference to non-existent sysfs entry Vinay Belgaumkar
2023-03-09 20:04 ` [Intel-gfx] [igt-dev] " Dixit, Ashutosh

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox