Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH i-g-t] i915/gem_map_gtt: Escape from slow forked GTT access
Date: Tue, 24 Sep 2019 16:09:53 +0300	[thread overview]
Message-ID: <87d0fpzvq6.fsf@gaia.fi.intel.com> (raw)
In-Reply-To: <20190924121821.31277-1-chris@chris-wilson.co.uk>

Chris Wilson <chris@chris-wilson.co.uk> writes:

> Beware the slithy t'oves.
>
> Forked GTT access on icl is notoriously slow, so rather than spend an
> eternity checking the whole object, check for a completion event after
> handling the pagefault. It's is the race of the pagefault vs reset that
> we care most about, and we expect the bug to result in the pagefault
> being blocked indefinitely, so checking afterwards does not reduce
> coverage.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>

Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>

> ---
>  tests/i915/gem_mmap_gtt.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/tests/i915/gem_mmap_gtt.c b/tests/i915/gem_mmap_gtt.c
> index 0428a1372..91da5a37b 100644
> --- a/tests/i915/gem_mmap_gtt.c
> +++ b/tests/i915/gem_mmap_gtt.c
> @@ -602,6 +602,9 @@ test_hang(int fd)
>  
>  				gtt[0][x] = patterns[next_pattern];
>  				gtt[1][x] = patterns[next_pattern];
> +
> +				if (READ_ONCE(control->done))
> +					break;
>  			}
>  
>  			last_pattern = next_pattern;
> -- 
> 2.23.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2019-09-24 13:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-24 12:18 [PATCH i-g-t] i915/gem_map_gtt: Escape from slow forked GTT access Chris Wilson
2019-09-24 12:44 ` Mika Kuoppala
2019-09-24 12:48   ` Chris Wilson
2019-09-24 12:53 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-09-24 13:09 ` Mika Kuoppala [this message]
2019-09-25  1:03 ` ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d0fpzvq6.fsf@gaia.fi.intel.com \
    --to=mika.kuoppala@linux.intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox