Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH i-g-t] i915/gem_map_gtt: Escape from slow forked GTT access
@ 2019-09-24 12:18 Chris Wilson
  2019-09-24 12:44 ` Mika Kuoppala
                   ` (3 more replies)
  0 siblings, 4 replies; 6+ messages in thread
From: Chris Wilson @ 2019-09-24 12:18 UTC (permalink / raw)
  To: intel-gfx

Beware the slithy t'oves.

Forked GTT access on icl is notoriously slow, so rather than spend an
eternity checking the whole object, check for a completion event after
handling the pagefault. It's is the race of the pagefault vs reset that
we care most about, and we expect the bug to result in the pagefault
being blocked indefinitely, so checking afterwards does not reduce
coverage.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
---
 tests/i915/gem_mmap_gtt.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/tests/i915/gem_mmap_gtt.c b/tests/i915/gem_mmap_gtt.c
index 0428a1372..91da5a37b 100644
--- a/tests/i915/gem_mmap_gtt.c
+++ b/tests/i915/gem_mmap_gtt.c
@@ -602,6 +602,9 @@ test_hang(int fd)
 
 				gtt[0][x] = patterns[next_pattern];
 				gtt[1][x] = patterns[next_pattern];
+
+				if (READ_ONCE(control->done))
+					break;
 			}
 
 			last_pattern = next_pattern;
-- 
2.23.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2019-09-25  1:03 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-09-24 12:18 [PATCH i-g-t] i915/gem_map_gtt: Escape from slow forked GTT access Chris Wilson
2019-09-24 12:44 ` Mika Kuoppala
2019-09-24 12:48   ` Chris Wilson
2019-09-24 12:53 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-09-24 13:09 ` [PATCH i-g-t] " Mika Kuoppala
2019-09-25  1:03 ` ✓ Fi.CI.IGT: success for " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox