From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH v6 02/12] drm/i915/mtl: Synchronize i915/BIOS on C6 enabling
Date: Thu, 16 Mar 2023 22:24:03 -0700 [thread overview]
Message-ID: <87edpovtl8.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <87jzzgvy8k.wl-ashutosh.dixit@intel.com>
On Thu, 16 Mar 2023 20:43:39 -0700, Dixit, Ashutosh wrote:
>
> On Wed, 15 Mar 2023 18:00:51 -0700, Umesh Nerlige Ramappa wrote:
> >
> > From: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
>
> Hi Vinay,
>
> > If BIOS enables/disables C6, i915 should do the same.
>
> So MTL bios has a control for enabling/disabling C6? Both RC6 and MC6
> individually or collectively?
>
> What happens if bios has disabled RC6 and i915 enables it: just that it
> will bust OA?
>
> The patch itself LGTM if the above is true, I can R-b it after I hear about
> the above.
>
> Thanks.
> --
> Ashutosh
>
> > Also, retain this value across driver reloads. This is needed only for
> > MTL as of now due to an existing bug in OA which needs C6 disabled for it
Let's say "C6 disabled in BIOS for it to function".
> > to function. BIOS behavior is also different across platforms in terms of
> > how C6 is enabled.
> >
> > Signed-off-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
Otherwise as promised above:
Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
next prev parent reply other threads:[~2023-03-17 5:24 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-16 1:00 [Intel-gfx] [PATCH v6 00/12] Add OAM support for MTL Umesh Nerlige Ramappa
2023-03-16 1:00 ` [Intel-gfx] [PATCH v6 01/12] drm/i915/perf: Drop wakeref on GuC RC error Umesh Nerlige Ramappa
2023-03-16 1:00 ` [Intel-gfx] [PATCH v6 02/12] drm/i915/mtl: Synchronize i915/BIOS on C6 enabling Umesh Nerlige Ramappa
2023-03-17 3:43 ` Dixit, Ashutosh
2023-03-17 5:24 ` Dixit, Ashutosh [this message]
2023-03-17 18:26 ` Belgaumkar, Vinay
2023-03-16 1:00 ` [Intel-gfx] [PATCH v6 03/12] drm/i915/perf: Add helper to check supported OA engines Umesh Nerlige Ramappa
2023-03-16 1:00 ` [Intel-gfx] [PATCH v6 04/12] drm/i915/perf: Validate OA sseu config outside switch Umesh Nerlige Ramappa
2023-03-16 1:00 ` [Intel-gfx] [PATCH v6 05/12] drm/i915/perf: Group engines into respective OA groups Umesh Nerlige Ramappa
2023-03-16 1:00 ` [Intel-gfx] [PATCH v6 06/12] drm/i915/perf: Fail modprobe if i915_perf_init fails on OOM Umesh Nerlige Ramappa
2023-03-16 1:00 ` [Intel-gfx] [PATCH v6 07/12] drm/i915/perf: Parse 64bit report header formats correctly Umesh Nerlige Ramappa
2023-03-16 1:00 ` [Intel-gfx] [PATCH v6 08/12] drm/i915/perf: Handle non-power-of-2 reports Umesh Nerlige Ramappa
2023-03-16 1:00 ` [Intel-gfx] [PATCH v6 09/12] drm/i915/perf: Add engine class instance parameters to perf Umesh Nerlige Ramappa
2023-03-16 1:00 ` [Intel-gfx] [PATCH v6 10/12] drm/i915/perf: Add support for OA media units Umesh Nerlige Ramappa
2023-03-16 1:01 ` [Intel-gfx] [PATCH v6 11/12] drm/i915/perf: Pass i915 object to perf revision helper Umesh Nerlige Ramappa
2023-03-17 5:01 ` Dixit, Ashutosh
2023-03-16 1:01 ` [Intel-gfx] [PATCH v6 12/12] drm/i915/perf: Wa_14017512683: Disable OAM if media C6 is enabled in BIOS Umesh Nerlige Ramappa
2023-03-17 5:14 ` Dixit, Ashutosh
2023-03-17 6:06 ` Dixit, Ashutosh
2023-03-17 16:24 ` Umesh Nerlige Ramappa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87edpovtl8.wl-ashutosh.dixit@intel.com \
--to=ashutosh.dixit@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=umesh.nerlige.ramappa@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox