Re: [Intel-gfx] [PATCH 1/2] drm/i915/dp_link_training: Add newlines to debug messages

[Jani Nikula <jani.nikula@linux.intel.com>]

On Thu, 11 Mar 2021, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> On Wed, Mar 10, 2021 at 04:47:56PM -0500, Sean Paul wrote:
>> From: Sean Paul <seanpaul@chromium.org>
>> 
>> This patch adds some newlines which are missing from debug messages.
>> This will prevent logs from being stacked up in dmesg.
>> 
>> Signed-off-by: Sean Paul <seanpaul@chromium.org>
>> ---
>>  drivers/gpu/drm/i915/display/intel_dp_link_training.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>> 
>> diff --git a/drivers/gpu/drm/i915/display/intel_dp_link_training.c b/drivers/gpu/drm/i915/display/intel_dp_link_training.c
>> index 892d7db7d94f..ad02d493ec16 100644
>> --- a/drivers/gpu/drm/i915/display/intel_dp_link_training.c
>> +++ b/drivers/gpu/drm/i915/display/intel_dp_link_training.c
>> @@ -29,7 +29,7 @@ static void
>>  intel_dp_dump_link_status(const u8 link_status[DP_LINK_STATUS_SIZE])
>>  {
>>  
>> -	DRM_DEBUG_KMS("ln0_1:0x%x ln2_3:0x%x align:0x%x sink:0x%x adj_req0_1:0x%x adj_req2_3:0x%x",
>> +	DRM_DEBUG_KMS("ln0_1:0x%x ln2_3:0x%x align:0x%x sink:0x%x adj_req0_1:0x%x adj_req2_3:0x%x\n",
>>  		      link_status[0], link_status[1], link_status[2],
>>  		      link_status[3], link_status[4], link_status[5]);
>>  }
>> @@ -731,7 +731,7 @@ intel_dp_link_train_phy(struct intel_dp *intel_dp,
>>  
>>  out:
>>  	drm_dbg_kms(&dp_to_i915(intel_dp)->drm,
>> -		    "[CONNECTOR:%d:%s] Link Training %s at link rate = %d, lane count = %d, at %s",
>> +		    "[CONNECTOR:%d:%s] Link Training %s at link rate = %d, lane count = %d, at %s\n",
>
> Looking through some ci logs we do get the newline here somehow. A bit
> weird.
>
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Thanks for the patches and review, pushed to din.

BR,
Jani.

-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx