* [Intel-gfx] [PATCH] drm/i915/gt: Delay execlist processing for tgl
@ 2020-10-15 19:50 Chris Wilson
2020-10-15 21:05 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Chris Wilson @ 2020-10-15 19:50 UTC (permalink / raw)
To: intel-gfx; +Cc: stable, Chris Wilson
When running gem_exec_nop, it floods the system with many requests (with
the goal of userspace submitting faster than the HW can process a single
empty batch). This causes the driver to continually resubmit new
requests onto the end of an active context, a flood of lite-restore
preemptions. If we time this just right, Tigerlake hangs.
Inserting a small delay between the processing of CS events and
submitting the next context, prevents the hang. Naturally it does not
occur with debugging enabled. The suspicion then is that this is related
to the issues with the CS event buffer, and inserting an mmio read of
the CS pointer status appears to be very successful in preventing the
hang. Other registers, or uncached reads, or plain mb, do not prevent
the hang, suggesting that register is key -- but that the hang can be
prevented by a simple udelay, suggests it is just a timing issue like
that encountered by commit 233c1ae3c83f ("drm/i915/gt: Wait for CSB
entries on Tigerlake"). Also note that the hang is not prevented by
applying CTX_DESC_FORCE_RESTORE, or by inserting a delay on the GPU
between requests.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Cc: Bruce Chang <yu.bruce.chang@intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: stable@vger.kernel.org
---
drivers/gpu/drm/i915/gt/intel_lrc.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/i915/gt/intel_lrc.c b/drivers/gpu/drm/i915/gt/intel_lrc.c
index 6170f6874f52..d15d561152ba 100644
--- a/drivers/gpu/drm/i915/gt/intel_lrc.c
+++ b/drivers/gpu/drm/i915/gt/intel_lrc.c
@@ -2711,6 +2711,9 @@ static void process_csb(struct intel_engine_cs *engine)
smp_wmb(); /* complete the seqlock */
WRITE_ONCE(execlists->active, execlists->inflight);
+ /* Magic delay for tgl */
+ ENGINE_POSTING_READ(engine, RING_CONTEXT_STATUS_PTR);
+
WRITE_ONCE(execlists->pending[0], NULL);
} else {
if (GEM_WARN_ON(!*execlists->active)) {
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Delay execlist processing for tgl
2020-10-15 19:50 [Intel-gfx] [PATCH] drm/i915/gt: Delay execlist processing for tgl Chris Wilson
@ 2020-10-15 21:05 ` Patchwork
2020-10-16 1:08 ` [Intel-gfx] [PATCH] " Shi, Yang A
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2020-10-15 21:05 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 4723 bytes --]
== Series Details ==
Series: drm/i915/gt: Delay execlist processing for tgl
URL : https://patchwork.freedesktop.org/series/82729/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9143 -> Patchwork_18708
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18708/index.html
Known issues
------------
Here are the changes found in Patchwork_18708 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_cursor_legacy@basic-flip-before-cursor-atomic:
- fi-icl-u2: [PASS][1] -> [DMESG-WARN][2] ([i915#1982]) +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9143/fi-icl-u2/igt@kms_cursor_legacy@basic-flip-before-cursor-atomic.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18708/fi-icl-u2/igt@kms_cursor_legacy@basic-flip-before-cursor-atomic.html
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-c:
- fi-tgl-y: [PASS][3] -> [DMESG-WARN][4] ([i915#1982]) +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9143/fi-tgl-y/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-c.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18708/fi-tgl-y/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-c.html
* igt@prime_self_import@basic-with_two_bos:
- fi-tgl-y: [PASS][5] -> [DMESG-WARN][6] ([i915#402]) +1 similar issue
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9143/fi-tgl-y/igt@prime_self_import@basic-with_two_bos.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18708/fi-tgl-y/igt@prime_self_import@basic-with_two_bos.html
#### Possible fixes ####
* igt@i915_module_load@reload:
- fi-icl-y: [DMESG-WARN][7] ([i915#1982]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9143/fi-icl-y/igt@i915_module_load@reload.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18708/fi-icl-y/igt@i915_module_load@reload.html
* igt@kms_flip@basic-flip-vs-wf_vblank@b-edp1:
- fi-icl-u2: [DMESG-WARN][9] ([i915#1982]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9143/fi-icl-u2/igt@kms_flip@basic-flip-vs-wf_vblank@b-edp1.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18708/fi-icl-u2/igt@kms_flip@basic-flip-vs-wf_vblank@b-edp1.html
* igt@vgem_basic@dmabuf-fence:
- fi-tgl-y: [DMESG-WARN][11] ([i915#402]) -> [PASS][12] +1 similar issue
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9143/fi-tgl-y/igt@vgem_basic@dmabuf-fence.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18708/fi-tgl-y/igt@vgem_basic@dmabuf-fence.html
#### Warnings ####
* igt@core_hotunplug@unbind-rebind:
- fi-icl-u2: [DMESG-WARN][13] ([i915#289]) -> [DMESG-WARN][14] ([i915#1982] / [i915#289])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9143/fi-icl-u2/igt@core_hotunplug@unbind-rebind.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18708/fi-icl-u2/igt@core_hotunplug@unbind-rebind.html
* igt@i915_pm_rpm@module-reload:
- fi-tgl-y: [DMESG-WARN][15] ([i915#1982] / [i915#2411]) -> [DMESG-WARN][16] ([i915#2411])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9143/fi-tgl-y/igt@i915_pm_rpm@module-reload.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18708/fi-tgl-y/igt@i915_pm_rpm@module-reload.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2411]: https://gitlab.freedesktop.org/drm/intel/issues/2411
[i915#289]: https://gitlab.freedesktop.org/drm/intel/issues/289
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
Participating hosts (44 -> 38)
------------------------------
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-byt-clapper fi-bdw-samus
Build changes
-------------
* Linux: CI_DRM_9143 -> Patchwork_18708
CI-20190529: 20190529
CI_DRM_9143: 4dbf348a230e183680a5b401cebe278d97411d9a @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5820: 520f88d7817ebb7464907252a32e8e747429102b @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_18708: 993d79ad26035b06a2c80677552e73a89da50e92 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
993d79ad2603 drm/i915/gt: Delay execlist processing for tgl
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18708/index.html
[-- Attachment #1.2: Type: text/html, Size: 6067 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/gt: Delay execlist processing for tgl
2020-10-15 19:50 [Intel-gfx] [PATCH] drm/i915/gt: Delay execlist processing for tgl Chris Wilson
2020-10-15 21:05 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
@ 2020-10-16 1:08 ` Shi, Yang A
2020-10-16 8:43 ` Chris Wilson
2020-10-16 1:47 ` [Intel-gfx] ✓ Fi.CI.IGT: success for " Patchwork
2020-10-16 7:07 ` [Intel-gfx] [PATCH] " Mika Kuoppala
3 siblings, 1 reply; 6+ messages in thread
From: Shi, Yang A @ 2020-10-16 1:08 UTC (permalink / raw)
To: Chris Wilson, intel-gfx@lists.freedesktop.org; +Cc: stable@vger.kernel.org
Hi Chris:
How to determine the length of the magic delay in here?
Best Regards.
Yang
> -----Original Message-----
> From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of Chris Wilson
> Sent: Friday, October 16, 2020 3:50 AM
> To: intel-gfx@lists.freedesktop.org
> Cc: stable@vger.kernel.org; Chris Wilson <chris@chris-wilson.co.uk>
> Subject: [Intel-gfx] [PATCH] drm/i915/gt: Delay execlist processing for tgl
>
> When running gem_exec_nop, it floods the system with many requests (with the goal of
> userspace submitting faster than the HW can process a single empty batch). This causes
> the driver to continually resubmit new requests onto the end of an active context, a flood
> of lite-restore preemptions. If we time this just right, Tigerlake hangs.
>
> Inserting a small delay between the processing of CS events and submitting the next
> context, prevents the hang. Naturally it does not occur with debugging enabled. The
> suspicion then is that this is related to the issues with the CS event buffer, and inserting
> an mmio read of the CS pointer status appears to be very successful in preventing the
> hang. Other registers, or uncached reads, or plain mb, do not prevent the hang, suggesting
> that register is key -- but that the hang can be prevented by a simple udelay, suggests it is
> just a timing issue like that encountered by commit 233c1ae3c83f ("drm/i915/gt: Wait for
> CSB entries on Tigerlake"). Also note that the hang is not prevented by applying
> CTX_DESC_FORCE_RESTORE, or by inserting a delay on the GPU between requests.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> Cc: Bruce Chang <yu.bruce.chang@intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: stable@vger.kernel.org
> ---
> drivers/gpu/drm/i915/gt/intel_lrc.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_lrc.c b/drivers/gpu/drm/i915/gt/intel_lrc.c
> index 6170f6874f52..d15d561152ba 100644
> --- a/drivers/gpu/drm/i915/gt/intel_lrc.c
> +++ b/drivers/gpu/drm/i915/gt/intel_lrc.c
> @@ -2711,6 +2711,9 @@ static void process_csb(struct intel_engine_cs *engine)
> smp_wmb(); /* complete the seqlock */
> WRITE_ONCE(execlists->active, execlists->inflight);
>
> + /* Magic delay for tgl */
> + ENGINE_POSTING_READ(engine,
> RING_CONTEXT_STATUS_PTR);
> +
> WRITE_ONCE(execlists->pending[0], NULL);
> } else {
> if (GEM_WARN_ON(!*execlists->active)) {
> --
> 2.20.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gt: Delay execlist processing for tgl
2020-10-15 19:50 [Intel-gfx] [PATCH] drm/i915/gt: Delay execlist processing for tgl Chris Wilson
2020-10-15 21:05 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2020-10-16 1:08 ` [Intel-gfx] [PATCH] " Shi, Yang A
@ 2020-10-16 1:47 ` Patchwork
2020-10-16 7:07 ` [Intel-gfx] [PATCH] " Mika Kuoppala
3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2020-10-16 1:47 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 15258 bytes --]
== Series Details ==
Series: drm/i915/gt: Delay execlist processing for tgl
URL : https://patchwork.freedesktop.org/series/82729/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9143_full -> Patchwork_18708_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_18708_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@core_hotunplug@hotrebind-lateclose:
- shard-snb: [PASS][1] -> [INCOMPLETE][2] ([i915#82])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9143/shard-snb7/igt@core_hotunplug@hotrebind-lateclose.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18708/shard-snb7/igt@core_hotunplug@hotrebind-lateclose.html
* igt@feature_discovery@psr2:
- shard-iclb: [PASS][3] -> [SKIP][4] ([i915#658])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9143/shard-iclb2/igt@feature_discovery@psr2.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18708/shard-iclb3/igt@feature_discovery@psr2.html
* igt@gem_exec_whisper@basic-contexts:
- shard-glk: [PASS][5] -> [DMESG-WARN][6] ([i915#118] / [i915#95])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9143/shard-glk7/igt@gem_exec_whisper@basic-contexts.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18708/shard-glk3/igt@gem_exec_whisper@basic-contexts.html
* igt@gem_userptr_blits@sync-unmap-cycles:
- shard-skl: [PASS][7] -> [TIMEOUT][8] ([i915#2424])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9143/shard-skl7/igt@gem_userptr_blits@sync-unmap-cycles.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18708/shard-skl6/igt@gem_userptr_blits@sync-unmap-cycles.html
* igt@kms_atomic_transition@plane-all-modeset-transition@dp-1-pipe-c:
- shard-kbl: [PASS][9] -> [DMESG-WARN][10] ([i915#62])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9143/shard-kbl1/igt@kms_atomic_transition@plane-all-modeset-transition@dp-1-pipe-c.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18708/shard-kbl2/igt@kms_atomic_transition@plane-all-modeset-transition@dp-1-pipe-c.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-skl: [PASS][11] -> [FAIL][12] ([i915#2346])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9143/shard-skl1/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18708/shard-skl2/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1:
- shard-skl: [PASS][13] -> [FAIL][14] ([i915#79])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9143/shard-skl10/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18708/shard-skl9/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html
* igt@kms_flip@flip-vs-suspend-interruptible@a-edp1:
- shard-skl: [PASS][15] -> [INCOMPLETE][16] ([i915#198])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9143/shard-skl1/igt@kms_flip@flip-vs-suspend-interruptible@a-edp1.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18708/shard-skl10/igt@kms_flip@flip-vs-suspend-interruptible@a-edp1.html
* igt@kms_flip@plain-flip-ts-check-interruptible@c-edp1:
- shard-skl: [PASS][17] -> [FAIL][18] ([i915#2122])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9143/shard-skl2/igt@kms_flip@plain-flip-ts-check-interruptible@c-edp1.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18708/shard-skl5/igt@kms_flip@plain-flip-ts-check-interruptible@c-edp1.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-mmap-cpu:
- shard-kbl: [PASS][19] -> [DMESG-WARN][20] ([i915#1982]) +1 similar issue
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9143/shard-kbl1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-mmap-cpu.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18708/shard-kbl4/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-mmap-cpu.html
* igt@kms_frontbuffer_tracking@fbc-stridechange:
- shard-glk: [PASS][21] -> [DMESG-WARN][22] ([i915#1982])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9143/shard-glk4/igt@kms_frontbuffer_tracking@fbc-stridechange.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18708/shard-glk1/igt@kms_frontbuffer_tracking@fbc-stridechange.html
* igt@kms_hdr@bpc-switch-suspend:
- shard-skl: [PASS][23] -> [FAIL][24] ([i915#1188])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9143/shard-skl5/igt@kms_hdr@bpc-switch-suspend.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18708/shard-skl3/igt@kms_hdr@bpc-switch-suspend.html
* igt@kms_psr@psr2_sprite_plane_move:
- shard-iclb: [PASS][25] -> [SKIP][26] ([fdo#109441]) +2 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9143/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18708/shard-iclb3/igt@kms_psr@psr2_sprite_plane_move.html
* igt@kms_universal_plane@disable-primary-vs-flip-pipe-c:
- shard-skl: [PASS][27] -> [DMESG-WARN][28] ([i915#1982]) +7 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9143/shard-skl7/igt@kms_universal_plane@disable-primary-vs-flip-pipe-c.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18708/shard-skl7/igt@kms_universal_plane@disable-primary-vs-flip-pipe-c.html
- shard-apl: [PASS][29] -> [DMESG-WARN][30] ([i915#1635] / [i915#1982])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9143/shard-apl8/igt@kms_universal_plane@disable-primary-vs-flip-pipe-c.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18708/shard-apl4/igt@kms_universal_plane@disable-primary-vs-flip-pipe-c.html
* igt@kms_vblank@pipe-c-wait-idle:
- shard-tglb: [PASS][31] -> [DMESG-WARN][32] ([i915#1982])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9143/shard-tglb3/igt@kms_vblank@pipe-c-wait-idle.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18708/shard-tglb2/igt@kms_vblank@pipe-c-wait-idle.html
* igt@perf@polling-small-buf:
- shard-skl: [PASS][33] -> [FAIL][34] ([i915#1722])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9143/shard-skl1/igt@perf@polling-small-buf.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18708/shard-skl2/igt@perf@polling-small-buf.html
* igt@perf_pmu@module-unload:
- shard-iclb: [PASS][35] -> [DMESG-WARN][36] ([i915#1982])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9143/shard-iclb3/igt@perf_pmu@module-unload.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18708/shard-iclb7/igt@perf_pmu@module-unload.html
#### Possible fixes ####
* igt@gem_exec_balancer@bonded-dual:
- shard-kbl: [INCOMPLETE][37] -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9143/shard-kbl4/igt@gem_exec_balancer@bonded-dual.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18708/shard-kbl1/igt@gem_exec_balancer@bonded-dual.html
* {igt@gem_exec_capture@pi@vcs0}:
- shard-apl: [INCOMPLETE][39] ([i915#1635]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9143/shard-apl1/igt@gem_exec_capture@pi@vcs0.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18708/shard-apl2/igt@gem_exec_capture@pi@vcs0.html
* {igt@kms_async_flips@async-flip-with-page-flip-events}:
- shard-kbl: [FAIL][41] ([i915#2521]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9143/shard-kbl6/igt@kms_async_flips@async-flip-with-page-flip-events.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18708/shard-kbl2/igt@kms_async_flips@async-flip-with-page-flip-events.html
* igt@kms_big_fb@x-tiled-64bpp-rotate-180:
- shard-snb: [FAIL][43] -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9143/shard-snb7/igt@kms_big_fb@x-tiled-64bpp-rotate-180.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18708/shard-snb7/igt@kms_big_fb@x-tiled-64bpp-rotate-180.html
* igt@kms_draw_crc@draw-method-rgb565-render-untiled:
- shard-skl: [FAIL][45] ([i915#52] / [i915#54]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9143/shard-skl5/igt@kms_draw_crc@draw-method-rgb565-render-untiled.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18708/shard-skl3/igt@kms_draw_crc@draw-method-rgb565-render-untiled.html
* igt@kms_flip@plain-flip-fb-recreate-interruptible@c-edp1:
- shard-skl: [FAIL][47] ([i915#2122]) -> [PASS][48] +1 similar issue
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9143/shard-skl6/igt@kms_flip@plain-flip-fb-recreate-interruptible@c-edp1.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18708/shard-skl4/igt@kms_flip@plain-flip-fb-recreate-interruptible@c-edp1.html
* igt@kms_frontbuffer_tracking@fbc-stridechange:
- shard-tglb: [DMESG-WARN][49] ([i915#1982]) -> [PASS][50] +4 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9143/shard-tglb8/igt@kms_frontbuffer_tracking@fbc-stridechange.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18708/shard-tglb5/igt@kms_frontbuffer_tracking@fbc-stridechange.html
* igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min:
- shard-skl: [FAIL][51] ([fdo#108145] / [i915#265]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9143/shard-skl5/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18708/shard-skl3/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min.html
* igt@kms_plane_lowres@pipe-a-tiling-yf:
- shard-skl: [DMESG-WARN][53] ([i915#1982]) -> [PASS][54] +6 similar issues
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9143/shard-skl7/igt@kms_plane_lowres@pipe-a-tiling-yf.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18708/shard-skl6/igt@kms_plane_lowres@pipe-a-tiling-yf.html
* igt@kms_psr@psr2_sprite_mmap_gtt:
- shard-iclb: [SKIP][55] ([fdo#109441]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9143/shard-iclb4/igt@kms_psr@psr2_sprite_mmap_gtt.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18708/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_gtt.html
* igt@kms_vblank@pipe-c-wait-idle:
- shard-kbl: [DMESG-WARN][57] ([i915#1982]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9143/shard-kbl4/igt@kms_vblank@pipe-c-wait-idle.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18708/shard-kbl7/igt@kms_vblank@pipe-c-wait-idle.html
- shard-apl: [DMESG-WARN][59] ([i915#1635] / [i915#1982]) -> [PASS][60]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9143/shard-apl2/igt@kms_vblank@pipe-c-wait-idle.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18708/shard-apl7/igt@kms_vblank@pipe-c-wait-idle.html
* igt@perf@blocking:
- shard-skl: [FAIL][61] ([i915#1542]) -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9143/shard-skl9/igt@perf@blocking.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18708/shard-skl8/igt@perf@blocking.html
* igt@perf@polling-parameterized:
- shard-tglb: [FAIL][63] ([i915#1542]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9143/shard-tglb1/igt@perf@polling-parameterized.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18708/shard-tglb7/igt@perf@polling-parameterized.html
* igt@prime_vgem@fence-wait@bcs0:
- shard-tglb: [INCOMPLETE][65] -> [PASS][66]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9143/shard-tglb8/igt@prime_vgem@fence-wait@bcs0.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18708/shard-tglb3/igt@prime_vgem@fence-wait@bcs0.html
#### Warnings ####
* igt@gem_exec_reloc@basic-many-active@bcs0:
- shard-snb: [FAIL][67] ([i915#2389]) -> [INCOMPLETE][68] ([i915#82])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9143/shard-snb7/igt@gem_exec_reloc@basic-many-active@bcs0.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18708/shard-snb7/igt@gem_exec_reloc@basic-many-active@bcs0.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542
[i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
[i915#1722]: https://gitlab.freedesktop.org/drm/intel/issues/1722
[i915#198]: https://gitlab.freedesktop.org/drm/intel/issues/198
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2389]: https://gitlab.freedesktop.org/drm/intel/issues/2389
[i915#2424]: https://gitlab.freedesktop.org/drm/intel/issues/2424
[i915#2521]: https://gitlab.freedesktop.org/drm/intel/issues/2521
[i915#2553]: https://gitlab.freedesktop.org/drm/intel/issues/2553
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#52]: https://gitlab.freedesktop.org/drm/intel/issues/52
[i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#82]: https://gitlab.freedesktop.org/drm/intel/issues/82
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (11 -> 11)
------------------------------
No changes in participating hosts
Build changes
-------------
* Linux: CI_DRM_9143 -> Patchwork_18708
CI-20190529: 20190529
CI_DRM_9143: 4dbf348a230e183680a5b401cebe278d97411d9a @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5820: 520f88d7817ebb7464907252a32e8e747429102b @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_18708: 993d79ad26035b06a2c80677552e73a89da50e92 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18708/index.html
[-- Attachment #1.2: Type: text/html, Size: 17640 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/gt: Delay execlist processing for tgl
2020-10-15 19:50 [Intel-gfx] [PATCH] drm/i915/gt: Delay execlist processing for tgl Chris Wilson
` (2 preceding siblings ...)
2020-10-16 1:47 ` [Intel-gfx] ✓ Fi.CI.IGT: success for " Patchwork
@ 2020-10-16 7:07 ` Mika Kuoppala
3 siblings, 0 replies; 6+ messages in thread
From: Mika Kuoppala @ 2020-10-16 7:07 UTC (permalink / raw)
To: Chris Wilson, intel-gfx; +Cc: stable, Chris Wilson
Chris Wilson <chris@chris-wilson.co.uk> writes:
> When running gem_exec_nop, it floods the system with many requests (with
> the goal of userspace submitting faster than the HW can process a single
> empty batch). This causes the driver to continually resubmit new
> requests onto the end of an active context, a flood of lite-restore
> preemptions. If we time this just right, Tigerlake hangs.
>
> Inserting a small delay between the processing of CS events and
> submitting the next context, prevents the hang. Naturally it does not
> occur with debugging enabled. The suspicion then is that this is related
> to the issues with the CS event buffer, and inserting an mmio read of
> the CS pointer status appears to be very successful in preventing the
> hang. Other registers, or uncached reads, or plain mb, do not prevent
> the hang, suggesting that register is key -- but that the hang can be
> prevented by a simple udelay, suggests it is just a timing issue like
> that encountered by commit 233c1ae3c83f ("drm/i915/gt: Wait for CSB
> entries on Tigerlake"). Also note that the hang is not prevented by
> applying CTX_DESC_FORCE_RESTORE, or by inserting a delay on the GPU
> between requests.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> Cc: Bruce Chang <yu.bruce.chang@intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: stable@vger.kernel.org
Acked-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/gt/intel_lrc.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_lrc.c b/drivers/gpu/drm/i915/gt/intel_lrc.c
> index 6170f6874f52..d15d561152ba 100644
> --- a/drivers/gpu/drm/i915/gt/intel_lrc.c
> +++ b/drivers/gpu/drm/i915/gt/intel_lrc.c
> @@ -2711,6 +2711,9 @@ static void process_csb(struct intel_engine_cs *engine)
> smp_wmb(); /* complete the seqlock */
> WRITE_ONCE(execlists->active, execlists->inflight);
>
> + /* Magic delay for tgl */
> + ENGINE_POSTING_READ(engine, RING_CONTEXT_STATUS_PTR);
> +
> WRITE_ONCE(execlists->pending[0], NULL);
> } else {
> if (GEM_WARN_ON(!*execlists->active)) {
> --
> 2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/gt: Delay execlist processing for tgl
2020-10-16 1:08 ` [Intel-gfx] [PATCH] " Shi, Yang A
@ 2020-10-16 8:43 ` Chris Wilson
0 siblings, 0 replies; 6+ messages in thread
From: Chris Wilson @ 2020-10-16 8:43 UTC (permalink / raw)
To: Shi, Yang A, intel-gfx; +Cc: stable
Quoting Shi, Yang A (2020-10-16 02:08:24)
> Hi Chris:
>
> How to determine the length of the magic delay in here?
That is the question. I started with a large udelay, played with moving
it around and shortening (5us) to try and isolate what is going on. An
arbitrary delay is awful as it is guaranteed to fail since it imposes no
barrier/serialisation, mmio often have the desired side-effect, if you
can tickle the right one.
Still this is nothing more than empirical evidence (an easily reproduced
hang that goes away), and not a hard explanation. An uncached read upon
acking the preemption event, is a pretty nasty nuisance (it's 80% of our
CS bottom half) but as compromises go, it could be far worse.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-10-16 8:44 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-10-15 19:50 [Intel-gfx] [PATCH] drm/i915/gt: Delay execlist processing for tgl Chris Wilson
2020-10-15 21:05 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2020-10-16 1:08 ` [Intel-gfx] [PATCH] " Shi, Yang A
2020-10-16 8:43 ` Chris Wilson
2020-10-16 1:47 ` [Intel-gfx] ✓ Fi.CI.IGT: success for " Patchwork
2020-10-16 7:07 ` [Intel-gfx] [PATCH] " Mika Kuoppala
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox