Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Intel-gfx] [PATCH] drm/i915: Disable frontbuffer tracking
@ 2020-09-08  5:25 Animesh Manna
  2020-09-08  6:08 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Animesh Manna @ 2020-09-08  5:25 UTC (permalink / raw)
  To: intel-gfx

From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>

Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_frontbuffer.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/gpu/drm/i915/display/intel_frontbuffer.c b/drivers/gpu/drm/i915/display/intel_frontbuffer.c
index d898b370d7a4..0f1d7a34dcf7 100644
--- a/drivers/gpu/drm/i915/display/intel_frontbuffer.c
+++ b/drivers/gpu/drm/i915/display/intel_frontbuffer.c
@@ -166,6 +166,9 @@ void __intel_fb_invalidate(struct intel_frontbuffer *front,
 {
 	struct drm_i915_private *i915 = to_i915(front->obj->base.dev);
 
+	if (origin != ORIGIN_FLIP)
+		return;
+
 	if (origin == ORIGIN_CS) {
 		spin_lock(&i915->fb_tracking.lock);
 		i915->fb_tracking.busy_bits |= frontbuffer_bits;
@@ -185,6 +188,9 @@ void __intel_fb_flush(struct intel_frontbuffer *front,
 {
 	struct drm_i915_private *i915 = to_i915(front->obj->base.dev);
 
+	if (origin != ORIGIN_FLIP)
+		return;
+
 	if (origin == ORIGIN_CS) {
 		spin_lock(&i915->fb_tracking.lock);
 		/* Filter out new bits since rendering started. */
-- 
2.26.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Disable frontbuffer tracking
  2020-09-08  5:25 [Intel-gfx] [PATCH] drm/i915: Disable frontbuffer tracking Animesh Manna
@ 2020-09-08  6:08 ` Patchwork
  2020-09-08  6:32 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
  2020-09-10 13:26 ` [Intel-gfx] [PATCH] " Jani Nikula
  2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2020-09-08  6:08 UTC (permalink / raw)
  To: Animesh Manna; +Cc: intel-gfx

== Series Details ==

Series: drm/i915: Disable frontbuffer tracking
URL   : https://patchwork.freedesktop.org/series/81440/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
0856e7221aba drm/i915: Disable frontbuffer tracking
-:7: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one

total: 0 errors, 1 warnings, 0 checks, 18 lines checked


_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 4+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Disable frontbuffer tracking
  2020-09-08  5:25 [Intel-gfx] [PATCH] drm/i915: Disable frontbuffer tracking Animesh Manna
  2020-09-08  6:08 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
@ 2020-09-08  6:32 ` Patchwork
  2020-09-10 13:26 ` [Intel-gfx] [PATCH] " Jani Nikula
  2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2020-09-08  6:32 UTC (permalink / raw)
  To: Animesh Manna; +Cc: intel-gfx


[-- Attachment #1.1: Type: text/plain, Size: 10203 bytes --]

== Series Details ==

Series: drm/i915: Disable frontbuffer tracking
URL   : https://patchwork.freedesktop.org/series/81440/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_8976 -> Patchwork_18451
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with Patchwork_18451 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_18451, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18451/index.html

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in Patchwork_18451:

### IGT changes ###

#### Possible regressions ####

  * igt@kms_frontbuffer_tracking@basic:
    - fi-bdw-5557u:       [PASS][1] -> [FAIL][2]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8976/fi-bdw-5557u/igt@kms_frontbuffer_tracking@basic.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18451/fi-bdw-5557u/igt@kms_frontbuffer_tracking@basic.html

  * igt@kms_psr@primary_mmap_gtt:
    - fi-tgl-u2:          NOTRUN -> [FAIL][3]
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18451/fi-tgl-u2/igt@kms_psr@primary_mmap_gtt.html
    - fi-tgl-y:           [PASS][4] -> [FAIL][5]
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8976/fi-tgl-y/igt@kms_psr@primary_mmap_gtt.html
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18451/fi-tgl-y/igt@kms_psr@primary_mmap_gtt.html

  
#### Suppressed ####

  The following results come from untrusted machines, tests, or statuses.
  They do not affect the overall result.

  * igt@kms_frontbuffer_tracking@basic:
    - {fi-ehl-1}:         [PASS][6] -> [FAIL][7]
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8976/fi-ehl-1/igt@kms_frontbuffer_tracking@basic.html
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18451/fi-ehl-1/igt@kms_frontbuffer_tracking@basic.html

  
Known issues
------------

  Here are the changes found in Patchwork_18451 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@i915_module_load@reload:
    - fi-tgl-y:           [PASS][8] -> [DMESG-WARN][9] ([i915#1982])
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8976/fi-tgl-y/igt@i915_module_load@reload.html
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18451/fi-tgl-y/igt@i915_module_load@reload.html

  * igt@kms_busy@basic@flip:
    - fi-kbl-x1275:       [PASS][10] -> [DMESG-WARN][11] ([i915#62] / [i915#92] / [i915#95])
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8976/fi-kbl-x1275/igt@kms_busy@basic@flip.html
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18451/fi-kbl-x1275/igt@kms_busy@basic@flip.html

  * igt@kms_frontbuffer_tracking@basic:
    - fi-cfl-guc:         [PASS][12] -> [FAIL][13] ([i915#49])
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8976/fi-cfl-guc/igt@kms_frontbuffer_tracking@basic.html
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18451/fi-cfl-guc/igt@kms_frontbuffer_tracking@basic.html
    - fi-bxt-dsi:         [PASS][14] -> [FAIL][15] ([i915#1635] / [i915#49])
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8976/fi-bxt-dsi/igt@kms_frontbuffer_tracking@basic.html
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18451/fi-bxt-dsi/igt@kms_frontbuffer_tracking@basic.html
    - fi-skl-lmem:        [PASS][16] -> [FAIL][17] ([i915#49])
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8976/fi-skl-lmem/igt@kms_frontbuffer_tracking@basic.html
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18451/fi-skl-lmem/igt@kms_frontbuffer_tracking@basic.html
    - fi-cfl-8700k:       [PASS][18] -> [FAIL][19] ([i915#49])
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8976/fi-cfl-8700k/igt@kms_frontbuffer_tracking@basic.html
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18451/fi-cfl-8700k/igt@kms_frontbuffer_tracking@basic.html
    - fi-kbl-7500u:       [PASS][20] -> [FAIL][21] ([i915#49])
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8976/fi-kbl-7500u/igt@kms_frontbuffer_tracking@basic.html
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18451/fi-kbl-7500u/igt@kms_frontbuffer_tracking@basic.html
    - fi-cfl-8109u:       [PASS][22] -> [FAIL][23] ([i915#49])
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8976/fi-cfl-8109u/igt@kms_frontbuffer_tracking@basic.html
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18451/fi-cfl-8109u/igt@kms_frontbuffer_tracking@basic.html
    - fi-glk-dsi:         [PASS][24] -> [FAIL][25] ([i915#49])
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8976/fi-glk-dsi/igt@kms_frontbuffer_tracking@basic.html
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18451/fi-glk-dsi/igt@kms_frontbuffer_tracking@basic.html
    - fi-icl-y:           [PASS][26] -> [FAIL][27] ([i915#49])
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8976/fi-icl-y/igt@kms_frontbuffer_tracking@basic.html
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18451/fi-icl-y/igt@kms_frontbuffer_tracking@basic.html

  * igt@vgem_basic@dmabuf-fence:
    - fi-tgl-y:           [PASS][28] -> [DMESG-WARN][29] ([i915#402])
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8976/fi-tgl-y/igt@vgem_basic@dmabuf-fence.html
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18451/fi-tgl-y/igt@vgem_basic@dmabuf-fence.html

  
#### Possible fixes ####

  * igt@gem_flink_basic@flink-lifetime:
    - fi-tgl-y:           [DMESG-WARN][30] ([i915#402]) -> [PASS][31]
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8976/fi-tgl-y/igt@gem_flink_basic@flink-lifetime.html
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18451/fi-tgl-y/igt@gem_flink_basic@flink-lifetime.html

  * igt@i915_selftest@live@execlists:
    - fi-tgl-y:           [INCOMPLETE][32] ([i915#2268]) -> [PASS][33]
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8976/fi-tgl-y/igt@i915_selftest@live@execlists.html
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18451/fi-tgl-y/igt@i915_selftest@live@execlists.html

  * igt@kms_flip@basic-flip-vs-wf_vblank@c-edp1:
    - fi-icl-u2:          [DMESG-WARN][34] ([i915#1982]) -> [PASS][35] +1 similar issue
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8976/fi-icl-u2/igt@kms_flip@basic-flip-vs-wf_vblank@c-edp1.html
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18451/fi-icl-u2/igt@kms_flip@basic-flip-vs-wf_vblank@c-edp1.html

  
#### Warnings ####

  * igt@i915_pm_rpm@basic-pci-d3-state:
    - fi-kbl-x1275:       [DMESG-WARN][36] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][37] ([i915#62] / [i915#92]) +1 similar issue
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8976/fi-kbl-x1275/igt@i915_pm_rpm@basic-pci-d3-state.html
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18451/fi-kbl-x1275/igt@i915_pm_rpm@basic-pci-d3-state.html

  * igt@i915_pm_rpm@module-reload:
    - fi-tgl-y:           [DMESG-WARN][38] ([i915#1982] / [i915#2411]) -> [DMESG-WARN][39] ([i915#2411])
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8976/fi-tgl-y/igt@i915_pm_rpm@module-reload.html
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18451/fi-tgl-y/igt@i915_pm_rpm@module-reload.html
    - fi-kbl-x1275:       [DMESG-FAIL][40] ([i915#62]) -> [DMESG-FAIL][41] ([i915#62] / [i915#95])
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8976/fi-kbl-x1275/igt@i915_pm_rpm@module-reload.html
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18451/fi-kbl-x1275/igt@i915_pm_rpm@module-reload.html

  * igt@kms_force_connector_basic@force-edid:
    - fi-kbl-x1275:       [DMESG-WARN][42] ([i915#62] / [i915#92]) -> [DMESG-WARN][43] ([i915#62] / [i915#92] / [i915#95]) +3 similar issues
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8976/fi-kbl-x1275/igt@kms_force_connector_basic@force-edid.html
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18451/fi-kbl-x1275/igt@kms_force_connector_basic@force-edid.html

  * igt@kms_frontbuffer_tracking@basic:
    - fi-kbl-x1275:       [DMESG-WARN][44] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-FAIL][45] ([i915#49] / [i915#62])
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8976/fi-kbl-x1275/igt@kms_frontbuffer_tracking@basic.html
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18451/fi-kbl-x1275/igt@kms_frontbuffer_tracking@basic.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
  [i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
  [i915#2268]: https://gitlab.freedesktop.org/drm/intel/issues/2268
  [i915#2411]: https://gitlab.freedesktop.org/drm/intel/issues/2411
  [i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
  [i915#49]: https://gitlab.freedesktop.org/drm/intel/issues/49
  [i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
  [i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
  [i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95


Participating hosts (43 -> 38)
------------------------------

  Additional (1): fi-tgl-u2 
  Missing    (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-byt-clapper fi-bdw-samus 


Build changes
-------------

  * Linux: CI_DRM_8976 -> Patchwork_18451

  CI-20190529: 20190529
  CI_DRM_8976: 6ffcbb1cbfa3e4e7b3e54229a20a8ab721ca0103 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_5779: f52bf19b5f02d52fc3e201c6467ec3f511227fba @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_18451: 0856e7221abae6b3fbbbb4063eff0eb1382a74f4 @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

0856e7221aba drm/i915: Disable frontbuffer tracking

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18451/index.html

[-- Attachment #1.2: Type: text/html, Size: 13199 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Disable frontbuffer tracking
  2020-09-08  5:25 [Intel-gfx] [PATCH] drm/i915: Disable frontbuffer tracking Animesh Manna
  2020-09-08  6:08 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
  2020-09-08  6:32 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
@ 2020-09-10 13:26 ` Jani Nikula
  2 siblings, 0 replies; 4+ messages in thread
From: Jani Nikula @ 2020-09-10 13:26 UTC (permalink / raw)
  To: Animesh Manna, intel-gfx

On Tue, 08 Sep 2020, Animesh Manna <animesh.manna@intel.com> wrote:
> From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>

The "why" would go here.

> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>

Please add your own Signed-off-by when you send someone else's patches.

BR,
Jani.

> ---
>  drivers/gpu/drm/i915/display/intel_frontbuffer.c | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_frontbuffer.c b/drivers/gpu/drm/i915/display/intel_frontbuffer.c
> index d898b370d7a4..0f1d7a34dcf7 100644
> --- a/drivers/gpu/drm/i915/display/intel_frontbuffer.c
> +++ b/drivers/gpu/drm/i915/display/intel_frontbuffer.c
> @@ -166,6 +166,9 @@ void __intel_fb_invalidate(struct intel_frontbuffer *front,
>  {
>  	struct drm_i915_private *i915 = to_i915(front->obj->base.dev);
>  
> +	if (origin != ORIGIN_FLIP)
> +		return;
> +
>  	if (origin == ORIGIN_CS) {
>  		spin_lock(&i915->fb_tracking.lock);
>  		i915->fb_tracking.busy_bits |= frontbuffer_bits;
> @@ -185,6 +188,9 @@ void __intel_fb_flush(struct intel_frontbuffer *front,
>  {
>  	struct drm_i915_private *i915 = to_i915(front->obj->base.dev);
>  
> +	if (origin != ORIGIN_FLIP)
> +		return;
> +
>  	if (origin == ORIGIN_CS) {
>  		spin_lock(&i915->fb_tracking.lock);
>  		/* Filter out new bits since rendering started. */

-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-09-10 13:26 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-09-08  5:25 [Intel-gfx] [PATCH] drm/i915: Disable frontbuffer tracking Animesh Manna
2020-09-08  6:08 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2020-09-08  6:32 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2020-09-10 13:26 ` [Intel-gfx] [PATCH] " Jani Nikula

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox