From: Eric Anholt <eric@anholt.net>
To: Kenneth Graunke <kenneth@whitecape.org>, mesa-dev@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org, Ben Widawsky <ben@bwidawsk.net>
Subject: Re: [PATCH] i965: Add hardware context support.
Date: Wed, 13 Jun 2012 10:59:47 -0700 [thread overview]
Message-ID: <87ehpjm6ss.fsf@eliezer.anholt.net> (raw)
In-Reply-To: <1339528029-7470-1-git-send-email-kenneth@whitecape.org>
[-- Attachment #1.1: Type: text/plain, Size: 1180 bytes --]
On Tue, 12 Jun 2012 12:07:09 -0700, Kenneth Graunke <kenneth@whitecape.org> wrote:
> With fixes and updates from Ben Widawsky and comments from Paul Berry.
>
> This should not be pushed until libdrm 2.4.36 is released with Ben's
> hardware context support.
>
> I haven't hooked up the context destroy function yet as I'm not entirely
> sure about tear-down, but they will be freed on fd close, so it should
> only be a problem for long running processes that open and destroy many
> GL contexts.
What's wrong with just freeing our context at brw_destroy_context()? We
definietly have to manually free the stuff, since some apps (web
browsers) will have many context create/destroy cycles.
> diff --git a/src/mesa/drivers/dri/intel/intel_context.c b/src/mesa/drivers/dri/intel/intel_context.c
> index c2f7d29..fc244c1 100644
> --- a/src/mesa/drivers/dri/intel/intel_context.c
> +++ b/src/mesa/drivers/dri/intel/intel_context.c
> @@ -593,6 +593,8 @@ intelInitContext(struct intel_context *intel,
> if (intelScreen->bufmgr == NULL)
> return false;
>
> + intel->hw_ctx = NULL;
it's rzalloced, so we don't manually zero most of our data.
[-- Attachment #1.2: Type: application/pgp-signature, Size: 197 bytes --]
[-- Attachment #2: Type: text/plain, Size: 156 bytes --]
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
next prev parent reply other threads:[~2012-06-13 17:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-12 19:07 [PATCH] i965: Add hardware context support Kenneth Graunke
2012-06-13 17:59 ` Eric Anholt [this message]
2012-06-29 17:06 ` Ben Widawsky
2012-06-29 18:23 ` Ben Widawsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ehpjm6ss.fsf@eliezer.anholt.net \
--to=eric@anholt.net \
--cc=ben@bwidawsk.net \
--cc=intel-gfx@lists.freedesktop.org \
--cc=kenneth@whitecape.org \
--cc=mesa-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox