From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915/guc/slpc: Disable rps_boost debugfs
Date: Fri, 12 May 2023 17:39:25 -0700 [thread overview]
Message-ID: <87fs81dpz6.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <20230512235603.431386-1-vinay.belgaumkar@intel.com>
On Fri, 12 May 2023 16:56:03 -0700, Vinay Belgaumkar wrote:
>
Hi Vinay,
> rps_boost debugfs shows host turbo related info. This is not valid
> when SLPC is enabled.
A couple of thoughts about this. It appears people are know only about
rps_boost_info and don't know about guc_slpc_info? So:
a. Instead of hiding the rps_boost_info file do we need to print there
saying "SLPC is enabled, go look at guc_slpc_info"?
b. Or, even just call guc_slpc_info_show from rps_boost_show (so the two
files will show the same SLPC information)?
Ashutosh
> guc_slpc_info already shows the number of boosts. Add num_waiters there
> as well and disable rps_boost when SLPC is enabled.
>
> Bug: https://gitlab.freedesktop.org/drm/intel/-/issues/7632
> Signed-off-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
next prev parent reply other threads:[~2023-05-13 0:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-12 23:56 [Intel-gfx] [PATCH] drm/i915/guc/slpc: Disable rps_boost debugfs Vinay Belgaumkar
2023-05-13 0:39 ` Dixit, Ashutosh [this message]
2023-05-15 22:23 ` Belgaumkar, Vinay
2023-05-15 22:58 ` Dixit, Ashutosh
2023-05-16 0:22 ` Dixit, Ashutosh
2023-05-13 0:51 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2023-05-13 0:57 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-05-13 3:57 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2023-05-16 15:49 [Intel-gfx] [PATCH] " Vinay Belgaumkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fs81dpz6.wl-ashutosh.dixit@intel.com \
--to=ashutosh.dixit@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=vinay.belgaumkar@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox