From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915/guc/slpc: Add a new SLPC selftest
Date: Mon, 27 Jun 2022 21:48:27 -0700 [thread overview]
Message-ID: <87h745pf50.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <20220627230346.27720-1-vinay.belgaumkar@intel.com>
On Mon, 27 Jun 2022 16:03:46 -0700, Vinay Belgaumkar wrote:
>
> /* Actual frequency should rise above min */
> - if (max_act_freq == slpc_min_freq) {
> + if (max_act_freq <= slpc_min_freq) {
> pr_err("Actual freq did not rise above min\n");
> + pr_err("Perf Limit Reasons: 0x%x\n",
> + intel_uncore_read(gt->uncore, GT0_PERF_LIMIT_REASONS));
> err = -EINVAL;
> }
Maybe to be clear, we should combine these two pr_err's into a single
pr_err.
In any case this patch is:
Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
next prev parent reply other threads:[~2022-06-28 4:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-27 23:03 [Intel-gfx] [PATCH] drm/i915/guc/slpc: Add a new SLPC selftest Vinay Belgaumkar
2022-06-28 4:48 ` Dixit, Ashutosh [this message]
2022-06-28 4:59 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/guc/slpc: Add a new SLPC selftest (rev4) Patchwork
2022-06-28 14:37 ` Belgaumkar, Vinay
2022-06-28 22:15 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/guc/slpc: Add a new SLPC selftest (rev5) Patchwork
2022-06-29 14:22 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2022-06-29 15:07 ` Belgaumkar, Vinay
-- strict thread matches above, loose matches on Subject: below --
2022-06-23 23:33 [Intel-gfx] [PATCH] drm/i915/guc/slpc: Add a new SLPC selftest Vinay Belgaumkar
2022-06-25 3:59 ` Dixit, Ashutosh
2022-06-27 22:52 ` Belgaumkar, Vinay
2022-06-27 23:02 ` Belgaumkar, Vinay
2022-06-10 23:47 Vinay Belgaumkar
2022-06-22 20:32 ` Dixit, Ashutosh
2022-06-23 23:21 ` Belgaumkar, Vinay
2022-06-25 3:59 ` Dixit, Ashutosh
2022-06-27 22:52 ` Belgaumkar, Vinay
2022-06-10 21:18 Vinay Belgaumkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h745pf50.wl-ashutosh.dixit@intel.com \
--to=ashutosh.dixit@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=vinay.belgaumkar@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox