From: Jani Nikula <jani.nikula@intel.com>
To: "Saarinen, Jani" <jani.saarinen@intel.com>,
"Dave Airlie" <airlied@gmail.com>,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
Dave Airlie <airlied@redhat.com>, "Sarvela\,
Tomi P" <tomi.p.sarvela@intel.com>
Subject: Re: [Intel-gfx] [PATCH 01/24] drm/i915/uncore: split the fw get function into separate vfunc
Date: Mon, 04 Oct 2021 10:45:49 +0300 [thread overview]
Message-ID: <87h7dx2pxu.fsf@intel.com> (raw)
In-Reply-To: <DM8PR11MB5655047BD25AD19BA9E1FFFEE0AE9@DM8PR11MB5655.namprd11.prod.outlook.com>
On Mon, 04 Oct 2021, "Saarinen, Jani" <jani.saarinen@intel.com> wrote:
>> -----Original Message-----
>> From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of Dave Airlie
>> Sent: maanantai 4. lokakuuta 2021 3.33
>> To: Ville Syrjälä <ville.syrjala@linux.intel.com>
>> Cc: Nikula, Jani <jani.nikula@intel.com>; Intel Graphics Development <intel-
>> gfx@lists.freedesktop.org>; Dave Airlie <airlied@redhat.com>; Sarvela, Tomi P
>> <tomi.p.sarvela@intel.com>
>> Subject: Re: [Intel-gfx] [PATCH 01/24] drm/i915/uncore: split the fw get function
>> into separate vfunc
>>
>> On Sun, 3 Oct 2021 at 05:27, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
>> >
>> > On Wed, Sep 29, 2021 at 01:57:45AM +0300, Jani Nikula wrote:
>> > > From: Dave Airlie <airlied@redhat.com>
>> > >
>> > > constify it while here. drop the put function since it was never
>> > > overloaded and always has done the same thing, no point in
>> > > indirecting it for show.
>> > >
>> > > Reviewed-by: Jani Nikula <jani.nikula@intel.com>
>> > > Signed-off-by: Dave Airlie <airlied@redhat.com>
>> > > Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>> >
>> > This has totally broken snb and ivb machines. Total death ensues
>> > somewhere in uncore init after some backtraces fly by.
>> > Didn't get any logs out to disk unfortunately. Please revert.
>> >
>> > Sadly CI is still afraid to report when machines disappear.
>> > For the bat report you at least get a list of machines that were awol,
>> > but the shard run seems to not even mention that all snbs suddenly
>> > vanished.
>> >
>> > I've said it before and I'll say it again. We really should
>> > *not* be loading i915 when the machine boots. That way we'd at least
>> > get the machine up and running and can report that loading i915 is the
>> > thing that killed it...
>>
>> That is frustrating, I've sent a oneline fix that should fix it up.
>> hopefully CI will pick it up.
> It seems it did (this for ivb, snb only):
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21231/index.html?hosts=snb%7Civb
Pushed now.
BR,
Jani.
>
>>
>> Dave.
--
Jani Nikula, Intel Open Source Graphics Center
next prev parent reply other threads:[~2021-10-04 7:46 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-28 22:57 [Intel-gfx] [PATCH 00/24] i915/display: split and constify vtable, again Jani Nikula
2021-09-28 22:57 ` [Intel-gfx] [PATCH 01/24] drm/i915/uncore: split the fw get function into separate vfunc Jani Nikula
2021-10-02 19:27 ` Ville Syrjälä
2021-10-04 0:33 ` Dave Airlie
2021-10-04 7:03 ` Saarinen, Jani
2021-10-04 7:45 ` Jani Nikula [this message]
2021-10-04 7:44 ` Sarvela, Tomi P
2021-09-28 22:57 ` [Intel-gfx] [PATCH 02/24] drm/i915/pm: drop get_fifo_size vfunc Jani Nikula
2021-09-28 22:57 ` [Intel-gfx] [PATCH 03/24] drm/i915: make update_wm take a dev_priv Jani Nikula
2021-09-28 22:57 ` [Intel-gfx] [PATCH 04/24] drm/i915/wm: provide wrappers around watermark vfuncs calls (v3) Jani Nikula
2021-09-28 22:57 ` [Intel-gfx] [PATCH 05/24] drm/i915: add wrappers around cdclk vtable funcs Jani Nikula
2021-09-28 22:57 ` [Intel-gfx] [PATCH 06/24] drm/i915/display: add intel_fdi_link_train wrapper Jani Nikula
2021-09-28 22:57 ` [Intel-gfx] [PATCH 07/24] drm/i915: split clock gating init from display vtable Jani Nikula
2021-09-28 22:57 ` [Intel-gfx] [PATCH 08/24] drm/i915: split watermark vfuncs " Jani Nikula
2021-09-28 22:57 ` [Intel-gfx] [PATCH 09/24] drm/i915: split color functions " Jani Nikula
2021-09-28 22:57 ` [Intel-gfx] [PATCH 10/24] drm/i915: split audio " Jani Nikula
2021-09-28 22:57 ` [Intel-gfx] [PATCH 11/24] drm/i915: split cdclk " Jani Nikula
2021-09-28 22:57 ` [Intel-gfx] [PATCH 12/24] drm/i915: split irq hotplug function " Jani Nikula
2021-09-28 22:57 ` [Intel-gfx] [PATCH 13/24] drm/i915: split fdi link training " Jani Nikula
2021-09-28 22:57 ` [Intel-gfx] [PATCH 14/24] drm/i915: split the dpll clock compute out " Jani Nikula
2021-09-28 22:57 ` [Intel-gfx] [PATCH 15/24] drm/i915: constify fdi link training vtable Jani Nikula
2021-09-28 22:58 ` [Intel-gfx] [PATCH 16/24] drm/i915: constify hotplug function vtable Jani Nikula
2021-09-28 22:58 ` [Intel-gfx] [PATCH 17/24] drm/i915: constify color " Jani Nikula
2021-09-28 22:58 ` [Intel-gfx] [PATCH 18/24] drm/i915: constify the audio " Jani Nikula
2021-09-28 22:58 ` [Intel-gfx] [PATCH 19/24] drm/i915: constify the dpll clock vtable Jani Nikula
2021-09-28 22:58 ` [Intel-gfx] [PATCH 20/24] drm/i915: constify the cdclk vtable Jani Nikula
2021-09-28 22:58 ` [Intel-gfx] [PATCH 21/24] drm/i915: drop unused function ptr and comments Jani Nikula
2021-09-28 22:58 ` [Intel-gfx] [PATCH 22/24] drm/i915: constify display function vtable Jani Nikula
2021-09-28 22:58 ` [Intel-gfx] [PATCH 23/24] drm/i915: constify clock gating init vtable Jani Nikula
2021-09-28 22:58 ` [Intel-gfx] [PATCH 24/24] drm/i915: constify display wm vtable Jani Nikula
2021-09-28 23:38 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for i915/display: split and constify vtable, again Patchwork
2021-09-29 0:09 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-09-29 3:12 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2021-09-29 6:59 ` [Intel-gfx] [PATCH 00/24] " Jani Nikula
-- strict thread matches above, loose matches on Subject: below --
2021-09-22 14:29 [Intel-gfx] [PATCH 00/24] i915/display: split and constify vtable (v6) Jani Nikula
2021-09-22 14:29 ` [Intel-gfx] [PATCH 01/24] drm/i915/uncore: split the fw get function into separate vfunc Jani Nikula
2021-09-14 18:24 [Intel-gfx] [PATCH 00/24] i915/display: split and constify vtable (v5) Jani Nikula
2021-09-14 18:24 ` [Intel-gfx] [PATCH 01/24] drm/i915/uncore: split the fw get function into separate vfunc Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h7dx2pxu.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=airlied@gmail.com \
--cc=airlied@redhat.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.saarinen@intel.com \
--cc=tomi.p.sarvela@intel.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox