From: Jani Nikula <jani.nikula@intel.com>
To: "Murthy, Arun R" <arun.r.murthy@intel.com>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [PATCH 2/2] drm/i915/hdcp: replace BIT() with REG_BIT() in register definitions
Date: Wed, 10 Aug 2022 13:09:03 +0300 [thread overview]
Message-ID: <87iln0v29s.fsf@intel.com> (raw)
In-Reply-To: <DM6PR11MB317739FF517CFEE8D12BA9A7BA659@DM6PR11MB3177.namprd11.prod.outlook.com>
On Wed, 10 Aug 2022, "Murthy, Arun R" <arun.r.murthy@intel.com> wrote:
>> -----Original Message-----
>> From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of Jani
>> Nikula
>> Sent: Thursday, August 4, 2022 3:29 PM
>> To: intel-gfx@lists.freedesktop.org
>> Cc: Nikula, Jani <jani.nikula@intel.com>
>> Subject: [Intel-gfx] [PATCH 2/2] drm/i915/hdcp: replace BIT() with REG_BIT()
>> in register definitions
>>
>> Registers contents are supposed to be defined using REG_BIT() to ensure
>> they're u32 and the shift is within bounds.
>>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>> ---
>
> Reviewed-by: Arun R Murthy <arun.r.murthy@intel.com>
Thanks for the review, pushed both.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
next prev parent reply other threads:[~2022-08-10 10:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-04 9:58 [Intel-gfx] [PATCH 0/2] drm/i915/hdcp: register cleanup Jani Nikula
2022-08-04 9:58 ` [Intel-gfx] [PATCH 1/2] drm/i915/hdcp: split out hdcp registers to a separate file Jani Nikula
2022-08-10 3:57 ` Murthy, Arun R
2022-08-04 9:58 ` [Intel-gfx] [PATCH 2/2] drm/i915/hdcp: replace BIT() with REG_BIT() in register definitions Jani Nikula
2022-08-10 4:04 ` Murthy, Arun R
2022-08-10 10:09 ` Jani Nikula [this message]
2022-08-04 10:47 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/hdcp: register cleanup Patchwork
2022-08-04 10:47 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2022-08-04 11:10 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2022-08-04 12:19 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/hdcp: register cleanup (rev2) Patchwork
2022-08-04 12:46 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2022-08-05 9:01 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/hdcp: register cleanup (rev3) Patchwork
2022-08-05 9:01 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2022-08-05 9:20 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-08-05 11:28 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87iln0v29s.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=arun.r.murthy@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox