Re: [PATCH] drm/i915/execlists: Move the GEM_BUG_ON context matches CSB later

From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/execlists: Move the GEM_BUG_ON context matches CSB later
Date: Thu, 22 Feb 2018 10:51:40 +0200	[thread overview]
Message-ID: <87inaps8yr.fsf@gaia.fi.intel.com> (raw)
In-Reply-To: <20180221152301.9178-1-chris@chris-wilson.co.uk>

Chris Wilson <chris@chris-wilson.co.uk> writes:

> Print out the current request/context before doing the GEM_BUG_ON, so
> that we can inspect the values in the ftrace.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>

Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>

> ---
>  drivers/gpu/drm/i915/intel_lrc.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/drivers/gpu/drm/i915/intel_lrc.c
> index 9b6d781b22ec..2ad55c1ffd54 100644
> --- a/drivers/gpu/drm/i915/intel_lrc.c
> +++ b/drivers/gpu/drm/i915/intel_lrc.c
> @@ -872,14 +872,15 @@ static void execlists_submission_tasklet(unsigned long data)
>  			GEM_BUG_ON(!execlists_is_active(execlists,
>  							EXECLISTS_ACTIVE_USER));
>  
> -			/* Check the context/desc id for this event matches */
> -			GEM_DEBUG_BUG_ON(buf[2 * head + 1] != port->context_id);
> -
>  			rq = port_unpack(port, &count);
>  			GEM_TRACE("%s out[0]: ctx=%d.%d, seqno=%x\n",
>  				  engine->name,
>  				  port->context_id, count,
>  				  rq ? rq->global_seqno : 0);
> +
> +			/* Check the context/desc id for this event matches */
> +			GEM_DEBUG_BUG_ON(buf[2 * head + 1] != port->context_id);
> +
>  			GEM_BUG_ON(count == 0);
>  			if (--count == 0) {
>  				GEM_BUG_ON(status & GEN8_CTX_STATUS_PREEMPTED);
> -- 
> 2.16.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx