* [PATCH] drm/i915/execlists: Move the GEM_BUG_ON context matches CSB later
@ 2018-02-21 15:23 Chris Wilson
2018-02-21 16:06 ` ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Chris Wilson @ 2018-02-21 15:23 UTC (permalink / raw)
To: intel-gfx
Print out the current request/context before doing the GEM_BUG_ON, so
that we can inspect the values in the ftrace.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
---
drivers/gpu/drm/i915/intel_lrc.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/drivers/gpu/drm/i915/intel_lrc.c
index 9b6d781b22ec..2ad55c1ffd54 100644
--- a/drivers/gpu/drm/i915/intel_lrc.c
+++ b/drivers/gpu/drm/i915/intel_lrc.c
@@ -872,14 +872,15 @@ static void execlists_submission_tasklet(unsigned long data)
GEM_BUG_ON(!execlists_is_active(execlists,
EXECLISTS_ACTIVE_USER));
- /* Check the context/desc id for this event matches */
- GEM_DEBUG_BUG_ON(buf[2 * head + 1] != port->context_id);
-
rq = port_unpack(port, &count);
GEM_TRACE("%s out[0]: ctx=%d.%d, seqno=%x\n",
engine->name,
port->context_id, count,
rq ? rq->global_seqno : 0);
+
+ /* Check the context/desc id for this event matches */
+ GEM_DEBUG_BUG_ON(buf[2 * head + 1] != port->context_id);
+
GEM_BUG_ON(count == 0);
if (--count == 0) {
GEM_BUG_ON(status & GEN8_CTX_STATUS_PREEMPTED);
--
2.16.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 5+ messages in thread* ✓ Fi.CI.BAT: success for drm/i915/execlists: Move the GEM_BUG_ON context matches CSB later
2018-02-21 15:23 [PATCH] drm/i915/execlists: Move the GEM_BUG_ON context matches CSB later Chris Wilson
@ 2018-02-21 16:06 ` Patchwork
2018-02-21 20:19 ` ✗ Fi.CI.IGT: failure " Patchwork
2018-02-22 8:51 ` [PATCH] " Mika Kuoppala
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2018-02-21 16:06 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/execlists: Move the GEM_BUG_ON context matches CSB later
URL : https://patchwork.freedesktop.org/series/38709/
State : success
== Summary ==
Series 38709v1 drm/i915/execlists: Move the GEM_BUG_ON context matches CSB later
https://patchwork.freedesktop.org/api/1.0/series/38709/revisions/1/mbox/
Test gem_mmap_gtt:
Subgroup basic-small-bo-tiledx:
pass -> FAIL (fi-gdg-551) fdo#102575
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-a:
fail -> PASS (fi-ivb-3520m)
Subgroup suspend-read-crc-pipe-b:
fail -> PASS (fi-ivb-3520m)
Subgroup suspend-read-crc-pipe-c:
fail -> PASS (fi-ivb-3520m)
pass -> INCOMPLETE (fi-bxt-dsi) fdo#103927
Test prime_vgem:
Subgroup basic-fence-flip:
pass -> FAIL (fi-bdw-5557u) fdo#104008
fdo#102575 https://bugs.freedesktop.org/show_bug.cgi?id=102575
fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
fdo#104008 https://bugs.freedesktop.org/show_bug.cgi?id=104008
fi-bdw-5557u total:288 pass:266 dwarn:0 dfail:0 fail:1 skip:21 time:415s
fi-bdw-gvtdvm total:288 pass:264 dwarn:0 dfail:0 fail:0 skip:24 time:422s
fi-blb-e6850 total:288 pass:223 dwarn:1 dfail:0 fail:0 skip:64 time:373s
fi-bsw-n3050 total:288 pass:242 dwarn:0 dfail:0 fail:0 skip:46 time:487s
fi-bwr-2160 total:288 pass:183 dwarn:0 dfail:0 fail:0 skip:105 time:284s
fi-bxt-dsi total:246 pass:219 dwarn:0 dfail:0 fail:0 skip:26
fi-bxt-j4205 total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:479s
fi-byt-j1900 total:288 pass:253 dwarn:0 dfail:0 fail:0 skip:35 time:464s
fi-byt-n2820 total:288 pass:249 dwarn:0 dfail:0 fail:0 skip:39 time:453s
fi-cfl-s2 total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:566s
fi-elk-e7500 total:288 pass:229 dwarn:0 dfail:0 fail:0 skip:59 time:413s
fi-gdg-551 total:288 pass:179 dwarn:0 dfail:0 fail:1 skip:108 time:284s
fi-glk-1 total:288 pass:260 dwarn:0 dfail:0 fail:0 skip:28 time:507s
fi-hsw-4770 total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:384s
fi-ilk-650 total:288 pass:228 dwarn:0 dfail:0 fail:0 skip:60 time:408s
fi-ivb-3520m total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:455s
fi-ivb-3770 total:288 pass:255 dwarn:0 dfail:0 fail:0 skip:33 time:415s
fi-kbl-7500u total:288 pass:263 dwarn:1 dfail:0 fail:0 skip:24 time:450s
fi-kbl-7560u total:288 pass:269 dwarn:0 dfail:0 fail:0 skip:19 time:488s
fi-kbl-7567u total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:447s
fi-kbl-r total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:494s
fi-pnv-d510 total:288 pass:222 dwarn:1 dfail:0 fail:0 skip:65 time:589s
fi-skl-6260u total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:426s
fi-skl-6600u total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:500s
fi-skl-6700hq total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:518s
fi-skl-6700k2 total:288 pass:264 dwarn:0 dfail:0 fail:0 skip:24 time:487s
fi-skl-6770hq total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:475s
fi-skl-guc total:288 pass:260 dwarn:0 dfail:0 fail:0 skip:28 time:408s
fi-skl-gvtdvm total:288 pass:265 dwarn:0 dfail:0 fail:0 skip:23 time:431s
fi-snb-2520m total:245 pass:211 dwarn:0 dfail:0 fail:0 skip:33
fi-snb-2600 total:288 pass:248 dwarn:0 dfail:0 fail:0 skip:40 time:389s
42d073db2a8593a8d1832037ffe0988403031568 drm-tip: 2018y-02m-21d-14h-03m-58s UTC integration manifest
3704ae073969 drm/i915/execlists: Move the GEM_BUG_ON context matches CSB later
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8107/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread* ✗ Fi.CI.IGT: failure for drm/i915/execlists: Move the GEM_BUG_ON context matches CSB later
2018-02-21 15:23 [PATCH] drm/i915/execlists: Move the GEM_BUG_ON context matches CSB later Chris Wilson
2018-02-21 16:06 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2018-02-21 20:19 ` Patchwork
2018-02-22 8:51 ` [PATCH] " Mika Kuoppala
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2018-02-21 20:19 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/execlists: Move the GEM_BUG_ON context matches CSB later
URL : https://patchwork.freedesktop.org/series/38709/
State : failure
== Summary ==
Test kms_plane_multiple:
Subgroup legacy-pipe-b-tiling-none:
skip -> PASS (shard-snb)
Test kms_vblank:
Subgroup pipe-b-wait-busy-hang:
skip -> PASS (shard-snb)
Test kms_flip:
Subgroup 2x-flip-vs-absolute-wf_vblank-interruptible:
fail -> PASS (shard-hsw) fdo#100368 +1
Subgroup 2x-dpms-vs-vblank-race:
pass -> FAIL (shard-hsw) fdo#103060
Test kms_pipe_crc_basic:
Subgroup read-crc-pipe-c-frame-sequence:
fail -> PASS (shard-apl) fdo#103481
Test gem_eio:
Subgroup suspend:
pass -> INCOMPLETE (shard-hsw) fdo#105055
Subgroup in-flight:
incomplete -> PASS (shard-apl)
Subgroup in-flight-external:
pass -> INCOMPLETE (shard-apl)
Test kms_cursor_crc:
Subgroup cursor-128x128-suspend:
pass -> INCOMPLETE (shard-hsw) fdo#103540
Test kms_atomic_transition:
Subgroup 1x-modeset-transitions-nonblocking-fencing:
fail -> PASS (shard-apl) fdo#103207
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060
fdo#103481 https://bugs.freedesktop.org/show_bug.cgi?id=103481
fdo#105055 https://bugs.freedesktop.org/show_bug.cgi?id=105055
fdo#103540 https://bugs.freedesktop.org/show_bug.cgi?id=103540
fdo#103207 https://bugs.freedesktop.org/show_bug.cgi?id=103207
shard-apl total:3275 pass:1712 dwarn:1 dfail:0 fail:13 skip:1547 time:11710s
shard-hsw total:3422 pass:1743 dwarn:1 dfail:0 fail:3 skip:1672 time:11273s
shard-snb total:3464 pass:1356 dwarn:1 dfail:0 fail:3 skip:2104 time:6627s
Blacklisted hosts:
shard-kbl total:3464 pass:1960 dwarn:1 dfail:0 fail:15 skip:1488 time:9697s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8107/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drm/i915/execlists: Move the GEM_BUG_ON context matches CSB later
2018-02-21 15:23 [PATCH] drm/i915/execlists: Move the GEM_BUG_ON context matches CSB later Chris Wilson
2018-02-21 16:06 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-02-21 20:19 ` ✗ Fi.CI.IGT: failure " Patchwork
@ 2018-02-22 8:51 ` Mika Kuoppala
2018-02-22 9:09 ` Chris Wilson
2 siblings, 1 reply; 5+ messages in thread
From: Mika Kuoppala @ 2018-02-22 8:51 UTC (permalink / raw)
To: Chris Wilson, intel-gfx
Chris Wilson <chris@chris-wilson.co.uk> writes:
> Print out the current request/context before doing the GEM_BUG_ON, so
> that we can inspect the values in the ftrace.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/intel_lrc.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/drivers/gpu/drm/i915/intel_lrc.c
> index 9b6d781b22ec..2ad55c1ffd54 100644
> --- a/drivers/gpu/drm/i915/intel_lrc.c
> +++ b/drivers/gpu/drm/i915/intel_lrc.c
> @@ -872,14 +872,15 @@ static void execlists_submission_tasklet(unsigned long data)
> GEM_BUG_ON(!execlists_is_active(execlists,
> EXECLISTS_ACTIVE_USER));
>
> - /* Check the context/desc id for this event matches */
> - GEM_DEBUG_BUG_ON(buf[2 * head + 1] != port->context_id);
> -
> rq = port_unpack(port, &count);
> GEM_TRACE("%s out[0]: ctx=%d.%d, seqno=%x\n",
> engine->name,
> port->context_id, count,
> rq ? rq->global_seqno : 0);
> +
> + /* Check the context/desc id for this event matches */
> + GEM_DEBUG_BUG_ON(buf[2 * head + 1] != port->context_id);
> +
> GEM_BUG_ON(count == 0);
> if (--count == 0) {
> GEM_BUG_ON(status & GEN8_CTX_STATUS_PREEMPTED);
> --
> 2.16.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drm/i915/execlists: Move the GEM_BUG_ON context matches CSB later
2018-02-22 8:51 ` [PATCH] " Mika Kuoppala
@ 2018-02-22 9:09 ` Chris Wilson
0 siblings, 0 replies; 5+ messages in thread
From: Chris Wilson @ 2018-02-22 9:09 UTC (permalink / raw)
To: Mika Kuoppala, intel-gfx
Quoting Mika Kuoppala (2018-02-22 08:51:40)
> Chris Wilson <chris@chris-wilson.co.uk> writes:
>
> > Print out the current request/context before doing the GEM_BUG_ON, so
> > that we can inspect the values in the ftrace.
> >
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
>
> Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Thanks, pushed this pair in the hope it gleams some light into the
gem_eio deaths.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-02-22 9:09 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-02-21 15:23 [PATCH] drm/i915/execlists: Move the GEM_BUG_ON context matches CSB later Chris Wilson
2018-02-21 16:06 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-02-21 20:19 ` ✗ Fi.CI.IGT: failure " Patchwork
2018-02-22 8:51 ` [PATCH] " Mika Kuoppala
2018-02-22 9:09 ` Chris Wilson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox