Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] string: add mem_is_zero() helper to check if memory area is all zeros
@ 2024-05-27  9:43 Jani Nikula
  2024-05-27  9:43 ` [PATCH 2/2] drm: use mem_is_zero() instead of !memchr_inv(s, 0, n) Jani Nikula
                   ` (3 more replies)
  0 siblings, 4 replies; 8+ messages in thread
From: Jani Nikula @ 2024-05-27  9:43 UTC (permalink / raw)
  To: linux-kernel, dri-devel
  Cc: intel-gfx, jani.nikula, Kees Cook, Andy Shevchenko

Almost two thirds of the memchr_inv() usages check if the memory area is
all zeros, with no interest in where in the buffer the first non-zero
byte is located. Checking for !memchr_inv(s, 0, n) is also not very
intuitive or discoverable. Add an explicit mem_is_zero() helper for this
use case.

Signed-off-by: Jani Nikula <jani.nikula@intel.com>

---

Cc: Kees Cook <keescook@chromium.org>
Cc: Andy Shevchenko <andy@kernel.org>
---
 include/linux/string.h | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/include/linux/string.h b/include/linux/string.h
index 60168aa2af07..3da305dab927 100644
--- a/include/linux/string.h
+++ b/include/linux/string.h
@@ -279,6 +279,18 @@ static inline void memcpy_flushcache(void *dst, const void *src, size_t cnt)
 void *memchr_inv(const void *s, int c, size_t n);
 char *strreplace(char *str, char old, char new);
 
+/**
+ * mem_is_zero - Check if an area of memory is all 0's.
+ * @s: The memory area
+ * @n: The size of the area
+ *
+ * Return: True if the area of memory is all 0's.
+ */
+static inline bool mem_is_zero(const void *s, size_t n)
+{
+	return !memchr_inv(s, 0, n);
+}
+
 extern void kfree_const(const void *x);
 
 extern char *kstrdup(const char *s, gfp_t gfp) __malloc;
-- 
2.39.2


^ permalink raw reply related	[flat|nested] 8+ messages in thread
end of thread, other threads:[~2024-05-27 18:13 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-27  9:43 [PATCH 1/2] string: add mem_is_zero() helper to check if memory area is all zeros Jani Nikula
2024-05-27  9:43 ` [PATCH 2/2] drm: use mem_is_zero() instead of !memchr_inv(s, 0, n) Jani Nikula
2024-05-27 13:19   ` Andy Shevchenko
2024-05-27 14:08     ` Jani Nikula
2024-05-27 11:23 ` ✓ Fi.CI.BAT: success for series starting with [1/2] string: add mem_is_zero() helper to check if memory area is all zeros Patchwork
2024-05-27 13:27 ` [PATCH 1/2] " Andy Shevchenko
2024-05-27 14:06   ` Jani Nikula
2024-05-27 18:13 ` ✗ Fi.CI.IGT: failure for series starting with [1/2] " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox