* [Intel-gfx] [PATCH] drm/i915/guc: Dump perf_limit_reasons for debug
@ 2023-06-27 2:12 Vinay Belgaumkar
2023-06-27 3:17 ` Dixit, Ashutosh
2023-06-27 8:14 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
0 siblings, 2 replies; 6+ messages in thread
From: Vinay Belgaumkar @ 2023-06-27 2:12 UTC (permalink / raw)
To: intel-gfx, dri-devel
GuC load takes longer sometimes due to GT frequency not ramping up.
Add perf_limit_reasons to the existing warn print to see if frequency
is being throttled.
Signed-off-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
---
drivers/gpu/drm/i915/gt/uc/intel_guc_fw.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_fw.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_fw.c
index 364d0d546ec8..73911536a8e7 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_guc_fw.c
+++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_fw.c
@@ -254,6 +254,8 @@ static int guc_wait_ucode(struct intel_guc *guc)
guc_warn(guc, "excessive init time: %lldms! [freq = %dMHz, before = %dMHz, status = 0x%08X, count = %d, ret = %d]\n",
delta_ms, intel_rps_read_actual_frequency(&uncore->gt->rps),
before_freq, status, count, ret);
+ guc_warn(guc, "perf limit reasons = 0x%08X\n",
+ intel_uncore_read(uncore, intel_gt_perf_limit_reasons_reg(gt)));
} else {
guc_dbg(guc, "init took %lldms, freq = %dMHz, before = %dMHz, status = 0x%08X, count = %d, ret = %d\n",
delta_ms, intel_rps_read_actual_frequency(&uncore->gt->rps),
--
2.38.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/guc: Dump perf_limit_reasons for debug
2023-06-27 2:12 [Intel-gfx] [PATCH] drm/i915/guc: Dump perf_limit_reasons for debug Vinay Belgaumkar
@ 2023-06-27 3:17 ` Dixit, Ashutosh
2023-06-27 4:02 ` Belgaumkar, Vinay
2023-06-27 8:14 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
1 sibling, 1 reply; 6+ messages in thread
From: Dixit, Ashutosh @ 2023-06-27 3:17 UTC (permalink / raw)
To: Vinay Belgaumkar; +Cc: intel-gfx, dri-devel
On Mon, 26 Jun 2023 19:12:18 -0700, Vinay Belgaumkar wrote:
>
> GuC load takes longer sometimes due to GT frequency not ramping up.
> Add perf_limit_reasons to the existing warn print to see if frequency
> is being throttled.
>
> Signed-off-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
> ---
> drivers/gpu/drm/i915/gt/uc/intel_guc_fw.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_fw.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_fw.c
> index 364d0d546ec8..73911536a8e7 100644
> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_fw.c
> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_fw.c
> @@ -254,6 +254,8 @@ static int guc_wait_ucode(struct intel_guc *guc)
> guc_warn(guc, "excessive init time: %lldms! [freq = %dMHz, before = %dMHz, status = 0x%08X, count = %d, ret = %d]\n",
> delta_ms, intel_rps_read_actual_frequency(&uncore->gt->rps),
> before_freq, status, count, ret);
> + guc_warn(guc, "perf limit reasons = 0x%08X\n",
> + intel_uncore_read(uncore, intel_gt_perf_limit_reasons_reg(gt)));
Maybe just add at the end of the previous guc_warn?
> } else {
> guc_dbg(guc, "init took %lldms, freq = %dMHz, before = %dMHz, status = 0x%08X, count = %d, ret = %d\n",
> delta_ms, intel_rps_read_actual_frequency(&uncore->gt->rps),
> --
> 2.38.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/guc: Dump perf_limit_reasons for debug
2023-06-27 3:17 ` Dixit, Ashutosh
@ 2023-06-27 4:02 ` Belgaumkar, Vinay
2023-06-27 6:43 ` Dixit, Ashutosh
0 siblings, 1 reply; 6+ messages in thread
From: Belgaumkar, Vinay @ 2023-06-27 4:02 UTC (permalink / raw)
To: Dixit, Ashutosh; +Cc: intel-gfx, dri-devel
On 6/26/2023 8:17 PM, Dixit, Ashutosh wrote:
> On Mon, 26 Jun 2023 19:12:18 -0700, Vinay Belgaumkar wrote:
>> GuC load takes longer sometimes due to GT frequency not ramping up.
>> Add perf_limit_reasons to the existing warn print to see if frequency
>> is being throttled.
>>
>> Signed-off-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
>> ---
>> drivers/gpu/drm/i915/gt/uc/intel_guc_fw.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_fw.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_fw.c
>> index 364d0d546ec8..73911536a8e7 100644
>> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_fw.c
>> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_fw.c
>> @@ -254,6 +254,8 @@ static int guc_wait_ucode(struct intel_guc *guc)
>> guc_warn(guc, "excessive init time: %lldms! [freq = %dMHz, before = %dMHz, status = 0x%08X, count = %d, ret = %d]\n",
>> delta_ms, intel_rps_read_actual_frequency(&uncore->gt->rps),
>> before_freq, status, count, ret);
>> + guc_warn(guc, "perf limit reasons = 0x%08X\n",
>> + intel_uncore_read(uncore, intel_gt_perf_limit_reasons_reg(gt)));
> Maybe just add at the end of the previous guc_warn?
Its already too long a line. If I try adding on the next line checkpatch
complains about splitting double quotes.
Thanks,
Vinay.
>
>> } else {
>> guc_dbg(guc, "init took %lldms, freq = %dMHz, before = %dMHz, status = 0x%08X, count = %d, ret = %d\n",
>> delta_ms, intel_rps_read_actual_frequency(&uncore->gt->rps),
>> --
>> 2.38.1
>>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/guc: Dump perf_limit_reasons for debug
2023-06-27 4:02 ` Belgaumkar, Vinay
@ 2023-06-27 6:43 ` Dixit, Ashutosh
2023-06-27 19:03 ` Belgaumkar, Vinay
0 siblings, 1 reply; 6+ messages in thread
From: Dixit, Ashutosh @ 2023-06-27 6:43 UTC (permalink / raw)
To: Belgaumkar, Vinay; +Cc: intel-gfx, dri-devel
On Mon, 26 Jun 2023 21:02:14 -0700, Belgaumkar, Vinay wrote:
>
>
> On 6/26/2023 8:17 PM, Dixit, Ashutosh wrote:
> > On Mon, 26 Jun 2023 19:12:18 -0700, Vinay Belgaumkar wrote:
> >> GuC load takes longer sometimes due to GT frequency not ramping up.
> >> Add perf_limit_reasons to the existing warn print to see if frequency
> >> is being throttled.
> >>
> >> Signed-off-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
> >> ---
> >> drivers/gpu/drm/i915/gt/uc/intel_guc_fw.c | 2 ++
> >> 1 file changed, 2 insertions(+)
> >>
> >> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_fw.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_fw.c
> >> index 364d0d546ec8..73911536a8e7 100644
> >> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_fw.c
> >> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_fw.c
> >> @@ -254,6 +254,8 @@ static int guc_wait_ucode(struct intel_guc *guc)
> >> guc_warn(guc, "excessive init time: %lldms! [freq = %dMHz, before = %dMHz, status = 0x%08X, count = %d, ret = %d]\n",
> >> delta_ms, intel_rps_read_actual_frequency(&uncore->gt->rps),
> >> before_freq, status, count, ret);
> >> + guc_warn(guc, "perf limit reasons = 0x%08X\n",
> >> + intel_uncore_read(uncore, intel_gt_perf_limit_reasons_reg(gt)));
> > Maybe just add at the end of the previous guc_warn?
>
> Its already too long a line. If I try adding on the next line checkpatch
> complains about splitting double quotes.
In these cases of long quoted lines we generally ignore checkpatch. Because
perf limit reasons is part of the "excessive init time" message it should
be on the same line within the square brackets. So should not be
splitting double quotes.
Another idea would be something like this:
guc_warn(guc, "excessive init time: %lldms! [freq = %dMHz, before = %dMHz, status = 0x%08X]\n",
delta_ms, intel_rps_read_actual_frequency(&uncore->gt->rps),
before_freq, status);
guc_warn(guc, "excessive init time: [count = %d, ret = %d, perf limit reasons = 0x%08X]\n",
count, ret, intel_uncore_read(uncore, intel_gt_perf_limit_reasons_reg(gt)));
Thanks.
--
Ashutosh
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/guc: Dump perf_limit_reasons for debug
2023-06-27 2:12 [Intel-gfx] [PATCH] drm/i915/guc: Dump perf_limit_reasons for debug Vinay Belgaumkar
2023-06-27 3:17 ` Dixit, Ashutosh
@ 2023-06-27 8:14 ` Patchwork
1 sibling, 0 replies; 6+ messages in thread
From: Patchwork @ 2023-06-27 8:14 UTC (permalink / raw)
To: Belgaumkar, Vinay; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 5285 bytes --]
== Series Details ==
Series: drm/i915/guc: Dump perf_limit_reasons for debug
URL : https://patchwork.freedesktop.org/series/119893/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_13324 -> Patchwork_119893v1
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_119893v1 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_119893v1, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119893v1/index.html
Participating hosts (40 -> 40)
------------------------------
Additional (1): bat-adlp-11
Missing (1): fi-snb-2520m
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_119893v1:
### IGT changes ###
#### Possible regressions ####
* igt@gem_exec_suspend@basic-s3@lmem0:
- bat-dg1-5: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13324/bat-dg1-5/igt@gem_exec_suspend@basic-s3@lmem0.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119893v1/bat-dg1-5/igt@gem_exec_suspend@basic-s3@lmem0.html
* igt@i915_module_load@reload:
- bat-mtlp-8: [PASS][3] -> [ABORT][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13324/bat-mtlp-8/igt@i915_module_load@reload.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119893v1/bat-mtlp-8/igt@i915_module_load@reload.html
Known issues
------------
Here are the changes found in Patchwork_119893v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_module_load@load:
- bat-adlp-11: NOTRUN -> [ABORT][5] ([i915#4423])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119893v1/bat-adlp-11/igt@i915_module_load@load.html
* igt@i915_selftest@live@reset:
- bat-rpls-2: [PASS][6] -> [ABORT][7] ([i915#4983] / [i915#7461] / [i915#7913] / [i915#8347])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13324/bat-rpls-2/igt@i915_selftest@live@reset.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119893v1/bat-rpls-2/igt@i915_selftest@live@reset.html
* igt@kms_chamelium_hpd@common-hpd-after-suspend:
- bat-dg2-11: NOTRUN -> [SKIP][8] ([i915#7828])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119893v1/bat-dg2-11/igt@kms_chamelium_hpd@common-hpd-after-suspend.html
* igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-d-edp-1:
- bat-rplp-1: [PASS][9] -> [ABORT][10] ([i915#8442])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13324/bat-rplp-1/igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-d-edp-1.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119893v1/bat-rplp-1/igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-d-edp-1.html
#### Possible fixes ####
* igt@i915_selftest@live@gt_mocs:
- bat-mtlp-6: [DMESG-FAIL][11] ([i915#7059]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13324/bat-mtlp-6/igt@i915_selftest@live@gt_mocs.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119893v1/bat-mtlp-6/igt@i915_selftest@live@gt_mocs.html
* igt@i915_selftest@live@workarounds:
- bat-mtlp-6: [DMESG-FAIL][13] ([i915#6763]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13324/bat-mtlp-6/igt@i915_selftest@live@workarounds.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119893v1/bat-mtlp-6/igt@i915_selftest@live@workarounds.html
- bat-dg2-11: [INCOMPLETE][15] ([i915#7913]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13324/bat-dg2-11/igt@i915_selftest@live@workarounds.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119893v1/bat-dg2-11/igt@i915_selftest@live@workarounds.html
[i915#4423]: https://gitlab.freedesktop.org/drm/intel/issues/4423
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#6763]: https://gitlab.freedesktop.org/drm/intel/issues/6763
[i915#7059]: https://gitlab.freedesktop.org/drm/intel/issues/7059
[i915#7461]: https://gitlab.freedesktop.org/drm/intel/issues/7461
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
[i915#8347]: https://gitlab.freedesktop.org/drm/intel/issues/8347
[i915#8442]: https://gitlab.freedesktop.org/drm/intel/issues/8442
Build changes
-------------
* Linux: CI_DRM_13324 -> Patchwork_119893v1
CI-20190529: 20190529
CI_DRM_13324: d0f10363d9fd8f1cb22a020a878f76c627389355 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7351: d8dc96b95c60e4737fdfa1664ce9b1dcebfdef60 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_119893v1: d0f10363d9fd8f1cb22a020a878f76c627389355 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
18ebc2e8c567 drm/i915/guc: Dump perf_limit_reasons for debug
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119893v1/index.html
[-- Attachment #2: Type: text/html, Size: 6194 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/guc: Dump perf_limit_reasons for debug
2023-06-27 6:43 ` Dixit, Ashutosh
@ 2023-06-27 19:03 ` Belgaumkar, Vinay
0 siblings, 0 replies; 6+ messages in thread
From: Belgaumkar, Vinay @ 2023-06-27 19:03 UTC (permalink / raw)
To: Dixit, Ashutosh; +Cc: intel-gfx, dri-devel
On 6/26/2023 11:43 PM, Dixit, Ashutosh wrote:
> On Mon, 26 Jun 2023 21:02:14 -0700, Belgaumkar, Vinay wrote:
>>
>> On 6/26/2023 8:17 PM, Dixit, Ashutosh wrote:
>>> On Mon, 26 Jun 2023 19:12:18 -0700, Vinay Belgaumkar wrote:
>>>> GuC load takes longer sometimes due to GT frequency not ramping up.
>>>> Add perf_limit_reasons to the existing warn print to see if frequency
>>>> is being throttled.
>>>>
>>>> Signed-off-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
>>>> ---
>>>> drivers/gpu/drm/i915/gt/uc/intel_guc_fw.c | 2 ++
>>>> 1 file changed, 2 insertions(+)
>>>>
>>>> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_fw.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_fw.c
>>>> index 364d0d546ec8..73911536a8e7 100644
>>>> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_fw.c
>>>> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_fw.c
>>>> @@ -254,6 +254,8 @@ static int guc_wait_ucode(struct intel_guc *guc)
>>>> guc_warn(guc, "excessive init time: %lldms! [freq = %dMHz, before = %dMHz, status = 0x%08X, count = %d, ret = %d]\n",
>>>> delta_ms, intel_rps_read_actual_frequency(&uncore->gt->rps),
>>>> before_freq, status, count, ret);
>>>> + guc_warn(guc, "perf limit reasons = 0x%08X\n",
>>>> + intel_uncore_read(uncore, intel_gt_perf_limit_reasons_reg(gt)));
>>> Maybe just add at the end of the previous guc_warn?
>> Its already too long a line. If I try adding on the next line checkpatch
>> complains about splitting double quotes.
> In these cases of long quoted lines we generally ignore checkpatch. Because
> perf limit reasons is part of the "excessive init time" message it should
> be on the same line within the square brackets. So should not be
> splitting double quotes.
>
> Another idea would be something like this:
>
> guc_warn(guc, "excessive init time: %lldms! [freq = %dMHz, before = %dMHz, status = 0x%08X]\n",
> delta_ms, intel_rps_read_actual_frequency(&uncore->gt->rps),
> before_freq, status);
> guc_warn(guc, "excessive init time: [count = %d, ret = %d, perf limit reasons = 0x%08X]\n",
> count, ret, intel_uncore_read(uncore, intel_gt_perf_limit_reasons_reg(gt)));
ok, I will split iut based on freq and non-freq based debug.
Thanks,
Vinay.
>
> Thanks.
> --
> Ashutosh
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-06-27 19:03 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-27 2:12 [Intel-gfx] [PATCH] drm/i915/guc: Dump perf_limit_reasons for debug Vinay Belgaumkar
2023-06-27 3:17 ` Dixit, Ashutosh
2023-06-27 4:02 ` Belgaumkar, Vinay
2023-06-27 6:43 ` Dixit, Ashutosh
2023-06-27 19:03 ` Belgaumkar, Vinay
2023-06-27 8:14 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox