Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: Randy Dunlap <rdunlap@infradead.org>, intel-gfx@lists.freedesktop.org
Cc: Masahiro Yamada <masahiroy@kernel.org>
Subject: Re: [Intel-gfx] [PATCH] drm/i915: fix header test with GCOV
Date: Mon, 24 Feb 2020 14:22:32 +0200	[thread overview]
Message-ID: <87k14ctbsn.fsf@intel.com> (raw)
In-Reply-To: <3d2e87f0-f42f-5217-bef3-7b07c02b3eec@infradead.org>

On Fri, 21 Feb 2020, Randy Dunlap <rdunlap@infradead.org> wrote:
> On 2/21/20 2:54 AM, Jani Nikula wrote:
>> $(CC) with $(CFLAGS_GCOV) assumes the output filename with .gcno suffix
>> appended is writable. This is not the case when the output filename is
>> /dev/null:
>> 
>>   HDRTEST drivers/gpu/drm/i915/display/intel_frontbuffer.h
>> /dev/null:1:0: error: cannot open /dev/null.gcno
>>   HDRTEST drivers/gpu/drm/i915/display/intel_ddi.h
>> /dev/null:1:0: error: cannot open /dev/null.gcno
>> make[5]: *** [../drivers/gpu/drm/i915/Makefile:307:
>> drivers/gpu/drm/i915/display/intel_ddi.hdrtest] Error 1
>> make[5]: *** Waiting for unfinished jobs....
>> make[5]: *** [../drivers/gpu/drm/i915/Makefile:307:
>> drivers/gpu/drm/i915/display/intel_frontbuffer.hdrtest] Error 1
>> 
>> Filter out $(CFLAGS_GVOC) from the header test $(c_flags) as they don't
>> make sense here anyway.
>> 
>> References: http://lore.kernel.org/r/d8112767-4089-4c58-d7d3-2ce03139858a@infradead.org
>> Reported-by: Randy Dunlap <rdunlap@infradead.org>
>> Fixes: c6d4a099a240 ("drm/i915: reimplement header test feature")
>> Cc: Masahiro Yamada <masahiroy@kernel.org>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested

And pushed, thanks for the ack.

BR,
Jani.

>
> Thanks.
>
>> ---
>>  drivers/gpu/drm/i915/Makefile | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile
>> index b314d44ded5e..bc28c31c4f78 100644
>> --- a/drivers/gpu/drm/i915/Makefile
>> +++ b/drivers/gpu/drm/i915/Makefile
>> @@ -301,7 +301,7 @@ extra-$(CONFIG_DRM_I915_WERROR) += \
>>  		$(shell cd $(srctree)/$(src) && find * -name '*.h')))
>>  
>>  quiet_cmd_hdrtest = HDRTEST $(patsubst %.hdrtest,%.h,$@)
>> -      cmd_hdrtest = $(CC) $(c_flags) -S -o /dev/null -x c /dev/null -include $<; touch $@
>> +      cmd_hdrtest = $(CC) $(filter-out $(CFLAGS_GCOV), $(c_flags)) -S -o /dev/null -x c /dev/null -include $<; touch $@
>>  
>>  $(obj)/%.hdrtest: $(src)/%.h FORCE
>>  	$(call if_changed_dep,hdrtest)
>> 

-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2020-02-24 12:22 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-21 10:54 [Intel-gfx] [PATCH] drm/i915: fix header test with GCOV Jani Nikula
2020-02-21 15:59 ` Randy Dunlap
2020-02-24 12:22   ` Jani Nikula [this message]
2020-02-21 18:03 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2020-02-21 18:28 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-02-22  4:43 ` [Intel-gfx] [PATCH] " Masahiro Yamada
2020-02-22  4:53   ` Masahiro Yamada
2020-02-22  5:25     ` Randy Dunlap
2020-02-22  5:49       ` Masahiro Yamada
2020-02-22  5:53         ` Randy Dunlap
2020-02-24 12:29           ` Jani Nikula
2020-02-24 11:54 ` [Intel-gfx] ✓ Fi.CI.IGT: success for " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k14ctbsn.fsf@intel.com \
    --to=jani.nikula@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=masahiroy@kernel.org \
    --cc=rdunlap@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox