Re: [PATCH v2 1/4] drm/dp: Add a way to init/add a connector in separate steps

[Jani Nikula <jani.nikula@intel.com>]

On Mon, 02 Dec 2024, Maxime Ripard <mripard@kernel.org> wrote:
> It's not about whether we have a problem or not: you introduce new
> framework functions, you need to have kunit tests to check their
> behaviour.

I don't fundamentally disagree with that goal, but it does seem like a
pretty drastic policy change. I don't recall a discussion where we made
that decision, nor can I find any documentation stating this. Or what
exactly the requirement is; it's totally unclear to me.

Had I been involved, I would've pointed out that while adding tests is
good, it inevitably increases the friction of adding new stuff to drm
core. It's super tempting for people to just get their jobs done. If
doing the right thing adds yet another hurdle, we may see more stuff
being added in drivers instead of drm core.

(Case in point, we already hacked around the problem being solved here
with commit d58f65df2dcb ("drm/i915/dp_mst: Fix connector initialization
in intel_dp_add_mst_connector()"). We could've just dropped the ball
right there.)

BR,
Jani.


-- 
Jani Nikula, Intel