[PATCH] drm/i915/display: Maintain alphabetical order for HAS_AS_SDP and HAS_CMRR

[PATCH] drm/i915/display: Maintain alphabetical order for HAS_AS_SDP and HAS_CMRR

[Ankit Nautiyal]

Reorder the macros HAS_AS_SDP and HAS_CMRR as per alphabetical order.

Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
---
 drivers/gpu/drm/i915/display/intel_display_device.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_display_device.h b/drivers/gpu/drm/i915/display/intel_display_device.h
index 717286981687..332647c4ca81 100644
--- a/drivers/gpu/drm/i915/display/intel_display_device.h
+++ b/drivers/gpu/drm/i915/display/intel_display_device.h
@@ -142,10 +142,12 @@ struct intel_display_platforms {
 	func(supports_tv);
 
 #define HAS_4TILE(__display)		((__display)->platform.dg2 || DISPLAY_VER(__display) >= 14)
+#define HAS_AS_SDP(__display)		(DISPLAY_VER(__display) >= 13)
 #define HAS_ASYNC_FLIPS(__display)	(DISPLAY_VER(__display) >= 5)
 #define HAS_BIGJOINER(__display)	(DISPLAY_VER(__display) >= 11 && HAS_DSC(__display))
 #define HAS_CDCLK_CRAWL(__display)	(DISPLAY_INFO(__display)->has_cdclk_crawl)
 #define HAS_CDCLK_SQUASH(__display)	(DISPLAY_INFO(__display)->has_cdclk_squash)
+#define HAS_CMRR(__display)		(DISPLAY_VER(__display) >= 20)
 #define HAS_CMTG(__display)		(!(__display)->platform.dg2 && DISPLAY_VER(__display) >= 13)
 #define HAS_CUR_FBC(__display)		(!HAS_GMCH(__display) && IS_DISPLAY_VER(__display, 7, 13))
 #define HAS_D12_PLANE_MINIMIZATION(__display)	((__display)->platform.rocketlake || (__display)->platform.alderlake_s)
@@ -189,8 +191,6 @@ struct intel_display_platforms {
 					  ((__display)->platform.dgfx && DISPLAY_VER(__display) == 14)) && \
 					 HAS_DSC(__display))
 #define HAS_VRR(__display)		(DISPLAY_VER(__display) >= 11)
-#define HAS_AS_SDP(__display)		(DISPLAY_VER(__display) >= 13)
-#define HAS_CMRR(__display)		(DISPLAY_VER(__display) >= 20)
 #define INTEL_NUM_PIPES(__display)	(hweight8(DISPLAY_RUNTIME_INFO(__display)->pipe_mask))
 #define I915_HAS_HOTPLUG(__display)	(DISPLAY_INFO(__display)->has_hotplug)
 #define OVERLAY_NEEDS_PHYSICAL(__display)	(DISPLAY_INFO(__display)->overlay_needs_physical)
-- 
2.45.2

✗ Fi.CI.SPARSE: warning for drm/i915/display: Maintain alphabetical order for HAS_AS_SDP and HAS_CMRR

[Patchwork]

== Series Details ==

Series: drm/i915/display: Maintain alphabetical order for HAS_AS_SDP and HAS_CMRR
URL   : https://patchwork.freedesktop.org/series/146143/
State : warning

== Summary ==

Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.

Re: [PATCH] drm/i915/display: Maintain alphabetical order for HAS_AS_SDP and HAS_CMRR

[Jani Nikula]

On Tue, 11 Mar 2025, Ankit Nautiyal <ankit.k.nautiyal@intel.com> wrote:
> Reorder the macros HAS_AS_SDP and HAS_CMRR as per alphabetical order.
>
> Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_display_device.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display_device.h b/drivers/gpu/drm/i915/display/intel_display_device.h
> index 717286981687..332647c4ca81 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_device.h
> +++ b/drivers/gpu/drm/i915/display/intel_display_device.h
> @@ -142,10 +142,12 @@ struct intel_display_platforms {
>  	func(supports_tv);
>  
>  #define HAS_4TILE(__display)		((__display)->platform.dg2 || DISPLAY_VER(__display) >= 14)
> +#define HAS_AS_SDP(__display)		(DISPLAY_VER(__display) >= 13)
>  #define HAS_ASYNC_FLIPS(__display)	(DISPLAY_VER(__display) >= 5)

Y comes before _ in asciibetical order.

BR,
Jani.

>  #define HAS_BIGJOINER(__display)	(DISPLAY_VER(__display) >= 11 && HAS_DSC(__display))
>  #define HAS_CDCLK_CRAWL(__display)	(DISPLAY_INFO(__display)->has_cdclk_crawl)
>  #define HAS_CDCLK_SQUASH(__display)	(DISPLAY_INFO(__display)->has_cdclk_squash)
> +#define HAS_CMRR(__display)		(DISPLAY_VER(__display) >= 20)
>  #define HAS_CMTG(__display)		(!(__display)->platform.dg2 && DISPLAY_VER(__display) >= 13)
>  #define HAS_CUR_FBC(__display)		(!HAS_GMCH(__display) && IS_DISPLAY_VER(__display, 7, 13))
>  #define HAS_D12_PLANE_MINIMIZATION(__display)	((__display)->platform.rocketlake || (__display)->platform.alderlake_s)
> @@ -189,8 +191,6 @@ struct intel_display_platforms {
>  					  ((__display)->platform.dgfx && DISPLAY_VER(__display) == 14)) && \
>  					 HAS_DSC(__display))
>  #define HAS_VRR(__display)		(DISPLAY_VER(__display) >= 11)
> -#define HAS_AS_SDP(__display)		(DISPLAY_VER(__display) >= 13)
> -#define HAS_CMRR(__display)		(DISPLAY_VER(__display) >= 20)
>  #define INTEL_NUM_PIPES(__display)	(hweight8(DISPLAY_RUNTIME_INFO(__display)->pipe_mask))
>  #define I915_HAS_HOTPLUG(__display)	(DISPLAY_INFO(__display)->has_hotplug)
>  #define OVERLAY_NEEDS_PHYSICAL(__display)	(DISPLAY_INFO(__display)->overlay_needs_physical)

-- 
Jani Nikula, Intel

Re: [PATCH] drm/i915/display: Maintain alphabetical order for HAS_AS_SDP and HAS_CMRR

[Nautiyal, Ankit K]

On 3/11/2025 11:38 PM, Jani Nikula wrote:
> On Tue, 11 Mar 2025, Ankit Nautiyal <ankit.k.nautiyal@intel.com> wrote:
>> Reorder the macros HAS_AS_SDP and HAS_CMRR as per alphabetical order.
>>
>> Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
>> ---
>>   drivers/gpu/drm/i915/display/intel_display_device.h | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_display_device.h b/drivers/gpu/drm/i915/display/intel_display_device.h
>> index 717286981687..332647c4ca81 100644
>> --- a/drivers/gpu/drm/i915/display/intel_display_device.h
>> +++ b/drivers/gpu/drm/i915/display/intel_display_device.h
>> @@ -142,10 +142,12 @@ struct intel_display_platforms {
>>   	func(supports_tv);
>>   
>>   #define HAS_4TILE(__display)		((__display)->platform.dg2 || DISPLAY_VER(__display) >= 14)
>> +#define HAS_AS_SDP(__display)		(DISPLAY_VER(__display) >= 13)
>>   #define HAS_ASYNC_FLIPS(__display)	(DISPLAY_VER(__display) >= 5)
> Y comes before _ in asciibetical order.

Thanks for pointing this out. I had a misconception that we use _ as 
delimiter and sort the words in alphabetical order.

Will correct this as per asciibetical order.

Also will change :

HAS_DP_MST
HAS_DP20
HAS_DPT

to:

HAS_DP20
HAS_DPT
HAS_DP_MST

Regards,

Ankit

>
> BR,
> Jani.
>
>>   #define HAS_BIGJOINER(__display)	(DISPLAY_VER(__display) >= 11 && HAS_DSC(__display))
>>   #define HAS_CDCLK_CRAWL(__display)	(DISPLAY_INFO(__display)->has_cdclk_crawl)
>>   #define HAS_CDCLK_SQUASH(__display)	(DISPLAY_INFO(__display)->has_cdclk_squash)
>> +#define HAS_CMRR(__display)		(DISPLAY_VER(__display) >= 20)
>>   #define HAS_CMTG(__display)		(!(__display)->platform.dg2 && DISPLAY_VER(__display) >= 13)
>>   #define HAS_CUR_FBC(__display)		(!HAS_GMCH(__display) && IS_DISPLAY_VER(__display, 7, 13))
>>   #define HAS_D12_PLANE_MINIMIZATION(__display)	((__display)->platform.rocketlake || (__display)->platform.alderlake_s)
>> @@ -189,8 +191,6 @@ struct intel_display_platforms {
>>   					  ((__display)->platform.dgfx && DISPLAY_VER(__display) == 14)) && \
>>   					 HAS_DSC(__display))
>>   #define HAS_VRR(__display)		(DISPLAY_VER(__display) >= 11)
>> -#define HAS_AS_SDP(__display)		(DISPLAY_VER(__display) >= 13)
>> -#define HAS_CMRR(__display)		(DISPLAY_VER(__display) >= 20)
>>   #define INTEL_NUM_PIPES(__display)	(hweight8(DISPLAY_RUNTIME_INFO(__display)->pipe_mask))
>>   #define I915_HAS_HOTPLUG(__display)	(DISPLAY_INFO(__display)->has_hotplug)
>>   #define OVERLAY_NEEDS_PHYSICAL(__display)	(DISPLAY_INFO(__display)->overlay_needs_physical)

Re: [PATCH] drm/i915/display: Maintain alphabetical order for HAS_AS_SDP and HAS_CMRR

[Jani Nikula]

On Wed, 12 Mar 2025, "Nautiyal, Ankit K" <ankit.k.nautiyal@intel.com> wrote:
> On 3/11/2025 11:38 PM, Jani Nikula wrote:
>> On Tue, 11 Mar 2025, Ankit Nautiyal <ankit.k.nautiyal@intel.com> wrote:
>>> Reorder the macros HAS_AS_SDP and HAS_CMRR as per alphabetical order.
>>>
>>> Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
>>> ---
>>>   drivers/gpu/drm/i915/display/intel_display_device.h | 4 ++--
>>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/i915/display/intel_display_device.h b/drivers/gpu/drm/i915/display/intel_display_device.h
>>> index 717286981687..332647c4ca81 100644
>>> --- a/drivers/gpu/drm/i915/display/intel_display_device.h
>>> +++ b/drivers/gpu/drm/i915/display/intel_display_device.h
>>> @@ -142,10 +142,12 @@ struct intel_display_platforms {
>>>   	func(supports_tv);
>>>   
>>>   #define HAS_4TILE(__display)		((__display)->platform.dg2 || DISPLAY_VER(__display) >= 14)
>>> +#define HAS_AS_SDP(__display)		(DISPLAY_VER(__display) >= 13)
>>>   #define HAS_ASYNC_FLIPS(__display)	(DISPLAY_VER(__display) >= 5)
>> Y comes before _ in asciibetical order.
>
> Thanks for pointing this out. I had a misconception that we use _ as 
> delimiter and sort the words in alphabetical order.

Emacs M-x sort-lines is the definition for me. ;)

BR,
Jani.


>
> Will correct this as per asciibetical order.
>
> Also will change :
>
> HAS_DP_MST
> HAS_DP20
> HAS_DPT
>
> to:
>
> HAS_DP20
> HAS_DPT
> HAS_DP_MST
>
> Regards,
>
> Ankit
>
>>
>> BR,
>> Jani.
>>
>>>   #define HAS_BIGJOINER(__display)	(DISPLAY_VER(__display) >= 11 && HAS_DSC(__display))
>>>   #define HAS_CDCLK_CRAWL(__display)	(DISPLAY_INFO(__display)->has_cdclk_crawl)
>>>   #define HAS_CDCLK_SQUASH(__display)	(DISPLAY_INFO(__display)->has_cdclk_squash)
>>> +#define HAS_CMRR(__display)		(DISPLAY_VER(__display) >= 20)
>>>   #define HAS_CMTG(__display)		(!(__display)->platform.dg2 && DISPLAY_VER(__display) >= 13)
>>>   #define HAS_CUR_FBC(__display)		(!HAS_GMCH(__display) && IS_DISPLAY_VER(__display, 7, 13))
>>>   #define HAS_D12_PLANE_MINIMIZATION(__display)	((__display)->platform.rocketlake || (__display)->platform.alderlake_s)
>>> @@ -189,8 +191,6 @@ struct intel_display_platforms {
>>>   					  ((__display)->platform.dgfx && DISPLAY_VER(__display) == 14)) && \
>>>   					 HAS_DSC(__display))
>>>   #define HAS_VRR(__display)		(DISPLAY_VER(__display) >= 11)
>>> -#define HAS_AS_SDP(__display)		(DISPLAY_VER(__display) >= 13)
>>> -#define HAS_CMRR(__display)		(DISPLAY_VER(__display) >= 20)
>>>   #define INTEL_NUM_PIPES(__display)	(hweight8(DISPLAY_RUNTIME_INFO(__display)->pipe_mask))
>>>   #define I915_HAS_HOTPLUG(__display)	(DISPLAY_INFO(__display)->has_hotplug)
>>>   #define OVERLAY_NEEDS_PHYSICAL(__display)	(DISPLAY_INFO(__display)->overlay_needs_physical)

-- 
Jani Nikula, Intel

Re: [PATCH] drm/i915/display: Maintain alphabetical order for HAS_AS_SDP and HAS_CMRR

[Lucas De Marchi]

On Wed, Mar 12, 2025 at 01:25:28PM +0200, Jani Nikula wrote:
>On Wed, 12 Mar 2025, "Nautiyal, Ankit K" <ankit.k.nautiyal@intel.com> wrote:
>> On 3/11/2025 11:38 PM, Jani Nikula wrote:
>>> On Tue, 11 Mar 2025, Ankit Nautiyal <ankit.k.nautiyal@intel.com> wrote:
>>>> Reorder the macros HAS_AS_SDP and HAS_CMRR as per alphabetical order.
>>>>
>>>> Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
>>>> ---
>>>>   drivers/gpu/drm/i915/display/intel_display_device.h | 4 ++--
>>>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/drivers/gpu/drm/i915/display/intel_display_device.h b/drivers/gpu/drm/i915/display/intel_display_device.h
>>>> index 717286981687..332647c4ca81 100644
>>>> --- a/drivers/gpu/drm/i915/display/intel_display_device.h
>>>> +++ b/drivers/gpu/drm/i915/display/intel_display_device.h
>>>> @@ -142,10 +142,12 @@ struct intel_display_platforms {
>>>>   	func(supports_tv);
>>>>
>>>>   #define HAS_4TILE(__display)		((__display)->platform.dg2 || DISPLAY_VER(__display) >= 14)
>>>> +#define HAS_AS_SDP(__display)		(DISPLAY_VER(__display) >= 13)
>>>>   #define HAS_ASYNC_FLIPS(__display)	(DISPLAY_VER(__display) >= 5)
>>> Y comes before _ in asciibetical order.
>>
>> Thanks for pointing this out. I had a misconception that we use _ as
>> delimiter and sort the words in alphabetical order.
>
>Emacs M-x sort-lines is the definition for me. ;)

`LANG=C sort -u` and it works in vim and anywhere else :).  -u because
we also don't want duplicate lines.

Lucas De Marchi

Re: [PATCH] drm/i915/display: Maintain alphabetical order for HAS_AS_SDP and HAS_CMRR

[Gustavo Sousa]

Quoting Jani Nikula (2025-03-11 15:08:48-03:00)
>On Tue, 11 Mar 2025, Ankit Nautiyal <ankit.k.nautiyal@intel.com> wrote:
>> Reorder the macros HAS_AS_SDP and HAS_CMRR as per alphabetical order.
>>
>> Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
>> ---
>>  drivers/gpu/drm/i915/display/intel_display_device.h | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_display_device.h b/drivers/gpu/drm/i915/display/intel_display_device.h
>> index 717286981687..332647c4ca81 100644
>> --- a/drivers/gpu/drm/i915/display/intel_display_device.h
>> +++ b/drivers/gpu/drm/i915/display/intel_display_device.h
>> @@ -142,10 +142,12 @@ struct intel_display_platforms {
>>          func(supports_tv);
>>  
>>  #define HAS_4TILE(__display)                ((__display)->platform.dg2 || DISPLAY_VER(__display) >= 14)
>> +#define HAS_AS_SDP(__display)                (DISPLAY_VER(__display) >= 13)
>>  #define HAS_ASYNC_FLIPS(__display)        (DISPLAY_VER(__display) >= 5)
>
>Y comes before _ in asciibetical order.

Maybe that's just me, but I feel that's counter-intuitive in a context
where we use _ to separate words.

--
Gustavo Sousa

>
>BR,
>Jani.
>
>>  #define HAS_BIGJOINER(__display)        (DISPLAY_VER(__display) >= 11 && HAS_DSC(__display))
>>  #define HAS_CDCLK_CRAWL(__display)        (DISPLAY_INFO(__display)->has_cdclk_crawl)
>>  #define HAS_CDCLK_SQUASH(__display)        (DISPLAY_INFO(__display)->has_cdclk_squash)
>> +#define HAS_CMRR(__display)                (DISPLAY_VER(__display) >= 20)
>>  #define HAS_CMTG(__display)                (!(__display)->platform.dg2 && DISPLAY_VER(__display) >= 13)
>>  #define HAS_CUR_FBC(__display)                (!HAS_GMCH(__display) && IS_DISPLAY_VER(__display, 7, 13))
>>  #define HAS_D12_PLANE_MINIMIZATION(__display)        ((__display)->platform.rocketlake || (__display)->platform.alderlake_s)
>> @@ -189,8 +191,6 @@ struct intel_display_platforms {
>>                                            ((__display)->platform.dgfx && DISPLAY_VER(__display) == 14)) && \
>>                                           HAS_DSC(__display))
>>  #define HAS_VRR(__display)                (DISPLAY_VER(__display) >= 11)
>> -#define HAS_AS_SDP(__display)                (DISPLAY_VER(__display) >= 13)
>> -#define HAS_CMRR(__display)                (DISPLAY_VER(__display) >= 20)
>>  #define INTEL_NUM_PIPES(__display)        (hweight8(DISPLAY_RUNTIME_INFO(__display)->pipe_mask))
>>  #define I915_HAS_HOTPLUG(__display)        (DISPLAY_INFO(__display)->has_hotplug)
>>  #define OVERLAY_NEEDS_PHYSICAL(__display)        (DISPLAY_INFO(__display)->overlay_needs_physical)
>
>-- 
>Jani Nikula, Intel

Re: [PATCH] drm/i915/display: Maintain alphabetical order for HAS_AS_SDP and HAS_CMRR

[Nautiyal, Ankit K]

On 3/12/2025 10:37 PM, Gustavo Sousa wrote:
> Quoting Jani Nikula (2025-03-11 15:08:48-03:00)
>> On Tue, 11 Mar 2025, Ankit Nautiyal <ankit.k.nautiyal@intel.com> wrote:
>>> Reorder the macros HAS_AS_SDP and HAS_CMRR as per alphabetical order.
>>>
>>> Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
>>> ---
>>>   drivers/gpu/drm/i915/display/intel_display_device.h | 4 ++--
>>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/i915/display/intel_display_device.h b/drivers/gpu/drm/i915/display/intel_display_device.h
>>> index 717286981687..332647c4ca81 100644
>>> --- a/drivers/gpu/drm/i915/display/intel_display_device.h
>>> +++ b/drivers/gpu/drm/i915/display/intel_display_device.h
>>> @@ -142,10 +142,12 @@ struct intel_display_platforms {
>>>           func(supports_tv);
>>>   
>>>   #define HAS_4TILE(__display)                ((__display)->platform.dg2 || DISPLAY_VER(__display) >= 14)
>>> +#define HAS_AS_SDP(__display)                (DISPLAY_VER(__display) >= 13)
>>>   #define HAS_ASYNC_FLIPS(__display)        (DISPLAY_VER(__display) >= 5)
>> Y comes before _ in asciibetical order.
> Maybe that's just me, but I feel that's counter-intuitive in a context
> where we use _ to separate words.

I do agree. I was assuming that we sort the words separated by '_' as 
delimiter.

For a given hypothetical list, I thought the ordering will result in 
similar items grouped together

(please forgive me for making up silly names here)

HAS_HD
HAS_HD_AUDIO
HAS_HD_DISPLAY
HAS_HD_SUPPORT
HAS_HDMI
HAS_HDMI_PCON
HAS_HDR

But with the `sort` command it will be:

HAS_HD
HAS_HDMI
HAS_HDMI_PCON
HAS_HDR
HAS_HD_AUDIO
HAS_HD_DISPLAY
HAS_HD_SUPPORT

However, if majority of folks use editor's sort command it becomes 
simpler to have the ASCII ordering for everyone.


Regards,

Ankit


>
> --
> Gustavo Sousa
>
>> BR,
>> Jani.
>>
>>>   #define HAS_BIGJOINER(__display)        (DISPLAY_VER(__display) >= 11 && HAS_DSC(__display))
>>>   #define HAS_CDCLK_CRAWL(__display)        (DISPLAY_INFO(__display)->has_cdclk_crawl)
>>>   #define HAS_CDCLK_SQUASH(__display)        (DISPLAY_INFO(__display)->has_cdclk_squash)
>>> +#define HAS_CMRR(__display)                (DISPLAY_VER(__display) >= 20)
>>>   #define HAS_CMTG(__display)                (!(__display)->platform.dg2 && DISPLAY_VER(__display) >= 13)
>>>   #define HAS_CUR_FBC(__display)                (!HAS_GMCH(__display) && IS_DISPLAY_VER(__display, 7, 13))
>>>   #define HAS_D12_PLANE_MINIMIZATION(__display)        ((__display)->platform.rocketlake || (__display)->platform.alderlake_s)
>>> @@ -189,8 +191,6 @@ struct intel_display_platforms {
>>>                                             ((__display)->platform.dgfx && DISPLAY_VER(__display) == 14)) && \
>>>                                            HAS_DSC(__display))
>>>   #define HAS_VRR(__display)                (DISPLAY_VER(__display) >= 11)
>>> -#define HAS_AS_SDP(__display)                (DISPLAY_VER(__display) >= 13)
>>> -#define HAS_CMRR(__display)                (DISPLAY_VER(__display) >= 20)
>>>   #define INTEL_NUM_PIPES(__display)        (hweight8(DISPLAY_RUNTIME_INFO(__display)->pipe_mask))
>>>   #define I915_HAS_HOTPLUG(__display)        (DISPLAY_INFO(__display)->has_hotplug)
>>>   #define OVERLAY_NEEDS_PHYSICAL(__display)        (DISPLAY_INFO(__display)->overlay_needs_physical)
>> -- 
>> Jani Nikula, Intel

Re: [PATCH] drm/i915/display: Maintain alphabetical order for HAS_AS_SDP and HAS_CMRR

[Lucas De Marchi]

On Thu, Mar 13, 2025 at 10:08:30AM +0530, Nautiyal, Ankit K wrote:
>
>On 3/12/2025 10:37 PM, Gustavo Sousa wrote:
>>Quoting Jani Nikula (2025-03-11 15:08:48-03:00)
>>>On Tue, 11 Mar 2025, Ankit Nautiyal <ankit.k.nautiyal@intel.com> wrote:
>>>>Reorder the macros HAS_AS_SDP and HAS_CMRR as per alphabetical order.
>>>>
>>>>Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
>>>>---
>>>>  drivers/gpu/drm/i915/display/intel_display_device.h | 4 ++--
>>>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>>>
>>>>diff --git a/drivers/gpu/drm/i915/display/intel_display_device.h b/drivers/gpu/drm/i915/display/intel_display_device.h
>>>>index 717286981687..332647c4ca81 100644
>>>>--- a/drivers/gpu/drm/i915/display/intel_display_device.h
>>>>+++ b/drivers/gpu/drm/i915/display/intel_display_device.h
>>>>@@ -142,10 +142,12 @@ struct intel_display_platforms {
>>>>          func(supports_tv);
>>>>  #define HAS_4TILE(__display)                ((__display)->platform.dg2 || DISPLAY_VER(__display) >= 14)
>>>>+#define HAS_AS_SDP(__display)                (DISPLAY_VER(__display) >= 13)
>>>>  #define HAS_ASYNC_FLIPS(__display)        (DISPLAY_VER(__display) >= 5)
>>>Y comes before _ in asciibetical order.
>>Maybe that's just me, but I feel that's counter-intuitive in a context
>>where we use _ to separate words.
>
>I do agree. I was assuming that we sort the words separated by '_' as 
>delimiter.
>
>For a given hypothetical list, I thought the ordering will result in 
>similar items grouped together
>
>(please forgive me for making up silly names here)
>
>HAS_HD
>HAS_HD_AUDIO
>HAS_HD_DISPLAY
>HAS_HD_SUPPORT
>HAS_HDMI
>HAS_HDMI_PCON
>HAS_HDR
>
>But with the `sort` command it will be:
>
>HAS_HD
>HAS_HDMI
>HAS_HDMI_PCON
>HAS_HDR
>HAS_HD_AUDIO
>HAS_HD_DISPLAY
>HAS_HD_SUPPORT
>
>However, if majority of folks use editor's sort command it becomes 
>simpler to have the ASCII ordering for everyone.

we would need another command to do "the right thing", for whatever
definition of "right" we want.  Not sure if it's worth pursuing as the
sort is also used in other places like includes and build objects in
the Makefile. Would we change all of them?

Lucas De Marchi

Re: [PATCH] drm/i915/display: Maintain alphabetical order for HAS_AS_SDP and HAS_CMRR

[Nautiyal, Ankit K]

On 3/13/2025 10:15 AM, Lucas De Marchi wrote:
> On Thu, Mar 13, 2025 at 10:08:30AM +0530, Nautiyal, Ankit K wrote:
>>
>> On 3/12/2025 10:37 PM, Gustavo Sousa wrote:
>>> Quoting Jani Nikula (2025-03-11 15:08:48-03:00)
>>>> On Tue, 11 Mar 2025, Ankit Nautiyal <ankit.k.nautiyal@intel.com> 
>>>> wrote:
>>>>> Reorder the macros HAS_AS_SDP and HAS_CMRR as per alphabetical order.
>>>>>
>>>>> Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
>>>>> ---
>>>>>  drivers/gpu/drm/i915/display/intel_display_device.h | 4 ++--
>>>>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>>>>
>>>>> diff --git a/drivers/gpu/drm/i915/display/intel_display_device.h 
>>>>> b/drivers/gpu/drm/i915/display/intel_display_device.h
>>>>> index 717286981687..332647c4ca81 100644
>>>>> --- a/drivers/gpu/drm/i915/display/intel_display_device.h
>>>>> +++ b/drivers/gpu/drm/i915/display/intel_display_device.h
>>>>> @@ -142,10 +142,12 @@ struct intel_display_platforms {
>>>>>          func(supports_tv);
>>>>>  #define HAS_4TILE(__display) ((__display)->platform.dg2 || 
>>>>> DISPLAY_VER(__display) >= 14)
>>>>> +#define HAS_AS_SDP(__display) (DISPLAY_VER(__display) >= 13)
>>>>>  #define HAS_ASYNC_FLIPS(__display) (DISPLAY_VER(__display) >= 5)
>>>> Y comes before _ in asciibetical order.
>>> Maybe that's just me, but I feel that's counter-intuitive in a context
>>> where we use _ to separate words.
>>
>> I do agree. I was assuming that we sort the words separated by '_' as 
>> delimiter.
>>
>> For a given hypothetical list, I thought the ordering will result in 
>> similar items grouped together
>>
>> (please forgive me for making up silly names here)
>>
>> HAS_HD
>> HAS_HD_AUDIO
>> HAS_HD_DISPLAY
>> HAS_HD_SUPPORT
>> HAS_HDMI
>> HAS_HDMI_PCON
>> HAS_HDR
>>
>> But with the `sort` command it will be:
>>
>> HAS_HD
>> HAS_HDMI
>> HAS_HDMI_PCON
>> HAS_HDR
>> HAS_HD_AUDIO
>> HAS_HD_DISPLAY
>> HAS_HD_SUPPORT
>>
>> However, if majority of folks use editor's sort command it becomes 
>> simpler to have the ASCII ordering for everyone.
>
> we would need another command to do "the right thing", for whatever
> definition of "right" we want.  Not sure if it's worth pursuing as the
> sort is also used in other places like includes and build objects in
> the Makefile. Would we change all of them?

You are right. I understand the importance of maintaining consistency. 
With that in mind, have also sent updated patch: 
https://patchwork.freedesktop.org/patch/642578/?series=146185&rev=1

Just to clarify, the example I provided was meant to show my thought 
process rather than to define the right way to sort.

Thanks for your input and the tip for vim too.


Regards,

Ankit

>
> Lucas De Marchi

Re: [PATCH] drm/i915/display: Maintain alphabetical order for HAS_AS_SDP and HAS_CMRR

[Jani Nikula]

On Wed, 12 Mar 2025, Lucas De Marchi <lucas.demarchi@intel.com> wrote:
> On Thu, Mar 13, 2025 at 10:08:30AM +0530, Nautiyal, Ankit K wrote:
>>
>>On 3/12/2025 10:37 PM, Gustavo Sousa wrote:
>>>Quoting Jani Nikula (2025-03-11 15:08:48-03:00)
>>>>On Tue, 11 Mar 2025, Ankit Nautiyal <ankit.k.nautiyal@intel.com> wrote:
>>>>>Reorder the macros HAS_AS_SDP and HAS_CMRR as per alphabetical order.
>>>>>
>>>>>Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
>>>>>---
>>>>>  drivers/gpu/drm/i915/display/intel_display_device.h | 4 ++--
>>>>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>>>>
>>>>>diff --git a/drivers/gpu/drm/i915/display/intel_display_device.h b/drivers/gpu/drm/i915/display/intel_display_device.h
>>>>>index 717286981687..332647c4ca81 100644
>>>>>--- a/drivers/gpu/drm/i915/display/intel_display_device.h
>>>>>+++ b/drivers/gpu/drm/i915/display/intel_display_device.h
>>>>>@@ -142,10 +142,12 @@ struct intel_display_platforms {
>>>>>          func(supports_tv);
>>>>>  #define HAS_4TILE(__display)                ((__display)->platform.dg2 || DISPLAY_VER(__display) >= 14)
>>>>>+#define HAS_AS_SDP(__display)                (DISPLAY_VER(__display) >= 13)
>>>>>  #define HAS_ASYNC_FLIPS(__display)        (DISPLAY_VER(__display) >= 5)
>>>>Y comes before _ in asciibetical order.
>>>Maybe that's just me, but I feel that's counter-intuitive in a context
>>>where we use _ to separate words.
>>
>>I do agree. I was assuming that we sort the words separated by '_' as 
>>delimiter.
>>
>>For a given hypothetical list, I thought the ordering will result in 
>>similar items grouped together
>>
>>(please forgive me for making up silly names here)
>>
>>HAS_HD
>>HAS_HD_AUDIO
>>HAS_HD_DISPLAY
>>HAS_HD_SUPPORT
>>HAS_HDMI
>>HAS_HDMI_PCON
>>HAS_HDR
>>
>>But with the `sort` command it will be:
>>
>>HAS_HD
>>HAS_HDMI
>>HAS_HDMI_PCON
>>HAS_HDR
>>HAS_HD_AUDIO
>>HAS_HD_DISPLAY
>>HAS_HD_SUPPORT
>>
>>However, if majority of folks use editor's sort command it becomes 
>>simpler to have the ASCII ordering for everyone.
>
> we would need another command to do "the right thing", for whatever
> definition of "right" we want.  Not sure if it's worth pursuing as the
> sort is also used in other places like includes and build objects in
> the Makefile. Would we change all of them?

This.

Just use what the common tools do as the default, and go with that.


BR,
Jani.

-- 
Jani Nikula, Intel

✗ i915.CI.BAT: failure for drm/i915/display: Maintain alphabetical order for HAS_AS_SDP and HAS_CMRR

[Patchwork]

[-- Attachment #1: Type: text/plain, Size: 13740 bytes --]

== Series Details ==

Series: drm/i915/display: Maintain alphabetical order for HAS_AS_SDP and HAS_CMRR
URL   : https://patchwork.freedesktop.org/series/146143/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_16263 -> Patchwork_146143v1
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with Patchwork_146143v1 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_146143v1, please notify your bug team (I915-ci-infra@lists.freedesktop.org) to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_146143v1/index.html

Participating hosts (43 -> 43)
------------------------------

  Additional (1): bat-arlh-2 
  Missing    (1): fi-snb-2520m 

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in Patchwork_146143v1:

### IGT changes ###

#### Possible regressions ####

  * igt@i915_pm_rpm@module-reload:
    - bat-dg1-7:          [PASS][1] -> [FAIL][2]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16263/bat-dg1-7/igt@i915_pm_rpm@module-reload.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_146143v1/bat-dg1-7/igt@i915_pm_rpm@module-reload.html
    - bat-rpls-4:         [PASS][3] -> [FAIL][4]
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16263/bat-rpls-4/igt@i915_pm_rpm@module-reload.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_146143v1/bat-rpls-4/igt@i915_pm_rpm@module-reload.html

  * igt@kms_addfb_basic@too-high:
    - fi-kbl-8809g:       NOTRUN -> [FAIL][5] +3 other tests fail
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_146143v1/fi-kbl-8809g/igt@kms_addfb_basic@too-high.html

  * igt@kms_force_connector_basic@force-connector-state:
    - fi-kbl-8809g:       NOTRUN -> [DMESG-WARN][6]
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_146143v1/fi-kbl-8809g/igt@kms_force_connector_basic@force-connector-state.html

  * igt@kms_force_connector_basic@force-edid:
    - fi-kbl-8809g:       NOTRUN -> [DMESG-FAIL][7]
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_146143v1/fi-kbl-8809g/igt@kms_force_connector_basic@force-edid.html

  
New tests
---------

  New tests have been introduced between CI_DRM_16263 and Patchwork_146143v1:

### New IGT tests (1) ###

  * igt@core_auth:
    - Statuses :
    - Exec time: [None] s

  

Known issues
------------

  Here are the changes found in Patchwork_146143v1 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@core_auth@basic-auth:
    - fi-kbl-8809g:       NOTRUN -> [DMESG-WARN][8] ([i915#10462]) +1 other test dmesg-warn
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_146143v1/fi-kbl-8809g/igt@core_auth@basic-auth.html

  * igt@debugfs_test@basic-hwmon:
    - bat-arlh-2:         NOTRUN -> [SKIP][9] ([i915#11346] / [i915#9318])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_146143v1/bat-arlh-2/igt@debugfs_test@basic-hwmon.html

  * igt@dmabuf@all-tests:
    - bat-apl-1:          [PASS][10] -> [INCOMPLETE][11] ([i915#12904]) +1 other test incomplete
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16263/bat-apl-1/igt@dmabuf@all-tests.html
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_146143v1/bat-apl-1/igt@dmabuf@all-tests.html

  * igt@fbdev@eof:
    - bat-arlh-2:         NOTRUN -> [SKIP][12] ([i915#11345] / [i915#11346]) +3 other tests skip
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_146143v1/bat-arlh-2/igt@fbdev@eof.html

  * igt@fbdev@info:
    - bat-arlh-2:         NOTRUN -> [SKIP][13] ([i915#11346] / [i915#1849])
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_146143v1/bat-arlh-2/igt@fbdev@info.html
    - fi-kbl-8809g:       NOTRUN -> [SKIP][14] ([i915#1849])
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_146143v1/fi-kbl-8809g/igt@fbdev@info.html

  * igt@gem_huc_copy@huc-copy:
    - fi-kbl-8809g:       NOTRUN -> [SKIP][15] ([i915#2190])
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_146143v1/fi-kbl-8809g/igt@gem_huc_copy@huc-copy.html
    - fi-skl-6600u:       NOTRUN -> [SKIP][16] ([i915#2190])
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_146143v1/fi-skl-6600u/igt@gem_huc_copy@huc-copy.html

  * igt@gem_lmem_swapping@basic:
    - bat-arlh-2:         NOTRUN -> [SKIP][17] ([i915#10213] / [i915#11346] / [i915#11671]) +3 other tests skip
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_146143v1/bat-arlh-2/igt@gem_lmem_swapping@basic.html

  * igt@gem_lmem_swapping@parallel-random-engines:
    - fi-kbl-8809g:       NOTRUN -> [SKIP][18] ([i915#4613]) +3 other tests skip
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_146143v1/fi-kbl-8809g/igt@gem_lmem_swapping@parallel-random-engines.html

  * igt@gem_lmem_swapping@random-engines:
    - fi-skl-6600u:       NOTRUN -> [SKIP][19] ([i915#4613]) +3 other tests skip
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_146143v1/fi-skl-6600u/igt@gem_lmem_swapping@random-engines.html

  * igt@gem_mmap@basic:
    - bat-arlh-2:         NOTRUN -> [SKIP][20] ([i915#11343] / [i915#11346])
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_146143v1/bat-arlh-2/igt@gem_mmap@basic.html

  * igt@gem_render_tiled_blits@basic:
    - bat-arlh-2:         NOTRUN -> [SKIP][21] ([i915#10197] / [i915#10211] / [i915#11346] / [i915#11725])
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_146143v1/bat-arlh-2/igt@gem_render_tiled_blits@basic.html

  * igt@gem_tiled_blits@basic:
    - bat-arlh-2:         NOTRUN -> [SKIP][22] ([i915#11346] / [i915#12637]) +4 other tests skip
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_146143v1/bat-arlh-2/igt@gem_tiled_blits@basic.html

  * igt@gem_tiled_pread_basic:
    - bat-arlh-2:         NOTRUN -> [SKIP][23] ([i915#10206] / [i915#11346] / [i915#11724])
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_146143v1/bat-arlh-2/igt@gem_tiled_pread_basic.html

  * igt@i915_module_load@load:
    - bat-arlh-2:         NOTRUN -> [SKIP][24] ([i915#11346]) +33 other tests skip
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_146143v1/bat-arlh-2/igt@i915_module_load@load.html

  * igt@i915_pm_rps@basic-api:
    - bat-arlh-2:         NOTRUN -> [SKIP][25] ([i915#10209] / [i915#11346] / [i915#11681])
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_146143v1/bat-arlh-2/igt@i915_pm_rps@basic-api.html

  * igt@i915_selftest@live:
    - bat-arlh-3:         [PASS][26] -> [DMESG-FAIL][27] ([i915#12061] / [i915#12435])
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16263/bat-arlh-3/igt@i915_selftest@live.html
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_146143v1/bat-arlh-3/igt@i915_selftest@live.html

  * igt@i915_selftest@live@workarounds:
    - bat-arlh-3:         [PASS][28] -> [DMESG-FAIL][29] ([i915#12061])
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16263/bat-arlh-3/igt@i915_selftest@live@workarounds.html
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_146143v1/bat-arlh-3/igt@i915_selftest@live@workarounds.html
    - bat-mtlp-6:         [PASS][30] -> [DMESG-FAIL][31] ([i915#12061]) +1 other test dmesg-fail
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16263/bat-mtlp-6/igt@i915_selftest@live@workarounds.html
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_146143v1/bat-mtlp-6/igt@i915_selftest@live@workarounds.html

  * igt@kms_addfb_basic@addfb25-y-tiled-small-legacy:
    - bat-arlh-2:         NOTRUN -> [SKIP][32] ([i915#10200] / [i915#11346] / [i915#11666] / [i915#12203])
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_146143v1/bat-arlh-2/igt@kms_addfb_basic@addfb25-y-tiled-small-legacy.html

  * igt@kms_addfb_basic@basic-x-tiled-legacy:
    - bat-arlh-2:         NOTRUN -> [SKIP][33] ([i915#10200] / [i915#11346] / [i915#11666]) +8 other tests skip
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_146143v1/bat-arlh-2/igt@kms_addfb_basic@basic-x-tiled-legacy.html

  * igt@kms_dsc@dsc-basic:
    - fi-kbl-8809g:       NOTRUN -> [SKIP][34] +62 other tests skip
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_146143v1/fi-kbl-8809g/igt@kms_dsc@dsc-basic.html
    - fi-skl-6600u:       NOTRUN -> [SKIP][35] +10 other tests skip
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_146143v1/fi-skl-6600u/igt@kms_dsc@dsc-basic.html

  * igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence:
    - bat-dg2-11:         [PASS][36] -> [SKIP][37] ([i915#9197]) +3 other tests skip
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16263/bat-dg2-11/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence.html
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_146143v1/bat-dg2-11/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence.html

  * igt@kms_setmode@basic-clone-single-crtc:
    - bat-arlh-2:         NOTRUN -> [SKIP][38] ([i915#10208] / [i915#11346] / [i915#8809])
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_146143v1/bat-arlh-2/igt@kms_setmode@basic-clone-single-crtc.html

  * igt@prime_vgem@basic-fence-read:
    - bat-arlh-2:         NOTRUN -> [SKIP][39] ([i915#10212] / [i915#11346] / [i915#11726])
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_146143v1/bat-arlh-2/igt@prime_vgem@basic-fence-read.html

  * igt@prime_vgem@basic-read:
    - bat-arlh-2:         NOTRUN -> [SKIP][40] ([i915#10214] / [i915#11346] / [i915#11726])
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_146143v1/bat-arlh-2/igt@prime_vgem@basic-read.html

  * igt@prime_vgem@basic-write:
    - bat-arlh-2:         NOTRUN -> [SKIP][41] ([i915#10216] / [i915#11346] / [i915#11723])
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_146143v1/bat-arlh-2/igt@prime_vgem@basic-write.html

  
#### Possible fixes ####

  * igt@i915_selftest@live:
    - bat-mtlp-8:         [DMESG-FAIL][42] ([i915#12061]) -> [PASS][43] +1 other test pass
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16263/bat-mtlp-8/igt@i915_selftest@live.html
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_146143v1/bat-mtlp-8/igt@i915_selftest@live.html

  * igt@i915_selftest@live@workarounds:
    - bat-mtlp-9:         [DMESG-FAIL][44] ([i915#12061]) -> [PASS][45] +1 other test pass
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16263/bat-mtlp-9/igt@i915_selftest@live@workarounds.html
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_146143v1/bat-mtlp-9/igt@i915_selftest@live@workarounds.html

  
  [i915#10197]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10197
  [i915#10200]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10200
  [i915#10206]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10206
  [i915#10208]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10208
  [i915#10209]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10209
  [i915#10211]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10211
  [i915#10212]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10212
  [i915#10213]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10213
  [i915#10214]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10214
  [i915#10216]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10216
  [i915#10462]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10462
  [i915#11343]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11343
  [i915#11345]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11345
  [i915#11346]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11346
  [i915#11666]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11666
  [i915#11671]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11671
  [i915#11681]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11681
  [i915#11723]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11723
  [i915#11724]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11724
  [i915#11725]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11725
  [i915#11726]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11726
  [i915#12061]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12061
  [i915#12203]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12203
  [i915#12435]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12435
  [i915#12637]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12637
  [i915#12904]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12904
  [i915#1849]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1849
  [i915#2190]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2190
  [i915#4613]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4613
  [i915#8809]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8809
  [i915#9197]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9197
  [i915#9318]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9318


Build changes
-------------

  * Linux: CI_DRM_16263 -> Patchwork_146143v1

  CI-20190529: 20190529
  CI_DRM_16263: f8df428b3850ed87a1e2f3b12b6025328d8a6373 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_8270: 49751c5c11723262ec66e564c76503f74a9fa831 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
  Patchwork_146143v1: f8df428b3850ed87a1e2f3b12b6025328d8a6373 @ git://anongit.freedesktop.org/gfx-ci/linux

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_146143v1/index.html

[-- Attachment #2: Type: text/html, Size: 17024 bytes --]