[Intel-gfx] [PATCH 0/4] drm/amd/display: stop using drm_edid_override_connector_update()

[Intel-gfx] [PATCH 0/4] drm/amd/display: stop using drm_edid_override_connector_update()

[Jani Nikula]

Over the past years I've been trying to unify the override and firmware
EDID handling as well as EDID property updates. It won't work if drivers
do their own random things.

BR,
Jani.


Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: Alex Hung <alex.hung@amd.com>
Cc: Chao-kai Wang <Stylon.Wang@amd.com>
Cc: Daniel Wheeler <daniel.wheeler@amd.com>
Cc: Harry Wentland <harry.wentland@amd.com>
Cc: Hersen Wu <hersenxs.wu@amd.com>
Cc: Leo Li <sunpeng.li@amd.com>
Cc: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
Cc: Wenchieh Chien <wenchieh.chien@amd.com>
Cc: David Airlie <airlied@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>

Jani Nikula (4):
  Revert "drm/amd/display: drop unused count variable in
    create_eml_sink()"
  Revert "drm/amd/display: assign edid_blob_ptr with edid from debugfs"
  Revert "drm/amd/display: mark amdgpu_dm_connector_funcs_force static"
  Revert "drm/amd/display: implement force function in
    amdgpu_dm_connector_funcs"

 .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 44 +++----------------
 1 file changed, 5 insertions(+), 39 deletions(-)

-- 
2.39.2

[Intel-gfx] [PATCH 1/4] Revert "drm/amd/display: drop unused count variable in create_eml_sink()"

[Jani Nikula]

This reverts commit 8789989b476b5f3bb0bf1a63b5223f6e76cfd13d.

Dependency for reverting the next commit cleanly.

Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: Alex Hung <alex.hung@amd.com>
Cc: Chao-kai Wang <Stylon.Wang@amd.com>
Cc: Daniel Wheeler <daniel.wheeler@amd.com>
Cc: Harry Wentland <harry.wentland@amd.com>
Cc: Hersen Wu <hersenxs.wu@amd.com>
Cc: Leo Li <sunpeng.li@amd.com>
Cc: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
Cc: Wenchieh Chien <wenchieh.chien@amd.com>
Cc: David Airlie <airlied@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index 268cb99a4c4b..3e132438bc13 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
@@ -6373,8 +6373,9 @@ static void create_eml_sink(struct amdgpu_dm_connector *aconnector)
 		/* if connector->edid_override valid, pass
 		 * it to edid_override to edid_blob_ptr
 		 */
+		int count;
 
-		drm_edid_override_connector_update(&aconnector->base);
+		count = drm_edid_override_connector_update(&aconnector->base);
 
 		if (!aconnector->base.edid_blob_ptr) {
 			DRM_ERROR("No EDID firmware found on connector: %s ,forcing to OFF!\n",
-- 
2.39.2

[Intel-gfx] [PATCH 2/4] Revert "drm/amd/display: assign edid_blob_ptr with edid from debugfs"

[Jani Nikula]

This reverts commit 550e5d23f14784e2a625c25fe0c9d498589c9256.

drm_edid_override_connector_update() is *not* supposed to be used by
drivers directly.

From the documentation:

  Only to be used from drm_helper_probe_single_connector_modes() as a
  fallback for when DDC probe failed during drm_get_edid() and caused
  the override/firmware EDID to be skipped.

It's impossible to unify firmare and override EDID handling and property
updates if drivers mess with this directly.

Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: Alex Hung <alex.hung@amd.com>
Cc: Chao-kai Wang <Stylon.Wang@amd.com>
Cc: Daniel Wheeler <daniel.wheeler@amd.com>
Cc: Harry Wentland <harry.wentland@amd.com>
Cc: Hersen Wu <hersenxs.wu@amd.com>
Cc: Leo Li <sunpeng.li@amd.com>
Cc: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
Cc: Wenchieh Chien <wenchieh.chien@amd.com>
Cc: David Airlie <airlied@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c   | 17 ++++-------------
 1 file changed, 4 insertions(+), 13 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index 3e132438bc13..c7c1260b7b6e 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
@@ -6370,20 +6370,11 @@ static void create_eml_sink(struct amdgpu_dm_connector *aconnector)
 	struct edid *edid;
 
 	if (!aconnector->base.edid_blob_ptr) {
-		/* if connector->edid_override valid, pass
-		 * it to edid_override to edid_blob_ptr
-		 */
-		int count;
-
-		count = drm_edid_override_connector_update(&aconnector->base);
-
-		if (!aconnector->base.edid_blob_ptr) {
-			DRM_ERROR("No EDID firmware found on connector: %s ,forcing to OFF!\n",
-					aconnector->base.name);
+		DRM_ERROR("No EDID firmware found on connector: %s ,forcing to OFF!\n",
+				aconnector->base.name);
 
-			aconnector->base.force = DRM_FORCE_OFF;
-			return;
-		}
+		aconnector->base.force = DRM_FORCE_OFF;
+		return;
 	}
 
 	edid = (struct edid *) aconnector->base.edid_blob_ptr->data;
-- 
2.39.2

[Intel-gfx] [PATCH 3/4] Revert "drm/amd/display: mark amdgpu_dm_connector_funcs_force static"

[Jani Nikula]

This reverts commit dae343b343ff741d727312b2a9b03d86e64b31c5.

Dependency for reverting the next commit cleanly.

Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: Alex Hung <alex.hung@amd.com>
Cc: Chao-kai Wang <Stylon.Wang@amd.com>
Cc: Daniel Wheeler <daniel.wheeler@amd.com>
Cc: Harry Wentland <harry.wentland@amd.com>
Cc: Hersen Wu <hersenxs.wu@amd.com>
Cc: Leo Li <sunpeng.li@amd.com>
Cc: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
Cc: Wenchieh Chien <wenchieh.chien@amd.com>
Cc: David Airlie <airlied@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index c7c1260b7b6e..adfe2fcb915c 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
@@ -6317,7 +6317,7 @@ amdgpu_dm_connector_late_register(struct drm_connector *connector)
 	return 0;
 }
 
-static void amdgpu_dm_connector_funcs_force(struct drm_connector *connector)
+void amdgpu_dm_connector_funcs_force(struct drm_connector *connector)
 {
 	struct amdgpu_dm_connector *aconnector = to_amdgpu_dm_connector(connector);
 	struct dc_link *dc_link = aconnector->dc_link;
-- 
2.39.2

[Intel-gfx] [PATCH 4/4] Revert "drm/amd/display: implement force function in amdgpu_dm_connector_funcs"

[Jani Nikula]

This reverts commit 0ba4a784a14592abed41873e339eab78ceb6e230.

drm_edid_override_connector_update() is *not* supposed to be used by
drivers directly.

From the documentation:

  Only to be used from drm_helper_probe_single_connector_modes() as a
  fallback for when DDC probe failed during drm_get_edid() and caused
  the override/firmware EDID to be skipped.

It's impossible to unify firmare and override EDID handling and property
updates if drivers mess with this directly.

Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: Alex Hung <alex.hung@amd.com>
Cc: Chao-kai Wang <Stylon.Wang@amd.com>
Cc: Daniel Wheeler <daniel.wheeler@amd.com>
Cc: Harry Wentland <harry.wentland@amd.com>
Cc: Hersen Wu <hersenxs.wu@amd.com>
Cc: Leo Li <sunpeng.li@amd.com>
Cc: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
Cc: Wenchieh Chien <wenchieh.chien@amd.com>
Cc: David Airlie <airlied@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 28 +------------------
 1 file changed, 1 insertion(+), 27 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index adfe2fcb915c..25151085508f 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
@@ -6317,31 +6317,6 @@ amdgpu_dm_connector_late_register(struct drm_connector *connector)
 	return 0;
 }
 
-void amdgpu_dm_connector_funcs_force(struct drm_connector *connector)
-{
-	struct amdgpu_dm_connector *aconnector = to_amdgpu_dm_connector(connector);
-	struct dc_link *dc_link = aconnector->dc_link;
-	struct dc_sink *dc_em_sink = aconnector->dc_em_sink;
-	struct edid *edid;
-
-	if (!connector->edid_override)
-		return;
-
-	drm_edid_override_connector_update(&aconnector->base);
-	edid = aconnector->base.edid_blob_ptr->data;
-	aconnector->edid = edid;
-
-	/* Update emulated (virtual) sink's EDID */
-	if (dc_em_sink && dc_link) {
-		memset(&dc_em_sink->edid_caps, 0, sizeof(struct dc_edid_caps));
-		memmove(dc_em_sink->dc_edid.raw_edid, edid, (edid->extensions + 1) * EDID_LENGTH);
-		dm_helpers_parse_edid_caps(
-			dc_link,
-			&dc_em_sink->dc_edid,
-			&dc_em_sink->edid_caps);
-	}
-}
-
 static const struct drm_connector_funcs amdgpu_dm_connector_funcs = {
 	.reset = amdgpu_dm_connector_funcs_reset,
 	.detect = amdgpu_dm_connector_detect,
@@ -6352,8 +6327,7 @@ static const struct drm_connector_funcs amdgpu_dm_connector_funcs = {
 	.atomic_set_property = amdgpu_dm_connector_atomic_set_property,
 	.atomic_get_property = amdgpu_dm_connector_atomic_get_property,
 	.late_register = amdgpu_dm_connector_late_register,
-	.early_unregister = amdgpu_dm_connector_unregister,
-	.force = amdgpu_dm_connector_funcs_force
+	.early_unregister = amdgpu_dm_connector_unregister
 };
 
 static int get_modes(struct drm_connector *connector)
-- 
2.39.2

Re: [Intel-gfx] [PATCH 4/4] Revert "drm/amd/display: implement force function in amdgpu_dm_connector_funcs"

[Jani Nikula]

On Tue, 22 Aug 2023, Jani Nikula <jani.nikula@intel.com> wrote:
> This reverts commit 0ba4a784a14592abed41873e339eab78ceb6e230.
>
> drm_edid_override_connector_update() is *not* supposed to be used by
> drivers directly.
>
> From the documentation:
>
>   Only to be used from drm_helper_probe_single_connector_modes() as a
>   fallback for when DDC probe failed during drm_get_edid() and caused
>   the override/firmware EDID to be skipped.
>
> It's impossible to unify firmare and override EDID handling and property
> updates if drivers mess with this directly.
>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: Alex Hung <alex.hung@amd.com>
> Cc: Chao-kai Wang <Stylon.Wang@amd.com>
> Cc: Daniel Wheeler <daniel.wheeler@amd.com>
> Cc: Harry Wentland <harry.wentland@amd.com>
> Cc: Hersen Wu <hersenxs.wu@amd.com>
> Cc: Leo Li <sunpeng.li@amd.com>
> Cc: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
> Cc: Wenchieh Chien <wenchieh.chien@amd.com>
> Cc: David Airlie <airlied@gmail.com>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
>  .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 28 +------------------
>  1 file changed, 1 insertion(+), 27 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index adfe2fcb915c..25151085508f 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -6317,31 +6317,6 @@ amdgpu_dm_connector_late_register(struct drm_connector *connector)
>  	return 0;
>  }
>  
> -void amdgpu_dm_connector_funcs_force(struct drm_connector *connector)
> -{
> -	struct amdgpu_dm_connector *aconnector = to_amdgpu_dm_connector(connector);
> -	struct dc_link *dc_link = aconnector->dc_link;
> -	struct dc_sink *dc_em_sink = aconnector->dc_em_sink;
> -	struct edid *edid;
> -
> -	if (!connector->edid_override)
> -		return;

This one too, also documented:

	/**
	 * @edid_override: Override EDID set via debugfs.
	 *
	 * Do not modify or access outside of the drm_edid_override_* family of
	 * functions.
	 */

> -
> -	drm_edid_override_connector_update(&aconnector->base);
> -	edid = aconnector->base.edid_blob_ptr->data;
> -	aconnector->edid = edid;
> -
> -	/* Update emulated (virtual) sink's EDID */
> -	if (dc_em_sink && dc_link) {
> -		memset(&dc_em_sink->edid_caps, 0, sizeof(struct dc_edid_caps));
> -		memmove(dc_em_sink->dc_edid.raw_edid, edid, (edid->extensions + 1) * EDID_LENGTH);
> -		dm_helpers_parse_edid_caps(
> -			dc_link,
> -			&dc_em_sink->dc_edid,
> -			&dc_em_sink->edid_caps);
> -	}
> -}
> -
>  static const struct drm_connector_funcs amdgpu_dm_connector_funcs = {
>  	.reset = amdgpu_dm_connector_funcs_reset,
>  	.detect = amdgpu_dm_connector_detect,
> @@ -6352,8 +6327,7 @@ static const struct drm_connector_funcs amdgpu_dm_connector_funcs = {
>  	.atomic_set_property = amdgpu_dm_connector_atomic_set_property,
>  	.atomic_get_property = amdgpu_dm_connector_atomic_get_property,
>  	.late_register = amdgpu_dm_connector_late_register,
> -	.early_unregister = amdgpu_dm_connector_unregister,
> -	.force = amdgpu_dm_connector_funcs_force
> +	.early_unregister = amdgpu_dm_connector_unregister
>  };
>  
>  static int get_modes(struct drm_connector *connector)

-- 
Jani Nikula, Intel Open Source Graphics Center

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/amd/display: stop using drm_edid_override_connector_update()

[Patchwork]

== Series Details ==

Series: drm/amd/display: stop using drm_edid_override_connector_update()
URL   : https://patchwork.freedesktop.org/series/122739/
State : warning

== Summary ==

Error: dim checkpatch failed
/home/kbuild2/linux/maintainer-tools/dim: line 50: /home/kbuild2/.dimrc: No such file or directory

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/amd/display: stop using drm_edid_override_connector_update()

[Patchwork]

== Series Details ==

Series: drm/amd/display: stop using drm_edid_override_connector_update()
URL   : https://patchwork.freedesktop.org/series/122739/
State : warning

== Summary ==

Error: dim sparse failed
/home/kbuild/linux/maintainer-tools/dim: line 50: /home/kbuild/.dimrc: No such file or directory

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/amd/display: stop using drm_edid_override_connector_update()

[Patchwork]

[-- Attachment #1: Type: text/plain, Size: 3319 bytes --]

== Series Details ==

Series: drm/amd/display: stop using drm_edid_override_connector_update()
URL   : https://patchwork.freedesktop.org/series/122739/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_13543 -> Patchwork_122739v1
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with Patchwork_122739v1 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_122739v1, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v1/index.html

Participating hosts (41 -> 13)
------------------------------

  ERROR: It appears as if the changes made in Patchwork_122739v1 prevented too many machines from booting.

  Missing    (28): fi-kbl-soraka fi-rkl-11600 bat-adls-5 bat-dg1-5 fi-apl-guc fi-snb-2520m fi-pnv-d510 bat-rpls-1 fi-bsw-n3050 bat-adlm-1 bat-dg2-9 fi-ilk-650 fi-hsw-4770 bat-adln-1 fi-ivb-3770 bat-jsl-3 bat-rplp-1 bat-kbl-2 bat-adlp-9 fi-skl-guc fi-glk-j4005 bat-mtlp-8 bat-jsl-1 bat-mtlp-6 fi-kbl-guc fi-cfl-8109u fi-kbl-8809g bat-dg2-14 

Known issues
------------

  Here are the changes found in Patchwork_122739v1 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@i915_suspend@basic-s3-without-i915:
    - bat-rpls-2:         [PASS][1] -> [ABORT][2] ([i915#7978] / [i915#8668])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13543/bat-rpls-2/igt@i915_suspend@basic-s3-without-i915.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v1/bat-rpls-2/igt@i915_suspend@basic-s3-without-i915.html

  
#### Possible fixes ####

  * igt@i915_selftest@live@migrate:
    - bat-atsm-1:         [DMESG-FAIL][3] ([i915#7699] / [i915#7913]) -> [PASS][4]
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13543/bat-atsm-1/igt@i915_selftest@live@migrate.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v1/bat-atsm-1/igt@i915_selftest@live@migrate.html

  
  [i915#7699]: https://gitlab.freedesktop.org/drm/intel/issues/7699
  [i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
  [i915#7978]: https://gitlab.freedesktop.org/drm/intel/issues/7978
  [i915#8668]: https://gitlab.freedesktop.org/drm/intel/issues/8668


Build changes
-------------

  * Linux: CI_DRM_13543 -> Patchwork_122739v1

  CI-20190529: 20190529
  CI_DRM_13543: f450aa57b6725458339a934f474d5a0e5cb2dce0 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_7448: 84aa6d50648d9349fb4f1520f37e5374908c9f4d @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
  Patchwork_122739v1: f450aa57b6725458339a934f474d5a0e5cb2dce0 @ git://anongit.freedesktop.org/gfx-ci/linux


### Linux commits

c5ebb77a1a8a Revert "drm/amd/display: implement force function in amdgpu_dm_connector_funcs"
35f6a108d8c0 Revert "drm/amd/display: mark amdgpu_dm_connector_funcs_force static"
fe7e98185e75 Revert "drm/amd/display: assign edid_blob_ptr with edid from debugfs"
a6ad35907d63 Revert "drm/amd/display: drop unused count variable in create_eml_sink()"

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v1/index.html

[-- Attachment #2: Type: text/html, Size: 3976 bytes --]

Re: [Intel-gfx] [PATCH 0/4] drm/amd/display: stop using drm_edid_override_connector_update()

[Alex Hung]

On 2023-08-22 06:01, Jani Nikula wrote:
> Over the past years I've been trying to unify the override and firmware
> EDID handling as well as EDID property updates. It won't work if drivers
> do their own random things.
Let's check how to replace these references by appropriate ones or fork 
the function as reverting these patches causes regressions.

Cheers,
Alex

> 
> BR,
> Jani.
> 
> 
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: Alex Hung <alex.hung@amd.com>
> Cc: Chao-kai Wang <Stylon.Wang@amd.com>
> Cc: Daniel Wheeler <daniel.wheeler@amd.com>
> Cc: Harry Wentland <harry.wentland@amd.com>
> Cc: Hersen Wu <hersenxs.wu@amd.com>
> Cc: Leo Li <sunpeng.li@amd.com>
> Cc: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
> Cc: Wenchieh Chien <wenchieh.chien@amd.com>
> Cc: David Airlie <airlied@gmail.com>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> 
> Jani Nikula (4):
>    Revert "drm/amd/display: drop unused count variable in
>      create_eml_sink()"
>    Revert "drm/amd/display: assign edid_blob_ptr with edid from debugfs"
>    Revert "drm/amd/display: mark amdgpu_dm_connector_funcs_force static"
>    Revert "drm/amd/display: implement force function in
>      amdgpu_dm_connector_funcs"
> 
>   .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 44 +++----------------
>   1 file changed, 5 insertions(+), 39 deletions(-)
> 

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/amd/display: stop using drm_edid_override_connector_update() (rev2)

[Patchwork]

== Series Details ==

Series: drm/amd/display: stop using drm_edid_override_connector_update() (rev2)
URL   : https://patchwork.freedesktop.org/series/122739/
State : warning

== Summary ==

Error: dim checkpatch failed
/home/kbuild2/linux/maintainer-tools/dim: line 50: /home/kbuild2/.dimrc: No such file or directory

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/amd/display: stop using drm_edid_override_connector_update() (rev2)

[Patchwork]

== Series Details ==

Series: drm/amd/display: stop using drm_edid_override_connector_update() (rev2)
URL   : https://patchwork.freedesktop.org/series/122739/
State : warning

== Summary ==

Error: dim sparse failed
/home/kbuild2/linux/maintainer-tools/dim: line 50: /home/kbuild2/.dimrc: No such file or directory

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/amd/display: stop using drm_edid_override_connector_update() (rev2)

[Patchwork]

[-- Attachment #1: Type: text/plain, Size: 5333 bytes --]

== Series Details ==

Series: drm/amd/display: stop using drm_edid_override_connector_update() (rev2)
URL   : https://patchwork.freedesktop.org/series/122739/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_13549 -> Patchwork_122739v2
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/index.html

Participating hosts (41 -> 41)
------------------------------

  Additional (1): fi-pnv-d510 
  Missing    (1): fi-snb-2520m 

Known issues
------------

  Here are the changes found in Patchwork_122739v2 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@i915_selftest@live@gt_heartbeat:
    - fi-kbl-soraka:      [PASS][1] -> [DMESG-FAIL][2] ([i915#5334] / [i915#7872])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13549/fi-kbl-soraka/igt@i915_selftest@live@gt_heartbeat.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/fi-kbl-soraka/igt@i915_selftest@live@gt_heartbeat.html

  * igt@i915_selftest@live@mman:
    - bat-rpls-2:         [PASS][3] -> [TIMEOUT][4] ([i915#6794] / [i915#7392])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13549/bat-rpls-2/igt@i915_selftest@live@mman.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/bat-rpls-2/igt@i915_selftest@live@mman.html

  * igt@i915_suspend@basic-s2idle-without-i915:
    - bat-rpls-2:         [PASS][5] -> [WARN][6] ([i915#8747])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13549/bat-rpls-2/igt@i915_suspend@basic-s2idle-without-i915.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/bat-rpls-2/igt@i915_suspend@basic-s2idle-without-i915.html

  * igt@i915_suspend@basic-s3-without-i915:
    - bat-adlp-9:         NOTRUN -> [INCOMPLETE][7] ([i915#7443])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/bat-adlp-9/igt@i915_suspend@basic-s3-without-i915.html
    - bat-dg2-11:         NOTRUN -> [INCOMPLETE][8] ([i915#4817])
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/bat-dg2-11/igt@i915_suspend@basic-s3-without-i915.html

  * igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-d-edp-1:
    - bat-rplp-1:         [PASS][9] -> [ABORT][10] ([i915#8442] / [i915#8668])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13549/bat-rplp-1/igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-d-edp-1.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/bat-rplp-1/igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-d-edp-1.html

  * igt@kms_psr@primary_page_flip:
    - fi-pnv-d510:        NOTRUN -> [SKIP][11] ([fdo#109271]) +30 similar issues
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/fi-pnv-d510/igt@kms_psr@primary_page_flip.html

  
#### Possible fixes ####

  * igt@i915_selftest@live@gt_lrc:
    - bat-adlp-9:         [INCOMPLETE][12] ([i915#4983] / [i915#7913]) -> [PASS][13]
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13549/bat-adlp-9/igt@i915_selftest@live@gt_lrc.html
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/bat-adlp-9/igt@i915_selftest@live@gt_lrc.html
    - bat-dg2-11:         [INCOMPLETE][14] ([i915#7609] / [i915#7913]) -> [PASS][15]
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13549/bat-dg2-11/igt@i915_selftest@live@gt_lrc.html
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/bat-dg2-11/igt@i915_selftest@live@gt_lrc.html

  
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [i915#4817]: https://gitlab.freedesktop.org/drm/intel/issues/4817
  [i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
  [i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
  [i915#6794]: https://gitlab.freedesktop.org/drm/intel/issues/6794
  [i915#7392]: https://gitlab.freedesktop.org/drm/intel/issues/7392
  [i915#7443]: https://gitlab.freedesktop.org/drm/intel/issues/7443
  [i915#7609]: https://gitlab.freedesktop.org/drm/intel/issues/7609
  [i915#7872]: https://gitlab.freedesktop.org/drm/intel/issues/7872
  [i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
  [i915#8442]: https://gitlab.freedesktop.org/drm/intel/issues/8442
  [i915#8668]: https://gitlab.freedesktop.org/drm/intel/issues/8668
  [i915#8747]: https://gitlab.freedesktop.org/drm/intel/issues/8747


Build changes
-------------

  * Linux: CI_DRM_13549 -> Patchwork_122739v2

  CI-20190529: 20190529
  CI_DRM_13549: daa7b246575041e069f151cfbc69d07e321bdc01 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_7451: 5d48d1fb231f449fe2f80cda14ea7a1ecfda59fa @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
  Patchwork_122739v2: daa7b246575041e069f151cfbc69d07e321bdc01 @ git://anongit.freedesktop.org/gfx-ci/linux


### Linux commits

7d0bd568ddb9 Revert "drm/amd/display: implement force function in amdgpu_dm_connector_funcs"
39fee86752df Revert "drm/amd/display: mark amdgpu_dm_connector_funcs_force static"
3183ae07f49c Revert "drm/amd/display: assign edid_blob_ptr with edid from debugfs"
cdc93251a033 Revert "drm/amd/display: drop unused count variable in create_eml_sink()"

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/index.html

[-- Attachment #2: Type: text/html, Size: 6224 bytes --]

Re: [Intel-gfx] [PATCH 0/4] drm/amd/display: stop using drm_edid_override_connector_update()

[Jani Nikula]

On Tue, 22 Aug 2023, Alex Hung <alex.hung@amd.com> wrote:
> On 2023-08-22 06:01, Jani Nikula wrote:
>> Over the past years I've been trying to unify the override and firmware
>> EDID handling as well as EDID property updates. It won't work if drivers
>> do their own random things.
> Let's check how to replace these references by appropriate ones or fork 
> the function as reverting these patches causes regressions.

I think the fundamental problem you have is conflating connector forcing
with EDID override. They're orthogonal. The .force callback has no
business basing the decisions on connector->edid_override. Force is
force, override is override.

The driver isn't even supposed to know or care if the EDID originates
from the firmware loader or override EDID debugfs. drm_get_edid() will
handle that for you transparently. It'll return the EDID, and you
shouldn't look at connector->edid_blob_ptr either. Using that will make
future work in drm_edid.c harder.

You can't fix that with minor tweaks. I think you'll be better off
starting from scratch.

Also, connector->edid_override is debugfs. You actually can change the
behaviour. If your userspace, whatever it is, has been written to assume
connector forcing if EDID override is set, you *do* have to fix that,
and set both.

BR,
Jani.


>
> Cheers,
> Alex
>
>> 
>> BR,
>> Jani.
>> 
>> 
>> Cc: Alex Deucher <alexander.deucher@amd.com>
>> Cc: Alex Hung <alex.hung@amd.com>
>> Cc: Chao-kai Wang <Stylon.Wang@amd.com>
>> Cc: Daniel Wheeler <daniel.wheeler@amd.com>
>> Cc: Harry Wentland <harry.wentland@amd.com>
>> Cc: Hersen Wu <hersenxs.wu@amd.com>
>> Cc: Leo Li <sunpeng.li@amd.com>
>> Cc: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
>> Cc: Wenchieh Chien <wenchieh.chien@amd.com>
>> Cc: David Airlie <airlied@gmail.com>
>> Cc: Daniel Vetter <daniel@ffwll.ch>
>> 
>> Jani Nikula (4):
>>    Revert "drm/amd/display: drop unused count variable in
>>      create_eml_sink()"
>>    Revert "drm/amd/display: assign edid_blob_ptr with edid from debugfs"
>>    Revert "drm/amd/display: mark amdgpu_dm_connector_funcs_force static"
>>    Revert "drm/amd/display: implement force function in
>>      amdgpu_dm_connector_funcs"
>> 
>>   .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 44 +++----------------
>>   1 file changed, 5 insertions(+), 39 deletions(-)
>> 

-- 
Jani Nikula, Intel Open Source Graphics Center

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/amd/display: stop using drm_edid_override_connector_update() (rev2)

[Patchwork]

[-- Attachment #1: Type: text/plain, Size: 56459 bytes --]

== Series Details ==

Series: drm/amd/display: stop using drm_edid_override_connector_update() (rev2)
URL   : https://patchwork.freedesktop.org/series/122739/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_13549_full -> Patchwork_122739v2_full
====================================================

Summary
-------

  **WARNING**

  Minor unknown changes coming with Patchwork_122739v2_full need to be verified
  manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_122739v2_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  

Participating hosts (9 -> 9)
------------------------------

  No changes in participating hosts

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in Patchwork_122739v2_full:

### IGT changes ###

#### Warnings ####

  * igt@i915_pm_rps@reset:
    - shard-dg2:          [FAIL][1] ([i915#8229]) -> [FAIL][2]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13549/shard-dg2-3/igt@i915_pm_rps@reset.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-dg2-2/igt@i915_pm_rps@reset.html

  
Known issues
------------

  Here are the changes found in Patchwork_122739v2_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@api_intel_bb@blit-reloc-keep-cache:
    - shard-dg2:          NOTRUN -> [SKIP][3] ([i915#8411])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-dg2-11/igt@api_intel_bb@blit-reloc-keep-cache.html

  * igt@api_intel_bb@blit-reloc-purge-cache:
    - shard-mtlp:         NOTRUN -> [SKIP][4] ([i915#8411])
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-mtlp-6/igt@api_intel_bb@blit-reloc-purge-cache.html

  * igt@api_intel_bb@object-noreloc-keep-cache-simple:
    - shard-snb:          NOTRUN -> [SKIP][5] ([fdo#109271]) +88 similar issues
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-snb5/igt@api_intel_bb@object-noreloc-keep-cache-simple.html

  * igt@drm_fdinfo@all-busy-idle-check-all:
    - shard-dg2:          NOTRUN -> [SKIP][6] ([i915#8414])
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-dg2-11/igt@drm_fdinfo@all-busy-idle-check-all.html

  * igt@feature_discovery@display-3x:
    - shard-dg2:          NOTRUN -> [SKIP][7] ([i915#1839])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-dg2-11/igt@feature_discovery@display-3x.html

  * igt@feature_discovery@display-4x:
    - shard-mtlp:         NOTRUN -> [SKIP][8] ([i915#1839])
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-mtlp-6/igt@feature_discovery@display-4x.html

  * igt@gem_caching@writes:
    - shard-mtlp:         NOTRUN -> [SKIP][9] ([i915#4873])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-mtlp-2/igt@gem_caching@writes.html

  * igt@gem_ccs@block-multicopy-inplace:
    - shard-mtlp:         NOTRUN -> [SKIP][10] ([i915#5325])
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-mtlp-6/igt@gem_ccs@block-multicopy-inplace.html

  * igt@gem_ctx_persistence@legacy-engines-cleanup:
    - shard-snb:          NOTRUN -> [SKIP][11] ([fdo#109271] / [i915#1099])
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-snb5/igt@gem_ctx_persistence@legacy-engines-cleanup.html

  * igt@gem_ctx_sseu@invalid-args:
    - shard-dg2:          NOTRUN -> [SKIP][12] ([i915#280])
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-dg2-5/igt@gem_ctx_sseu@invalid-args.html

  * igt@gem_eio@reset-stress:
    - shard-dg1:          [PASS][13] -> [FAIL][14] ([i915#5784])
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13549/shard-dg1-17/igt@gem_eio@reset-stress.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-dg1-19/igt@gem_eio@reset-stress.html

  * igt@gem_exec_balancer@noheartbeat:
    - shard-mtlp:         NOTRUN -> [SKIP][15] ([i915#8555])
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-mtlp-6/igt@gem_exec_balancer@noheartbeat.html

  * igt@gem_exec_endless@dispatch@bcs0:
    - shard-dg2:          [PASS][16] -> [TIMEOUT][17] ([i915#3778] / [i915#7016] / [i915#7921])
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13549/shard-dg2-3/igt@gem_exec_endless@dispatch@bcs0.html
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-dg2-2/igt@gem_exec_endless@dispatch@bcs0.html

  * igt@gem_exec_fair@basic-none@bcs0:
    - shard-rkl:          [PASS][18] -> [FAIL][19] ([i915#2842]) +1 similar issue
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13549/shard-rkl-4/igt@gem_exec_fair@basic-none@bcs0.html
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-rkl-6/igt@gem_exec_fair@basic-none@bcs0.html

  * igt@gem_exec_fair@basic-pace:
    - shard-mtlp:         NOTRUN -> [SKIP][20] ([i915#4473] / [i915#4771])
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-mtlp-6/igt@gem_exec_fair@basic-pace.html

  * igt@gem_exec_gttfill@multigpu-basic:
    - shard-dg2:          NOTRUN -> [SKIP][21] ([i915#7697])
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-dg2-5/igt@gem_exec_gttfill@multigpu-basic.html

  * igt@gem_exec_params@secure-non-root:
    - shard-dg2:          NOTRUN -> [SKIP][22] ([fdo#112283])
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-dg2-5/igt@gem_exec_params@secure-non-root.html

  * igt@gem_exec_reloc@basic-gtt-cpu-active:
    - shard-dg2:          NOTRUN -> [SKIP][23] ([i915#3281]) +7 similar issues
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-dg2-12/igt@gem_exec_reloc@basic-gtt-cpu-active.html

  * igt@gem_exec_reloc@basic-wc-cpu-noreloc:
    - shard-mtlp:         NOTRUN -> [SKIP][24] ([i915#3281]) +5 similar issues
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-mtlp-6/igt@gem_exec_reloc@basic-wc-cpu-noreloc.html

  * igt@gem_exec_schedule@noreorder@bcs0:
    - shard-mtlp:         [PASS][25] -> [DMESG-FAIL][26] ([i915#9121])
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13549/shard-mtlp-2/igt@gem_exec_schedule@noreorder@bcs0.html
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-mtlp-4/igt@gem_exec_schedule@noreorder@bcs0.html

  * igt@gem_exec_schedule@reorder-wide:
    - shard-mtlp:         NOTRUN -> [SKIP][27] ([i915#4812])
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-mtlp-6/igt@gem_exec_schedule@reorder-wide.html

  * igt@gem_fence_thrash@bo-copy:
    - shard-dg2:          NOTRUN -> [SKIP][28] ([i915#4860]) +1 similar issue
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-dg2-11/igt@gem_fence_thrash@bo-copy.html

  * igt@gem_lmem_swapping@heavy-multi:
    - shard-mtlp:         NOTRUN -> [SKIP][29] ([i915#4613])
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-mtlp-6/igt@gem_lmem_swapping@heavy-multi.html

  * igt@gem_mmap@bad-offset:
    - shard-dg2:          NOTRUN -> [SKIP][30] ([i915#4083]) +1 similar issue
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-dg2-11/igt@gem_mmap@bad-offset.html

  * igt@gem_mmap_gtt@basic-write-read:
    - shard-mtlp:         NOTRUN -> [SKIP][31] ([i915#4077]) +2 similar issues
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-mtlp-6/igt@gem_mmap_gtt@basic-write-read.html

  * igt@gem_mmap_wc@write-cpu-read-wc:
    - shard-mtlp:         NOTRUN -> [SKIP][32] ([i915#4083])
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-mtlp-6/igt@gem_mmap_wc@write-cpu-read-wc.html

  * igt@gem_partial_pwrite_pread@writes-after-reads-snoop:
    - shard-dg2:          NOTRUN -> [SKIP][33] ([i915#3282]) +2 similar issues
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-dg2-12/igt@gem_partial_pwrite_pread@writes-after-reads-snoop.html

  * igt@gem_pxp@reject-modify-context-protection-off-3:
    - shard-dg2:          NOTRUN -> [SKIP][34] ([i915#4270]) +1 similar issue
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-dg2-5/igt@gem_pxp@reject-modify-context-protection-off-3.html

  * igt@gem_pxp@verify-pxp-stale-buf-optout-execution:
    - shard-mtlp:         NOTRUN -> [SKIP][35] ([i915#4270])
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-mtlp-6/igt@gem_pxp@verify-pxp-stale-buf-optout-execution.html

  * igt@gem_render_copy@y-tiled-to-vebox-yf-tiled:
    - shard-mtlp:         NOTRUN -> [SKIP][36] ([i915#8428])
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-mtlp-6/igt@gem_render_copy@y-tiled-to-vebox-yf-tiled.html

  * igt@gem_set_tiling_vs_blt@tiled-to-untiled:
    - shard-dg2:          NOTRUN -> [SKIP][37] ([i915#4079])
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-dg2-12/igt@gem_set_tiling_vs_blt@tiled-to-untiled.html

  * igt@gem_softpin@evict-snoop-interruptible:
    - shard-dg2:          NOTRUN -> [SKIP][38] ([i915#4885])
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-dg2-5/igt@gem_softpin@evict-snoop-interruptible.html

  * igt@gem_userptr_blits@dmabuf-sync:
    - shard-mtlp:         NOTRUN -> [SKIP][39] ([i915#3297])
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-mtlp-6/igt@gem_userptr_blits@dmabuf-sync.html

  * igt@gem_userptr_blits@dmabuf-unsync:
    - shard-dg2:          NOTRUN -> [SKIP][40] ([i915#3297])
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-dg2-5/igt@gem_userptr_blits@dmabuf-unsync.html

  * igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy:
    - shard-dg2:          NOTRUN -> [SKIP][41] ([i915#3297] / [i915#4880])
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-dg2-5/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy.html

  * igt@gem_userptr_blits@vma-merge:
    - shard-dg2:          NOTRUN -> [FAIL][42] ([i915#3318])
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-dg2-5/igt@gem_userptr_blits@vma-merge.html

  * igt@gem_workarounds@suspend-resume-context:
    - shard-dg2:          [PASS][43] -> [INCOMPLETE][44] ([i915#9138])
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13549/shard-dg2-1/igt@gem_workarounds@suspend-resume-context.html
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-dg2-5/igt@gem_workarounds@suspend-resume-context.html

  * igt@gen9_exec_parse@bb-chained:
    - shard-dg2:          NOTRUN -> [SKIP][45] ([i915#2856]) +1 similar issue
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-dg2-12/igt@gen9_exec_parse@bb-chained.html

  * igt@gen9_exec_parse@valid-registers:
    - shard-mtlp:         NOTRUN -> [SKIP][46] ([i915#2856])
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-mtlp-6/igt@gen9_exec_parse@valid-registers.html

  * igt@i915_fb_tiling:
    - shard-dg2:          NOTRUN -> [SKIP][47] ([i915#4881])
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-dg2-5/igt@i915_fb_tiling.html

  * igt@i915_module_load@load:
    - shard-snb:          NOTRUN -> [SKIP][48] ([fdo#109271] / [i915#6227])
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-snb5/igt@i915_module_load@load.html

  * igt@i915_pipe_stress@stress-xrgb8888-untiled:
    - shard-mtlp:         [PASS][49] -> [FAIL][50] ([i915#8691])
   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13549/shard-mtlp-3/igt@i915_pipe_stress@stress-xrgb8888-untiled.html
   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-mtlp-3/igt@i915_pipe_stress@stress-xrgb8888-untiled.html

  * igt@i915_pm_backlight@fade-with-dpms:
    - shard-dg2:          NOTRUN -> [SKIP][51] ([i915#5354] / [i915#7561])
   [51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-dg2-5/igt@i915_pm_backlight@fade-with-dpms.html

  * igt@i915_pm_dc@dc6-dpms:
    - shard-tglu:         [PASS][52] -> [FAIL][53] ([i915#3989] / [i915#454])
   [52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13549/shard-tglu-10/igt@i915_pm_dc@dc6-dpms.html
   [53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-tglu-7/igt@i915_pm_dc@dc6-dpms.html

  * igt@i915_pm_rc6_residency@media-rc6-accuracy:
    - shard-dg2:          NOTRUN -> [SKIP][54] ([fdo#109289])
   [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-dg2-11/igt@i915_pm_rc6_residency@media-rc6-accuracy.html

  * igt@i915_pm_rc6_residency@rc6-idle@bcs0:
    - shard-dg1:          [PASS][55] -> [FAIL][56] ([i915#3591])
   [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13549/shard-dg1-13/igt@i915_pm_rc6_residency@rc6-idle@bcs0.html
   [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-dg1-14/igt@i915_pm_rc6_residency@rc6-idle@bcs0.html

  * igt@i915_pm_rpm@modeset-lpsp:
    - shard-dg1:          [PASS][57] -> [SKIP][58] ([i915#1397])
   [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13549/shard-dg1-19/igt@i915_pm_rpm@modeset-lpsp.html
   [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-dg1-13/igt@i915_pm_rpm@modeset-lpsp.html

  * igt@i915_pm_rpm@modeset-non-lpsp-stress:
    - shard-dg2:          [PASS][59] -> [SKIP][60] ([i915#1397]) +1 similar issue
   [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13549/shard-dg2-5/igt@i915_pm_rpm@modeset-non-lpsp-stress.html
   [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-dg2-12/igt@i915_pm_rpm@modeset-non-lpsp-stress.html

  * igt@i915_pm_rps@reset:
    - shard-snb:          [PASS][61] -> [INCOMPLETE][62] ([i915#7790])
   [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13549/shard-snb4/igt@i915_pm_rps@reset.html
   [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-snb6/igt@i915_pm_rps@reset.html

  * igt@i915_pm_rps@thresholds-idle@gt0:
    - shard-dg2:          NOTRUN -> [SKIP][63] ([i915#8925])
   [63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-dg2-11/igt@i915_pm_rps@thresholds-idle@gt0.html

  * igt@i915_selftest@live@requests:
    - shard-mtlp:         [PASS][64] -> [ABORT][65] ([i915#7982])
   [64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13549/shard-mtlp-8/igt@i915_selftest@live@requests.html
   [65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-mtlp-8/igt@i915_selftest@live@requests.html

  * igt@i915_suspend@fence-restore-untiled:
    - shard-dg2:          NOTRUN -> [SKIP][66] ([i915#4077]) +5 similar issues
   [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-dg2-11/igt@i915_suspend@fence-restore-untiled.html

  * igt@kms_async_flips@async-flip-with-page-flip-events@pipe-b-hdmi-a-1-y-rc_ccs:
    - shard-rkl:          NOTRUN -> [SKIP][67] ([i915#8502]) +3 similar issues
   [67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-rkl-7/igt@kms_async_flips@async-flip-with-page-flip-events@pipe-b-hdmi-a-1-y-rc_ccs.html

  * igt@kms_async_flips@async-flip-with-page-flip-events@pipe-b-hdmi-a-2-4-rc_ccs-cc:
    - shard-dg2:          NOTRUN -> [SKIP][68] ([i915#8709]) +11 similar issues
   [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-dg2-2/igt@kms_async_flips@async-flip-with-page-flip-events@pipe-b-hdmi-a-2-4-rc_ccs-cc.html

  * igt@kms_async_flips@async-flip-with-page-flip-events@pipe-d-hdmi-a-1-y-rc_ccs:
    - shard-dg1:          NOTRUN -> [SKIP][69] ([i915#8502]) +7 similar issues
   [69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-dg1-19/igt@kms_async_flips@async-flip-with-page-flip-events@pipe-d-hdmi-a-1-y-rc_ccs.html

  * igt@kms_async_flips@crc@pipe-d-dp-4:
    - shard-dg2:          NOTRUN -> [FAIL][70] ([i915#8247]) +3 similar issues
   [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-dg2-11/igt@kms_async_flips@crc@pipe-d-dp-4.html

  * igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0-hflip:
    - shard-mtlp:         [PASS][71] -> [FAIL][72] ([i915#5138])
   [71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13549/shard-mtlp-3/igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0-hflip.html
   [72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-mtlp-3/igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0-hflip.html

  * igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0-hflip-async-flip:
    - shard-mtlp:         [PASS][73] -> [FAIL][74] ([i915#3743]) +2 similar issues
   [73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13549/shard-mtlp-7/igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0-hflip-async-flip.html
   [74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-mtlp-6/igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0-hflip-async-flip.html

  * igt@kms_big_fb@x-tiled-32bpp-rotate-270:
    - shard-dg2:          NOTRUN -> [SKIP][75] ([fdo#111614])
   [75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-dg2-5/igt@kms_big_fb@x-tiled-32bpp-rotate-270.html

  * igt@kms_big_fb@y-tiled-8bpp-rotate-270:
    - shard-mtlp:         NOTRUN -> [SKIP][76] ([fdo#111615]) +2 similar issues
   [76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-mtlp-6/igt@kms_big_fb@y-tiled-8bpp-rotate-270.html

  * igt@kms_big_fb@y-tiled-8bpp-rotate-90:
    - shard-dg2:          NOTRUN -> [SKIP][77] ([i915#5190]) +5 similar issues
   [77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-dg2-5/igt@kms_big_fb@y-tiled-8bpp-rotate-90.html

  * igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip:
    - shard-dg2:          NOTRUN -> [SKIP][78] ([i915#4538] / [i915#5190]) +1 similar issue
   [78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-dg2-5/igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip.html

  * igt@kms_big_joiner@basic:
    - shard-dg2:          NOTRUN -> [SKIP][79] ([i915#2705])
   [79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-dg2-5/igt@kms_big_joiner@basic.html

  * igt@kms_ccs@pipe-a-bad-pixel-format-y_tiled_gen12_rc_ccs_cc:
    - shard-mtlp:         NOTRUN -> [SKIP][80] ([i915#3886] / [i915#6095]) +4 similar issues
   [80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-mtlp-6/igt@kms_ccs@pipe-a-bad-pixel-format-y_tiled_gen12_rc_ccs_cc.html

  * igt@kms_ccs@pipe-a-ccs-on-another-bo-4_tiled_mtl_mc_ccs:
    - shard-glk:          NOTRUN -> [SKIP][81] ([fdo#109271]) +26 similar issues
   [81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-glk4/igt@kms_ccs@pipe-a-ccs-on-another-bo-4_tiled_mtl_mc_ccs.html

  * igt@kms_ccs@pipe-b-crc-primary-basic-yf_tiled_ccs:
    - shard-mtlp:         NOTRUN -> [SKIP][82] ([i915#6095]) +4 similar issues
   [82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-mtlp-7/igt@kms_ccs@pipe-b-crc-primary-basic-yf_tiled_ccs.html

  * igt@kms_ccs@pipe-b-crc-sprite-planes-basic-y_tiled_gen12_rc_ccs_cc:
    - shard-dg2:          NOTRUN -> [SKIP][83] ([i915#3689] / [i915#3886] / [i915#5354]) +3 similar issues
   [83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-dg2-5/igt@kms_ccs@pipe-b-crc-sprite-planes-basic-y_tiled_gen12_rc_ccs_cc.html

  * igt@kms_ccs@pipe-c-bad-rotation-90-4_tiled_mtl_mc_ccs:
    - shard-dg2:          NOTRUN -> [SKIP][84] ([i915#5354]) +26 similar issues
   [84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-dg2-11/igt@kms_ccs@pipe-c-bad-rotation-90-4_tiled_mtl_mc_ccs.html

  * igt@kms_ccs@pipe-d-crc-primary-basic-y_tiled_gen12_rc_ccs:
    - shard-dg2:          NOTRUN -> [SKIP][85] ([i915#3689] / [i915#5354]) +9 similar issues
   [85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-dg2-5/igt@kms_ccs@pipe-d-crc-primary-basic-y_tiled_gen12_rc_ccs.html

  * igt@kms_chamelium_color@ctm-0-75:
    - shard-dg2:          NOTRUN -> [SKIP][86] ([fdo#111827])
   [86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-dg2-11/igt@kms_chamelium_color@ctm-0-75.html

  * igt@kms_chamelium_frames@dp-crc-single:
    - shard-mtlp:         NOTRUN -> [SKIP][87] ([i915#7828]) +2 similar issues
   [87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-mtlp-6/igt@kms_chamelium_frames@dp-crc-single.html

  * igt@kms_chamelium_hpd@vga-hpd-with-enabled-mode:
    - shard-dg2:          NOTRUN -> [SKIP][88] ([i915#7828]) +3 similar issues
   [88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-dg2-11/igt@kms_chamelium_hpd@vga-hpd-with-enabled-mode.html

  * igt@kms_content_protection@type1:
    - shard-dg2:          NOTRUN -> [SKIP][89] ([i915#7118])
   [89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-dg2-5/igt@kms_content_protection@type1.html

  * igt@kms_content_protection@uevent@pipe-a-dp-4:
    - shard-dg2:          NOTRUN -> [FAIL][90] ([i915#1339])
   [90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-dg2-11/igt@kms_content_protection@uevent@pipe-a-dp-4.html

  * igt@kms_cursor_crc@cursor-onscreen-max-size:
    - shard-dg2:          NOTRUN -> [SKIP][91] ([i915#3555]) +3 similar issues
   [91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-dg2-5/igt@kms_cursor_crc@cursor-onscreen-max-size.html

  * igt@kms_cursor_crc@cursor-random-512x170:
    - shard-dg2:          NOTRUN -> [SKIP][92] ([i915#3359])
   [92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-dg2-5/igt@kms_cursor_crc@cursor-random-512x170.html

  * igt@kms_cursor_crc@cursor-rapid-movement-32x32:
    - shard-mtlp:         NOTRUN -> [SKIP][93] ([i915#8814])
   [93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-mtlp-6/igt@kms_cursor_crc@cursor-rapid-movement-32x32.html

  * igt@kms_cursor_crc@cursor-suspend@pipe-b-vga-1:
    - shard-snb:          NOTRUN -> [DMESG-WARN][94] ([i915#8841]) +2 similar issues
   [94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-snb2/igt@kms_cursor_crc@cursor-suspend@pipe-b-vga-1.html

  * igt@kms_cursor_crc@cursor-suspend@pipe-d-edp-1:
    - shard-mtlp:         [PASS][95] -> [FAIL][96] ([fdo#103375])
   [95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13549/shard-mtlp-5/igt@kms_cursor_crc@cursor-suspend@pipe-d-edp-1.html
   [96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-mtlp-1/igt@kms_cursor_crc@cursor-suspend@pipe-d-edp-1.html

  * igt@kms_cursor_legacy@2x-nonblocking-modeset-vs-cursor-atomic:
    - shard-mtlp:         NOTRUN -> [SKIP][97] ([i915#3546]) +1 similar issue
   [97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-mtlp-6/igt@kms_cursor_legacy@2x-nonblocking-modeset-vs-cursor-atomic.html

  * igt@kms_cursor_legacy@cursorb-vs-flipb-varying-size:
    - shard-dg2:          NOTRUN -> [SKIP][98] ([fdo#109274] / [i915#5354]) +2 similar issues
   [98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-dg2-5/igt@kms_cursor_legacy@cursorb-vs-flipb-varying-size.html

  * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
    - shard-glk:          NOTRUN -> [FAIL][99] ([i915#2346])
   [99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-glk4/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html

  * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
    - shard-apl:          [PASS][100] -> [FAIL][101] ([i915#2346])
   [100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13549/shard-apl1/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
   [101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-apl1/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
    - shard-glk:          [PASS][102] -> [FAIL][103] ([i915#2346])
   [102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13549/shard-glk5/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
   [103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-glk6/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html

  * igt@kms_cursor_legacy@short-busy-flip-before-cursor-atomic-transitions:
    - shard-dg2:          NOTRUN -> [SKIP][104] ([i915#4103] / [i915#4213]) +1 similar issue
   [104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-dg2-5/igt@kms_cursor_legacy@short-busy-flip-before-cursor-atomic-transitions.html

  * igt@kms_cursor_legacy@single-bo@all-pipes:
    - shard-mtlp:         [PASS][105] -> [DMESG-WARN][106] ([i915#2017]) +1 similar issue
   [105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13549/shard-mtlp-2/igt@kms_cursor_legacy@single-bo@all-pipes.html
   [106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-mtlp-4/igt@kms_cursor_legacy@single-bo@all-pipes.html

  * igt@kms_dsc@dsc-basic:
    - shard-dg2:          NOTRUN -> [SKIP][107] ([i915#3555] / [i915#3840])
   [107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-dg2-11/igt@kms_dsc@dsc-basic.html

  * igt@kms_flip@2x-plain-flip:
    - shard-mtlp:         NOTRUN -> [SKIP][108] ([i915#3637]) +2 similar issues
   [108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-mtlp-6/igt@kms_flip@2x-plain-flip.html

  * igt@kms_flip@2x-plain-flip-ts-check:
    - shard-dg2:          NOTRUN -> [SKIP][109] ([fdo#109274])
   [109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-dg2-5/igt@kms_flip@2x-plain-flip-ts-check.html

  * igt@kms_flip@flip-vs-expired-vblank-interruptible@a-hdmi-a1:
    - shard-glk:          [PASS][110] -> [FAIL][111] ([i915#79])
   [110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13549/shard-glk5/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-hdmi-a1.html
   [111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-glk9/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-hdmi-a1.html

  * igt@kms_flip@flip-vs-suspend@a-hdmi-a3:
    - shard-dg2:          NOTRUN -> [FAIL][112] ([fdo#103375]) +3 similar issues
   [112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-dg2-5/igt@kms_flip@flip-vs-suspend@a-hdmi-a3.html

  * igt@kms_flip_scaled_crc@flip-32bpp-xtile-to-64bpp-xtile-downscaling@pipe-a-default-mode:
    - shard-mtlp:         NOTRUN -> [SKIP][113] ([i915#8810])
   [113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-mtlp-6/igt@kms_flip_scaled_crc@flip-32bpp-xtile-to-64bpp-xtile-downscaling@pipe-a-default-mode.html

  * igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-32bpp-yftileccs-downscaling@pipe-a-valid-mode:
    - shard-dg2:          NOTRUN -> [SKIP][114] ([i915#2672]) +2 similar issues
   [114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-dg2-11/igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-32bpp-yftileccs-downscaling@pipe-a-valid-mode.html

  * igt@kms_force_connector_basic@force-load-detect:
    - shard-mtlp:         NOTRUN -> [SKIP][115] ([fdo#109285])
   [115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-mtlp-6/igt@kms_force_connector_basic@force-load-detect.html

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-pgflip-blt:
    - shard-dg2:          NOTRUN -> [FAIL][116] ([i915#6880])
   [116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-dg2-11/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-pgflip-blt.html

  * igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-pri-indfb-draw-blt:
    - shard-mtlp:         NOTRUN -> [SKIP][117] ([i915#1825]) +5 similar issues
   [117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-mtlp-6/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-pri-indfb-draw-blt.html

  * igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-spr-indfb-draw-mmap-wc:
    - shard-dg2:          NOTRUN -> [SKIP][118] ([i915#8708]) +7 similar issues
   [118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-dg2-11/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-spr-indfb-draw-mmap-wc.html

  * igt@kms_frontbuffer_tracking@fbcpsr-tiling-y:
    - shard-mtlp:         NOTRUN -> [SKIP][119] ([i915#5460])
   [119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-mtlp-7/igt@kms_frontbuffer_tracking@fbcpsr-tiling-y.html

  * igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-mmap-gtt:
    - shard-mtlp:         NOTRUN -> [SKIP][120] ([i915#8708]) +3 similar issues
   [120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-mtlp-6/igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-mmap-gtt.html

  * igt@kms_frontbuffer_tracking@psr-indfb-scaledprimary:
    - shard-dg2:          NOTRUN -> [SKIP][121] ([i915#3458]) +6 similar issues
   [121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-dg2-5/igt@kms_frontbuffer_tracking@psr-indfb-scaledprimary.html

  * igt@kms_hdr@static-toggle-suspend:
    - shard-dg2:          NOTRUN -> [SKIP][122] ([i915#3555] / [i915#8228]) +2 similar issues
   [122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-dg2-1/igt@kms_hdr@static-toggle-suspend.html

  * igt@kms_multipipe_modeset@basic-max-pipe-crc-check:
    - shard-mtlp:         NOTRUN -> [SKIP][123] ([i915#4816])
   [123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-mtlp-6/igt@kms_multipipe_modeset@basic-max-pipe-crc-check.html

  * igt@kms_plane@pixel-format-source-clamping@pipe-b-planes:
    - shard-mtlp:         [PASS][124] -> [FAIL][125] ([i915#1623])
   [124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13549/shard-mtlp-6/igt@kms_plane@pixel-format-source-clamping@pipe-b-planes.html
   [125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-mtlp-2/igt@kms_plane@pixel-format-source-clamping@pipe-b-planes.html

  * igt@kms_plane_cursor@overlay@pipe-d-edp-1-size-128:
    - shard-mtlp:         [PASS][126] -> [DMESG-WARN][127] ([i915#1982]) +1 similar issue
   [126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13549/shard-mtlp-1/igt@kms_plane_cursor@overlay@pipe-d-edp-1-size-128.html
   [127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-mtlp-3/igt@kms_plane_cursor@overlay@pipe-d-edp-1-size-128.html

  * igt@kms_plane_multiple@tiling-yf:
    - shard-dg2:          NOTRUN -> [SKIP][128] ([i915#3555] / [i915#8806])
   [128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-dg2-11/igt@kms_plane_multiple@tiling-yf.html

  * igt@kms_plane_scaling@intel-max-src-size:
    - shard-mtlp:         NOTRUN -> [SKIP][129] ([i915#6953])
   [129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-mtlp-6/igt@kms_plane_scaling@intel-max-src-size.html

  * igt@kms_plane_scaling@intel-max-src-size@pipe-a-hdmi-a-2:
    - shard-rkl:          NOTRUN -> [FAIL][130] ([i915#8292])
   [130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-rkl-1/igt@kms_plane_scaling@intel-max-src-size@pipe-a-hdmi-a-2.html

  * igt@kms_plane_scaling@plane-downscale-with-rotation-factor-0-25@pipe-b-hdmi-a-3:
    - shard-dg2:          NOTRUN -> [SKIP][131] ([i915#5176]) +3 similar issues
   [131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-dg2-5/igt@kms_plane_scaling@plane-downscale-with-rotation-factor-0-25@pipe-b-hdmi-a-3.html

  * igt@kms_plane_scaling@plane-downscale-with-rotation-factor-0-5@pipe-b-hdmi-a-1:
    - shard-dg1:          NOTRUN -> [SKIP][132] ([i915#5176]) +11 similar issues
   [132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-dg1-19/igt@kms_plane_scaling@plane-downscale-with-rotation-factor-0-5@pipe-b-hdmi-a-1.html

  * igt@kms_plane_scaling@plane-upscale-with-rotation-20x20@pipe-a-hdmi-a-2:
    - shard-rkl:          NOTRUN -> [SKIP][133] ([i915#5176]) +7 similar issues
   [133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-rkl-2/igt@kms_plane_scaling@plane-upscale-with-rotation-20x20@pipe-a-hdmi-a-2.html

  * igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-20x20@pipe-b-hdmi-a-2:
    - shard-rkl:          NOTRUN -> [SKIP][134] ([i915#5235]) +3 similar issues
   [134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-rkl-1/igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-20x20@pipe-b-hdmi-a-2.html

  * igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-factor-0-25@pipe-d-dp-4:
    - shard-dg2:          NOTRUN -> [SKIP][135] ([i915#5235]) +11 similar issues
   [135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-dg2-11/igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-factor-0-25@pipe-d-dp-4.html

  * igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-25@pipe-c-hdmi-a-1:
    - shard-dg1:          NOTRUN -> [SKIP][136] ([i915#5235]) +7 similar issues
   [136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-dg1-19/igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-25@pipe-c-hdmi-a-1.html

  * igt@kms_psr2_sf@plane-move-sf-dmg-area:
    - shard-dg2:          NOTRUN -> [SKIP][137] ([i915#658]) +1 similar issue
   [137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-dg2-5/igt@kms_psr2_sf@plane-move-sf-dmg-area.html

  * igt@kms_psr@psr2_sprite_mmap_gtt:
    - shard-dg2:          NOTRUN -> [SKIP][138] ([i915#1072]) +4 similar issues
   [138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-dg2-11/igt@kms_psr@psr2_sprite_mmap_gtt.html

  * igt@kms_rotation_crc@sprite-rotation-90:
    - shard-dg2:          NOTRUN -> [SKIP][139] ([i915#4235])
   [139]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-dg2-5/igt@kms_rotation_crc@sprite-rotation-90.html

  * igt@kms_selftest@drm_format:
    - shard-mtlp:         NOTRUN -> [SKIP][140] ([i915#8661])
   [140]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-mtlp-6/igt@kms_selftest@drm_format.html

  * igt@perf@global-sseu-config:
    - shard-mtlp:         NOTRUN -> [SKIP][141] ([i915#7387])
   [141]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-mtlp-6/igt@perf@global-sseu-config.html

  * igt@perf_pmu@semaphore-busy@vcs1:
    - shard-mtlp:         NOTRUN -> [FAIL][142] ([i915#4349]) +3 similar issues
   [142]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-mtlp-6/igt@perf_pmu@semaphore-busy@vcs1.html

  * igt@prime_vgem@fence-write-hang:
    - shard-mtlp:         NOTRUN -> [SKIP][143] ([i915#3708])
   [143]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-mtlp-6/igt@prime_vgem@fence-write-hang.html

  * igt@v3d/v3d_perfmon@create-perfmon-invalid-counters:
    - shard-dg2:          NOTRUN -> [SKIP][144] ([i915#2575]) +6 similar issues
   [144]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-dg2-11/igt@v3d/v3d_perfmon@create-perfmon-invalid-counters.html

  * igt@v3d/v3d_submit_csd@bad-bo:
    - shard-mtlp:         NOTRUN -> [SKIP][145] ([i915#2575])
   [145]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-mtlp-6/igt@v3d/v3d_submit_csd@bad-bo.html

  * igt@vc4/vc4_perfmon@get-values-invalid-pointer:
    - shard-mtlp:         NOTRUN -> [SKIP][146] ([i915#7711]) +3 similar issues
   [146]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-mtlp-6/igt@vc4/vc4_perfmon@get-values-invalid-pointer.html

  * igt@vc4/vc4_wait_seqno@bad-seqno-1ns:
    - shard-dg2:          NOTRUN -> [SKIP][147] ([i915#7711]) +3 similar issues
   [147]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-dg2-5/igt@vc4/vc4_wait_seqno@bad-seqno-1ns.html

  
#### Possible fixes ####

  * igt@drm_fdinfo@most-busy-check-all@rcs0:
    - shard-rkl:          [FAIL][148] ([i915#7742]) -> [PASS][149] +1 similar issue
   [148]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13549/shard-rkl-1/igt@drm_fdinfo@most-busy-check-all@rcs0.html
   [149]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-rkl-4/igt@drm_fdinfo@most-busy-check-all@rcs0.html

  * igt@gem_ctx_exec@basic-nohangcheck:
    - shard-rkl:          [FAIL][150] ([i915#6268]) -> [PASS][151]
   [150]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13549/shard-rkl-2/igt@gem_ctx_exec@basic-nohangcheck.html
   [151]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-rkl-6/igt@gem_ctx_exec@basic-nohangcheck.html
    - shard-tglu:         [FAIL][152] ([i915#6268]) -> [PASS][153]
   [152]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13549/shard-tglu-4/igt@gem_ctx_exec@basic-nohangcheck.html
   [153]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-tglu-4/igt@gem_ctx_exec@basic-nohangcheck.html

  * igt@gem_ctx_isolation@preservation-s3@ccs3:
    - shard-dg2:          [INCOMPLETE][154] ([i915#9162]) -> [PASS][155]
   [154]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13549/shard-dg2-11/igt@gem_ctx_isolation@preservation-s3@ccs3.html
   [155]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-dg2-12/igt@gem_ctx_isolation@preservation-s3@ccs3.html

  * igt@gem_exec_capture@pi@rcs0:
    - shard-mtlp:         [FAIL][156] ([i915#4475]) -> [PASS][157]
   [156]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13549/shard-mtlp-2/igt@gem_exec_capture@pi@rcs0.html
   [157]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-mtlp-5/igt@gem_exec_capture@pi@rcs0.html

  * igt@gem_exec_endless@dispatch@vcs0:
    - shard-dg1:          [TIMEOUT][158] ([i915#3778]) -> [PASS][159]
   [158]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13549/shard-dg1-14/igt@gem_exec_endless@dispatch@vcs0.html
   [159]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-dg1-19/igt@gem_exec_endless@dispatch@vcs0.html

  * igt@gem_exec_fair@basic-deadline:
    - shard-glk:          [FAIL][160] ([i915#2846]) -> [PASS][161]
   [160]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13549/shard-glk8/igt@gem_exec_fair@basic-deadline.html
   [161]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-glk4/igt@gem_exec_fair@basic-deadline.html

  * igt@gem_exec_fair@basic-none-solo@rcs0:
    - shard-apl:          [FAIL][162] ([i915#2842]) -> [PASS][163]
   [162]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13549/shard-apl1/igt@gem_exec_fair@basic-none-solo@rcs0.html
   [163]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-apl1/igt@gem_exec_fair@basic-none-solo@rcs0.html

  * igt@gen9_exec_parse@allowed-single:
    - shard-glk:          [ABORT][164] ([i915#5566]) -> [PASS][165]
   [164]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13549/shard-glk8/igt@gen9_exec_parse@allowed-single.html
   [165]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-glk4/igt@gen9_exec_parse@allowed-single.html

  * igt@i915_pm_rpm@dpms-lpsp:
    - shard-rkl:          [SKIP][166] ([i915#1397]) -> [PASS][167] +1 similar issue
   [166]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13549/shard-rkl-1/igt@i915_pm_rpm@dpms-lpsp.html
   [167]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-rkl-7/igt@i915_pm_rpm@dpms-lpsp.html
    - shard-dg1:          [SKIP][168] ([i915#1397]) -> [PASS][169]
   [168]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13549/shard-dg1-14/igt@i915_pm_rpm@dpms-lpsp.html
   [169]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-dg1-19/igt@i915_pm_rpm@dpms-lpsp.html

  * igt@i915_suspend@forcewake:
    - shard-dg2:          [FAIL][170] ([fdo#103375]) -> [PASS][171] +2 similar issues
   [170]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13549/shard-dg2-5/igt@i915_suspend@forcewake.html
   [171]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-dg2-12/igt@i915_suspend@forcewake.html

  * igt@i915_suspend@sysfs-reader:
    - shard-mtlp:         [ABORT][172] ([i915#8466]) -> [PASS][173]
   [172]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13549/shard-mtlp-7/igt@i915_suspend@sysfs-reader.html
   [173]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-mtlp-6/igt@i915_suspend@sysfs-reader.html

  * igt@kms_big_fb@4-tiled-64bpp-rotate-180:
    - shard-mtlp:         [FAIL][174] ([i915#5138]) -> [PASS][175]
   [174]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13549/shard-mtlp-5/igt@kms_big_fb@4-tiled-64bpp-rotate-180.html
   [175]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-mtlp-1/igt@kms_big_fb@4-tiled-64bpp-rotate-180.html

  * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
    - shard-apl:          [FAIL][176] ([i915#2346]) -> [PASS][177]
   [176]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13549/shard-apl3/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
   [177]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-apl4/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html

  * igt@kms_fbcon_fbt@psr-suspend:
    - shard-mtlp:         [FAIL][178] ([i915#4767]) -> [PASS][179]
   [178]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13549/shard-mtlp-5/igt@kms_fbcon_fbt@psr-suspend.html
   [179]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-mtlp-1/igt@kms_fbcon_fbt@psr-suspend.html

  * igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite:
    - shard-dg2:          [FAIL][180] ([i915#6880]) -> [PASS][181] +1 similar issue
   [180]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13549/shard-dg2-3/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite.html
   [181]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-dg2-6/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite.html

  * igt@kms_getfb@getfb-addfb-different-handles:
    - shard-mtlp:         [DMESG-WARN][182] ([i915#2017]) -> [PASS][183]
   [182]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13549/shard-mtlp-4/igt@kms_getfb@getfb-addfb-different-handles.html
   [183]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-mtlp-4/igt@kms_getfb@getfb-addfb-different-handles.html

  * igt@kms_plane@pixel-format@pipe-b-planes:
    - shard-mtlp:         [FAIL][184] ([i915#1623]) -> [PASS][185]
   [184]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13549/shard-mtlp-7/igt@kms_plane@pixel-format@pipe-b-planes.html
   [185]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-mtlp-1/igt@kms_plane@pixel-format@pipe-b-planes.html

  * igt@perf@non-zero-reason@0-rcs0:
    - shard-dg2:          [FAIL][186] ([i915#7484]) -> [PASS][187]
   [186]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13549/shard-dg2-3/igt@perf@non-zero-reason@0-rcs0.html
   [187]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-dg2-6/igt@perf@non-zero-reason@0-rcs0.html

  
#### Warnings ####

  * igt@gem_exec_fence@parallel@bcs0:
    - shard-mtlp:         [DMESG-FAIL][188] ([i915#8962] / [i915#9121]) -> [TIMEOUT][189] ([i915#9137])
   [188]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13549/shard-mtlp-4/igt@gem_exec_fence@parallel@bcs0.html
   [189]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-mtlp-4/igt@gem_exec_fence@parallel@bcs0.html

  * igt@gem_spin_batch@user-each:
    - shard-mtlp:         [DMESG-FAIL][190] ([i915#8962] / [i915#9121]) -> [DMESG-FAIL][191] ([i915#9121])
   [190]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13549/shard-mtlp-4/igt@gem_spin_batch@user-each.html
   [191]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-mtlp-4/igt@gem_spin_batch@user-each.html

  * igt@i915_pm_rc6_residency@rc6-idle@rcs0:
    - shard-tglu:         [FAIL][192] ([i915#2681] / [i915#3591]) -> [WARN][193] ([i915#2681])
   [192]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13549/shard-tglu-9/igt@i915_pm_rc6_residency@rc6-idle@rcs0.html
   [193]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-tglu-3/igt@i915_pm_rc6_residency@rc6-idle@rcs0.html

  * igt@i915_pm_rps@reset:
    - shard-dg1:          [FAIL][194] -> [FAIL][195] ([i915#8229])
   [194]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13549/shard-dg1-14/igt@i915_pm_rps@reset.html
   [195]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-dg1-19/igt@i915_pm_rps@reset.html

  * igt@kms_content_protection@content_type_change:
    - shard-dg2:          [SKIP][196] ([i915#7118]) -> [SKIP][197] ([i915#7118] / [i915#7162])
   [196]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13549/shard-dg2-5/igt@kms_content_protection@content_type_change.html
   [197]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-dg2-12/igt@kms_content_protection@content_type_change.html

  * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
    - shard-mtlp:         [FAIL][198] ([i915#2346]) -> [DMESG-FAIL][199] ([i915#1982] / [i915#2017] / [i915#5954])
   [198]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13549/shard-mtlp-2/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
   [199]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-mtlp-4/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html

  * igt@kms_fbcon_fbt@psr:
    - shard-rkl:          [SKIP][200] ([fdo#110189] / [i915#3955]) -> [SKIP][201] ([i915#3955])
   [200]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13549/shard-rkl-1/igt@kms_fbcon_fbt@psr.html
   [201]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-rkl-7/igt@kms_fbcon_fbt@psr.html

  * igt@kms_force_connector_basic@force-load-detect:
    - shard-rkl:          [SKIP][202] ([fdo#109285]) -> [SKIP][203] ([fdo#109285] / [i915#4098])
   [202]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13549/shard-rkl-7/igt@kms_force_connector_basic@force-load-detect.html
   [203]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-rkl-1/igt@kms_force_connector_basic@force-load-detect.html

  * igt@kms_multipipe_modeset@basic-max-pipe-crc-check:
    - shard-rkl:          [SKIP][204] ([i915#4816]) -> [SKIP][205] ([i915#4070] / [i915#4816])
   [204]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13549/shard-rkl-7/igt@kms_multipipe_modeset@basic-max-pipe-crc-check.html
   [205]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-rkl-1/igt@kms_multipipe_modeset@basic-max-pipe-crc-check.html

  * igt@kms_psr@cursor_plane_move:
    - shard-dg1:          [SKIP][206] ([i915#1072] / [i915#4078]) -> [SKIP][207] ([i915#1072])
   [206]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13549/shard-dg1-13/igt@kms_psr@cursor_plane_move.html
   [207]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-dg1-14/igt@kms_psr@cursor_plane_move.html

  * igt@kms_psr@sprite_plane_onoff:
    - shard-dg1:          [SKIP][208] ([i915#1072]) -> [SKIP][209] ([i915#1072] / [i915#4078]) +1 similar issue
   [208]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13549/shard-dg1-15/igt@kms_psr@sprite_plane_onoff.html
   [209]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/shard-dg1-16/igt@kms_psr@sprite_plane_onoff.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
  [fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
  [fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
  [fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
  [fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
  [fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
  [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
  [fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283
  [i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
  [i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099
  [i915#1339]: https://gitlab.freedesktop.org/drm/intel/issues/1339
  [i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
  [i915#1623]: https://gitlab.freedesktop.org/drm/intel/issues/1623
  [i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
  [i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
  [i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
  [i915#2017]: https://gitlab.freedesktop.org/drm/intel/issues/2017
  [i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
  [i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
  [i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
  [i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
  [i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
  [i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
  [i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
  [i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
  [i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
  [i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
  [i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
  [i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
  [i915#3318]: https://gitlab.freedesktop.org/drm/intel/issues/3318
  [i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
  [i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
  [i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
  [i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
  [i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
  [i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
  [i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
  [i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
  [i915#3743]: https://gitlab.freedesktop.org/drm/intel/issues/3743
  [i915#3778]: https://gitlab.freedesktop.org/drm/intel/issues/3778
  [i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840
  [i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
  [i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
  [i915#3989]: https://gitlab.freedesktop.org/drm/intel/issues/3989
  [i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
  [i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
  [i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
  [i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
  [i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
  [i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
  [i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
  [i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
  [i915#4235]: https://gitlab.freedesktop.org/drm/intel/issues/4235
  [i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
  [i915#4349]: https://gitlab.freedesktop.org/drm/intel/issues/4349
  [i915#4473]: https://gitlab.freedesktop.org/drm/intel/issues/4473
  [i915#4475]: https://gitlab.freedesktop.org/drm/intel/issues/4475
  [i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
  [i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
  [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
  [i915#4767]: https://gitlab.freedesktop.org/drm/intel/issues/4767
  [i915#4771]: https://gitlab.freedesktop.org/drm/intel/issues/4771
  [i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
  [i915#4816]: https://gitlab.freedesktop.org/drm/intel/issues/4816
  [i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860
  [i915#4873]: https://gitlab.freedesktop.org/drm/intel/issues/4873
  [i915#4880]: https://gitlab.freedesktop.org/drm/intel/issues/4880
  [i915#4881]: https://gitlab.freedesktop.org/drm/intel/issues/4881
  [i915#4885]: https://gitlab.freedesktop.org/drm/intel/issues/4885
  [i915#5138]: https://gitlab.freedesktop.org/drm/intel/issues/5138
  [i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
  [i915#5190]: https://gitlab.freedesktop.org/drm/intel/issues/5190
  [i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
  [i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
  [i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
  [i915#5460]: https://gitlab.freedesktop.org/drm/intel/issues/5460
  [i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
  [i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
  [i915#5954]: https://gitlab.freedesktop.org/drm/intel/issues/5954
  [i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
  [i915#6227]: https://gitlab.freedesktop.org/drm/intel/issues/6227
  [i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
  [i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
  [i915#6880]: https://gitlab.freedesktop.org/drm/intel/issues/6880
  [i915#6953]: https://gitlab.freedesktop.org/drm/intel/issues/6953
  [i915#7016]: https://gitlab.freedesktop.org/drm/intel/issues/7016
  [i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
  [i915#7162]: https://gitlab.freedesktop.org/drm/intel/issues/7162
  [i915#7387]: https://gitlab.freedesktop.org/drm/intel/issues/7387
  [i915#7484]: https://gitlab.freedesktop.org/drm/intel/issues/7484
  [i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
  [i915#7697]: https://gitlab.freedesktop.org/drm/intel/issues/7697
  [i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
  [i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
  [i915#7790]: https://gitlab.freedesktop.org/drm/intel/issues/7790
  [i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
  [i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
  [i915#7921]: https://gitlab.freedesktop.org/drm/intel/issues/7921
  [i915#7982]: https://gitlab.freedesktop.org/drm/intel/issues/7982
  [i915#8228]: https://gitlab.freedesktop.org/drm/intel/issues/8228
  [i915#8229]: https://gitlab.freedesktop.org/drm/intel/issues/8229
  [i915#8247]: https://gitlab.freedesktop.org/drm/intel/issues/8247
  [i915#8292]: https://gitlab.freedesktop.org/drm/intel/issues/8292
  [i915#8411]: https://gitlab.freedesktop.org/drm/intel/issues/8411
  [i915#8414]: https://gitlab.freedesktop.org/drm/intel/issues/8414
  [i915#8428]: https://gitlab.freedesktop.org/drm/intel/issues/8428
  [i915#8466]: https://gitlab.freedesktop.org/drm/intel/issues/8466
  [i915#8502]: https://gitlab.freedesktop.org/drm/intel/issues/8502
  [i915#8555]: https://gitlab.freedesktop.org/drm/intel/issues/8555
  [i915#8661]: https://gitlab.freedesktop.org/drm/intel/issues/8661
  [i915#8691]: https://gitlab.freedesktop.org/drm/intel/issues/8691
  [i915#8708]: https://gitlab.freedesktop.org/drm/intel/issues/8708
  [i915#8709]: https://gitlab.freedesktop.org/drm/intel/issues/8709
  [i915#8806]: https://gitlab.freedesktop.org/drm/intel/issues/8806
  [i915#8810]: https://gitlab.freedesktop.org/drm/intel/issues/8810
  [i915#8814]: https://gitlab.freedesktop.org/drm/intel/issues/8814
  [i915#8841]: https://gitlab.freedesktop.org/drm/intel/issues/8841
  [i915#8925]: https://gitlab.freedesktop.org/drm/intel/issues/8925
  [i915#8962]: https://gitlab.freedesktop.org/drm/intel/issues/8962
  [i915#9121]: https://gitlab.freedesktop.org/drm/intel/issues/9121
  [i915#9137]: https://gitlab.freedesktop.org/drm/intel/issues/9137
  [i915#9138]: https://gitlab.freedesktop.org/drm/intel/issues/9138
  [i915#9162]: https://gitlab.freedesktop.org/drm/intel/issues/9162


Build changes
-------------

  * Linux: CI_DRM_13549 -> Patchwork_122739v2

  CI-20190529: 20190529
  CI_DRM_13549: daa7b246575041e069f151cfbc69d07e321bdc01 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_7451: 5d48d1fb231f449fe2f80cda14ea7a1ecfda59fa @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
  Patchwork_122739v2: daa7b246575041e069f151cfbc69d07e321bdc01 @ git://anongit.freedesktop.org/gfx-ci/linux
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122739v2/index.html

[-- Attachment #2: Type: text/html, Size: 65467 bytes --]

Re: [Intel-gfx] [PATCH 0/4] drm/amd/display: stop using drm_edid_override_connector_update()

[Jani Nikula]

On Wed, 23 Aug 2023, Jani Nikula <jani.nikula@intel.com> wrote:
> On Tue, 22 Aug 2023, Alex Hung <alex.hung@amd.com> wrote:
>> On 2023-08-22 06:01, Jani Nikula wrote:
>>> Over the past years I've been trying to unify the override and firmware
>>> EDID handling as well as EDID property updates. It won't work if drivers
>>> do their own random things.
>> Let's check how to replace these references by appropriate ones or fork 
>> the function as reverting these patches causes regressions.
>
> I think the fundamental problem you have is conflating connector forcing
> with EDID override. They're orthogonal. The .force callback has no
> business basing the decisions on connector->edid_override. Force is
> force, override is override.
>
> The driver isn't even supposed to know or care if the EDID originates
> from the firmware loader or override EDID debugfs. drm_get_edid() will
> handle that for you transparently. It'll return the EDID, and you
> shouldn't look at connector->edid_blob_ptr either. Using that will make
> future work in drm_edid.c harder.
>
> You can't fix that with minor tweaks. I think you'll be better off
> starting from scratch.
>
> Also, connector->edid_override is debugfs. You actually can change the
> behaviour. If your userspace, whatever it is, has been written to assume
> connector forcing if EDID override is set, you *do* have to fix that,
> and set both.

Any updates on fixing this, or shall we proceed with the reverts?

BR,
Jani.



>
> BR,
> Jani.
>
>
>>
>> Cheers,
>> Alex
>>
>>> 
>>> BR,
>>> Jani.
>>> 
>>> 
>>> Cc: Alex Deucher <alexander.deucher@amd.com>
>>> Cc: Alex Hung <alex.hung@amd.com>
>>> Cc: Chao-kai Wang <Stylon.Wang@amd.com>
>>> Cc: Daniel Wheeler <daniel.wheeler@amd.com>
>>> Cc: Harry Wentland <harry.wentland@amd.com>
>>> Cc: Hersen Wu <hersenxs.wu@amd.com>
>>> Cc: Leo Li <sunpeng.li@amd.com>
>>> Cc: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
>>> Cc: Wenchieh Chien <wenchieh.chien@amd.com>
>>> Cc: David Airlie <airlied@gmail.com>
>>> Cc: Daniel Vetter <daniel@ffwll.ch>
>>> 
>>> Jani Nikula (4):
>>>    Revert "drm/amd/display: drop unused count variable in
>>>      create_eml_sink()"
>>>    Revert "drm/amd/display: assign edid_blob_ptr with edid from debugfs"
>>>    Revert "drm/amd/display: mark amdgpu_dm_connector_funcs_force static"
>>>    Revert "drm/amd/display: implement force function in
>>>      amdgpu_dm_connector_funcs"
>>> 
>>>   .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 44 +++----------------
>>>   1 file changed, 5 insertions(+), 39 deletions(-)
>>> 

-- 
Jani Nikula, Intel Open Source Graphics Center

Re: [Intel-gfx] [PATCH 0/4] drm/amd/display: stop using drm_edid_override_connector_update()

[Wu, Hersen]

[AMD Official Use Only - General]

+ Charlie

-----Original Message-----
From: Jani Nikula <jani.nikula@intel.com>
Sent: Tuesday, August 29, 2023 6:49 AM
To: Hung, Alex <Alex.Hung@amd.com>; dri-devel@lists.freedesktop.org; amd-gfx@lists.freedesktop.org
Cc: Li, Sun peng (Leo) <Sunpeng.Li@amd.com>; David Airlie <airlied@gmail.com>; intel-gfx@lists.freedesktop.org; Siqueira, Rodrigo <Rodrigo.Siqueira@amd.com>; Wheeler, Daniel <Daniel.Wheeler@amd.com>; Wu, Hersen <hersenxs.wu@amd.com>; Daniel Vetter <daniel@ffwll.ch>; Chien, WenChieh (Jay) <WenChieh.Chien@amd.com>; Deucher, Alexander <Alexander.Deucher@amd.com>; Wentland, Harry <Harry.Wentland@amd.com>
Subject: Re: [Intel-gfx] [PATCH 0/4] drm/amd/display: stop using drm_edid_override_connector_update()

On Wed, 23 Aug 2023, Jani Nikula <jani.nikula@intel.com> wrote:
> On Tue, 22 Aug 2023, Alex Hung <alex.hung@amd.com> wrote:
>> On 2023-08-22 06:01, Jani Nikula wrote:
>>> Over the past years I've been trying to unify the override and
>>> firmware EDID handling as well as EDID property updates. It won't
>>> work if drivers do their own random things.
>> Let's check how to replace these references by appropriate ones or
>> fork the function as reverting these patches causes regressions.
>
> I think the fundamental problem you have is conflating connector
> forcing with EDID override. They're orthogonal. The .force callback
> has no business basing the decisions on connector->edid_override.
> Force is force, override is override.
>
> The driver isn't even supposed to know or care if the EDID originates
> from the firmware loader or override EDID debugfs. drm_get_edid() will
> handle that for you transparently. It'll return the EDID, and you
> shouldn't look at connector->edid_blob_ptr either. Using that will
> make future work in drm_edid.c harder.
>
> You can't fix that with minor tweaks. I think you'll be better off
> starting from scratch.
>
> Also, connector->edid_override is debugfs. You actually can change the
> behaviour. If your userspace, whatever it is, has been written to
> assume connector forcing if EDID override is set, you *do* have to fix
> that, and set both.

Any updates on fixing this, or shall we proceed with the reverts?

BR,
Jani.



>
> BR,
> Jani.
>
>
>>
>> Cheers,
>> Alex
>>
>>>
>>> BR,
>>> Jani.
>>>
>>>
>>> Cc: Alex Deucher <alexander.deucher@amd.com>
>>> Cc: Alex Hung <alex.hung@amd.com>
>>> Cc: Chao-kai Wang <Stylon.Wang@amd.com>
>>> Cc: Daniel Wheeler <daniel.wheeler@amd.com>
>>> Cc: Harry Wentland <harry.wentland@amd.com>
>>> Cc: Hersen Wu <hersenxs.wu@amd.com>
>>> Cc: Leo Li <sunpeng.li@amd.com>
>>> Cc: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
>>> Cc: Wenchieh Chien <wenchieh.chien@amd.com>
>>> Cc: David Airlie <airlied@gmail.com>
>>> Cc: Daniel Vetter <daniel@ffwll.ch>
>>>
>>> Jani Nikula (4):
>>>    Revert "drm/amd/display: drop unused count variable in
>>>      create_eml_sink()"
>>>    Revert "drm/amd/display: assign edid_blob_ptr with edid from debugfs"
>>>    Revert "drm/amd/display: mark amdgpu_dm_connector_funcs_force static"
>>>    Revert "drm/amd/display: implement force function in
>>>      amdgpu_dm_connector_funcs"
>>>
>>>   .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 44 +++----------------
>>>   1 file changed, 5 insertions(+), 39 deletions(-)
>>>

--
Jani Nikula, Intel Open Source Graphics Center

Re: [Intel-gfx] [PATCH 0/4] drm/amd/display: stop using drm_edid_override_connector_update()

[Alex Deucher]

On Tue, Aug 29, 2023 at 6:48 AM Jani Nikula <jani.nikula@intel.com> wrote:
>
> On Wed, 23 Aug 2023, Jani Nikula <jani.nikula@intel.com> wrote:
> > On Tue, 22 Aug 2023, Alex Hung <alex.hung@amd.com> wrote:
> >> On 2023-08-22 06:01, Jani Nikula wrote:
> >>> Over the past years I've been trying to unify the override and firmware
> >>> EDID handling as well as EDID property updates. It won't work if drivers
> >>> do their own random things.
> >> Let's check how to replace these references by appropriate ones or fork
> >> the function as reverting these patches causes regressions.
> >
> > I think the fundamental problem you have is conflating connector forcing
> > with EDID override. They're orthogonal. The .force callback has no
> > business basing the decisions on connector->edid_override. Force is
> > force, override is override.
> >
> > The driver isn't even supposed to know or care if the EDID originates
> > from the firmware loader or override EDID debugfs. drm_get_edid() will
> > handle that for you transparently. It'll return the EDID, and you
> > shouldn't look at connector->edid_blob_ptr either. Using that will make
> > future work in drm_edid.c harder.
> >
> > You can't fix that with minor tweaks. I think you'll be better off
> > starting from scratch.
> >
> > Also, connector->edid_override is debugfs. You actually can change the
> > behaviour. If your userspace, whatever it is, has been written to assume
> > connector forcing if EDID override is set, you *do* have to fix that,
> > and set both.
>
> Any updates on fixing this, or shall we proceed with the reverts?

What is the goal of the reverts?  I don't disagree that we may be
using the interfaces wrong, but reverting them will regess
functionality in the driver.

Alex

Re: [Intel-gfx] [PATCH 0/4] drm/amd/display: stop using drm_edid_override_connector_update()

[Wu, Hersen]

[AMD Official Use Only - General]

+ Charlie Wang

-----Original Message-----
From: Alex Deucher <alexdeucher@gmail.com>
Sent: Tuesday, August 29, 2023 11:44 AM
To: Jani Nikula <jani.nikula@intel.com>
Cc: Hung, Alex <Alex.Hung@amd.com>; dri-devel@lists.freedesktop.org; amd-gfx@lists.freedesktop.org; Li, Sun peng (Leo) <Sunpeng.Li@amd.com>; intel-gfx@lists.freedesktop.org; Siqueira, Rodrigo <Rodrigo.Siqueira@amd.com>; Wheeler, Daniel <Daniel.Wheeler@amd.com>; Wu, Hersen <hersenxs.wu@amd.com>; Chien, WenChieh (Jay) <WenChieh.Chien@amd.com>; Deucher, Alexander <Alexander.Deucher@amd.com>
Subject: Re: [Intel-gfx] [PATCH 0/4] drm/amd/display: stop using drm_edid_override_connector_update()

On Tue, Aug 29, 2023 at 6:48 AM Jani Nikula <jani.nikula@intel.com> wrote:
>
> On Wed, 23 Aug 2023, Jani Nikula <jani.nikula@intel.com> wrote:
> > On Tue, 22 Aug 2023, Alex Hung <alex.hung@amd.com> wrote:
> >> On 2023-08-22 06:01, Jani Nikula wrote:
> >>> Over the past years I've been trying to unify the override and
> >>> firmware EDID handling as well as EDID property updates. It won't
> >>> work if drivers do their own random things.
> >> Let's check how to replace these references by appropriate ones or
> >> fork the function as reverting these patches causes regressions.
> >
> > I think the fundamental problem you have is conflating connector
> > forcing with EDID override. They're orthogonal. The .force callback
> > has no business basing the decisions on connector->edid_override.
> > Force is force, override is override.
> >
> > The driver isn't even supposed to know or care if the EDID
> > originates from the firmware loader or override EDID debugfs.
> > drm_get_edid() will handle that for you transparently. It'll return
> > the EDID, and you shouldn't look at connector->edid_blob_ptr either.
> > Using that will make future work in drm_edid.c harder.
> >
> > You can't fix that with minor tweaks. I think you'll be better off
> > starting from scratch.
> >
> > Also, connector->edid_override is debugfs. You actually can change
> > the behaviour. If your userspace, whatever it is, has been written
> > to assume connector forcing if EDID override is set, you *do* have
> > to fix that, and set both.
>
> Any updates on fixing this, or shall we proceed with the reverts?

What is the goal of the reverts?  I don't disagree that we may be using the interfaces wrong, but reverting them will regess functionality in the driver.

Alex

Re: [Intel-gfx] [PATCH 0/4] drm/amd/display: stop using drm_edid_override_connector_update()

[Jani Nikula]

On Tue, 29 Aug 2023, Alex Deucher <alexdeucher@gmail.com> wrote:
> On Tue, Aug 29, 2023 at 6:48 AM Jani Nikula <jani.nikula@intel.com> wrote:
>>
>> On Wed, 23 Aug 2023, Jani Nikula <jani.nikula@intel.com> wrote:
>> > On Tue, 22 Aug 2023, Alex Hung <alex.hung@amd.com> wrote:
>> >> On 2023-08-22 06:01, Jani Nikula wrote:
>> >>> Over the past years I've been trying to unify the override and firmware
>> >>> EDID handling as well as EDID property updates. It won't work if drivers
>> >>> do their own random things.
>> >> Let's check how to replace these references by appropriate ones or fork
>> >> the function as reverting these patches causes regressions.
>> >
>> > I think the fundamental problem you have is conflating connector forcing
>> > with EDID override. They're orthogonal. The .force callback has no
>> > business basing the decisions on connector->edid_override. Force is
>> > force, override is override.
>> >
>> > The driver isn't even supposed to know or care if the EDID originates
>> > from the firmware loader or override EDID debugfs. drm_get_edid() will
>> > handle that for you transparently. It'll return the EDID, and you
>> > shouldn't look at connector->edid_blob_ptr either. Using that will make
>> > future work in drm_edid.c harder.
>> >
>> > You can't fix that with minor tweaks. I think you'll be better off
>> > starting from scratch.
>> >
>> > Also, connector->edid_override is debugfs. You actually can change the
>> > behaviour. If your userspace, whatever it is, has been written to assume
>> > connector forcing if EDID override is set, you *do* have to fix that,
>> > and set both.
>>
>> Any updates on fixing this, or shall we proceed with the reverts?
>
> What is the goal of the reverts?  I don't disagree that we may be
> using the interfaces wrong, but reverting them will regess
> functionality in the driver.

The commits are in v6.5-rc1, but not yet in a release. No user depends
on them yet. I'd strongly prefer them not reaching v6.5 final and users.

The firmware EDID, override EDID, connector forcing, the EDID property,
etc. have been and somewhat still are a hairy mess that we must keep
untangling, and this isn't helping.

I've put in crazy amounts of work on this, and I've added kernel-doc
comments about stuff that should and should not be done, but they go
unread and ignored.

I really don't want to end up having to clean this up myself before I
can embark on further cleanups and refactoring.

And again, if the functionality in the driver depends on conflating two
things that should be separate, it's probably not such a hot idea to let
it reach users either. Even if it's just debugfs.


BR,
Jani.


-- 
Jani Nikula, Intel Open Source Graphics Center

Re: [Intel-gfx] [PATCH 0/4] drm/amd/display: stop using drm_edid_override_connector_update()

[Jani Nikula]

On Tue, 29 Aug 2023, Jani Nikula <jani.nikula@intel.com> wrote:
> On Tue, 29 Aug 2023, Alex Deucher <alexdeucher@gmail.com> wrote:
>> On Tue, Aug 29, 2023 at 6:48 AM Jani Nikula <jani.nikula@intel.com> wrote:
>>>
>>> On Wed, 23 Aug 2023, Jani Nikula <jani.nikula@intel.com> wrote:
>>> > On Tue, 22 Aug 2023, Alex Hung <alex.hung@amd.com> wrote:
>>> >> On 2023-08-22 06:01, Jani Nikula wrote:
>>> >>> Over the past years I've been trying to unify the override and firmware
>>> >>> EDID handling as well as EDID property updates. It won't work if drivers
>>> >>> do their own random things.
>>> >> Let's check how to replace these references by appropriate ones or fork
>>> >> the function as reverting these patches causes regressions.
>>> >
>>> > I think the fundamental problem you have is conflating connector forcing
>>> > with EDID override. They're orthogonal. The .force callback has no
>>> > business basing the decisions on connector->edid_override. Force is
>>> > force, override is override.
>>> >
>>> > The driver isn't even supposed to know or care if the EDID originates
>>> > from the firmware loader or override EDID debugfs. drm_get_edid() will
>>> > handle that for you transparently. It'll return the EDID, and you
>>> > shouldn't look at connector->edid_blob_ptr either. Using that will make
>>> > future work in drm_edid.c harder.
>>> >
>>> > You can't fix that with minor tweaks. I think you'll be better off
>>> > starting from scratch.
>>> >
>>> > Also, connector->edid_override is debugfs. You actually can change the
>>> > behaviour. If your userspace, whatever it is, has been written to assume
>>> > connector forcing if EDID override is set, you *do* have to fix that,
>>> > and set both.
>>>
>>> Any updates on fixing this, or shall we proceed with the reverts?
>>
>> What is the goal of the reverts?  I don't disagree that we may be
>> using the interfaces wrong, but reverting them will regess
>> functionality in the driver.
>
> The commits are in v6.5-rc1, but not yet in a release. No user depends
> on them yet. I'd strongly prefer them not reaching v6.5 final and users.

Sorry for confusion here, that's obviously come and gone already. :(

> The firmware EDID, override EDID, connector forcing, the EDID property,
> etc. have been and somewhat still are a hairy mess that we must keep
> untangling, and this isn't helping.
>
> I've put in crazy amounts of work on this, and I've added kernel-doc
> comments about stuff that should and should not be done, but they go
> unread and ignored.
>
> I really don't want to end up having to clean this up myself before I
> can embark on further cleanups and refactoring.
>
> And again, if the functionality in the driver depends on conflating two
> things that should be separate, it's probably not such a hot idea to let
> it reach users either. Even if it's just debugfs.
>
>
> BR,
> Jani.

-- 
Jani Nikula, Intel Open Source Graphics Center

Re: [Intel-gfx] [PATCH 0/4] drm/amd/display: stop using drm_edid_override_connector_update()

[Alex Hung]

On 2023-08-29 11:03, Jani Nikula wrote:
> On Tue, 29 Aug 2023, Jani Nikula <jani.nikula@intel.com> wrote:
>> On Tue, 29 Aug 2023, Alex Deucher <alexdeucher@gmail.com> wrote:
>>> On Tue, Aug 29, 2023 at 6:48 AM Jani Nikula <jani.nikula@intel.com> wrote:
>>>>
>>>> On Wed, 23 Aug 2023, Jani Nikula <jani.nikula@intel.com> wrote:
>>>>> On Tue, 22 Aug 2023, Alex Hung <alex.hung@amd.com> wrote:
>>>>>> On 2023-08-22 06:01, Jani Nikula wrote:
>>>>>>> Over the past years I've been trying to unify the override and firmware
>>>>>>> EDID handling as well as EDID property updates. It won't work if drivers
>>>>>>> do their own random things.
>>>>>> Let's check how to replace these references by appropriate ones or fork
>>>>>> the function as reverting these patches causes regressions.
>>>>>
>>>>> I think the fundamental problem you have is conflating connector forcing
>>>>> with EDID override. They're orthogonal. The .force callback has no
>>>>> business basing the decisions on connector->edid_override. Force is
>>>>> force, override is override.
>>>>>
>>>>> The driver isn't even supposed to know or care if the EDID originates
>>>>> from the firmware loader or override EDID debugfs. drm_get_edid() will
>>>>> handle that for you transparently. It'll return the EDID, and you
>>>>> shouldn't look at connector->edid_blob_ptr either. Using that will make
>>>>> future work in drm_edid.c harder.
>>>>>
>>>>> You can't fix that with minor tweaks. I think you'll be better off
>>>>> starting from scratch.
>>>>>
>>>>> Also, connector->edid_override is debugfs. You actually can change the
>>>>> behaviour. If your userspace, whatever it is, has been written to assume
>>>>> connector forcing if EDID override is set, you *do* have to fix that,
>>>>> and set both.
>>>>
>>>> Any updates on fixing this, or shall we proceed with the reverts?

There is a patch under internal reviews. It removes calls edid_override 
and drm_edid_override_connector_update as intended in this patchset but 
does not remove the functionality.

With the patch. both following git grep commands return nothing in 
amd-staging-drm-next.

$ git grep drm_edid_override_connector_update -- drivers/gpu/drm/amd
$ git grep edid_override -- drivers/gpu/drm/amd

Best regards,
Alex Hung

>>>
>>> What is the goal of the reverts?  I don't disagree that we may be
>>> using the interfaces wrong, but reverting them will regess
>>> functionality in the driver.
>>
>> The commits are in v6.5-rc1, but not yet in a release. No user depends
>> on them yet. I'd strongly prefer them not reaching v6.5 final and users.
> 
> Sorry for confusion here, that's obviously come and gone already. :(
> 
>> The firmware EDID, override EDID, connector forcing, the EDID property,
>> etc. have been and somewhat still are a hairy mess that we must keep
>> untangling, and this isn't helping.
>>
>> I've put in crazy amounts of work on this, and I've added kernel-doc
>> comments about stuff that should and should not be done, but they go
>> unread and ignored.
>>
>> I really don't want to end up having to clean this up myself before I
>> can embark on further cleanups and refactoring.
>>
>> And again, if the functionality in the driver depends on conflating two
>> things that should be separate, it's probably not such a hot idea to let
>> it reach users either. Even if it's just debugfs.
>>
>>
>> BR,
>> Jani.
> 

Re: [Intel-gfx] [PATCH 0/4] drm/amd/display: stop using drm_edid_override_connector_update()

[Jani Nikula]

On Tue, 29 Aug 2023, Alex Hung <alex.hung@amd.com> wrote:
> On 2023-08-29 11:03, Jani Nikula wrote:
>> On Tue, 29 Aug 2023, Jani Nikula <jani.nikula@intel.com> wrote:
>>> On Tue, 29 Aug 2023, Alex Deucher <alexdeucher@gmail.com> wrote:
>>>> On Tue, Aug 29, 2023 at 6:48 AM Jani Nikula <jani.nikula@intel.com> wrote:
>>>>>
>>>>> On Wed, 23 Aug 2023, Jani Nikula <jani.nikula@intel.com> wrote:
>>>>>> On Tue, 22 Aug 2023, Alex Hung <alex.hung@amd.com> wrote:
>>>>>>> On 2023-08-22 06:01, Jani Nikula wrote:
>>>>>>>> Over the past years I've been trying to unify the override and firmware
>>>>>>>> EDID handling as well as EDID property updates. It won't work if drivers
>>>>>>>> do their own random things.
>>>>>>> Let's check how to replace these references by appropriate ones or fork
>>>>>>> the function as reverting these patches causes regressions.
>>>>>>
>>>>>> I think the fundamental problem you have is conflating connector forcing
>>>>>> with EDID override. They're orthogonal. The .force callback has no
>>>>>> business basing the decisions on connector->edid_override. Force is
>>>>>> force, override is override.
>>>>>>
>>>>>> The driver isn't even supposed to know or care if the EDID originates
>>>>>> from the firmware loader or override EDID debugfs. drm_get_edid() will
>>>>>> handle that for you transparently. It'll return the EDID, and you
>>>>>> shouldn't look at connector->edid_blob_ptr either. Using that will make
>>>>>> future work in drm_edid.c harder.
>>>>>>
>>>>>> You can't fix that with minor tweaks. I think you'll be better off
>>>>>> starting from scratch.
>>>>>>
>>>>>> Also, connector->edid_override is debugfs. You actually can change the
>>>>>> behaviour. If your userspace, whatever it is, has been written to assume
>>>>>> connector forcing if EDID override is set, you *do* have to fix that,
>>>>>> and set both.
>>>>>
>>>>> Any updates on fixing this, or shall we proceed with the reverts?
>
> There is a patch under internal reviews. It removes calls edid_override 
> and drm_edid_override_connector_update as intended in this patchset but 
> does not remove the functionality.

While I am happy to hear there's progress, I'm somewhat baffled the
review is internal. The commits that I suggested to revert were also
only reviewed internally, as far as I can see... And that's kind of the
problem.

Upstream code should be reviewed in public.


BR,
Jani.


>
> With the patch. both following git grep commands return nothing in 
> amd-staging-drm-next.
>
> $ git grep drm_edid_override_connector_update -- drivers/gpu/drm/amd
> $ git grep edid_override -- drivers/gpu/drm/amd
>
> Best regards,
> Alex Hung
>
>>>>
>>>> What is the goal of the reverts?  I don't disagree that we may be
>>>> using the interfaces wrong, but reverting them will regess
>>>> functionality in the driver.
>>>
>>> The commits are in v6.5-rc1, but not yet in a release. No user depends
>>> on them yet. I'd strongly prefer them not reaching v6.5 final and users.
>> 
>> Sorry for confusion here, that's obviously come and gone already. :(
>> 
>>> The firmware EDID, override EDID, connector forcing, the EDID property,
>>> etc. have been and somewhat still are a hairy mess that we must keep
>>> untangling, and this isn't helping.
>>>
>>> I've put in crazy amounts of work on this, and I've added kernel-doc
>>> comments about stuff that should and should not be done, but they go
>>> unread and ignored.
>>>
>>> I really don't want to end up having to clean this up myself before I
>>> can embark on further cleanups and refactoring.
>>>
>>> And again, if the functionality in the driver depends on conflating two
>>> things that should be separate, it's probably not such a hot idea to let
>>> it reach users either. Even if it's just debugfs.
>>>
>>>
>>> BR,
>>> Jani.
>> 

-- 
Jani Nikula, Intel Open Source Graphics Center

Re: [Intel-gfx] [PATCH 0/4] drm/amd/display: stop using drm_edid_override_connector_update()

[Daniel Vetter]

On Wed, Aug 30, 2023 at 10:29:46AM +0300, Jani Nikula wrote:
> Upstream code should be reviewed in public.
 
Yup
-Sima
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

Re: [Intel-gfx] [PATCH 0/4] drm/amd/display: stop using drm_edid_override_connector_update()

[Alex Hung]

On 2023-08-30 01:29, Jani Nikula wrote:
> On Tue, 29 Aug 2023, Alex Hung <alex.hung@amd.com> wrote:
>> On 2023-08-29 11:03, Jani Nikula wrote:
>>> On Tue, 29 Aug 2023, Jani Nikula <jani.nikula@intel.com> wrote:
>>>> On Tue, 29 Aug 2023, Alex Deucher <alexdeucher@gmail.com> wrote:
>>>>> On Tue, Aug 29, 2023 at 6:48 AM Jani Nikula <jani.nikula@intel.com> wrote:
>>>>>>
>>>>>> On Wed, 23 Aug 2023, Jani Nikula <jani.nikula@intel.com> wrote:
>>>>>>> On Tue, 22 Aug 2023, Alex Hung <alex.hung@amd.com> wrote:
>>>>>>>> On 2023-08-22 06:01, Jani Nikula wrote:
>>>>>>>>> Over the past years I've been trying to unify the override and firmware
>>>>>>>>> EDID handling as well as EDID property updates. It won't work if drivers
>>>>>>>>> do their own random things.
>>>>>>>> Let's check how to replace these references by appropriate ones or fork
>>>>>>>> the function as reverting these patches causes regressions.
>>>>>>>
>>>>>>> I think the fundamental problem you have is conflating connector forcing
>>>>>>> with EDID override. They're orthogonal. The .force callback has no
>>>>>>> business basing the decisions on connector->edid_override. Force is
>>>>>>> force, override is override.
>>>>>>>
>>>>>>> The driver isn't even supposed to know or care if the EDID originates
>>>>>>> from the firmware loader or override EDID debugfs. drm_get_edid() will
>>>>>>> handle that for you transparently. It'll return the EDID, and you
>>>>>>> shouldn't look at connector->edid_blob_ptr either. Using that will make
>>>>>>> future work in drm_edid.c harder.
>>>>>>>
>>>>>>> You can't fix that with minor tweaks. I think you'll be better off
>>>>>>> starting from scratch.
>>>>>>>
>>>>>>> Also, connector->edid_override is debugfs. You actually can change the
>>>>>>> behaviour. If your userspace, whatever it is, has been written to assume
>>>>>>> connector forcing if EDID override is set, you *do* have to fix that,
>>>>>>> and set both.
>>>>>>
>>>>>> Any updates on fixing this, or shall we proceed with the reverts?
>>
>> There is a patch under internal reviews. It removes calls edid_override
>> and drm_edid_override_connector_update as intended in this patchset but
>> does not remove the functionality.
> 
> While I am happy to hear there's progress, I'm somewhat baffled the
> review is internal. The commits that I suggested to revert were also
> only reviewed internally, as far as I can see... And that's kind of the
> problem.
> 
> Upstream code should be reviewed in public.

Hi Jani,

All patches are sent for public reviews, the progress is summarized as 
the followings:

== internal ==

1. a patch or patches are tested by CI.
2. internal technical and IP reviews are performed to ensure no concerns 
before patches are merged to internal branch.

== public ==

3. a regression test and IP reviews are performed by engineers before 
sending to public mailing lists.
4. the patchset is sent for public reviews ex. 
https://patchwork.freedesktop.org/series/122498/
5. patches are merged to public repo.

> 
> 
> BR,
> Jani.
> 
> 
>>
>> With the patch. both following git grep commands return nothing in
>> amd-staging-drm-next.
>>
>> $ git grep drm_edid_override_connector_update -- drivers/gpu/drm/amd
>> $ git grep edid_override -- drivers/gpu/drm/amd
>>
>> Best regards,
>> Alex Hung
>>
>>>>>
>>>>> What is the goal of the reverts?  I don't disagree that we may be
>>>>> using the interfaces wrong, but reverting them will regess
>>>>> functionality in the driver.
>>>>
>>>> The commits are in v6.5-rc1, but not yet in a release. No user depends
>>>> on them yet. I'd strongly prefer them not reaching v6.5 final and users.
>>>
>>> Sorry for confusion here, that's obviously come and gone already. :(
>>>
>>>> The firmware EDID, override EDID, connector forcing, the EDID property,
>>>> etc. have been and somewhat still are a hairy mess that we must keep
>>>> untangling, and this isn't helping.
>>>>
>>>> I've put in crazy amounts of work on this, and I've added kernel-doc
>>>> comments about stuff that should and should not be done, but they go
>>>> unread and ignored.
>>>>
>>>> I really don't want to end up having to clean this up myself before I
>>>> can embark on further cleanups and refactoring.
>>>>
>>>> And again, if the functionality in the driver depends on conflating two
>>>> things that should be separate, it's probably not such a hot idea to let
>>>> it reach users either. Even if it's just debugfs.
>>>>
>>>>
>>>> BR,
>>>> Jani.
>>>
> 

Re: [Intel-gfx] [PATCH 0/4] drm/amd/display: stop using drm_edid_override_connector_update()

[Jani Nikula]

On Thu, 31 Aug 2023, Alex Hung <alex.hung@amd.com> wrote:
> On 2023-08-30 01:29, Jani Nikula wrote:
>> On Tue, 29 Aug 2023, Alex Hung <alex.hung@amd.com> wrote:
>>> There is a patch under internal reviews. It removes calls edid_override
>>> and drm_edid_override_connector_update as intended in this patchset but
>>> does not remove the functionality.
>> 
>> While I am happy to hear there's progress, I'm somewhat baffled the
>> review is internal. The commits that I suggested to revert were also
>> only reviewed internally, as far as I can see... And that's kind of the
>> problem.
>> 
>> Upstream code should be reviewed in public.
>
> Hi Jani,
>
> All patches are sent for public reviews, the progress is summarized as 
> the followings:
>
> == internal ==
>
> 1. a patch or patches are tested by CI.
> 2. internal technical and IP reviews are performed to ensure no concerns 
> before patches are merged to internal branch.
>
> == public ==
>
> 3. a regression test and IP reviews are performed by engineers before 
> sending to public mailing lists.
> 4. the patchset is sent for public reviews ex. 
> https://patchwork.freedesktop.org/series/122498/
> 5. patches are merged to public repo.

The point about public review is that there's no transparency to the
steps before 4. The patches are posted for public review with
Reviewed-by and Acked-by already added, based on internal review, and
there is de facto no public review taking place on the code drops. There
is zero visibility to the discussions taking place. We don't know if
it's just rubber stamping, we don't know what concerns were raised, if
any.

I'm mainly disappointed about the double standards here, given that we
post most patches directly upstream (especially ones that have zero
reason to be embargoed like the ones being discussed here), and the ones
that have gone through internal review will be stripped of all prior
internal Reviewed-by's and Acked-by's before posting. Because that's the
upstream expectation.


BR,
Jani.


-- 
Jani Nikula, Intel Open Source Graphics Center

Re: [Intel-gfx] [PATCH 0/4] drm/amd/display: stop using drm_edid_override_connector_update()

[Alex Deucher]

On Thu, Aug 31, 2023 at 6:01 PM Alex Hung <alex.hung@amd.com> wrote:
>
>
>
> On 2023-08-30 01:29, Jani Nikula wrote:
> > On Tue, 29 Aug 2023, Alex Hung <alex.hung@amd.com> wrote:
> >> On 2023-08-29 11:03, Jani Nikula wrote:
> >>> On Tue, 29 Aug 2023, Jani Nikula <jani.nikula@intel.com> wrote:
> >>>> On Tue, 29 Aug 2023, Alex Deucher <alexdeucher@gmail.com> wrote:
> >>>>> On Tue, Aug 29, 2023 at 6:48 AM Jani Nikula <jani.nikula@intel.com> wrote:
> >>>>>>
> >>>>>> On Wed, 23 Aug 2023, Jani Nikula <jani.nikula@intel.com> wrote:
> >>>>>>> On Tue, 22 Aug 2023, Alex Hung <alex.hung@amd.com> wrote:
> >>>>>>>> On 2023-08-22 06:01, Jani Nikula wrote:
> >>>>>>>>> Over the past years I've been trying to unify the override and firmware
> >>>>>>>>> EDID handling as well as EDID property updates. It won't work if drivers
> >>>>>>>>> do their own random things.
> >>>>>>>> Let's check how to replace these references by appropriate ones or fork
> >>>>>>>> the function as reverting these patches causes regressions.
> >>>>>>>
> >>>>>>> I think the fundamental problem you have is conflating connector forcing
> >>>>>>> with EDID override. They're orthogonal. The .force callback has no
> >>>>>>> business basing the decisions on connector->edid_override. Force is
> >>>>>>> force, override is override.
> >>>>>>>
> >>>>>>> The driver isn't even supposed to know or care if the EDID originates
> >>>>>>> from the firmware loader or override EDID debugfs. drm_get_edid() will
> >>>>>>> handle that for you transparently. It'll return the EDID, and you
> >>>>>>> shouldn't look at connector->edid_blob_ptr either. Using that will make
> >>>>>>> future work in drm_edid.c harder.
> >>>>>>>
> >>>>>>> You can't fix that with minor tweaks. I think you'll be better off
> >>>>>>> starting from scratch.
> >>>>>>>
> >>>>>>> Also, connector->edid_override is debugfs. You actually can change the
> >>>>>>> behaviour. If your userspace, whatever it is, has been written to assume
> >>>>>>> connector forcing if EDID override is set, you *do* have to fix that,
> >>>>>>> and set both.
> >>>>>>
> >>>>>> Any updates on fixing this, or shall we proceed with the reverts?
> >>
> >> There is a patch under internal reviews. It removes calls edid_override
> >> and drm_edid_override_connector_update as intended in this patchset but
> >> does not remove the functionality.
> >
> > While I am happy to hear there's progress, I'm somewhat baffled the
> > review is internal. The commits that I suggested to revert were also
> > only reviewed internally, as far as I can see... And that's kind of the
> > problem.
> >
> > Upstream code should be reviewed in public.
>
> Hi Jani,
>
> All patches are sent for public reviews, the progress is summarized as
> the followings:
>
> == internal ==
>
> 1. a patch or patches are tested by CI.
> 2. internal technical and IP reviews are performed to ensure no concerns
> before patches are merged to internal branch.
>
> == public ==
>
> 3. a regression test and IP reviews are performed by engineers before
> sending to public mailing lists.
> 4. the patchset is sent for public reviews ex.
> https://patchwork.freedesktop.org/series/122498/
> 5. patches are merged to public repo.
>

This sort of thing is fine for unreleased chips or new IP prior public
exposure, but for released hardware, you really need to do the reviews
on the mailing lists.

Alex


> >
> >
> > BR,
> > Jani.
> >
> >
> >>
> >> With the patch. both following git grep commands return nothing in
> >> amd-staging-drm-next.
> >>
> >> $ git grep drm_edid_override_connector_update -- drivers/gpu/drm/amd
> >> $ git grep edid_override -- drivers/gpu/drm/amd
> >>
> >> Best regards,
> >> Alex Hung
> >>
> >>>>>
> >>>>> What is the goal of the reverts?  I don't disagree that we may be
> >>>>> using the interfaces wrong, but reverting them will regess
> >>>>> functionality in the driver.
> >>>>
> >>>> The commits are in v6.5-rc1, but not yet in a release. No user depends
> >>>> on them yet. I'd strongly prefer them not reaching v6.5 final and users.
> >>>
> >>> Sorry for confusion here, that's obviously come and gone already. :(
> >>>
> >>>> The firmware EDID, override EDID, connector forcing, the EDID property,
> >>>> etc. have been and somewhat still are a hairy mess that we must keep
> >>>> untangling, and this isn't helping.
> >>>>
> >>>> I've put in crazy amounts of work on this, and I've added kernel-doc
> >>>> comments about stuff that should and should not be done, but they go
> >>>> unread and ignored.
> >>>>
> >>>> I really don't want to end up having to clean this up myself before I
> >>>> can embark on further cleanups and refactoring.
> >>>>
> >>>> And again, if the functionality in the driver depends on conflating two
> >>>> things that should be separate, it's probably not such a hot idea to let
> >>>> it reach users either. Even if it's just debugfs.
> >>>>
> >>>>
> >>>> BR,
> >>>> Jani.
> >>>
> >

Re: [Intel-gfx] [PATCH 0/4] drm/amd/display: stop using drm_edid_override_connector_update()

[Daniel Vetter]

On Fri, 1 Sept 2023 at 21:00, Alex Deucher <alexdeucher@gmail.com> wrote:
>
> On Thu, Aug 31, 2023 at 6:01 PM Alex Hung <alex.hung@amd.com> wrote:
> >
> >
> >
> > On 2023-08-30 01:29, Jani Nikula wrote:
> > > On Tue, 29 Aug 2023, Alex Hung <alex.hung@amd.com> wrote:
> > >> On 2023-08-29 11:03, Jani Nikula wrote:
> > >>> On Tue, 29 Aug 2023, Jani Nikula <jani.nikula@intel.com> wrote:
> > >>>> On Tue, 29 Aug 2023, Alex Deucher <alexdeucher@gmail.com> wrote:
> > >>>>> On Tue, Aug 29, 2023 at 6:48 AM Jani Nikula <jani.nikula@intel.com> wrote:
> > >>>>>>
> > >>>>>> On Wed, 23 Aug 2023, Jani Nikula <jani.nikula@intel.com> wrote:
> > >>>>>>> On Tue, 22 Aug 2023, Alex Hung <alex.hung@amd.com> wrote:
> > >>>>>>>> On 2023-08-22 06:01, Jani Nikula wrote:
> > >>>>>>>>> Over the past years I've been trying to unify the override and firmware
> > >>>>>>>>> EDID handling as well as EDID property updates. It won't work if drivers
> > >>>>>>>>> do their own random things.
> > >>>>>>>> Let's check how to replace these references by appropriate ones or fork
> > >>>>>>>> the function as reverting these patches causes regressions.
> > >>>>>>>
> > >>>>>>> I think the fundamental problem you have is conflating connector forcing
> > >>>>>>> with EDID override. They're orthogonal. The .force callback has no
> > >>>>>>> business basing the decisions on connector->edid_override. Force is
> > >>>>>>> force, override is override.
> > >>>>>>>
> > >>>>>>> The driver isn't even supposed to know or care if the EDID originates
> > >>>>>>> from the firmware loader or override EDID debugfs. drm_get_edid() will
> > >>>>>>> handle that for you transparently. It'll return the EDID, and you
> > >>>>>>> shouldn't look at connector->edid_blob_ptr either. Using that will make
> > >>>>>>> future work in drm_edid.c harder.
> > >>>>>>>
> > >>>>>>> You can't fix that with minor tweaks. I think you'll be better off
> > >>>>>>> starting from scratch.
> > >>>>>>>
> > >>>>>>> Also, connector->edid_override is debugfs. You actually can change the
> > >>>>>>> behaviour. If your userspace, whatever it is, has been written to assume
> > >>>>>>> connector forcing if EDID override is set, you *do* have to fix that,
> > >>>>>>> and set both.
> > >>>>>>
> > >>>>>> Any updates on fixing this, or shall we proceed with the reverts?
> > >>
> > >> There is a patch under internal reviews. It removes calls edid_override
> > >> and drm_edid_override_connector_update as intended in this patchset but
> > >> does not remove the functionality.
> > >
> > > While I am happy to hear there's progress, I'm somewhat baffled the
> > > review is internal. The commits that I suggested to revert were also
> > > only reviewed internally, as far as I can see... And that's kind of the
> > > problem.
> > >
> > > Upstream code should be reviewed in public.
> >
> > Hi Jani,
> >
> > All patches are sent for public reviews, the progress is summarized as
> > the followings:
> >
> > == internal ==
> >
> > 1. a patch or patches are tested by CI.
> > 2. internal technical and IP reviews are performed to ensure no concerns
> > before patches are merged to internal branch.
> >
> > == public ==
> >
> > 3. a regression test and IP reviews are performed by engineers before
> > sending to public mailing lists.
> > 4. the patchset is sent for public reviews ex.
> > https://patchwork.freedesktop.org/series/122498/
> > 5. patches are merged to public repo.
> >
>
> This sort of thing is fine for unreleased chips or new IP prior public
> exposure, but for released hardware, you really need to do the reviews
> on the mailing lists.

Aye. Maybe with the clarification that if the embargoed code touches
areas that are common code (or really should be handled in common
code), then the cross-driver parts also need to be reviewed in public
as upfront prep patches. If that's not possible (try to fix your
process to make that possible please), at least ping stakeholders in
private to give them a heads up, so that when the IP enabling gets
published it's not going to be held up in the review for the necessary
common changes. What's not good is if code that should be reviewed on
dri-devel bypasses all that just because it's part of a hardware
enabling series.

Cheers, Sima

> Alex
>
>
> > >
> > >
> > > BR,
> > > Jani.
> > >
> > >
> > >>
> > >> With the patch. both following git grep commands return nothing in
> > >> amd-staging-drm-next.
> > >>
> > >> $ git grep drm_edid_override_connector_update -- drivers/gpu/drm/amd
> > >> $ git grep edid_override -- drivers/gpu/drm/amd
> > >>
> > >> Best regards,
> > >> Alex Hung
> > >>
> > >>>>>
> > >>>>> What is the goal of the reverts?  I don't disagree that we may be
> > >>>>> using the interfaces wrong, but reverting them will regess
> > >>>>> functionality in the driver.
> > >>>>
> > >>>> The commits are in v6.5-rc1, but not yet in a release. No user depends
> > >>>> on them yet. I'd strongly prefer them not reaching v6.5 final and users.
> > >>>
> > >>> Sorry for confusion here, that's obviously come and gone already. :(
> > >>>
> > >>>> The firmware EDID, override EDID, connector forcing, the EDID property,
> > >>>> etc. have been and somewhat still are a hairy mess that we must keep
> > >>>> untangling, and this isn't helping.
> > >>>>
> > >>>> I've put in crazy amounts of work on this, and I've added kernel-doc
> > >>>> comments about stuff that should and should not be done, but they go
> > >>>> unread and ignored.
> > >>>>
> > >>>> I really don't want to end up having to clean this up myself before I
> > >>>> can embark on further cleanups and refactoring.
> > >>>>
> > >>>> And again, if the functionality in the driver depends on conflating two
> > >>>> things that should be separate, it's probably not such a hot idea to let
> > >>>> it reach users either. Even if it's just debugfs.
> > >>>>
> > >>>>
> > >>>> BR,
> > >>>> Jani.
> > >>>
> > >



-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch