Re: [Intel-gfx] [PATCH 0/2] i915: Extract, polish, and document multicast handling

[Jani Nikula <jani.nikula@linux.intel.com>]

On Fri, 10 Jun 2022, Matt Roper <matthew.d.roper@intel.com> wrote:
> Multicast/replicated (MCR) registers on Intel hardware are a purely
> GT-specific concept.  Rather than leaving MCR register handling spread
> across several places throughout the driver (intel_uncore.c, intel_gt.c,
> etc.) with confusing combinations of handler functions living in
> different namespaces, let's consolidate it all into a single place
> (intel_gt_mcr.c) and provide a more consistent and clearly-documented
> interface for the rest of the driver to access such registers:

I don't have the time for review, but overall this seems like a nice
cleanup. Ack.

As to documentation, I think usually documenting static functions using
kernel-doc is excessive, and a short regular comment might suffice. On
the other hand, the nice documentation doesn't show up anywhere, because
you also need to bolt it to some .rst!

BR,
Jani.


>
>  * intel_gt_mcr_read -- unicast read from specific instance
>  * intel_gt_mcr_read_any[_fw] -- unicast read from any non-terminated
>    instance
>  * intel_gt_mcr_unicast_write -- unicast write to specific instance
>  * intel_gt_mcr_multicast_write[_fw] -- multicast write to all instances
>
> Matt Roper (2):
>   drm/i915/gt: Move multicast register handling to a dedicated file
>   drm/i915/gt: Cleanup interface for MCR operations
>
>  drivers/gpu/drm/i915/Makefile               |   1 +
>  drivers/gpu/drm/i915/gem/i915_gem_stolen.c  |   3 +-
>  drivers/gpu/drm/i915/gt/intel_engine_cs.c   |  36 +-
>  drivers/gpu/drm/i915/gt/intel_gt.c          | 297 +-----------
>  drivers/gpu/drm/i915/gt/intel_gt.h          |  15 -
>  drivers/gpu/drm/i915/gt/intel_gt_debugfs.c  |   3 +-
>  drivers/gpu/drm/i915/gt/intel_gt_mcr.c      | 483 ++++++++++++++++++++
>  drivers/gpu/drm/i915/gt/intel_gt_mcr.h      |  34 ++
>  drivers/gpu/drm/i915/gt/intel_region_lmem.c |   5 +-
>  drivers/gpu/drm/i915/gt/intel_workarounds.c |   9 +-
>  drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c  |   3 +-
>  drivers/gpu/drm/i915/i915_drv.h             |   2 -
>  drivers/gpu/drm/i915/intel_uncore.c         | 112 -----
>  drivers/gpu/drm/i915/intel_uncore.h         |   8 -
>  14 files changed, 551 insertions(+), 460 deletions(-)
>  create mode 100644 drivers/gpu/drm/i915/gt/intel_gt_mcr.c
>  create mode 100644 drivers/gpu/drm/i915/gt/intel_gt_mcr.h

-- 
Jani Nikula, Intel Open Source Graphics Center