Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Intel-gfx] [PATCH 0/2] i915: Extract, polish, and document multicast handling
@ 2022-06-11  0:57 Matt Roper
  2022-06-11  0:57 ` [Intel-gfx] [PATCH 1/2] drm/i915/gt: Move multicast register handling to a dedicated file Matt Roper
                   ` (6 more replies)
  0 siblings, 7 replies; 8+ messages in thread
From: Matt Roper @ 2022-06-11  0:57 UTC (permalink / raw)
  To: intel-gfx; +Cc: dri-devel

Multicast/replicated (MCR) registers on Intel hardware are a purely
GT-specific concept.  Rather than leaving MCR register handling spread
across several places throughout the driver (intel_uncore.c, intel_gt.c,
etc.) with confusing combinations of handler functions living in
different namespaces, let's consolidate it all into a single place
(intel_gt_mcr.c) and provide a more consistent and clearly-documented
interface for the rest of the driver to access such registers:

 * intel_gt_mcr_read -- unicast read from specific instance
 * intel_gt_mcr_read_any[_fw] -- unicast read from any non-terminated
   instance
 * intel_gt_mcr_unicast_write -- unicast write to specific instance
 * intel_gt_mcr_multicast_write[_fw] -- multicast write to all instances

Matt Roper (2):
  drm/i915/gt: Move multicast register handling to a dedicated file
  drm/i915/gt: Cleanup interface for MCR operations

 drivers/gpu/drm/i915/Makefile               |   1 +
 drivers/gpu/drm/i915/gem/i915_gem_stolen.c  |   3 +-
 drivers/gpu/drm/i915/gt/intel_engine_cs.c   |  36 +-
 drivers/gpu/drm/i915/gt/intel_gt.c          | 297 +-----------
 drivers/gpu/drm/i915/gt/intel_gt.h          |  15 -
 drivers/gpu/drm/i915/gt/intel_gt_debugfs.c  |   3 +-
 drivers/gpu/drm/i915/gt/intel_gt_mcr.c      | 483 ++++++++++++++++++++
 drivers/gpu/drm/i915/gt/intel_gt_mcr.h      |  34 ++
 drivers/gpu/drm/i915/gt/intel_region_lmem.c |   5 +-
 drivers/gpu/drm/i915/gt/intel_workarounds.c |   9 +-
 drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c  |   3 +-
 drivers/gpu/drm/i915/i915_drv.h             |   2 -
 drivers/gpu/drm/i915/intel_uncore.c         | 112 -----
 drivers/gpu/drm/i915/intel_uncore.h         |   8 -
 14 files changed, 551 insertions(+), 460 deletions(-)
 create mode 100644 drivers/gpu/drm/i915/gt/intel_gt_mcr.c
 create mode 100644 drivers/gpu/drm/i915/gt/intel_gt_mcr.h

-- 
2.35.3


^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2022-06-14 23:17 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-06-11  0:57 [Intel-gfx] [PATCH 0/2] i915: Extract, polish, and document multicast handling Matt Roper
2022-06-11  0:57 ` [Intel-gfx] [PATCH 1/2] drm/i915/gt: Move multicast register handling to a dedicated file Matt Roper
2022-06-11  0:57 ` [Intel-gfx] [PATCH 2/2] drm/i915/gt: Cleanup interface for MCR operations Matt Roper
2022-06-13  8:13 ` [Intel-gfx] [PATCH 0/2] i915: Extract, polish, and document multicast handling Jani Nikula
2022-06-13 22:11 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2022-06-13 22:11 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2022-06-13 22:35 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-06-14 23:17 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox