public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: Rodrigo Vivi <rodrigo.vivi@intel.com>, intel-gfx@lists.freedesktop.org
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>,
	Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Subject: Re: [Intel-gfx] [PATCH] drm/i915: Don't propagate the gen split confusion further
Date: Mon, 18 Oct 2021 11:25:00 +0300	[thread overview]
Message-ID: <87mtn6u4df.fsf@intel.com> (raw)
In-Reply-To: <20211015091650.87270-1-rodrigo.vivi@intel.com>

On Fri, 15 Oct 2021, Rodrigo Vivi <rodrigo.vivi@intel.com> wrote:
> There's no such thing as gen13. It is either display 13
> or graphics 13. Don't propagate the gen12 confusion
> further.

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
>  drivers/gpu/drm/i915/i915_reg.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
> index da9055c3ebf0..1e221fbe37fd 100644
> --- a/drivers/gpu/drm/i915/i915_reg.h
> +++ b/drivers/gpu/drm/i915/i915_reg.h
> @@ -8263,7 +8263,7 @@ enum {
>  
>  /*
>   * The below are numbered starting from "S1" on gen11/gen12, but starting
> - * with gen13 display, the bspec switches to a 0-based numbering scheme
> + * with display 13, the bspec switches to a 0-based numbering scheme
>   * (although the addresses stay the same so new S0 = old S1, new S1 = old S2).
>   * We'll just use the 0-based numbering here for all platforms since it's the
>   * way things will be named by the hardware team going forward, plus it's more

-- 
Jani Nikula, Intel Open Source Graphics Center

  parent reply	other threads:[~2021-10-18  8:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-15  9:16 [Intel-gfx] [PATCH] drm/i915: Don't propagate the gen split confusion further Rodrigo Vivi
2021-10-15 11:42 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2021-10-15 18:10 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2021-10-18  8:25 ` Jani Nikula [this message]
2021-10-18 13:23   ` [Intel-gfx] [PATCH] " Rodrigo Vivi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mtn6u4df.fsf@intel.com \
    --to=jani.nikula@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=joonas.lahtinen@linux.intel.com \
    --cc=rodrigo.vivi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox