Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915/gvt: Cast u64 array to u32 array
@ 2026-02-12 19:41 Jonathan Cavitt
  2026-02-12 21:05 ` ✓ i915.CI.BAT: success for " Patchwork
                   ` (2 more replies)
  0 siblings, 3 replies; 10+ messages in thread
From: Jonathan Cavitt @ 2026-02-12 19:41 UTC (permalink / raw)
  To: intel-gfx; +Cc: saurabhg.gupta, alex.zuo, jonathan.cavitt

Static analysis issue:

The u64 array workload->shadow_mm->ppgtt_mm.shadow_pdps is cast to a
void pointer and passed as a u32 array to set_context_pdp_root_pointer
as a part of update_shadow_pdps.  This isn't wrong, per se, but we
should properly cast it to an appropriately-sized u32 array before
submission.

Signed-off-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
---
 drivers/gpu/drm/i915/gvt/scheduler.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/gvt/scheduler.c b/drivers/gpu/drm/i915/gvt/scheduler.c
index 15fdd514ca83..1a95c9f76faa 100644
--- a/drivers/gpu/drm/i915/gvt/scheduler.c
+++ b/drivers/gpu/drm/i915/gvt/scheduler.c
@@ -72,6 +72,7 @@ static void update_shadow_pdps(struct intel_vgpu_workload *workload)
 {
 	struct execlist_ring_context *shadow_ring_context;
 	struct intel_context *ctx = workload->req->context;
+	u32 pdp[8];
 
 	if (WARN_ON(!workload->shadow_mm))
 		return;
@@ -79,9 +80,10 @@ static void update_shadow_pdps(struct intel_vgpu_workload *workload)
 	if (WARN_ON(!atomic_read(&workload->shadow_mm->pincount)))
 		return;
 
+	memcpy(pdp, workload->shadow_mm->ppgtt_mm.shadow_pdps,
+	       sizeof(u64) * ARRAY_SIZE(workload->shadow_mm->ppgtt_mm.shadow_pdps));
 	shadow_ring_context = (struct execlist_ring_context *)ctx->lrc_reg_state;
-	set_context_pdp_root_pointer(shadow_ring_context,
-			(void *)workload->shadow_mm->ppgtt_mm.shadow_pdps);
+	set_context_pdp_root_pointer(shadow_ring_context, pdp);
 }
 
 /*
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2026-02-24  7:29 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-12 19:41 [PATCH] drm/i915/gvt: Cast u64 array to u32 array Jonathan Cavitt
2026-02-12 21:05 ` ✓ i915.CI.BAT: success for " Patchwork
2026-02-12 23:48 ` ✗ i915.CI.Full: failure " Patchwork
2026-02-13 10:42 ` [PATCH] " Zhenyu Wang
2026-02-13 16:27   ` Cavitt, Jonathan
2026-02-19 20:43     ` Cavitt, Jonathan
2026-02-24  7:29       ` Krzysztof Karas
2026-02-20 14:40     ` Zhenyu Wang
2026-02-20 16:03       ` Cavitt, Jonathan
2026-02-21 15:34         ` Zhenyu Wang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox