* [PATCH v5 0/2] Remove support for UHBR13.5
@ 2025-04-04 4:55 Arun R Murthy
2025-04-04 4:55 ` [PATCH v5 1/2] drm/i915/display/dp: " Arun R Murthy
` (3 more replies)
0 siblings, 4 replies; 9+ messages in thread
From: Arun R Murthy @ 2025-04-04 4:55 UTC (permalink / raw)
To: intel-gfx, intel-xe; +Cc: Jani Nikula, imre.deak, Arun R Murthy
Signed-off-by: Arun R Murthy <arun.r.murthy@intel.com>
---
Changes in v5:
- EDITME: describe what is new in this series revision.
- EDITME: use bulletpoints and terse descriptions.
- Link to v4: https://lore.kernel.org/r/20250402-dprates-v4-0-752535b2068a@intel.com
Changes in v4:
- EDITME: describe what is new in this series revision.
- EDITME: use bulletpoints and terse descriptions.
- Link to v3: https://lore.kernel.org/r/20250402-dprates-v3-0-9e5d8ca989dd@intel.com
---
Arun R Murthy (2):
drm/i915/display/dp: Remove support for UHBR13.5
drm/i915/display/dp: Remove the uhbr13.5 pll state values
drivers/gpu/drm/i915/display/intel_cx0_phy.c | 26 --------------------
drivers/gpu/drm/i915/display/intel_dp.c | 4 +--
drivers/gpu/drm/i915/display/intel_snps_phy.c | 35 ---------------------------
3 files changed, 2 insertions(+), 63 deletions(-)
---
base-commit: 8a0f86f7106709c73acb1477af9ad5f267d7a340
change-id: 20250402-dprates-04caceb27541
Best regards,
--
Arun R Murthy <arun.r.murthy@intel.com>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v5 1/2] drm/i915/display/dp: Remove support for UHBR13.5
2025-04-04 4:55 [PATCH v5 0/2] Remove support for UHBR13.5 Arun R Murthy
@ 2025-04-04 4:55 ` Arun R Murthy
2025-04-04 12:34 ` Jani Nikula
2025-04-14 5:37 ` Murthy, Arun R
2025-04-04 4:55 ` [PATCH v5 2/2] drm/i915/display/dp: Remove the uhbr13.5 pll state values Arun R Murthy
` (2 subsequent siblings)
3 siblings, 2 replies; 9+ messages in thread
From: Arun R Murthy @ 2025-04-04 4:55 UTC (permalink / raw)
To: intel-gfx, intel-xe; +Cc: Jani Nikula, imre.deak, Arun R Murthy
The retimer issue for UHBR13.5 is fixed in BMG.
So for all platforms lesser than BMG(XE2_HPD/DISPLAY_VERx100 1401)
disable UHBR13.5.
commit caf3d748f646 ("drm/i915/dp: Remove support for UHBR13.5")
removes UHBR13.5 for MTL.
v2: Reframed the commit msg (Jani)
v4: Reframed the commit msg & update the max rate supported (Jani)
v5: Reframed the commit msg (Jani)
Signed-off-by: Arun R Murthy <arun.r.murthy@intel.com>
---
drivers/gpu/drm/i915/display/intel_dp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index f21f9b441fc2a4e644c69410e6ec6b3d37907478..92bca701a989b03e2ad4b3d9e7d0a9ef12567e5a 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -481,7 +481,7 @@ bool intel_dp_has_joiner(struct intel_dp *intel_dp)
static int dg2_max_source_rate(struct intel_dp *intel_dp)
{
- return intel_dp_is_edp(intel_dp) ? 810000 : 1350000;
+ return intel_dp_is_edp(intel_dp) ? 810000 : 1000000;
}
static int icl_max_source_rate(struct intel_dp *intel_dp)
@@ -550,7 +550,7 @@ intel_dp_set_source_rates(struct intel_dp *intel_dp)
};
static const int icl_rates[] = {
162000, 216000, 270000, 324000, 432000, 540000, 648000, 810000,
- 1000000, 1350000,
+ 1000000,
};
static const int bxt_rates[] = {
162000, 216000, 243000, 270000, 324000, 432000, 540000
--
2.25.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH v5 2/2] drm/i915/display/dp: Remove the uhbr13.5 pll state values
2025-04-04 4:55 [PATCH v5 0/2] Remove support for UHBR13.5 Arun R Murthy
2025-04-04 4:55 ` [PATCH v5 1/2] drm/i915/display/dp: " Arun R Murthy
@ 2025-04-04 4:55 ` Arun R Murthy
2025-04-14 9:49 ` Jani Nikula
2025-04-04 5:49 ` ✗ Fi.CI.SPARSE: warning for Remove support for UHBR13.5 Patchwork
2025-04-04 6:12 ` ✗ i915.CI.BAT: failure " Patchwork
3 siblings, 1 reply; 9+ messages in thread
From: Arun R Murthy @ 2025-04-04 4:55 UTC (permalink / raw)
To: intel-gfx, intel-xe; +Cc: Jani Nikula, imre.deak, Arun R Murthy
Remove the pll state table for UHBR13.5 on synps and c20 PHY as UHBR13.5
is removed in previous patch.
Signed-off-by: Arun R Murthy <arun.r.murthy@intel.com>
---
drivers/gpu/drm/i915/display/intel_cx0_phy.c | 26 --------------------
drivers/gpu/drm/i915/display/intel_snps_phy.c | 35 ---------------------------
2 files changed, 61 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_cx0_phy.c b/drivers/gpu/drm/i915/display/intel_cx0_phy.c
index 22595766eac5332e541f3441bed80a187dc80224..398e207159876a54472560087b5841ca372b4c01 100644
--- a/drivers/gpu/drm/i915/display/intel_cx0_phy.c
+++ b/drivers/gpu/drm/i915/display/intel_cx0_phy.c
@@ -902,31 +902,6 @@ static const struct intel_c20pll_state mtl_c20_dp_uhbr10 = {
},
};
-static const struct intel_c20pll_state mtl_c20_dp_uhbr13_5 = {
- .clock = 1350000, /* 13.5 Gbps */
- .tx = { 0xbea0, /* tx cfg0 */
- 0x4800, /* tx cfg1 */
- 0x0000, /* tx cfg2 */
- },
- .cmn = {0x0500, /* cmn cfg0*/
- 0x0005, /* cmn cfg1 */
- 0x0000, /* cmn cfg2 */
- 0x0000, /* cmn cfg3 */
- },
- .mpllb = { 0x015f, /* mpllb cfg0 */
- 0x2205, /* mpllb cfg1 */
- 0x1b17, /* mpllb cfg2 */
- 0xffc1, /* mpllb cfg3 */
- 0xe100, /* mpllb cfg4 */
- 0xbd00, /* mpllb cfg5 */
- 0x2000, /* mpllb cfg6 */
- 0x0001, /* mpllb cfg7 */
- 0x4800, /* mpllb cfg8 */
- 0x0000, /* mpllb cfg9 */
- 0x0000, /* mpllb cfg10 */
- },
-};
-
static const struct intel_c20pll_state mtl_c20_dp_uhbr20 = {
.clock = 2000000, /* 20 Gbps */
.tx = { 0xbe20, /* tx cfg0 */
@@ -957,7 +932,6 @@ static const struct intel_c20pll_state * const mtl_c20_dp_tables[] = {
&mtl_c20_dp_hbr2,
&mtl_c20_dp_hbr3,
&mtl_c20_dp_uhbr10,
- &mtl_c20_dp_uhbr13_5,
&mtl_c20_dp_uhbr20,
NULL,
};
diff --git a/drivers/gpu/drm/i915/display/intel_snps_phy.c b/drivers/gpu/drm/i915/display/intel_snps_phy.c
index b9acd9fe160cde7de682b48648eb183a0549b014..79a6d14d7592a35ba51c52f6fe26564f3e1c1340 100644
--- a/drivers/gpu/drm/i915/display/intel_snps_phy.c
+++ b/drivers/gpu/drm/i915/display/intel_snps_phy.c
@@ -215,47 +215,12 @@ static const struct intel_mpllb_state dg2_dp_uhbr10_100 = {
REG_FIELD_PREP(SNPS_PHY_MPLLB_SSC_STEPSIZE, 76101),
};
-static const struct intel_mpllb_state dg2_dp_uhbr13_100 = {
- .clock = 1350000,
- .ref_control =
- REG_FIELD_PREP(SNPS_PHY_REF_CONTROL_REF_RANGE, 3),
- .mpllb_cp =
- REG_FIELD_PREP(SNPS_PHY_MPLLB_CP_INT, 5) |
- REG_FIELD_PREP(SNPS_PHY_MPLLB_CP_PROP, 45) |
- REG_FIELD_PREP(SNPS_PHY_MPLLB_CP_INT_GS, 65) |
- REG_FIELD_PREP(SNPS_PHY_MPLLB_CP_PROP_GS, 127),
- .mpllb_div =
- REG_FIELD_PREP(SNPS_PHY_MPLLB_DIV5_CLK_EN, 1) |
- REG_FIELD_PREP(SNPS_PHY_MPLLB_DIV_CLK_EN, 1) |
- REG_FIELD_PREP(SNPS_PHY_MPLLB_DIV_MULTIPLIER, 8) |
- REG_FIELD_PREP(SNPS_PHY_MPLLB_PMIX_EN, 1) |
- REG_FIELD_PREP(SNPS_PHY_MPLLB_WORD_DIV2_EN, 1) |
- REG_FIELD_PREP(SNPS_PHY_MPLLB_DP2_MODE, 1) |
- REG_FIELD_PREP(SNPS_PHY_MPLLB_V2I, 3),
- .mpllb_div2 =
- REG_FIELD_PREP(SNPS_PHY_MPLLB_REF_CLK_DIV, 2) |
- REG_FIELD_PREP(SNPS_PHY_MPLLB_MULTIPLIER, 508),
- .mpllb_fracn1 =
- REG_FIELD_PREP(SNPS_PHY_MPLLB_FRACN_CGG_UPDATE_EN, 1) |
- REG_FIELD_PREP(SNPS_PHY_MPLLB_FRACN_DEN, 1),
-
- /*
- * SSC will be enabled, DP UHBR has a minimum SSC requirement.
- */
- .mpllb_sscen =
- REG_FIELD_PREP(SNPS_PHY_MPLLB_SSC_EN, 1) |
- REG_FIELD_PREP(SNPS_PHY_MPLLB_SSC_PEAK, 79626),
- .mpllb_sscstep =
- REG_FIELD_PREP(SNPS_PHY_MPLLB_SSC_STEPSIZE, 102737),
-};
-
static const struct intel_mpllb_state * const dg2_dp_100_tables[] = {
&dg2_dp_rbr_100,
&dg2_dp_hbr1_100,
&dg2_dp_hbr2_100,
&dg2_dp_hbr3_100,
&dg2_dp_uhbr10_100,
- &dg2_dp_uhbr13_100,
NULL,
};
--
2.25.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* ✗ Fi.CI.SPARSE: warning for Remove support for UHBR13.5
2025-04-04 4:55 [PATCH v5 0/2] Remove support for UHBR13.5 Arun R Murthy
2025-04-04 4:55 ` [PATCH v5 1/2] drm/i915/display/dp: " Arun R Murthy
2025-04-04 4:55 ` [PATCH v5 2/2] drm/i915/display/dp: Remove the uhbr13.5 pll state values Arun R Murthy
@ 2025-04-04 5:49 ` Patchwork
2025-04-04 6:12 ` ✗ i915.CI.BAT: failure " Patchwork
3 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2025-04-04 5:49 UTC (permalink / raw)
To: Arun R Murthy; +Cc: intel-gfx
== Series Details ==
Series: Remove support for UHBR13.5
URL : https://patchwork.freedesktop.org/series/147251/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
+./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return'
+./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return'
+./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return'
+./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return'
+./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit'
+./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit'
+./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit'
+./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit'
+./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit'
+./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit'
+./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return'
+./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return'
+./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return'
+./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return'
+./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit'
+./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit'
+./arch/x86/include/asm/bitops.h:179:35: warning: unreplaced symbol 'oldbit'
+./arch/x86/include/asm/bitops.h:179:35: warning: unreplaced symbol 'oldbit'
+./arch/x86/include/asm/bitops.h:181:16: warning: unreplaced symbol 'oldbit'
+./arch/x86/include/asm/bitops.h:181:16: warning: unreplaced symbol 'oldbit'
+./arch/x86/include/asm/bitops.h:181:9: warning: unreplaced symbol 'return'
+./arch/x86/include/asm/bitops.h:181:9: warning: unreplaced symbol 'return'
+./arch/x86/include/asm/bitops.h:185:1: warning: unreplaced symbol 'return'
+./arch/x86/include/asm/bitops.h:185:1: warning: unreplaced symbol 'return'
+./arch/x86/include/asm/bitops.h:187:9: warning: unreplaced symbol 'oldbit'
+./arch/x86/include/asm/bitops.h:187:9: warning: unreplaced symbol 'oldbit'
+./arch/x86/include/asm/bitops.h:191:35: warning: unreplaced symbol 'oldbit'
+./arch/x86/include/asm/bitops.h:191:35: warning: unreplaced symbol 'oldbit'
+./arch/x86/include/asm/bitops.h:194:16: warning: unreplaced symbol 'oldbit'
+./arch/x86/include/asm/bitops.h:194:16: warning: unreplaced symbol 'oldbit'
+./arch/x86/include/asm/bitops.h:194:9: warning: unreplaced symbol 'return'
+./arch/x86/include/asm/bitops.h:194:9: warning: unreplaced symbol 'return'
+./arch/x86/include/asm/bitops.h:236:1: warning: unreplaced symbol 'return'
+./arch/x86/include/asm/bitops.h:236:1: warning: unreplaced symbol 'return'
+./arch/x86/include/asm/bitops.h:238:9: warning: unreplaced symbol 'return'
+./arch/x86/include/asm/bitops.h:238:9: warning: unreplaced symbol 'return'
+./arch/x86/include/asm/bitops.h:243:1: warning: unreplaced symbol 'return'
+./arch/x86/include/asm/bitops.h:243:1: warning: unreplaced symbol 'return'
+./arch/x86/include/asm/bitops.h:245:9: warning: unreplaced symbol 'return'
+./arch/x86/include/asm/bitops.h:245:9: warning: unreplaced symbol 'return'
+./arch/x86/include/asm/bitops.h:66:1: warning: unreplaced symbol 'return'
+./arch/x86/include/asm/bitops.h:66:1: warning: unreplaced symbol 'return'
+./arch/x86/include/asm/bitops.h:92:1: warning: unreplaced symbol 'return'
+./arch/x86/include/asm/bitops.h:92:1: warning: unreplaced symbol 'return'
+./include/asm-generic/bitops/generic-non-atomic.h:100:17: warning: unreplaced symbol 'old'
+./include/asm-generic/bitops/generic-non-atomic.h:100:17: warning: unreplaced symbol 'old'
+./include/asm-generic/bitops/generic-non-atomic.h:100:23: warning: unreplaced symbol 'mask'
+./include/asm-generic/bitops/generic-non-atomic.h:100:23: warning: unreplaced symbol 'mask'
+./include/asm-generic/bitops/generic-non-atomic.h:100:9: warning: unreplaced symbol 'return'
+./include/asm-generic/bitops/generic-non-atomic.h:100:9: warning: unreplaced symbol 'return'
+./include/asm-generic/bitops/generic-non-atomic.h:105:1: warning: unreplaced symbol 'return'
+./include/asm-generic/bitops/generic-non-atomic.h:105:1: warning: unreplaced symbol 'return'
+./include/asm-generic/bitops/generic-non-atomic.h:107:9: warning: unreplaced symbol 'mask'
+./include/asm-generic/bitops/generic-non-atomic.h:107:9: warning: unreplaced symbol 'mask'
+./include/asm-generic/bitops/generic-non-atomic.h:108:9: warning: unreplaced symbol 'p'
+./include/asm-generic/bitops/generic-non-atomic.h:108:9: warning: unreplaced symbol 'p'
+./include/asm-generic/bitops/generic-non-atomic.h:109:9: warning: unreplaced symbol 'old'
+./include/asm-generic/bitops/generic-non-atomic.h:109:9: warning: unreplaced symbol 'old'
+./include/asm-generic/bitops/generic-non-atomic.h:111:10: warning: unreplaced symbol 'p'
+./include/asm-generic/bitops/generic-non-atomic.h:111:10: warning: unreplaced symbol 'p'
+./include/asm-generic/bitops/generic-non-atomic.h:111:14: warning: unreplaced symbol 'old'
+./include/asm-generic/bitops/generic-non-atomic.h:111:14: warning: unreplaced symbol 'old'
+./include/asm-generic/bitops/generic-non-atomic.h:111:20: warning: unreplaced symbol 'mask'
+./include/asm-generic/bitops/generic-non-atomic.h:111:20: warning: unreplaced symbol 'mask'
+./include/asm-generic/bitops/generic-non-atomic.h:112:17: warning: unreplaced symbol 'old'
+./include/asm-generic/bitops/generic-non-atomic.h:112:17: warning: unreplaced symbol 'old'
+./include/asm-generic/bitops/generic-non-atomic.h:112:23: warning: unreplaced symbol 'mask'
+./include/asm-generic/bitops/generic-non-atomic.h:112:23: warning: unreplaced symbol 'mask'
+./include/asm-generic/bitops/generic-non-atomic.h:112:9: warning: unreplaced symbol 'return'
+./include/asm-generic/bitops/generic-non-atomic.h:112:9: warning: unreplaced symbol 'return'
+./include/asm-generic/bitops/generic-non-atomic.h:121:1: warning: unreplaced symbol 'return'
+./include/asm-generic/bitops/generic-non-atomic.h:121:1: warning: unreplaced symbol 'return'
+./include/asm-generic/bitops/generic-non-atomic.h:128:9: warning: unreplaced symbol 'return'
+./include/asm-generic/bitops/generic-non-atomic.h:128:9: warning: unreplaced symbol 'return'
+./include/asm-generic/bitops/generic-non-atomic.h:137:1: warning: unreplaced symbol 'return'
+./include/asm-generic/bitops/generic-non-atomic.h:137:1: warning: unreplaced symbol 'return'
+./include/asm-generic/bitops/generic-non-atomic.h:139:9: warning: unreplaced symbol 'p'
+./include/asm-generic/bitops/generic-non-atomic.h:139:9: warning: unreplaced symbol 'p'
+./include/asm-generic/bitops/generic-non-atomic.h:140:23: warning: unreplaced symbol 'break'
+./include/asm-generic/bitops/generic-non-atomic.h:140:23: warning: unreplaced symbol 'break'
+./include/asm-generic/bitops/generic-non-atomic.h:140:23: warning: unreplaced symbol 'continue'
+./include/asm-generic/bitops/generic-non-atomic.h:140:23: warning: unreplaced symbol 'continue'
+./include/asm-generic/bitops/generic-non-atomic.h:140:23: warning: unreplaced symbol 'p'
+./include/asm-generic/bitops/generic-non-atomic.h:140:23: warning: unreplaced symbol 'p'
+./include/asm-generic/bitops/generic-non-atomic.h:140:23: warning: unreplaced symbol 'p'
+./include/asm-generic/bitops/generic-non-atomic.h:140:23: warning: unreplaced symbol 'p'
+./include/asm-generic/bitops/generic-non-atomic.h:140:23: warning: unreplaced symbol 'p'
+./include/asm-generic/bitops/generic-non-atomic.h:140:23: warning: unreplaced symbol 'p'
+./include/asm-generic/bitops/generic-non-atomic.h:140:23: warning: unreplaced symbol 'p'
+./include/asm-generic/bitops/generic-non-atomic.h:140:23: warning: unreplaced symbol 'p'
+./include/asm-generic/bitops/generic-non-atomic.h:140:23: warning: unreplaced symbol '___p1'
+./include/asm-generic/bitops/generic-non-atomic.h:140:23: warning: unreplaced symbol '___p1'
+./include/asm-generic/bitops/generic-non-atomic.h:140:23: warning: unreplaced symbol '___p1'
+./include/asm-generic/bitops/generic-non-atomic.h:140:23: warning: unreplaced symbol '___p1'
+./include/asm-generic/bitops/generic-non-atomic.h:140:9: warning: unreplaced symbol 'return'
+./include/asm-generic/bitops/generic-non-atomic.h:140:9: warning: unreplaced symbol 'return'
+./include/asm-generic/bitops/generic-non-atomic.h:166:1: warning: unreplaced symbol 'return'
+./include/asm-generic/bitops/generic-non-atomic.h:166:1: warning: unreplaced symbol 'return'
+./include/asm-generic/bitops/generic-non-atomic.h:168:9: warning: unreplaced symbol 'p'
+./include/asm-generic/bitops/generic-non-atomic.h:168:9: warning: unreplaced symbol 'p'
+./include/asm-generic/bitops/generic-non-atomic.h:169:9: warning: unreplaced symbol 'mask'
+./include/asm-generic/bitops/generic-non-atomic.h:169:9: warning: unreplaced symbol 'mask'
+./include/asm-generic/bitops/generic-non-atomic.h:170:9: warning: unreplaced symbol 'val'
+./include/asm-generic/bitops/generic-non-atomic.h:170:9: warning: unreplaced symbol 'val'
+./include/asm-generic/bitops/generic-non-atomic.h:172:19: warning: unreplaced symbol 'val'
+./include/asm-generic/bitops/generic-non-atomic.h:172:19: warning: unreplaced symbol 'val'
+./include/asm-generic/bitops/generic-non-atomic.h:172:25: warning: unreplaced symbol 'mask'
+./include/asm-generic/bitops/generic-non-atomic.h:172:25: warning: unreplaced symbol 'mask'
+./include/asm-generic/bitops/generic-non-atomic.h:172:9: warning: unreplaced symbol 'return'
+./include/asm-generic/bitops/generic-non-atomic.h:172:9: warning: unreplaced symbol 'return'
+./include/asm-generic/bitops/generic-non-atomic.h:28:1: warning: unreplaced symbol 'return'
+./include/asm-generic/bitops/generic-non-atomic.h:28:1: warning: unreplaced symbol 'return'
+./include/asm-generic/bitops/generic-non-atomic.h:30:9: warning: unreplaced symbol 'mask'
+./include/asm-generic/bitops/generic-non-atomic.h:30:9: warning: unreplaced symbol 'mask'
+./include/asm-generic/bitops/generic-non-atomic.h:31:9: warning: unreplaced symbol 'p'
+./include/asm-generic/bitops/generic-non-atomic.h:31:9: warning: unreplaced symbol 'p'
+./include/asm-generic/bitops/generic-non-atomic.h:33:10: warning: unreplaced symbol 'p'
+./include/asm-generic/bitops/generic-non-atomic.h:33:10: warning: unreplaced symbol 'p'
+./include/asm-generic/bitops/generic-non-atomic.h:33:16: warning: unreplaced symbol 'mask'
+./include/asm-generic/bitops/generic-non-atomic.h:33:16: warning: unreplaced symbol 'mask'
+./include/asm-generic/bitops/generic-non-atomic.h:37:1: warning: unreplaced symbol 'return'
+./include/asm-generic/bitops/generic-non-atomic.h:37:1: warning: unreplaced symbol 'return'
+./include/asm-generic/bitops/generic-non-atomic.h:39:9: warning: unreplaced symbol 'mask'
+./include/asm-generic/bitops/generic-non-atomic.h:39:9: warning: unreplaced symbol 'mask'
+./include/asm-generic/bitops/generic-non-atomic.h:40:9: warning: unreplaced symbol 'p'
+./include/asm-generic/bitops/generic-non-atomic.h:40:9: warning: unreplaced symbol 'p'
+./include/asm-generic/bitops/generic-non-atomic.h:42:10: warning: unreplaced symbol 'p'
+./include/asm-generic/bitops/generic-non-atomic.h:42:10: warning: unreplaced symbol 'p'
+./include/asm-generic/bitops/generic-non-atomic.h:42:16: warning: unreplaced symbol 'mask'
+./include/asm-generic/bitops/generic-non-atomic.h:42:16: warning: unreplaced symbol 'mask'
+./include/asm-generic/bitops/generic-non-atomic.h:55:1: warning: unreplaced symbol 'return'
+./include/asm-generic/bitops/generic-non-atomic.h:55:1: warning: unreplaced symbol 'return'
+./include/asm-generic/bitops/generic-non-atomic.h:57:9: warning: unreplaced symbol 'mask'
+./include/asm-generic/bitops/generic-non-atomic.h:57:9: warning: unreplaced symbol 'mask'
+./include/asm-generic/bitops/generic-non-atomic.h:58:9: warning: unreplaced symbol 'p'
+./include/asm-generic/bitops/generic-non-atomic.h:58:9: warning: unreplaced symbol 'p'
+./include/asm-generic/bitops/generic-non-atomic.h:60:10: warning: unreplaced symbol 'p'
+./include/asm-generic/bitops/generic-non-atomic.h:60:10: warning: unreplaced symbol 'p'
+./include/asm-generic/bitops/generic-non-atomic.h:60:15: warning: unreplaced symbol 'mask'
+./include/asm-generic/bitops/generic-non-atomic.h:60:15: warning: unreplaced symbol 'mask'
+./include/asm-generic/bitops/generic-non-atomic.h:73:1: warning: unreplaced symbol 'return'
+./include/asm-generic/bitops/generic-non-atomic.h:73:1: warning: unreplaced symbol 'return'
+./include/asm-generic/bitops/generic-non-atomic.h:75:9: warning: unreplaced symbol 'mask'
+./include/asm-generic/bitops/generic-non-atomic.h:75:9: warning: unreplaced symbol 'mask'
+./include/asm-generic/bitops/generic-non-atomic.h:76:9: warning: unreplaced symbol 'p'
+./include/asm-generic/bitops/generic-non-atomic.h:76:9: warning: unreplaced symbol 'p'
+./include/asm-generic/bitops/generic-non-atomic.h:77:9: warning: unreplaced symbol 'old'
+./include/asm-generic/bitops/generic-non-atomic.h:77:9: warning: unreplaced symbol 'old'
+./include/asm-generic/bitops/generic-non-atomic.h:79:10: warning: unreplaced symbol 'p'
+./include/asm-generic/bitops/generic-non-atomic.h:79:10: warning: unreplaced symbol 'p'
+./include/asm-generic/bitops/generic-non-atomic.h:79:14: warning: unreplaced symbol 'old'
+./include/asm-generic/bitops/generic-non-atomic.h:79:14: warning: unreplaced symbol 'old'
+./include/asm-generic/bitops/generic-non-atomic.h:79:20: warning: unreplaced symbol 'mask'
+./include/asm-generic/bitops/generic-non-atomic.h:79:20: warning: unreplaced symbol 'mask'
+./include/asm-generic/bitops/generic-non-atomic.h:80:17: warning: unreplaced symbol 'old'
+./include/asm-generic/bitops/generic-non-atomic.h:80:17: warning: unreplaced symbol 'old'
+./include/asm-generic/bitops/generic-non-atomic.h:80:23: warning: unreplaced symbol 'mask'
+./include/asm-generic/bitops/generic-non-atomic.h:80:23: warning: unreplaced symbol 'mask'
+./include/asm-generic/bitops/generic-non-atomic.h:80:9: warning: unreplaced symbol 'return'
+./include/asm-generic/bitops/generic-non-atomic.h:80:9: warning: unreplaced symbol 'return'
+./include/asm-generic/bitops/generic-non-atomic.h:93:1: warning: unreplaced symbol 'return'
+./include/asm-generic/bitops/generic-non-atomic.h:93:1: warning: unreplaced symbol 'return'
+./include/asm-generic/bitops/generic-non-atomic.h:95:9: warning: unreplaced symbol 'mask'
+./include/asm-generic/bitops/generic-non-atomic.h:95:9: warning: unreplaced symbol 'mask'
+./include/asm-generic/bitops/generic-non-atomic.h:96:9: warning: unreplaced symbol 'p'
+./include/asm-generic/bitops/generic-non-atomic.h:96:9: warning: unreplaced symbol 'p'
+./include/asm-generic/bitops/generic-non-atomic.h:97:9: warning: unreplaced symbol 'old'
+./include/asm-generic/bitops/generic-non-atomic.h:97:9: warning: unreplaced symbol 'old'
+./include/asm-generic/bitops/generic-non-atomic.h:99:10: warning: unreplaced symbol 'p'
+./include/asm-generic/bitops/generic-non-atomic.h:99:10: warning: unreplaced symbol 'p'
+./include/asm-generic/bitops/generic-non-atomic.h:99:14: warning: unreplaced symbol 'old'
+./include/asm-generic/bitops/generic-non-atomic.h:99:14: warning: unreplaced symbol 'old'
+./include/asm-generic/bitops/generic-non-atomic.h:99:21: warning: unreplaced symbol 'mask'
+./include/asm-generic/bitops/generic-non-atomic.h:99:21: warning: unreplaced symbol 'mask'
+./include/asm-generic/bitops/instrumented-non-atomic.h:100:9: warning: unreplaced symbol 'return'
+./include/asm-generic/bitops/instrumented-non-atomic.h:100:9: warning: unreplaced symbol 'return'
+./include/asm-generic/bitops/instrumented-non-atomic.h:112:1: warning: unreplaced symbol 'return'
+./include/asm-generic/bitops/instrumented-non-atomic.h:112:1: warning: unreplaced symbol 'return'
+./include/asm-generic/bitops/instrumented-non-atomic.h:115:9: warning: unreplaced symbol 'return'
+./include/asm-generic/bitops/instrumented-non-atomic.h:115:9: warning: unreplaced symbol 'return'
+./include/asm-generic/bitops/instrumented-non-atomic.h:127:1: warning: unreplaced symbol 'return'
+./include/asm-generic/bitops/instrumented-non-atomic.h:127:1: warning: unreplaced symbol 'return'
+./include/asm-generic/bitops/instrumented-non-atomic.h:130:9: warning: unreplaced symbol 'return'
+./include/asm-generic/bitops/instrumented-non-atomic.h:130:9: warning: unreplaced symbol 'return'
+./include/asm-generic/bitops/instrumented-non-atomic.h:139:1: warning: unreplaced symbol 'return'
+./include/asm-generic/bitops/instrumented-non-atomic.h:139:1: warning: unreplaced symbol 'return'
+./include/asm-generic/bitops/instrumented-non-atomic.h:142:9: warning: unreplaced symbol 'return'
+./include/asm-generic/bitops/instrumented-non-atomic.h:142:9: warning: unreplaced symbol 'return'
+./include/asm-generic/bitops/instrumented-non-atomic.h:151:1: warning: too many warnings
+./include/asm-generic/bitops/instrumented-non-atomic.h:151:1: warning: too many warnings
+./include/asm-generic/bitops/instrumented-non-atomic.h:154:9: warning: unreplaced symbol 'return'
+./include/asm-generic/bitops/instrumented-non-atomic.h:154:9: warning: unreplaced symbol 'return'
+./include/asm-generic/bitops/instrumented-non-atomic.h:26:1: warning: unreplaced symbol 'return'
+./include/asm-generic/bitops/instrumented-non-atomic.h:26:1: warning: unreplaced symbol 'return'
+./include/asm-generic/bitops/instrumented-non-atomic.h:42:1: warning: unreplaced symbol 'return'
+./include/asm-generic/bitops/instrumented-non-atomic.h:42:1: warning: unreplaced symbol 'return'
+./include/asm-generic/bitops/instrumented-non-atomic.h:58:1: warning: unreplaced symbol 'return'
+./include/asm-generic/bitops/instrumented-non-atomic.h:58:1: warning: unreplaced symbol 'return'
+./include/asm-generic/bitops/instrumented-non-atomic.h:97:1: warning: unreplaced symbol 'return'
+./include/asm-generic/bitops/instrumented-non-atomic.h:97:1: warning: unreplaced symbol 'return'
^ permalink raw reply [flat|nested] 9+ messages in thread
* ✗ i915.CI.BAT: failure for Remove support for UHBR13.5
2025-04-04 4:55 [PATCH v5 0/2] Remove support for UHBR13.5 Arun R Murthy
` (2 preceding siblings ...)
2025-04-04 5:49 ` ✗ Fi.CI.SPARSE: warning for Remove support for UHBR13.5 Patchwork
@ 2025-04-04 6:12 ` Patchwork
3 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2025-04-04 6:12 UTC (permalink / raw)
To: Arun R Murthy; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 3618 bytes --]
== Series Details ==
Series: Remove support for UHBR13.5
URL : https://patchwork.freedesktop.org/series/147251/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_16370 -> Patchwork_147251v1
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_147251v1 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_147251v1, please notify your bug team (I915-ci-infra@lists.freedesktop.org) to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_147251v1/index.html
Participating hosts (43 -> 42)
------------------------------
Missing (1): bat-adlp-11
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_147251v1:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live@requests:
- bat-atsm-1: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16370/bat-atsm-1/igt@i915_selftest@live@requests.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_147251v1/bat-atsm-1/igt@i915_selftest@live@requests.html
#### Warnings ####
* igt@i915_selftest@live:
- bat-atsm-1: [DMESG-FAIL][3] ([i915#12061] / [i915#13929]) -> [INCOMPLETE][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16370/bat-atsm-1/igt@i915_selftest@live.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_147251v1/bat-atsm-1/igt@i915_selftest@live.html
Known issues
------------
Here are the changes found in Patchwork_147251v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live@workarounds:
- bat-arlh-2: [PASS][5] -> [DMESG-FAIL][6] ([i915#12061]) +1 other test dmesg-fail
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16370/bat-arlh-2/igt@i915_selftest@live@workarounds.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_147251v1/bat-arlh-2/igt@i915_selftest@live@workarounds.html
#### Possible fixes ####
* igt@core_hotunplug@unbind-rebind:
- bat-rpls-4: [DMESG-WARN][7] ([i915#13400]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16370/bat-rpls-4/igt@core_hotunplug@unbind-rebind.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_147251v1/bat-rpls-4/igt@core_hotunplug@unbind-rebind.html
* igt@i915_selftest@live@workarounds:
- bat-dg2-9: [DMESG-FAIL][9] ([i915#12061]) -> [PASS][10] +1 other test pass
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16370/bat-dg2-9/igt@i915_selftest@live@workarounds.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_147251v1/bat-dg2-9/igt@i915_selftest@live@workarounds.html
[i915#12061]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12061
[i915#13400]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13400
[i915#13929]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13929
Build changes
-------------
* Linux: CI_DRM_16370 -> Patchwork_147251v1
CI-20190529: 20190529
CI_DRM_16370: bc18da45d48d337b92a7ff9546ba61da32b3b586 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_8304: 8304
Patchwork_147251v1: bc18da45d48d337b92a7ff9546ba61da32b3b586 @ git://anongit.freedesktop.org/gfx-ci/linux
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_147251v1/index.html
[-- Attachment #2: Type: text/html, Size: 4481 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v5 1/2] drm/i915/display/dp: Remove support for UHBR13.5
2025-04-04 4:55 ` [PATCH v5 1/2] drm/i915/display/dp: " Arun R Murthy
@ 2025-04-04 12:34 ` Jani Nikula
2025-04-14 5:37 ` Murthy, Arun R
1 sibling, 0 replies; 9+ messages in thread
From: Jani Nikula @ 2025-04-04 12:34 UTC (permalink / raw)
To: Arun R Murthy, intel-gfx, intel-xe; +Cc: imre.deak, Arun R Murthy
On Fri, 04 Apr 2025, Arun R Murthy <arun.r.murthy@intel.com> wrote:
> The retimer issue for UHBR13.5 is fixed in BMG.
As I said before, I don't even know what "the retimer issue" was. It's
never been explained anywhere. Please explain it to me. And don't send a
new version of the patch.
BR,
Jani.
> So for all platforms lesser than BMG(XE2_HPD/DISPLAY_VERx100 1401)
> disable UHBR13.5.
> commit caf3d748f646 ("drm/i915/dp: Remove support for UHBR13.5")
> removes UHBR13.5 for MTL.
>
> v2: Reframed the commit msg (Jani)
> v4: Reframed the commit msg & update the max rate supported (Jani)
> v5: Reframed the commit msg (Jani)
>
> Signed-off-by: Arun R Murthy <arun.r.murthy@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_dp.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> index f21f9b441fc2a4e644c69410e6ec6b3d37907478..92bca701a989b03e2ad4b3d9e7d0a9ef12567e5a 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -481,7 +481,7 @@ bool intel_dp_has_joiner(struct intel_dp *intel_dp)
>
> static int dg2_max_source_rate(struct intel_dp *intel_dp)
> {
> - return intel_dp_is_edp(intel_dp) ? 810000 : 1350000;
> + return intel_dp_is_edp(intel_dp) ? 810000 : 1000000;
> }
>
> static int icl_max_source_rate(struct intel_dp *intel_dp)
> @@ -550,7 +550,7 @@ intel_dp_set_source_rates(struct intel_dp *intel_dp)
> };
> static const int icl_rates[] = {
> 162000, 216000, 270000, 324000, 432000, 540000, 648000, 810000,
> - 1000000, 1350000,
> + 1000000,
> };
> static const int bxt_rates[] = {
> 162000, 216000, 243000, 270000, 324000, 432000, 540000
--
Jani Nikula, Intel
^ permalink raw reply [flat|nested] 9+ messages in thread
* RE: [PATCH v5 1/2] drm/i915/display/dp: Remove support for UHBR13.5
2025-04-04 4:55 ` [PATCH v5 1/2] drm/i915/display/dp: " Arun R Murthy
2025-04-04 12:34 ` Jani Nikula
@ 2025-04-14 5:37 ` Murthy, Arun R
2025-04-14 9:46 ` Jani Nikula
1 sibling, 1 reply; 9+ messages in thread
From: Murthy, Arun R @ 2025-04-14 5:37 UTC (permalink / raw)
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: Jani Nikula, Deak, Imre
Any comments?
Gentle Reminder!
Thanks and Regards,
Arun R Murthy
--------------------
> -----Original Message-----
> From: Murthy, Arun R <arun.r.murthy@intel.com>
> Sent: Friday, April 4, 2025 10:25 AM
> To: intel-gfx@lists.freedesktop.org; intel-xe@lists.freedesktop.org
> Cc: Jani Nikula <jani.nikula@linux.intel.com>; Deak, Imre
> <imre.deak@intel.com>; Murthy, Arun R <arun.r.murthy@intel.com>
> Subject: [PATCH v5 1/2] drm/i915/display/dp: Remove support for UHBR13.5
>
> The retimer issue for UHBR13.5 is fixed in BMG.
> So for all platforms lesser than BMG(XE2_HPD/DISPLAY_VERx100 1401) disable
> UHBR13.5.
> commit caf3d748f646 ("drm/i915/dp: Remove support for UHBR13.5")
> removes UHBR13.5 for MTL.
>
> v2: Reframed the commit msg (Jani)
> v4: Reframed the commit msg & update the max rate supported (Jani)
> v5: Reframed the commit msg (Jani)
>
> Signed-off-by: Arun R Murthy <arun.r.murthy@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_dp.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c
> b/drivers/gpu/drm/i915/display/intel_dp.c
> index
> f21f9b441fc2a4e644c69410e6ec6b3d37907478..92bca701a989b03e2ad4b3d9
> e7d0a9ef12567e5a 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -481,7 +481,7 @@ bool intel_dp_has_joiner(struct intel_dp *intel_dp)
>
> static int dg2_max_source_rate(struct intel_dp *intel_dp) {
> - return intel_dp_is_edp(intel_dp) ? 810000 : 1350000;
> + return intel_dp_is_edp(intel_dp) ? 810000 : 1000000;
> }
>
> static int icl_max_source_rate(struct intel_dp *intel_dp) @@ -550,7 +550,7
> @@ intel_dp_set_source_rates(struct intel_dp *intel_dp)
> };
> static const int icl_rates[] = {
> 162000, 216000, 270000, 324000, 432000, 540000, 648000,
> 810000,
> - 1000000, 1350000,
> + 1000000,
> };
> static const int bxt_rates[] = {
> 162000, 216000, 243000, 270000, 324000, 432000, 540000
>
> --
> 2.25.1
^ permalink raw reply [flat|nested] 9+ messages in thread
* RE: [PATCH v5 1/2] drm/i915/display/dp: Remove support for UHBR13.5
2025-04-14 5:37 ` Murthy, Arun R
@ 2025-04-14 9:46 ` Jani Nikula
0 siblings, 0 replies; 9+ messages in thread
From: Jani Nikula @ 2025-04-14 9:46 UTC (permalink / raw)
To: Murthy, Arun R, intel-gfx@lists.freedesktop.org,
intel-xe@lists.freedesktop.org
Cc: Deak, Imre
On Mon, 14 Apr 2025, "Murthy, Arun R" <arun.r.murthy@intel.com> wrote:
> Any comments?
> Gentle Reminder!
This is the level of clarity and accuracy I was hoping for in the commit
message:
"""
Subject: drm/i915/dp: DG2 does not support UHBR 13.5
DG2 does not actually support UHBR 13.5 link rate. Reduce DG2 max link
rate to UHBR 10, and drop UHBR 13.5 from the supported source rates for
DG2.
The VBT on DG2 platforms should already limit the max link rate to UHBR
10, but be defensive about it.
"""
>
> Thanks and Regards,
> Arun R Murthy
> --------------------
>
>> -----Original Message-----
>> From: Murthy, Arun R <arun.r.murthy@intel.com>
>> Sent: Friday, April 4, 2025 10:25 AM
>> To: intel-gfx@lists.freedesktop.org; intel-xe@lists.freedesktop.org
>> Cc: Jani Nikula <jani.nikula@linux.intel.com>; Deak, Imre
>> <imre.deak@intel.com>; Murthy, Arun R <arun.r.murthy@intel.com>
>> Subject: [PATCH v5 1/2] drm/i915/display/dp: Remove support for UHBR13.5
>>
>> The retimer issue for UHBR13.5 is fixed in BMG.
>> So for all platforms lesser than BMG(XE2_HPD/DISPLAY_VERx100 1401) disable
>> UHBR13.5.
>> commit caf3d748f646 ("drm/i915/dp: Remove support for UHBR13.5")
>> removes UHBR13.5 for MTL.
>>
>> v2: Reframed the commit msg (Jani)
>> v4: Reframed the commit msg & update the max rate supported (Jani)
>> v5: Reframed the commit msg (Jani)
>>
>> Signed-off-by: Arun R Murthy <arun.r.murthy@intel.com>
>> ---
>> drivers/gpu/drm/i915/display/intel_dp.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c
>> b/drivers/gpu/drm/i915/display/intel_dp.c
>> index
>> f21f9b441fc2a4e644c69410e6ec6b3d37907478..92bca701a989b03e2ad4b3d9
>> e7d0a9ef12567e5a 100644
>> --- a/drivers/gpu/drm/i915/display/intel_dp.c
>> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
>> @@ -481,7 +481,7 @@ bool intel_dp_has_joiner(struct intel_dp *intel_dp)
>>
>> static int dg2_max_source_rate(struct intel_dp *intel_dp) {
>> - return intel_dp_is_edp(intel_dp) ? 810000 : 1350000;
>> + return intel_dp_is_edp(intel_dp) ? 810000 : 1000000;
>> }
>>
>> static int icl_max_source_rate(struct intel_dp *intel_dp) @@ -550,7 +550,7
>> @@ intel_dp_set_source_rates(struct intel_dp *intel_dp)
>> };
>> static const int icl_rates[] = {
>> 162000, 216000, 270000, 324000, 432000, 540000, 648000,
>> 810000,
>> - 1000000, 1350000,
>> + 1000000,
>> };
>> static const int bxt_rates[] = {
>> 162000, 216000, 243000, 270000, 324000, 432000, 540000
>>
>> --
>> 2.25.1
>
--
Jani Nikula, Intel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v5 2/2] drm/i915/display/dp: Remove the uhbr13.5 pll state values
2025-04-04 4:55 ` [PATCH v5 2/2] drm/i915/display/dp: Remove the uhbr13.5 pll state values Arun R Murthy
@ 2025-04-14 9:49 ` Jani Nikula
0 siblings, 0 replies; 9+ messages in thread
From: Jani Nikula @ 2025-04-14 9:49 UTC (permalink / raw)
To: Arun R Murthy, intel-gfx, intel-xe; +Cc: imre.deak, Arun R Murthy
On Fri, 04 Apr 2025, Arun R Murthy <arun.r.murthy@intel.com> wrote:
> Remove the pll state table for UHBR13.5 on synps and c20 PHY as UHBR13.5
> is removed in previous patch.
Subject should be about the PHY, not about DP. drm/i915/display/dp is
excessive anyway.
There's no "previous patch" once this is committed. Don't mention
patches in commit messages. And it might not be "previous" anyway.
synps is a typo.
>
> Signed-off-by: Arun R Murthy <arun.r.murthy@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_cx0_phy.c | 26 --------------------
> drivers/gpu/drm/i915/display/intel_snps_phy.c | 35 ---------------------------
> 2 files changed, 61 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_cx0_phy.c b/drivers/gpu/drm/i915/display/intel_cx0_phy.c
> index 22595766eac5332e541f3441bed80a187dc80224..398e207159876a54472560087b5841ca372b4c01 100644
> --- a/drivers/gpu/drm/i915/display/intel_cx0_phy.c
> +++ b/drivers/gpu/drm/i915/display/intel_cx0_phy.c
> @@ -902,31 +902,6 @@ static const struct intel_c20pll_state mtl_c20_dp_uhbr10 = {
> },
> };
>
> -static const struct intel_c20pll_state mtl_c20_dp_uhbr13_5 = {
> - .clock = 1350000, /* 13.5 Gbps */
> - .tx = { 0xbea0, /* tx cfg0 */
> - 0x4800, /* tx cfg1 */
> - 0x0000, /* tx cfg2 */
> - },
> - .cmn = {0x0500, /* cmn cfg0*/
> - 0x0005, /* cmn cfg1 */
> - 0x0000, /* cmn cfg2 */
> - 0x0000, /* cmn cfg3 */
> - },
> - .mpllb = { 0x015f, /* mpllb cfg0 */
> - 0x2205, /* mpllb cfg1 */
> - 0x1b17, /* mpllb cfg2 */
> - 0xffc1, /* mpllb cfg3 */
> - 0xe100, /* mpllb cfg4 */
> - 0xbd00, /* mpllb cfg5 */
> - 0x2000, /* mpllb cfg6 */
> - 0x0001, /* mpllb cfg7 */
> - 0x4800, /* mpllb cfg8 */
> - 0x0000, /* mpllb cfg9 */
> - 0x0000, /* mpllb cfg10 */
> - },
> -};
> -
> static const struct intel_c20pll_state mtl_c20_dp_uhbr20 = {
> .clock = 2000000, /* 20 Gbps */
> .tx = { 0xbe20, /* tx cfg0 */
> @@ -957,7 +932,6 @@ static const struct intel_c20pll_state * const mtl_c20_dp_tables[] = {
> &mtl_c20_dp_hbr2,
> &mtl_c20_dp_hbr3,
> &mtl_c20_dp_uhbr10,
> - &mtl_c20_dp_uhbr13_5,
> &mtl_c20_dp_uhbr20,
> NULL,
> };
> diff --git a/drivers/gpu/drm/i915/display/intel_snps_phy.c b/drivers/gpu/drm/i915/display/intel_snps_phy.c
> index b9acd9fe160cde7de682b48648eb183a0549b014..79a6d14d7592a35ba51c52f6fe26564f3e1c1340 100644
> --- a/drivers/gpu/drm/i915/display/intel_snps_phy.c
> +++ b/drivers/gpu/drm/i915/display/intel_snps_phy.c
> @@ -215,47 +215,12 @@ static const struct intel_mpllb_state dg2_dp_uhbr10_100 = {
> REG_FIELD_PREP(SNPS_PHY_MPLLB_SSC_STEPSIZE, 76101),
> };
>
> -static const struct intel_mpllb_state dg2_dp_uhbr13_100 = {
> - .clock = 1350000,
> - .ref_control =
> - REG_FIELD_PREP(SNPS_PHY_REF_CONTROL_REF_RANGE, 3),
> - .mpllb_cp =
> - REG_FIELD_PREP(SNPS_PHY_MPLLB_CP_INT, 5) |
> - REG_FIELD_PREP(SNPS_PHY_MPLLB_CP_PROP, 45) |
> - REG_FIELD_PREP(SNPS_PHY_MPLLB_CP_INT_GS, 65) |
> - REG_FIELD_PREP(SNPS_PHY_MPLLB_CP_PROP_GS, 127),
> - .mpllb_div =
> - REG_FIELD_PREP(SNPS_PHY_MPLLB_DIV5_CLK_EN, 1) |
> - REG_FIELD_PREP(SNPS_PHY_MPLLB_DIV_CLK_EN, 1) |
> - REG_FIELD_PREP(SNPS_PHY_MPLLB_DIV_MULTIPLIER, 8) |
> - REG_FIELD_PREP(SNPS_PHY_MPLLB_PMIX_EN, 1) |
> - REG_FIELD_PREP(SNPS_PHY_MPLLB_WORD_DIV2_EN, 1) |
> - REG_FIELD_PREP(SNPS_PHY_MPLLB_DP2_MODE, 1) |
> - REG_FIELD_PREP(SNPS_PHY_MPLLB_V2I, 3),
> - .mpllb_div2 =
> - REG_FIELD_PREP(SNPS_PHY_MPLLB_REF_CLK_DIV, 2) |
> - REG_FIELD_PREP(SNPS_PHY_MPLLB_MULTIPLIER, 508),
> - .mpllb_fracn1 =
> - REG_FIELD_PREP(SNPS_PHY_MPLLB_FRACN_CGG_UPDATE_EN, 1) |
> - REG_FIELD_PREP(SNPS_PHY_MPLLB_FRACN_DEN, 1),
> -
> - /*
> - * SSC will be enabled, DP UHBR has a minimum SSC requirement.
> - */
> - .mpllb_sscen =
> - REG_FIELD_PREP(SNPS_PHY_MPLLB_SSC_EN, 1) |
> - REG_FIELD_PREP(SNPS_PHY_MPLLB_SSC_PEAK, 79626),
> - .mpllb_sscstep =
> - REG_FIELD_PREP(SNPS_PHY_MPLLB_SSC_STEPSIZE, 102737),
> -};
> -
> static const struct intel_mpllb_state * const dg2_dp_100_tables[] = {
> &dg2_dp_rbr_100,
> &dg2_dp_hbr1_100,
> &dg2_dp_hbr2_100,
> &dg2_dp_hbr3_100,
> &dg2_dp_uhbr10_100,
> - &dg2_dp_uhbr13_100,
> NULL,
> };
--
Jani Nikula, Intel
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2025-04-14 9:49 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-04 4:55 [PATCH v5 0/2] Remove support for UHBR13.5 Arun R Murthy
2025-04-04 4:55 ` [PATCH v5 1/2] drm/i915/display/dp: " Arun R Murthy
2025-04-04 12:34 ` Jani Nikula
2025-04-14 5:37 ` Murthy, Arun R
2025-04-14 9:46 ` Jani Nikula
2025-04-04 4:55 ` [PATCH v5 2/2] drm/i915/display/dp: Remove the uhbr13.5 pll state values Arun R Murthy
2025-04-14 9:49 ` Jani Nikula
2025-04-04 5:49 ` ✗ Fi.CI.SPARSE: warning for Remove support for UHBR13.5 Patchwork
2025-04-04 6:12 ` ✗ i915.CI.BAT: failure " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox