* [PATCH linux-next] drm/i915/ddi: use string choice helpers
@ 2024-10-07 17:33 R Sundar
2024-10-11 7:08 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: R Sundar @ 2024-10-07 17:33 UTC (permalink / raw)
To: Jani Nikula, Rodrigo Vivi, Joonas Lahtinen, Tvrtko Ursulin,
David Airlie, Simona Vetter, intel-gfx, intel-xe, dri-devel,
linux-kernel, imre.deak
Cc: R Sundar, kernel test robot, Julia Lawall
Use str_enabled_disabled string helpers for better readability and to
fix cocci warning.
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@inria.fr>
Closes: https://lore.kernel.org/r/202410071601.TFpXoqgW-lkp@intel.com/
Signed-off-by: R Sundar <prosunofficial@gmail.com>
---
Reported in linux repo:
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
cocci warnings: (new ones prefixed by >>)
>> drivers/gpu/drm/i915/display/intel_ddi.c:2225:7-13: opportunity for str_enabled_disabled(enable)
vim +2225 drivers/gpu/drm/i915/display/intel_ddi.c
compile tested only.
drivers/gpu/drm/i915/display/intel_ddi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
index fe1ded6707f9..ff4c633c8546 100644
--- a/drivers/gpu/drm/i915/display/intel_ddi.c
+++ b/drivers/gpu/drm/i915/display/intel_ddi.c
@@ -2236,7 +2236,7 @@ static void intel_dp_sink_set_fec_ready(struct intel_dp *intel_dp,
if (drm_dp_dpcd_writeb(&intel_dp->aux, DP_FEC_CONFIGURATION,
enable ? DP_FEC_READY : 0) <= 0)
drm_dbg_kms(display->drm, "Failed to set FEC_READY to %s in the sink\n",
- enable ? "enabled" : "disabled");
+ str_enabled_disabled(enable));
if (enable &&
drm_dp_dpcd_writeb(&intel_dp->aux, DP_FEC_STATUS,
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* ✗ Fi.CI.CHECKPATCH: warning for drm/i915/ddi: use string choice helpers
2024-10-07 17:33 [PATCH linux-next] drm/i915/ddi: use string choice helpers R Sundar
@ 2024-10-11 7:08 ` Patchwork
2024-10-11 7:15 ` ✗ Fi.CI.BAT: failure " Patchwork
2024-10-22 10:26 ` [PATCH linux-next] " Jani Nikula
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2024-10-11 7:08 UTC (permalink / raw)
To: R Sundar; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/ddi: use string choice helpers
URL : https://patchwork.freedesktop.org/series/139846/
State : warning
== Summary ==
Error: dim checkpatch failed
dd9ecbf84c0a drm/i915/ddi: use string choice helpers
-:9: WARNING:BAD_REPORTED_BY_LINK: Reported-by: should be immediately followed by Closes: with a URL to the report
#9:
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@inria.fr>
total: 0 errors, 1 warnings, 0 checks, 8 lines checked
^ permalink raw reply [flat|nested] 4+ messages in thread
* ✗ Fi.CI.BAT: failure for drm/i915/ddi: use string choice helpers
2024-10-07 17:33 [PATCH linux-next] drm/i915/ddi: use string choice helpers R Sundar
2024-10-11 7:08 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
@ 2024-10-11 7:15 ` Patchwork
2024-10-22 10:26 ` [PATCH linux-next] " Jani Nikula
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2024-10-11 7:15 UTC (permalink / raw)
To: R Sundar; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 6199 bytes --]
== Series Details ==
Series: drm/i915/ddi: use string choice helpers
URL : https://patchwork.freedesktop.org/series/139846/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_15514 -> Patchwork_139846v1
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_139846v1 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_139846v1, please notify your bug team (I915-ci-infra@lists.freedesktop.org) to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_139846v1/index.html
Participating hosts (45 -> 44)
------------------------------
Missing (1): fi-snb-2520m
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_139846v1:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live@gem_migrate:
- bat-jsl-3: [PASS][1] -> [DMESG-WARN][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15514/bat-jsl-3/igt@i915_selftest@live@gem_migrate.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_139846v1/bat-jsl-3/igt@i915_selftest@live@gem_migrate.html
Known issues
------------
Here are the changes found in Patchwork_139846v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live:
- bat-mtlp-8: [PASS][3] -> [ABORT][4] ([i915#12216]) +1 other test abort
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15514/bat-mtlp-8/igt@i915_selftest@live.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_139846v1/bat-mtlp-8/igt@i915_selftest@live.html
- bat-arls-2: [PASS][5] -> [ABORT][6] ([i915#12061] / [i915#12133])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15514/bat-arls-2/igt@i915_selftest@live.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_139846v1/bat-arls-2/igt@i915_selftest@live.html
- bat-adlp-6: [PASS][7] -> [INCOMPLETE][8] ([i915#9413])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15514/bat-adlp-6/igt@i915_selftest@live.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_139846v1/bat-adlp-6/igt@i915_selftest@live.html
- bat-jsl-3: [PASS][9] -> [DMESG-WARN][10] ([i915#12010])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15514/bat-jsl-3/igt@i915_selftest@live.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_139846v1/bat-jsl-3/igt@i915_selftest@live.html
* igt@i915_selftest@live@gt_lrc:
- bat-adlp-6: [PASS][11] -> [INCOMPLETE][12] ([i915#10886] / [i915#9413])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15514/bat-adlp-6/igt@i915_selftest@live@gt_lrc.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_139846v1/bat-adlp-6/igt@i915_selftest@live@gt_lrc.html
* igt@i915_selftest@live@workarounds:
- bat-arls-2: [PASS][13] -> [ABORT][14] ([i915#12061])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15514/bat-arls-2/igt@i915_selftest@live@workarounds.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_139846v1/bat-arls-2/igt@i915_selftest@live@workarounds.html
#### Possible fixes ####
* igt@i915_selftest@live@workarounds:
- bat-mtlp-6: [ABORT][15] ([i915#12216]) -> [PASS][16] +1 other test pass
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15514/bat-mtlp-6/igt@i915_selftest@live@workarounds.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_139846v1/bat-mtlp-6/igt@i915_selftest@live@workarounds.html
#### Warnings ####
* igt@i915_module_load@reload:
- fi-kbl-7567u: [DMESG-WARN][17] ([i915#11621] / [i915#180]) -> [DMESG-WARN][18] ([i915#11621] / [i915#180] / [i915#1982])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15514/fi-kbl-7567u/igt@i915_module_load@reload.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_139846v1/fi-kbl-7567u/igt@i915_module_load@reload.html
* igt@i915_selftest@live:
- bat-arls-5: [DMESG-WARN][19] ([i915#10341] / [i915#12133]) -> [ABORT][20] ([i915#12061] / [i915#12133])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15514/bat-arls-5/igt@i915_selftest@live.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_139846v1/bat-arls-5/igt@i915_selftest@live.html
* igt@i915_selftest@live@workarounds:
- bat-arls-5: [DMESG-WARN][21] ([i915#10341] / [i915#11637]) -> [ABORT][22] ([i915#12061])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15514/bat-arls-5/igt@i915_selftest@live@workarounds.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_139846v1/bat-arls-5/igt@i915_selftest@live@workarounds.html
[i915#10341]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10341
[i915#10886]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10886
[i915#11621]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11621
[i915#11637]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11637
[i915#12010]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12010
[i915#12061]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12061
[i915#12133]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12133
[i915#12216]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12216
[i915#180]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/180
[i915#1982]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1982
[i915#9413]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9413
Build changes
-------------
* Linux: CI_DRM_15514 -> Patchwork_139846v1
CI-20190529: 20190529
CI_DRM_15514: f3354eab2a45420cf38a67f6d7735d5dff53eb6f @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_8063: 8063
Patchwork_139846v1: f3354eab2a45420cf38a67f6d7735d5dff53eb6f @ git://anongit.freedesktop.org/gfx-ci/linux
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_139846v1/index.html
[-- Attachment #2: Type: text/html, Size: 7728 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH linux-next] drm/i915/ddi: use string choice helpers
2024-10-07 17:33 [PATCH linux-next] drm/i915/ddi: use string choice helpers R Sundar
2024-10-11 7:08 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2024-10-11 7:15 ` ✗ Fi.CI.BAT: failure " Patchwork
@ 2024-10-22 10:26 ` Jani Nikula
2 siblings, 0 replies; 4+ messages in thread
From: Jani Nikula @ 2024-10-22 10:26 UTC (permalink / raw)
To: R Sundar, Rodrigo Vivi, Joonas Lahtinen, Tvrtko Ursulin,
David Airlie, Simona Vetter, intel-gfx, intel-xe, dri-devel,
linux-kernel, imre.deak
Cc: R Sundar, kernel test robot, Julia Lawall
On Mon, 07 Oct 2024, R Sundar <prosunofficial@gmail.com> wrote:
> Use str_enabled_disabled string helpers for better readability and to
> fix cocci warning.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Julia Lawall <julia.lawall@inria.fr>
> Closes: https://lore.kernel.org/r/202410071601.TFpXoqgW-lkp@intel.com/
> Signed-off-by: R Sundar <prosunofficial@gmail.com>
Pushed to drm-intel-next, thanks for the patch.
BR,
Jani.
> ---
>
> Reported in linux repo:
>
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
>
> cocci warnings: (new ones prefixed by >>)
>>> drivers/gpu/drm/i915/display/intel_ddi.c:2225:7-13: opportunity for str_enabled_disabled(enable)
>
> vim +2225 drivers/gpu/drm/i915/display/intel_ddi.c
>
> compile tested only.
>
> drivers/gpu/drm/i915/display/intel_ddi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
> index fe1ded6707f9..ff4c633c8546 100644
> --- a/drivers/gpu/drm/i915/display/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/display/intel_ddi.c
> @@ -2236,7 +2236,7 @@ static void intel_dp_sink_set_fec_ready(struct intel_dp *intel_dp,
> if (drm_dp_dpcd_writeb(&intel_dp->aux, DP_FEC_CONFIGURATION,
> enable ? DP_FEC_READY : 0) <= 0)
> drm_dbg_kms(display->drm, "Failed to set FEC_READY to %s in the sink\n",
> - enable ? "enabled" : "disabled");
> + str_enabled_disabled(enable));
>
> if (enable &&
> drm_dp_dpcd_writeb(&intel_dp->aux, DP_FEC_STATUS,
--
Jani Nikula, Intel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-10-22 10:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-07 17:33 [PATCH linux-next] drm/i915/ddi: use string choice helpers R Sundar
2024-10-11 7:08 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2024-10-11 7:15 ` ✗ Fi.CI.BAT: failure " Patchwork
2024-10-22 10:26 ` [PATCH linux-next] " Jani Nikula
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox