[Intel-gfx] [PATCH] Revert "drm/i915: use localized __diag_ignore_all() instead of per file"

[Intel-gfx] [PATCH] Revert "drm/i915: use localized __diag_ignore_all() instead of per file"

[Jani Nikula]

This reverts commit 88e9664434c994e97a9f6f8cdd1535495c660cea.

__diag_ignore_all() only works for GCC 8 or later.

-Woverride-init (from -Wextra, enabled in i915 Makefile) combined with
CONFIG_WERROR=y or W=e breaks the build for older GCC.

With i386_defconfig and x86_64_defconfig enabling CONFIG_WERROR=y by
default, we really need to roll back the change.

An alternative would be to disable -Woverride-init in the Makefile for
GCC <8, but the revert seems like the safest bet now.

Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/8768
Reported-by: John Garry <john.g.garry@oracle.com>
References: https://lore.kernel.org/r/ad2601c0-84bb-c574-3702-a83ff8faf98c@oracle.com
References: https://lore.kernel.org/r/87wmzezns4.fsf@intel.com
Fixes: 88e9664434c9 ("drm/i915: use localized __diag_ignore_all() instead of per file")
Cc: Gustavo Sousa <gustavo.sousa@intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/Makefile                       | 5 +++++
 drivers/gpu/drm/i915/display/intel_display_device.c | 5 -----
 drivers/gpu/drm/i915/display/intel_fbdev.c          | 5 -----
 drivers/gpu/drm/i915/i915_pci.c                     | 5 -----
 4 files changed, 5 insertions(+), 15 deletions(-)

diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile
index 2be9dd960540..c5fc91cd58e7 100644
--- a/drivers/gpu/drm/i915/Makefile
+++ b/drivers/gpu/drm/i915/Makefile
@@ -23,6 +23,11 @@ subdir-ccflags-y += $(call cc-option, -Wunused-but-set-variable)
 subdir-ccflags-y += $(call cc-disable-warning, frame-address)
 subdir-ccflags-$(CONFIG_DRM_I915_WERROR) += -Werror
 
+# Fine grained warnings disable
+CFLAGS_i915_pci.o = $(call cc-disable-warning, override-init)
+CFLAGS_display/intel_display_device.o = $(call cc-disable-warning, override-init)
+CFLAGS_display/intel_fbdev.o = $(call cc-disable-warning, override-init)
+
 subdir-ccflags-y += -I$(srctree)/$(src)
 
 # Please keep these build lists sorted!
diff --git a/drivers/gpu/drm/i915/display/intel_display_device.c b/drivers/gpu/drm/i915/display/intel_display_device.c
index e4afa7334c82..8286e79522d1 100644
--- a/drivers/gpu/drm/i915/display/intel_display_device.c
+++ b/drivers/gpu/drm/i915/display/intel_display_device.c
@@ -16,9 +16,6 @@
 #include "intel_display_reg_defs.h"
 #include "intel_fbc.h"
 
-__diag_push();
-__diag_ignore_all("-Woverride-init", "Allow overriding inherited members");
-
 static const struct intel_display_device_info no_display = {};
 
 #define PIPE_A_OFFSET		0x70000
@@ -727,8 +724,6 @@ static const struct intel_display_device_info xe_lpdp_display = {
 		BIT(PORT_TC1) | BIT(PORT_TC2) | BIT(PORT_TC3) | BIT(PORT_TC4),
 };
 
-__diag_pop();
-
 #undef INTEL_VGA_DEVICE
 #undef INTEL_QUANTA_VGA_DEVICE
 #define INTEL_VGA_DEVICE(id, info) { id, info }
diff --git a/drivers/gpu/drm/i915/display/intel_fbdev.c b/drivers/gpu/drm/i915/display/intel_fbdev.c
index 1cc0ddc6a310..80c3f88310db 100644
--- a/drivers/gpu/drm/i915/display/intel_fbdev.c
+++ b/drivers/gpu/drm/i915/display/intel_fbdev.c
@@ -135,9 +135,6 @@ static int intel_fbdev_mmap(struct fb_info *info, struct vm_area_struct *vma)
 	return i915_gem_fb_mmap(obj, vma);
 }
 
-__diag_push();
-__diag_ignore_all("-Woverride-init", "Allow overriding the default ops");
-
 static const struct fb_ops intelfb_ops = {
 	.owner = THIS_MODULE,
 	__FB_DEFAULT_DEFERRED_OPS_RDWR(intel_fbdev),
@@ -149,8 +146,6 @@ static const struct fb_ops intelfb_ops = {
 	.fb_mmap = intel_fbdev_mmap,
 };
 
-__diag_pop();
-
 static int intelfb_alloc(struct drm_fb_helper *helper,
 			 struct drm_fb_helper_surface_size *sizes)
 {
diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c
index dea3609fc496..fcacdc21643c 100644
--- a/drivers/gpu/drm/i915/i915_pci.c
+++ b/drivers/gpu/drm/i915/i915_pci.c
@@ -38,9 +38,6 @@
 #include "i915_reg.h"
 #include "intel_pci_config.h"
 
-__diag_push();
-__diag_ignore_all("-Woverride-init", "Allow overriding inherited members");
-
 #define PLATFORM(x) .platform = (x)
 #define GEN(x) \
 	.__runtime.graphics.ip.ver = (x), \
@@ -846,8 +843,6 @@ static const struct intel_device_info mtl_info = {
 
 #undef PLATFORM
 
-__diag_pop();
-
 /*
  * Make sure any device matches here are from most specific to most
  * general.  For example, since the Quanta match is based on the subsystem
-- 
2.39.2

Re: [Intel-gfx] [PATCH] Revert "drm/i915: use localized __diag_ignore_all() instead of per file"

[Gustavo Sousa]

Quoting Jani Nikula (2023-07-11 08:02:14-03:00)
>This reverts commit 88e9664434c994e97a9f6f8cdd1535495c660cea.
>
>__diag_ignore_all() only works for GCC 8 or later.
>
>-Woverride-init (from -Wextra, enabled in i915 Makefile) combined with
>CONFIG_WERROR=y or W=e breaks the build for older GCC.
>
>With i386_defconfig and x86_64_defconfig enabling CONFIG_WERROR=y by
>default, we really need to roll back the change.
>
>An alternative would be to disable -Woverride-init in the Makefile for
>GCC <8, but the revert seems like the safest bet now.

Sounds good. We would keep it compatible with older compilers and still have the
warning enabled on newer environments.

Another alternative I thought about was to have separate files only for
initializations of that type (i.e. that would need the warning disabled), but I
guess we would need to expose a lot of symbols for that to work...

Reviewed-by: Gustavo Sousa <gustavo.sousa@intel.com>

>
>Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/8768
>Reported-by: John Garry <john.g.garry@oracle.com>
>References: https://lore.kernel.org/r/ad2601c0-84bb-c574-3702-a83ff8faf98c@oracle.com
>References: https://lore.kernel.org/r/87wmzezns4.fsf@intel.com
>Fixes: 88e9664434c9 ("drm/i915: use localized __diag_ignore_all() instead of per file")
>Cc: Gustavo Sousa <gustavo.sousa@intel.com>
>Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
>Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
>Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
>Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>---
> drivers/gpu/drm/i915/Makefile                       | 5 +++++
> drivers/gpu/drm/i915/display/intel_display_device.c | 5 -----
> drivers/gpu/drm/i915/display/intel_fbdev.c          | 5 -----
> drivers/gpu/drm/i915/i915_pci.c                     | 5 -----
> 4 files changed, 5 insertions(+), 15 deletions(-)
>
>diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile
>index 2be9dd960540..c5fc91cd58e7 100644
>--- a/drivers/gpu/drm/i915/Makefile
>+++ b/drivers/gpu/drm/i915/Makefile
>@@ -23,6 +23,11 @@ subdir-ccflags-y += $(call cc-option, -Wunused-but-set-variable)
> subdir-ccflags-y += $(call cc-disable-warning, frame-address)
> subdir-ccflags-$(CONFIG_DRM_I915_WERROR) += -Werror
> 
>+# Fine grained warnings disable
>+CFLAGS_i915_pci.o = $(call cc-disable-warning, override-init)
>+CFLAGS_display/intel_display_device.o = $(call cc-disable-warning, override-init)
>+CFLAGS_display/intel_fbdev.o = $(call cc-disable-warning, override-init)
>+
> subdir-ccflags-y += -I$(srctree)/$(src)
> 
> # Please keep these build lists sorted!
>diff --git a/drivers/gpu/drm/i915/display/intel_display_device.c b/drivers/gpu/drm/i915/display/intel_display_device.c
>index e4afa7334c82..8286e79522d1 100644
>--- a/drivers/gpu/drm/i915/display/intel_display_device.c
>+++ b/drivers/gpu/drm/i915/display/intel_display_device.c
>@@ -16,9 +16,6 @@
> #include "intel_display_reg_defs.h"
> #include "intel_fbc.h"
> 
>-__diag_push();
>-__diag_ignore_all("-Woverride-init", "Allow overriding inherited members");
>-
> static const struct intel_display_device_info no_display = {};
> 
> #define PIPE_A_OFFSET                0x70000
>@@ -727,8 +724,6 @@ static const struct intel_display_device_info xe_lpdp_display = {
>                 BIT(PORT_TC1) | BIT(PORT_TC2) | BIT(PORT_TC3) | BIT(PORT_TC4),
> };
> 
>-__diag_pop();
>-
> #undef INTEL_VGA_DEVICE
> #undef INTEL_QUANTA_VGA_DEVICE
> #define INTEL_VGA_DEVICE(id, info) { id, info }
>diff --git a/drivers/gpu/drm/i915/display/intel_fbdev.c b/drivers/gpu/drm/i915/display/intel_fbdev.c
>index 1cc0ddc6a310..80c3f88310db 100644
>--- a/drivers/gpu/drm/i915/display/intel_fbdev.c
>+++ b/drivers/gpu/drm/i915/display/intel_fbdev.c
>@@ -135,9 +135,6 @@ static int intel_fbdev_mmap(struct fb_info *info, struct vm_area_struct *vma)
>         return i915_gem_fb_mmap(obj, vma);
> }
> 
>-__diag_push();
>-__diag_ignore_all("-Woverride-init", "Allow overriding the default ops");
>-
> static const struct fb_ops intelfb_ops = {
>         .owner = THIS_MODULE,
>         __FB_DEFAULT_DEFERRED_OPS_RDWR(intel_fbdev),
>@@ -149,8 +146,6 @@ static const struct fb_ops intelfb_ops = {
>         .fb_mmap = intel_fbdev_mmap,
> };
> 
>-__diag_pop();
>-
> static int intelfb_alloc(struct drm_fb_helper *helper,
>                          struct drm_fb_helper_surface_size *sizes)
> {
>diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c
>index dea3609fc496..fcacdc21643c 100644
>--- a/drivers/gpu/drm/i915/i915_pci.c
>+++ b/drivers/gpu/drm/i915/i915_pci.c
>@@ -38,9 +38,6 @@
> #include "i915_reg.h"
> #include "intel_pci_config.h"
> 
>-__diag_push();
>-__diag_ignore_all("-Woverride-init", "Allow overriding inherited members");
>-
> #define PLATFORM(x) .platform = (x)
> #define GEN(x) \
>         .__runtime.graphics.ip.ver = (x), \
>@@ -846,8 +843,6 @@ static const struct intel_device_info mtl_info = {
> 
> #undef PLATFORM
> 
>-__diag_pop();
>-
> /*
>  * Make sure any device matches here are from most specific to most
>  * general.  For example, since the Quanta match is based on the subsystem
>-- 
>2.39.2
>

Re: [Intel-gfx] [PATCH] Revert "drm/i915: use localized __diag_ignore_all() instead of per file"

[John Garry]

On 11/07/2023 12:02, Jani Nikula wrote:
> This reverts commit 88e9664434c994e97a9f6f8cdd1535495c660cea.
> 
> __diag_ignore_all() only works for GCC 8 or later.
> 
> -Woverride-init (from -Wextra, enabled in i915 Makefile) combined with
> CONFIG_WERROR=y or W=e breaks the build for older GCC.
> 
> With i386_defconfig and x86_64_defconfig enabling CONFIG_WERROR=y by
> default, we really need to roll back the change.
> 
> An alternative would be to disable -Woverride-init in the Makefile for
> GCC <8, but the revert seems like the safest bet now.
> 
> Closes:https://urldefense.com/v3/__https://gitlab.freedesktop.org/drm/intel/-/issues/8768__;!!ACWV5N9M2RV99hQ!IHKvxwtPYBXBj_pfrXmPg5H_6OVsPZaDRDgUUuYsj2IY_JpxM3APirbZR_0yg5UO61Gf2d79Ud7fgySHuVwhOPo$  
> Reported-by: John Garry<john.g.garry@oracle.com>
> References:https://urldefense.com/v3/__https://lore.kernel.org/r/ad2601c0-84bb-c574-3702-a83ff8faf98c@oracle.com__;!!ACWV5N9M2RV99hQ!IHKvxwtPYBXBj_pfrXmPg5H_6OVsPZaDRDgUUuYsj2IY_JpxM3APirbZR_0yg5UO61Gf2d79Ud7fgySH0A7kxf4$  
> References:https://urldefense.com/v3/__https://lore.kernel.org/r/87wmzezns4.fsf@intel.com__;!!ACWV5N9M2RV99hQ!IHKvxwtPYBXBj_pfrXmPg5H_6OVsPZaDRDgUUuYsj2IY_JpxM3APirbZR_0yg5UO61Gf2d79Ud7fgySHAwJkTDk$  
> Fixes: 88e9664434c9 ("drm/i915: use localized __diag_ignore_all() instead of per file")
> Cc: Gustavo Sousa<gustavo.sousa@intel.com>
> Cc: Joonas Lahtinen<joonas.lahtinen@linux.intel.com>
> Cc: Rodrigo Vivi<rodrigo.vivi@intel.com>
> Cc: Tvrtko Ursulin<tvrtko.ursulin@linux.intel.com>
> Signed-off-by: Jani Nikula<jani.nikula@intel.com>

I tested on next-20230711, as this does not apply to v6.5-rc1 (where I 
originally experienced the issue):

Tested-by: John Garry <john.g.garry@oracle.com>

cheers

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Revert "drm/i915: use localized __diag_ignore_all() instead of per file"

[Patchwork]

== Series Details ==

Series: Revert "drm/i915: use localized __diag_ignore_all() instead of per file"
URL   : https://patchwork.freedesktop.org/series/120541/
State : warning

== Summary ==

Error: dim checkpatch failed
1b351f5b2ed0 Revert "drm/i915: use localized __diag_ignore_all() instead of per file"
-:21: WARNING:BAD_REPORTED_BY_LINK: Reported-by: should be immediately followed by Closes: with a URL to the report
#21: 
Reported-by: John Garry <john.g.garry@oracle.com>
References: https://lore.kernel.org/r/ad2601c0-84bb-c574-3702-a83ff8faf98c@oracle.com

-:22: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#22: 
References: https://lore.kernel.org/r/ad2601c0-84bb-c574-3702-a83ff8faf98c@oracle.com

-:22: WARNING:COMMIT_LOG_USE_LINK: Unknown link reference 'References:', use 'Link:' or 'Closes:' instead
#22: 
References: https://lore.kernel.org/r/ad2601c0-84bb-c574-3702-a83ff8faf98c@oracle.com

-:23: WARNING:COMMIT_LOG_USE_LINK: Unknown link reference 'References:', use 'Link:' or 'Closes:' instead
#23: 
References: https://lore.kernel.org/r/87wmzezns4.fsf@intel.com

total: 0 errors, 4 warnings, 0 checks, 62 lines checked

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Revert "drm/i915: use localized __diag_ignore_all() instead of per file"

[Patchwork]

== Series Details ==

Series: Revert "drm/i915: use localized __diag_ignore_all() instead of per file"
URL   : https://patchwork.freedesktop.org/series/120541/
State : warning

== Summary ==

Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
-drivers/gpu/drm/i915/display/intel_display_device.c:503:9: warning: Initializer entry defined twice
-drivers/gpu/drm/i915/display/intel_display_device.c:505:9:   also defined here
-drivers/gpu/drm/i915/display/intel_display_device.c:625:9: warning: Initializer entry defined twice
-drivers/gpu/drm/i915/display/intel_display_device.c:630:10:   also defined here
-drivers/gpu/drm/i915/display/intel_display_device.c:638:9: warning: Initializer entry defined twice
-drivers/gpu/drm/i915/display/intel_display_device.c:640:10:   also defined here
-drivers/gpu/drm/i915/display/intel_display_device.c:714:9: warning: Initializer entry defined twice
-drivers/gpu/drm/i915/display/intel_display_device.c:718:10:   also defined here
-drivers/gpu/drm/i915/display/intel_fbdev.c:141:9: warning: Initializer entry defined twice
-drivers/gpu/drm/i915/display/intel_fbdev.c:142:10:   also defined here
-drivers/gpu/drm/i915/i915_pci.c:151:9: warning: Initializer entry defined twice
-drivers/gpu/drm/i915/i915_pci.c:153:10:   also defined here
-drivers/gpu/drm/i915/i915_pci.c:182:9: warning: Initializer entry defined twice
-drivers/gpu/drm/i915/i915_pci.c:184:10:   also defined here
-drivers/gpu/drm/i915/i915_pci.c:188:9: warning: Initializer entry defined twice
-drivers/gpu/drm/i915/i915_pci.c:190:10:   also defined here
-drivers/gpu/drm/i915/i915_pci.c:194:9: warning: Initializer entry defined twice
-drivers/gpu/drm/i915/i915_pci.c:197:10:   also defined here
-drivers/gpu/drm/i915/i915_pci.c:214:9: warning: Initializer entry defined twice
-drivers/gpu/drm/i915/i915_pci.c:217:10:   also defined here
-drivers/gpu/drm/i915/i915_pci.c:221:9: warning: Initializer entry defined twice
-drivers/gpu/drm/i915/i915_pci.c:225:10:   also defined here
-drivers/gpu/drm/i915/i915_pci.c:229:9: warning: Initializer entry defined twice
-drivers/gpu/drm/i915/i915_pci.c:231:10:   also defined here
-drivers/gpu/drm/i915/i915_pci.c:236:9: warning: Initializer entry defined twice
-drivers/gpu/drm/i915/i915_pci.c:239:10:   also defined here
-drivers/gpu/drm/i915/i915_pci.c:405:9:   also defined here
-drivers/gpu/drm/i915/i915_pci.c:405:9: warning: Initializer entry defined twice
-drivers/gpu/drm/i915/i915_pci.c:410:9:   also defined here
-drivers/gpu/drm/i915/i915_pci.c:410:9: warning: Initializer entry defined twice
-drivers/gpu/drm/i915/i915_pci.c:415:9:   also defined here
-drivers/gpu/drm/i915/i915_pci.c:415:9: warning: Initializer entry defined twice
-drivers/gpu/drm/i915/i915_pci.c:433:9:   also defined here
-drivers/gpu/drm/i915/i915_pci.c:433:9: warning: Initializer entry defined twice
-drivers/gpu/drm/i915/i915_pci.c:438:9:   also defined here
-drivers/gpu/drm/i915/i915_pci.c:438:9: warning: Initializer entry defined twice
-drivers/gpu/drm/i915/i915_pci.c:443:9:   also defined here
-drivers/gpu/drm/i915/i915_pci.c:443:9: warning: Initializer entry defined twice
-drivers/gpu/drm/i915/i915_pci.c:451:9: warning: too many warnings

[Intel-gfx] ✓ Fi.CI.BAT: success for Revert "drm/i915: use localized __diag_ignore_all() instead of per file"

[Patchwork]

[-- Attachment #1: Type: text/plain, Size: 7001 bytes --]

== Series Details ==

Series: Revert "drm/i915: use localized __diag_ignore_all() instead of per file"
URL   : https://patchwork.freedesktop.org/series/120541/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_13371 -> Patchwork_120541v1
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120541v1/index.html

Participating hosts (41 -> 40)
------------------------------

  Missing    (1): fi-snb-2520m 

Known issues
------------

  Here are the changes found in Patchwork_120541v1 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_lmem_swapping@parallel-random-engines:
    - bat-adlp-9:         NOTRUN -> [SKIP][1] ([i915#4613]) +3 similar issues
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120541v1/bat-adlp-9/igt@gem_lmem_swapping@parallel-random-engines.html

  * igt@i915_pm_rpm@module-reload:
    - fi-kbl-7567u:       [PASS][2] -> [FAIL][3] ([i915#7940])
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13371/fi-kbl-7567u/igt@i915_pm_rpm@module-reload.html
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120541v1/fi-kbl-7567u/igt@i915_pm_rpm@module-reload.html

  * igt@i915_pm_rps@basic-api:
    - bat-adlp-9:         NOTRUN -> [SKIP][4] ([i915#6621])
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120541v1/bat-adlp-9/igt@i915_pm_rps@basic-api.html

  * igt@i915_selftest@live@gt_lrc:
    - bat-rpls-2:         [PASS][5] -> [INCOMPLETE][6] ([i915#4983] / [i915#7913])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13371/bat-rpls-2/igt@i915_selftest@live@gt_lrc.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120541v1/bat-rpls-2/igt@i915_selftest@live@gt_lrc.html

  * igt@i915_selftest@live@mman:
    - bat-rpls-1:         [PASS][7] -> [TIMEOUT][8] ([i915#6794] / [i915#7392])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13371/bat-rpls-1/igt@i915_selftest@live@mman.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120541v1/bat-rpls-1/igt@i915_selftest@live@mman.html

  * igt@i915_suspend@basic-s2idle-without-i915:
    - bat-rpls-1:         [PASS][9] -> [WARN][10] ([i915#8747])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13371/bat-rpls-1/igt@i915_suspend@basic-s2idle-without-i915.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120541v1/bat-rpls-1/igt@i915_suspend@basic-s2idle-without-i915.html

  * igt@kms_chamelium_hpd@common-hpd-after-suspend:
    - bat-adlp-9:         NOTRUN -> [SKIP][11] ([i915#7828])
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120541v1/bat-adlp-9/igt@kms_chamelium_hpd@common-hpd-after-suspend.html

  * igt@prime_vgem@basic-fence-read:
    - bat-adlp-9:         NOTRUN -> [SKIP][12] ([fdo#109295] / [i915#3291] / [i915#3708]) +2 similar issues
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120541v1/bat-adlp-9/igt@prime_vgem@basic-fence-read.html

  
#### Possible fixes ####

  * igt@i915_pm_rpm@basic-pci-d3-state:
    - fi-skl-guc:         [FAIL][13] ([i915#7691]) -> [PASS][14]
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13371/fi-skl-guc/igt@i915_pm_rpm@basic-pci-d3-state.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120541v1/fi-skl-guc/igt@i915_pm_rpm@basic-pci-d3-state.html

  * igt@i915_pm_rpm@basic-rte:
    - bat-adlp-9:         [ABORT][15] ([i915#7977] / [i915#8668]) -> [PASS][16]
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13371/bat-adlp-9/igt@i915_pm_rpm@basic-rte.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120541v1/bat-adlp-9/igt@i915_pm_rpm@basic-rte.html

  * igt@i915_selftest@live@migrate:
    - bat-dg2-11:         [DMESG-WARN][17] ([i915#7699]) -> [PASS][18]
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13371/bat-dg2-11/igt@i915_selftest@live@migrate.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120541v1/bat-dg2-11/igt@i915_selftest@live@migrate.html

  * igt@i915_selftest@live@requests:
    - bat-mtlp-8:         [DMESG-FAIL][19] ([i915#8497]) -> [PASS][20]
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13371/bat-mtlp-8/igt@i915_selftest@live@requests.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120541v1/bat-mtlp-8/igt@i915_selftest@live@requests.html

  * igt@i915_selftest@live@slpc:
    - bat-mtlp-8:         [DMESG-WARN][21] ([i915#6367]) -> [PASS][22]
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13371/bat-mtlp-8/igt@i915_selftest@live@slpc.html
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120541v1/bat-mtlp-8/igt@i915_selftest@live@slpc.html

  
#### Warnings ####

  * igt@i915_pm_rpm@basic-rte:
    - fi-kbl-guc:         [FAIL][23] ([i915#7940]) -> [FAIL][24] ([i915#8843])
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13371/fi-kbl-guc/igt@i915_pm_rpm@basic-rte.html
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120541v1/fi-kbl-guc/igt@i915_pm_rpm@basic-rte.html

  
  [fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
  [i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
  [i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
  [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
  [i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
  [i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
  [i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
  [i915#6794]: https://gitlab.freedesktop.org/drm/intel/issues/6794
  [i915#7392]: https://gitlab.freedesktop.org/drm/intel/issues/7392
  [i915#7691]: https://gitlab.freedesktop.org/drm/intel/issues/7691
  [i915#7699]: https://gitlab.freedesktop.org/drm/intel/issues/7699
  [i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
  [i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
  [i915#7940]: https://gitlab.freedesktop.org/drm/intel/issues/7940
  [i915#7977]: https://gitlab.freedesktop.org/drm/intel/issues/7977
  [i915#8497]: https://gitlab.freedesktop.org/drm/intel/issues/8497
  [i915#8668]: https://gitlab.freedesktop.org/drm/intel/issues/8668
  [i915#8747]: https://gitlab.freedesktop.org/drm/intel/issues/8747
  [i915#8843]: https://gitlab.freedesktop.org/drm/intel/issues/8843


Build changes
-------------

  * Linux: CI_DRM_13371 -> Patchwork_120541v1

  CI-20190529: 20190529
  CI_DRM_13371: de8998eaee8a3a6a3682e025ec17409b8cba78f8 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_7380: 8e65f12de2fd52c05dc48fdbcb8cfe86f6de1a75 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
  Patchwork_120541v1: de8998eaee8a3a6a3682e025ec17409b8cba78f8 @ git://anongit.freedesktop.org/gfx-ci/linux


### Linux commits

39f355722063 Revert "drm/i915: use localized __diag_ignore_all() instead of per file"

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120541v1/index.html

[-- Attachment #2: Type: text/html, Size: 8010 bytes --]

[Intel-gfx] ✓ Fi.CI.IGT: success for Revert "drm/i915: use localized __diag_ignore_all() instead of per file"

[Patchwork]

[-- Attachment #1: Type: text/plain, Size: 29368 bytes --]

== Series Details ==

Series: Revert "drm/i915: use localized __diag_ignore_all() instead of per file"
URL   : https://patchwork.freedesktop.org/series/120541/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_13371_full -> Patchwork_120541v1_full
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  

Participating hosts (10 -> 12)
------------------------------

  Additional (2): shard-rkl0 shard-tglu0 

Known issues
------------

  Here are the changes found in Patchwork_120541v1_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_barrier_race@remote-request@rcs0:
    - shard-dg2:          [PASS][1] -> [ABORT][2] ([i915#7461] / [i915#8211] / [i915#8234])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13371/shard-dg2-3/igt@gem_barrier_race@remote-request@rcs0.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120541v1/shard-dg2-10/igt@gem_barrier_race@remote-request@rcs0.html
    - shard-rkl:          [PASS][3] -> [ABORT][4] ([i915#7461] / [i915#8211])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13371/shard-rkl-1/igt@gem_barrier_race@remote-request@rcs0.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120541v1/shard-rkl-4/igt@gem_barrier_race@remote-request@rcs0.html

  * igt@gem_eio@kms:
    - shard-glk:          [PASS][5] -> [FAIL][6] ([i915#8764])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13371/shard-glk3/igt@gem_eio@kms.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120541v1/shard-glk6/igt@gem_eio@kms.html

  * igt@gem_exec_fair@basic-none:
    - shard-mtlp:         NOTRUN -> [SKIP][7] ([i915#4473] / [i915#4771])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120541v1/shard-mtlp-2/igt@gem_exec_fair@basic-none.html

  * igt@gem_exec_fair@basic-none-solo@rcs0:
    - shard-apl:          [PASS][8] -> [FAIL][9] ([i915#2842])
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13371/shard-apl3/igt@gem_exec_fair@basic-none-solo@rcs0.html
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120541v1/shard-apl4/igt@gem_exec_fair@basic-none-solo@rcs0.html

  * igt@gem_exec_suspend@basic-s3@lmem0:
    - shard-dg2:          [PASS][10] -> [FAIL][11] ([fdo#103375] / [i915#6121]) +2 similar issues
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13371/shard-dg2-6/igt@gem_exec_suspend@basic-s3@lmem0.html
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120541v1/shard-dg2-5/igt@gem_exec_suspend@basic-s3@lmem0.html

  * igt@gem_lmem_swapping@massive:
    - shard-apl:          NOTRUN -> [SKIP][12] ([fdo#109271] / [i915#4613])
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120541v1/shard-apl3/igt@gem_lmem_swapping@massive.html

  * igt@gem_lmem_swapping@parallel-multi:
    - shard-glk:          NOTRUN -> [SKIP][13] ([fdo#109271] / [i915#4613])
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120541v1/shard-glk8/igt@gem_lmem_swapping@parallel-multi.html

  * igt@gem_ppgtt@blt-vs-render-ctx0:
    - shard-snb:          [PASS][14] -> [FAIL][15] ([i915#8295])
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13371/shard-snb5/igt@gem_ppgtt@blt-vs-render-ctx0.html
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120541v1/shard-snb1/igt@gem_ppgtt@blt-vs-render-ctx0.html

  * igt@gem_pxp@create-regular-buffer:
    - shard-mtlp:         NOTRUN -> [SKIP][16] ([i915#4270])
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120541v1/shard-mtlp-2/igt@gem_pxp@create-regular-buffer.html

  * igt@i915_module_load@reload-with-fault-injection:
    - shard-dg2:          [PASS][17] -> [DMESG-WARN][18] ([i915#7061])
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13371/shard-dg2-1/igt@i915_module_load@reload-with-fault-injection.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120541v1/shard-dg2-1/igt@i915_module_load@reload-with-fault-injection.html

  * igt@i915_pm_rpm@cursor:
    - shard-tglu:         [PASS][19] -> [FAIL][20] ([i915#7940])
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13371/shard-tglu-9/igt@i915_pm_rpm@cursor.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120541v1/shard-tglu-3/igt@i915_pm_rpm@cursor.html

  * igt@i915_pm_rpm@dpms-lpsp:
    - shard-rkl:          [PASS][21] -> [SKIP][22] ([i915#1397])
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13371/shard-rkl-7/igt@i915_pm_rpm@dpms-lpsp.html
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120541v1/shard-rkl-4/igt@i915_pm_rpm@dpms-lpsp.html

  * igt@kms_async_flips@crc@pipe-a-hdmi-a-2:
    - shard-rkl:          NOTRUN -> [FAIL][23] ([i915#8247]) +1 similar issue
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120541v1/shard-rkl-6/igt@kms_async_flips@crc@pipe-a-hdmi-a-2.html

  * igt@kms_async_flips@crc@pipe-a-hdmi-a-3:
    - shard-dg2:          NOTRUN -> [FAIL][24] ([i915#8247]) +3 similar issues
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120541v1/shard-dg2-3/igt@kms_async_flips@crc@pipe-a-hdmi-a-3.html

  * igt@kms_atomic_transition@plane-all-modeset-transition-fencing-internal-panels:
    - shard-apl:          NOTRUN -> [SKIP][25] ([fdo#109271] / [i915#1769])
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120541v1/shard-apl3/igt@kms_atomic_transition@plane-all-modeset-transition-fencing-internal-panels.html

  * igt@kms_ccs@pipe-c-bad-aux-stride-yf_tiled_ccs:
    - shard-mtlp:         NOTRUN -> [SKIP][26] ([i915#6095])
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120541v1/shard-mtlp-2/igt@kms_ccs@pipe-c-bad-aux-stride-yf_tiled_ccs.html

  * igt@kms_ccs@pipe-c-ccs-on-another-bo-y_tiled_gen12_mc_ccs:
    - shard-apl:          NOTRUN -> [SKIP][27] ([fdo#109271] / [i915#3886]) +2 similar issues
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120541v1/shard-apl3/igt@kms_ccs@pipe-c-ccs-on-another-bo-y_tiled_gen12_mc_ccs.html

  * igt@kms_chamelium_audio@dp-audio:
    - shard-mtlp:         NOTRUN -> [SKIP][28] ([i915#7828]) +1 similar issue
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120541v1/shard-mtlp-2/igt@kms_chamelium_audio@dp-audio.html

  * igt@kms_chamelium_edid@dp-edid-resolution-list:
    - shard-apl:          NOTRUN -> [SKIP][29] ([fdo#109271]) +37 similar issues
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120541v1/shard-apl3/igt@kms_chamelium_edid@dp-edid-resolution-list.html

  * igt@kms_color@deep-color:
    - shard-dg2:          NOTRUN -> [SKIP][30] ([i915#3555])
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120541v1/shard-dg2-5/igt@kms_color@deep-color.html
    - shard-rkl:          NOTRUN -> [SKIP][31] ([i915#3555])
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120541v1/shard-rkl-7/igt@kms_color@deep-color.html

  * igt@kms_content_protection@atomic-dpms:
    - shard-dg2:          NOTRUN -> [SKIP][32] ([i915#7118]) +1 similar issue
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120541v1/shard-dg2-5/igt@kms_content_protection@atomic-dpms.html

  * igt@kms_content_protection@atomic@pipe-a-dp-4:
    - shard-dg2:          NOTRUN -> [TIMEOUT][33] ([i915#7173]) +1 similar issue
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120541v1/shard-dg2-11/igt@kms_content_protection@atomic@pipe-a-dp-4.html

  * igt@kms_cursor_crc@cursor-suspend@pipe-c-dp-1:
    - shard-apl:          [PASS][34] -> [ABORT][35] ([i915#180])
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13371/shard-apl2/igt@kms_cursor_crc@cursor-suspend@pipe-c-dp-1.html
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120541v1/shard-apl1/igt@kms_cursor_crc@cursor-suspend@pipe-c-dp-1.html

  * igt@kms_dither@fb-8bpc-vs-panel-6bpc@pipe-a-hdmi-a-1:
    - shard-glk:          NOTRUN -> [SKIP][36] ([fdo#109271]) +15 similar issues
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120541v1/shard-glk7/igt@kms_dither@fb-8bpc-vs-panel-6bpc@pipe-a-hdmi-a-1.html

  * igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling@pipe-a-default-mode:
    - shard-mtlp:         NOTRUN -> [SKIP][37] ([i915#2672])
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120541v1/shard-mtlp-2/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling@pipe-a-default-mode.html

  * igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-mmap-cpu:
    - shard-dg2:          [PASS][38] -> [FAIL][39] ([i915#6880])
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13371/shard-dg2-5/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-mmap-cpu.html
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120541v1/shard-dg2-6/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-mmap-cpu.html

  * igt@kms_hdr@bpc-switch:
    - shard-dg2:          NOTRUN -> [SKIP][40] ([i915#3555] / [i915#8228])
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120541v1/shard-dg2-8/igt@kms_hdr@bpc-switch.html
    - shard-rkl:          NOTRUN -> [SKIP][41] ([i915#3555] / [i915#8228]) +1 similar issue
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120541v1/shard-rkl-2/igt@kms_hdr@bpc-switch.html

  * igt@kms_plane_scaling@plane-downscale-with-rotation-factor-0-25@pipe-b-hdmi-a-1:
    - shard-rkl:          NOTRUN -> [SKIP][42] ([i915#5176]) +5 similar issues
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120541v1/shard-rkl-7/igt@kms_plane_scaling@plane-downscale-with-rotation-factor-0-25@pipe-b-hdmi-a-1.html

  * igt@kms_plane_scaling@plane-downscale-with-rotation-factor-0-25@pipe-d-hdmi-a-2:
    - shard-dg2:          NOTRUN -> [SKIP][43] ([i915#5176]) +7 similar issues
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120541v1/shard-dg2-2/igt@kms_plane_scaling@plane-downscale-with-rotation-factor-0-25@pipe-d-hdmi-a-2.html

  * igt@kms_plane_scaling@plane-upscale-with-modifiers-factor-0-25@pipe-a-vga-1:
    - shard-snb:          NOTRUN -> [SKIP][44] ([fdo#109271]) +100 similar issues
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120541v1/shard-snb4/igt@kms_plane_scaling@plane-upscale-with-modifiers-factor-0-25@pipe-a-vga-1.html

  * igt@kms_plane_scaling@planes-downscale-factor-0-25-unity-scaling@pipe-a-dp-4:
    - shard-dg2:          NOTRUN -> [SKIP][45] ([i915#5235]) +11 similar issues
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120541v1/shard-dg2-11/igt@kms_plane_scaling@planes-downscale-factor-0-25-unity-scaling@pipe-a-dp-4.html

  * igt@kms_plane_scaling@planes-downscale-factor-0-25-unity-scaling@pipe-b-hdmi-a-1:
    - shard-rkl:          NOTRUN -> [SKIP][46] ([i915#5235]) +1 similar issue
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120541v1/shard-rkl-7/igt@kms_plane_scaling@planes-downscale-factor-0-25-unity-scaling@pipe-b-hdmi-a-1.html

  * igt@kms_psr2_sf@cursor-plane-move-continuous-sf:
    - shard-glk:          NOTRUN -> [SKIP][47] ([fdo#109271] / [i915#658])
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120541v1/shard-glk8/igt@kms_psr2_sf@cursor-plane-move-continuous-sf.html

  * igt@kms_psr2_sf@plane-move-sf-dmg-area:
    - shard-apl:          NOTRUN -> [SKIP][48] ([fdo#109271] / [i915#658]) +1 similar issue
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120541v1/shard-apl3/igt@kms_psr2_sf@plane-move-sf-dmg-area.html

  * igt@kms_setmode@basic@pipe-a-vga-1:
    - shard-snb:          NOTRUN -> [FAIL][49] ([i915#5465]) +1 similar issue
   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120541v1/shard-snb4/igt@kms_setmode@basic@pipe-a-vga-1.html

  * igt@kms_vblank@pipe-b-ts-continuation-suspend:
    - shard-snb:          NOTRUN -> [DMESG-WARN][50] ([i915#8841]) +1 similar issue
   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120541v1/shard-snb7/igt@kms_vblank@pipe-b-ts-continuation-suspend.html

  * igt@vc4/vc4_perfmon@destroy-invalid-perfmon:
    - shard-mtlp:         NOTRUN -> [SKIP][51] ([i915#7711])
   [51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120541v1/shard-mtlp-2/igt@vc4/vc4_perfmon@destroy-invalid-perfmon.html

  
#### Possible fixes ####

  * igt@drm_fdinfo@idle@rcs0:
    - shard-rkl:          [FAIL][52] ([i915#7742]) -> [PASS][53]
   [52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13371/shard-rkl-1/igt@drm_fdinfo@idle@rcs0.html
   [53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120541v1/shard-rkl-2/igt@drm_fdinfo@idle@rcs0.html

  * igt@gem_barrier_race@remote-request@rcs0:
    - shard-glk:          [ABORT][54] ([i915#7461] / [i915#8211]) -> [PASS][55]
   [54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13371/shard-glk2/igt@gem_barrier_race@remote-request@rcs0.html
   [55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120541v1/shard-glk9/igt@gem_barrier_race@remote-request@rcs0.html

  * igt@gem_ctx_exec@basic-nohangcheck:
    - shard-rkl:          [FAIL][56] ([i915#6268]) -> [PASS][57]
   [56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13371/shard-rkl-1/igt@gem_ctx_exec@basic-nohangcheck.html
   [57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120541v1/shard-rkl-1/igt@gem_ctx_exec@basic-nohangcheck.html

  * igt@gem_eio@reset-stress:
    - {shard-dg1}:        [FAIL][58] ([i915#5784]) -> [PASS][59]
   [58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13371/shard-dg1-13/igt@gem_eio@reset-stress.html
   [59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120541v1/shard-dg1-19/igt@gem_eio@reset-stress.html

  * igt@gem_exec_whisper@basic-contexts-forked-all:
    - shard-mtlp:         [TIMEOUT][60] ([i915#8628]) -> [PASS][61]
   [60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13371/shard-mtlp-2/igt@gem_exec_whisper@basic-contexts-forked-all.html
   [61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120541v1/shard-mtlp-7/igt@gem_exec_whisper@basic-contexts-forked-all.html

  * igt@gem_exec_whisper@basic-normal-all:
    - shard-mtlp:         [FAIL][62] ([i915#6363]) -> [PASS][63]
   [62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13371/shard-mtlp-7/igt@gem_exec_whisper@basic-normal-all.html
   [63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120541v1/shard-mtlp-3/igt@gem_exec_whisper@basic-normal-all.html

  * igt@gen9_exec_parse@allowed-single:
    - shard-apl:          [ABORT][64] ([i915#5566]) -> [PASS][65]
   [64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13371/shard-apl6/igt@gen9_exec_parse@allowed-single.html
   [65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120541v1/shard-apl3/igt@gen9_exec_parse@allowed-single.html

  * igt@i915_pm_rpm@basic-pci-d3-state:
    - {shard-dg1}:        [FAIL][66] ([i915#7691]) -> [PASS][67]
   [66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13371/shard-dg1-16/igt@i915_pm_rpm@basic-pci-d3-state.html
   [67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120541v1/shard-dg1-13/igt@i915_pm_rpm@basic-pci-d3-state.html

  * igt@i915_pm_rpm@cursor-dpms:
    - shard-tglu:         [FAIL][68] ([i915#7940]) -> [PASS][69]
   [68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13371/shard-tglu-9/igt@i915_pm_rpm@cursor-dpms.html
   [69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120541v1/shard-tglu-10/igt@i915_pm_rpm@cursor-dpms.html

  * igt@i915_pm_rpm@dpms-non-lpsp:
    - shard-rkl:          [SKIP][70] ([i915#1397]) -> [PASS][71] +3 similar issues
   [70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13371/shard-rkl-7/igt@i915_pm_rpm@dpms-non-lpsp.html
   [71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120541v1/shard-rkl-6/igt@i915_pm_rpm@dpms-non-lpsp.html

  * igt@i915_pm_rpm@modeset-lpsp:
    - {shard-dg1}:        [SKIP][72] ([i915#1397]) -> [PASS][73] +1 similar issue
   [72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13371/shard-dg1-13/igt@i915_pm_rpm@modeset-lpsp.html
   [73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120541v1/shard-dg1-19/igt@i915_pm_rpm@modeset-lpsp.html

  * igt@i915_pm_rpm@modeset-non-lpsp-stress:
    - {shard-dg1}:        [FAIL][74] ([i915#7940]) -> [PASS][75]
   [74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13371/shard-dg1-14/igt@i915_pm_rpm@modeset-non-lpsp-stress.html
   [75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120541v1/shard-dg1-14/igt@i915_pm_rpm@modeset-non-lpsp-stress.html

  * igt@i915_pm_rpm@modeset-non-lpsp-stress-no-wait:
    - shard-dg2:          [SKIP][76] ([i915#1397]) -> [PASS][77] +1 similar issue
   [76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13371/shard-dg2-12/igt@i915_pm_rpm@modeset-non-lpsp-stress-no-wait.html
   [77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120541v1/shard-dg2-3/igt@i915_pm_rpm@modeset-non-lpsp-stress-no-wait.html

  * igt@i915_selftest@live@gt_mocs:
    - shard-mtlp:         [DMESG-FAIL][78] ([i915#7059]) -> [PASS][79]
   [78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13371/shard-mtlp-8/igt@i915_selftest@live@gt_mocs.html
   [79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120541v1/shard-mtlp-4/igt@i915_selftest@live@gt_mocs.html

  * igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-180-async-flip:
    - shard-mtlp:         [FAIL][80] ([i915#3743]) -> [PASS][81]
   [80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13371/shard-mtlp-8/igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-180-async-flip.html
   [81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120541v1/shard-mtlp-4/igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-180-async-flip.html

  * igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0-hflip:
    - shard-mtlp:         [FAIL][82] ([i915#5138]) -> [PASS][83] +1 similar issue
   [82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13371/shard-mtlp-3/igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0-hflip.html
   [83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120541v1/shard-mtlp-5/igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0-hflip.html

  * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
    - shard-apl:          [FAIL][84] ([i915#2346]) -> [PASS][85]
   [84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13371/shard-apl2/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
   [85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120541v1/shard-apl1/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html

  * igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@bc-hdmi-a1-hdmi-a2:
    - shard-glk:          [FAIL][86] ([i915#79]) -> [PASS][87]
   [86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13371/shard-glk6/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@bc-hdmi-a1-hdmi-a2.html
   [87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120541v1/shard-glk8/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@bc-hdmi-a1-hdmi-a2.html

  * igt@kms_sysfs_edid_timing:
    - shard-dg2:          [FAIL][88] ([IGT#2]) -> [PASS][89]
   [88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13371/shard-dg2-6/igt@kms_sysfs_edid_timing.html
   [89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120541v1/shard-dg2-11/igt@kms_sysfs_edid_timing.html

  * igt@kms_vblank@pipe-a-accuracy-idle:
    - shard-snb:          [SKIP][90] ([fdo#109271]) -> [PASS][91] +3 similar issues
   [90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13371/shard-snb6/igt@kms_vblank@pipe-a-accuracy-idle.html
   [91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120541v1/shard-snb6/igt@kms_vblank@pipe-a-accuracy-idle.html

  * igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend:
    - shard-dg2:          [FAIL][92] ([fdo#103375] / [i915#6121]) -> [PASS][93] +4 similar issues
   [92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13371/shard-dg2-5/igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend.html
   [93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120541v1/shard-dg2-7/igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend.html

  * igt@sysfs_heartbeat_interval@nopreempt@bcs0:
    - shard-mtlp:         [FAIL][94] ([i915#6015]) -> [PASS][95]
   [94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13371/shard-mtlp-8/igt@sysfs_heartbeat_interval@nopreempt@bcs0.html
   [95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120541v1/shard-mtlp-4/igt@sysfs_heartbeat_interval@nopreempt@bcs0.html

  
#### Warnings ####

  * igt@gem_exec_whisper@basic-contexts-priority-all:
    - shard-mtlp:         [TIMEOUT][96] ([i915#7392]) -> [ABORT][97] ([i915#8131])
   [96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13371/shard-mtlp-5/igt@gem_exec_whisper@basic-contexts-priority-all.html
   [97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120541v1/shard-mtlp-4/igt@gem_exec_whisper@basic-contexts-priority-all.html

  * igt@i915_pm_rc6_residency@rc6-idle@bcs0:
    - shard-tglu:         [WARN][98] ([i915#2681]) -> [FAIL][99] ([i915#2681] / [i915#3591])
   [98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13371/shard-tglu-10/igt@i915_pm_rc6_residency@rc6-idle@bcs0.html
   [99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120541v1/shard-tglu-6/igt@i915_pm_rc6_residency@rc6-idle@bcs0.html

  * igt@i915_pm_rc6_residency@rc6-idle@vcs0:
    - shard-tglu:         [FAIL][100] ([i915#2681] / [i915#3591]) -> [WARN][101] ([i915#2681])
   [100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13371/shard-tglu-10/igt@i915_pm_rc6_residency@rc6-idle@vcs0.html
   [101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120541v1/shard-tglu-6/igt@i915_pm_rc6_residency@rc6-idle@vcs0.html

  * igt@kms_cursor_legacy@cursorb-vs-flipb-atomic-transitions:
    - shard-snb:          [SKIP][102] ([fdo#109271]) -> [SKIP][103] ([fdo#109271] / [fdo#111767])
   [102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13371/shard-snb6/igt@kms_cursor_legacy@cursorb-vs-flipb-atomic-transitions.html
   [103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120541v1/shard-snb6/igt@kms_cursor_legacy@cursorb-vs-flipb-atomic-transitions.html

  * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
    - shard-mtlp:         [FAIL][104] ([i915#2346]) -> [DMESG-FAIL][105] ([i915#1982] / [i915#2017] / [i915#5954])
   [104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13371/shard-mtlp-3/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
   [105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120541v1/shard-mtlp-2/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html

  * igt@kms_multipipe_modeset@basic-max-pipe-crc-check:
    - shard-rkl:          [SKIP][106] ([i915#4070] / [i915#4816]) -> [SKIP][107] ([i915#4816])
   [106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13371/shard-rkl-1/igt@kms_multipipe_modeset@basic-max-pipe-crc-check.html
   [107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120541v1/shard-rkl-7/igt@kms_multipipe_modeset@basic-max-pipe-crc-check.html

  * igt@kms_pipe_crc_basic@suspend-read-crc@pipe-b-vga-1:
    - shard-snb:          [DMESG-WARN][108] ([i915#5090] / [i915#8841]) -> [DMESG-WARN][109] ([i915#8841])
   [108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13371/shard-snb4/igt@kms_pipe_crc_basic@suspend-read-crc@pipe-b-vga-1.html
   [109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120541v1/shard-snb2/igt@kms_pipe_crc_basic@suspend-read-crc@pipe-b-vga-1.html

  * igt@sysfs_timeslice_duration@timeout@vecs0:
    - shard-mtlp:         [ABORT][110] ([i915#8521]) -> [TIMEOUT][111] ([i915#6950])
   [110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13371/shard-mtlp-3/igt@sysfs_timeslice_duration@timeout@vecs0.html
   [111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120541v1/shard-mtlp-2/igt@sysfs_timeslice_duration@timeout@vecs0.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [IGT#2]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/2
  [fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
  [fdo#111767]: https://bugs.freedesktop.org/show_bug.cgi?id=111767
  [fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
  [i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
  [i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
  [i915#1769]: https://gitlab.freedesktop.org/drm/intel/issues/1769
  [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
  [i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
  [i915#2017]: https://gitlab.freedesktop.org/drm/intel/issues/2017
  [i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
  [i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
  [i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
  [i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
  [i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
  [i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
  [i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
  [i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
  [i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
  [i915#3743]: https://gitlab.freedesktop.org/drm/intel/issues/3743
  [i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
  [i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
  [i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
  [i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
  [i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
  [i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
  [i915#4473]: https://gitlab.freedesktop.org/drm/intel/issues/4473
  [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
  [i915#4771]: https://gitlab.freedesktop.org/drm/intel/issues/4771
  [i915#4816]: https://gitlab.freedesktop.org/drm/intel/issues/4816
  [i915#5090]: https://gitlab.freedesktop.org/drm/intel/issues/5090
  [i915#5138]: https://gitlab.freedesktop.org/drm/intel/issues/5138
  [i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
  [i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
  [i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
  [i915#5465]: https://gitlab.freedesktop.org/drm/intel/issues/5465
  [i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
  [i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
  [i915#5954]: https://gitlab.freedesktop.org/drm/intel/issues/5954
  [i915#6015]: https://gitlab.freedesktop.org/drm/intel/issues/6015
  [i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
  [i915#6121]: https://gitlab.freedesktop.org/drm/intel/issues/6121
  [i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
  [i915#6363]: https://gitlab.freedesktop.org/drm/intel/issues/6363
  [i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
  [i915#6880]: https://gitlab.freedesktop.org/drm/intel/issues/6880
  [i915#6950]: https://gitlab.freedesktop.org/drm/intel/issues/6950
  [i915#7059]: https://gitlab.freedesktop.org/drm/intel/issues/7059
  [i915#7061]: https://gitlab.freedesktop.org/drm/intel/issues/7061
  [i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
  [i915#7173]: https://gitlab.freedesktop.org/drm/intel/issues/7173
  [i915#7392]: https://gitlab.freedesktop.org/drm/intel/issues/7392
  [i915#7461]: https://gitlab.freedesktop.org/drm/intel/issues/7461
  [i915#7691]: https://gitlab.freedesktop.org/drm/intel/issues/7691
  [i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
  [i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
  [i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
  [i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
  [i915#7940]: https://gitlab.freedesktop.org/drm/intel/issues/7940
  [i915#8131]: https://gitlab.freedesktop.org/drm/intel/issues/8131
  [i915#8211]: https://gitlab.freedesktop.org/drm/intel/issues/8211
  [i915#8228]: https://gitlab.freedesktop.org/drm/intel/issues/8228
  [i915#8234]: https://gitlab.freedesktop.org/drm/intel/issues/8234
  [i915#8247]: https://gitlab.freedesktop.org/drm/intel/issues/8247
  [i915#8295]: https://gitlab.freedesktop.org/drm/intel/issues/8295
  [i915#8521]: https://gitlab.freedesktop.org/drm/intel/issues/8521
  [i915#8628]: https://gitlab.freedesktop.org/drm/intel/issues/8628
  [i915#8708]: https://gitlab.freedesktop.org/drm/intel/issues/8708
  [i915#8709]: https://gitlab.freedesktop.org/drm/intel/issues/8709
  [i915#8764]: https://gitlab.freedesktop.org/drm/intel/issues/8764
  [i915#8841]: https://gitlab.freedesktop.org/drm/intel/issues/8841


Build changes
-------------

  * Linux: CI_DRM_13371 -> Patchwork_120541v1

  CI-20190529: 20190529
  CI_DRM_13371: de8998eaee8a3a6a3682e025ec17409b8cba78f8 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_7380: 8e65f12de2fd52c05dc48fdbcb8cfe86f6de1a75 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
  Patchwork_120541v1: de8998eaee8a3a6a3682e025ec17409b8cba78f8 @ git://anongit.freedesktop.org/gfx-ci/linux
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120541v1/index.html

[-- Attachment #2: Type: text/html, Size: 33457 bytes --]

Re: [Intel-gfx] [PATCH] Revert "drm/i915: use localized __diag_ignore_all() instead of per file"

[Jani Nikula]

On Tue, 11 Jul 2023, Gustavo Sousa <gustavo.sousa@intel.com> wrote:
> Quoting Jani Nikula (2023-07-11 08:02:14-03:00)
>>This reverts commit 88e9664434c994e97a9f6f8cdd1535495c660cea.
>>
>>__diag_ignore_all() only works for GCC 8 or later.
>>
>>-Woverride-init (from -Wextra, enabled in i915 Makefile) combined with
>>CONFIG_WERROR=y or W=e breaks the build for older GCC.
>>
>>With i386_defconfig and x86_64_defconfig enabling CONFIG_WERROR=y by
>>default, we really need to roll back the change.
>>
>>An alternative would be to disable -Woverride-init in the Makefile for
>>GCC <8, but the revert seems like the safest bet now.
>
> Sounds good. We would keep it compatible with older compilers and still have the
> warning enabled on newer environments.
>
> Another alternative I thought about was to have separate files only for
> initializations of that type (i.e. that would need the warning disabled), but I
> guess we would need to expose a lot of symbols for that to work...
>
> Reviewed-by: Gustavo Sousa <gustavo.sousa@intel.com>

Thanks, pushed to drm-intel-next.

BR,
Jani.

>
>>
>>Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/8768
>>Reported-by: John Garry <john.g.garry@oracle.com>
>>References: https://lore.kernel.org/r/ad2601c0-84bb-c574-3702-a83ff8faf98c@oracle.com
>>References: https://lore.kernel.org/r/87wmzezns4.fsf@intel.com
>>Fixes: 88e9664434c9 ("drm/i915: use localized __diag_ignore_all() instead of per file")
>>Cc: Gustavo Sousa <gustavo.sousa@intel.com>
>>Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
>>Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
>>Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
>>Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>>---
>> drivers/gpu/drm/i915/Makefile                       | 5 +++++
>> drivers/gpu/drm/i915/display/intel_display_device.c | 5 -----
>> drivers/gpu/drm/i915/display/intel_fbdev.c          | 5 -----
>> drivers/gpu/drm/i915/i915_pci.c                     | 5 -----
>> 4 files changed, 5 insertions(+), 15 deletions(-)
>>
>>diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile
>>index 2be9dd960540..c5fc91cd58e7 100644
>>--- a/drivers/gpu/drm/i915/Makefile
>>+++ b/drivers/gpu/drm/i915/Makefile
>>@@ -23,6 +23,11 @@ subdir-ccflags-y += $(call cc-option, -Wunused-but-set-variable)
>> subdir-ccflags-y += $(call cc-disable-warning, frame-address)
>> subdir-ccflags-$(CONFIG_DRM_I915_WERROR) += -Werror
>> 
>>+# Fine grained warnings disable
>>+CFLAGS_i915_pci.o = $(call cc-disable-warning, override-init)
>>+CFLAGS_display/intel_display_device.o = $(call cc-disable-warning, override-init)
>>+CFLAGS_display/intel_fbdev.o = $(call cc-disable-warning, override-init)
>>+
>> subdir-ccflags-y += -I$(srctree)/$(src)
>> 
>> # Please keep these build lists sorted!
>>diff --git a/drivers/gpu/drm/i915/display/intel_display_device.c b/drivers/gpu/drm/i915/display/intel_display_device.c
>>index e4afa7334c82..8286e79522d1 100644
>>--- a/drivers/gpu/drm/i915/display/intel_display_device.c
>>+++ b/drivers/gpu/drm/i915/display/intel_display_device.c
>>@@ -16,9 +16,6 @@
>> #include "intel_display_reg_defs.h"
>> #include "intel_fbc.h"
>> 
>>-__diag_push();
>>-__diag_ignore_all("-Woverride-init", "Allow overriding inherited members");
>>-
>> static const struct intel_display_device_info no_display = {};
>> 
>> #define PIPE_A_OFFSET                0x70000
>>@@ -727,8 +724,6 @@ static const struct intel_display_device_info xe_lpdp_display = {
>>                 BIT(PORT_TC1) | BIT(PORT_TC2) | BIT(PORT_TC3) | BIT(PORT_TC4),
>> };
>> 
>>-__diag_pop();
>>-
>> #undef INTEL_VGA_DEVICE
>> #undef INTEL_QUANTA_VGA_DEVICE
>> #define INTEL_VGA_DEVICE(id, info) { id, info }
>>diff --git a/drivers/gpu/drm/i915/display/intel_fbdev.c b/drivers/gpu/drm/i915/display/intel_fbdev.c
>>index 1cc0ddc6a310..80c3f88310db 100644
>>--- a/drivers/gpu/drm/i915/display/intel_fbdev.c
>>+++ b/drivers/gpu/drm/i915/display/intel_fbdev.c
>>@@ -135,9 +135,6 @@ static int intel_fbdev_mmap(struct fb_info *info, struct vm_area_struct *vma)
>>         return i915_gem_fb_mmap(obj, vma);
>> }
>> 
>>-__diag_push();
>>-__diag_ignore_all("-Woverride-init", "Allow overriding the default ops");
>>-
>> static const struct fb_ops intelfb_ops = {
>>         .owner = THIS_MODULE,
>>         __FB_DEFAULT_DEFERRED_OPS_RDWR(intel_fbdev),
>>@@ -149,8 +146,6 @@ static const struct fb_ops intelfb_ops = {
>>         .fb_mmap = intel_fbdev_mmap,
>> };
>> 
>>-__diag_pop();
>>-
>> static int intelfb_alloc(struct drm_fb_helper *helper,
>>                          struct drm_fb_helper_surface_size *sizes)
>> {
>>diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c
>>index dea3609fc496..fcacdc21643c 100644
>>--- a/drivers/gpu/drm/i915/i915_pci.c
>>+++ b/drivers/gpu/drm/i915/i915_pci.c
>>@@ -38,9 +38,6 @@
>> #include "i915_reg.h"
>> #include "intel_pci_config.h"
>> 
>>-__diag_push();
>>-__diag_ignore_all("-Woverride-init", "Allow overriding inherited members");
>>-
>> #define PLATFORM(x) .platform = (x)
>> #define GEN(x) \
>>         .__runtime.graphics.ip.ver = (x), \
>>@@ -846,8 +843,6 @@ static const struct intel_device_info mtl_info = {
>> 
>> #undef PLATFORM
>> 
>>-__diag_pop();
>>-
>> /*
>>  * Make sure any device matches here are from most specific to most
>>  * general.  For example, since the Quanta match is based on the subsystem
>>-- 
>>2.39.2
>>

-- 
Jani Nikula, Intel Open Source Graphics Center