Re: [Intel-gfx] [PATCH 1/2] drm/i915: Make intel_mpllb_state_verify() safer

[Jani Nikula <jani.nikula@linux.intel.com>]

On Thu, 13 Apr 2023, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> intel_mpllb_state_verify() blows up if you call it for a
> non-modeset/fastset commit on account of the relevant
> connector not being part of the overall atomic state.
> Currently the state checker only runs for modeset/fastset
> commits, but for testing purposes it is sometimes desirable
> to run it for other commits too. Check for modeset/fastset
> in intel_mpllb_state_verify() itself to make this safe.

Seems a bit redundant, but okay.

Reviewed-by: Jani Nikula <jani.nikula@intel.com>


>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_snps_phy.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_snps_phy.c b/drivers/gpu/drm/i915/display/intel_snps_phy.c
> index 1cfb94b5cedb..4efc79d47e43 100644
> --- a/drivers/gpu/drm/i915/display/intel_snps_phy.c
> +++ b/drivers/gpu/drm/i915/display/intel_snps_phy.c
> @@ -2007,6 +2007,10 @@ void intel_mpllb_state_verify(struct intel_atomic_state *state,
>  	if (!new_crtc_state->hw.active)
>  		return;
>  
> +	if (!intel_crtc_needs_modeset(new_crtc_state) &&
> +	    !intel_crtc_needs_fastset(new_crtc_state))
> +		return;
> +
>  	encoder = intel_get_crtc_new_encoder(state, new_crtc_state);
>  	intel_mpllb_readout_hw_state(encoder, &mpllb_hw_state);

-- 
Jani Nikula, Intel Open Source Graphics Center