RE: [PATCH] drm/i915/pcode: Fix the coding style

[Jani Nikula <jani.nikula@linux.intel.com>]

On Wed, 12 Feb 2025, "Gote, Nitin R" <nitin.r.gote@intel.com> wrote:
> Hi,
>
>> -----Original Message-----
>> From: Jani Nikula <jani.nikula@linux.intel.com>
>> Sent: Tuesday, February 11, 2025 6:56 PM
>> To: Andi Shyti <andi.shyti@linux.intel.com>; Gote, Nitin R
>> <nitin.r.gote@intel.com>
>> Cc: intel-gfx@lists.freedesktop.org
>> Subject: Re: [PATCH] drm/i915/pcode: Fix the coding style
>> 
>> On Mon, 10 Feb 2025, Andi Shyti <andi.shyti@linux.intel.com> wrote:
>> > Hi Nitin,
>> >
>> > On Mon, Feb 10, 2025 at 07:39:24PM +0530, Nitin Gote wrote:
>> >> Prefer binary operator at the end of the previous line instead of
>> >> putting operator at the start of the next line as per coding style.
>> >
>> > I'm not finding any documentation for this change, where did you take
>> > it?
>> 
>> If not documented, it's the prevalent style, anyway.
>
> Yeah, My bad I thought it is a standard coding style but it is not so.
> But still, I feel the more correct way is to use binary "|" operator in continuation of first line
> instead of second line.

Yes, that's what I said, that's the prevalent style.

>
> Thanks,
> Nitin
>> 
>> BR,
>> Jani.
>> 
>> 
>> --
>> Jani Nikula, Intel

-- 
Jani Nikula, Intel