[PATCH] drm/i915/pcode: Fix the coding style

[PATCH] drm/i915/pcode: Fix the coding style

[Nitin Gote]

Prefer binary operator at the end of the previous
line instead of putting operator at the start of
the next line as per coding style.

Signed-off-by: Nitin Gote <nitin.r.gote@intel.com>
---
 drivers/gpu/drm/i915/intel_pcode.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_pcode.c b/drivers/gpu/drm/i915/intel_pcode.c
index 3db2ba439bb5..3e6cf3eb831e 100644
--- a/drivers/gpu/drm/i915/intel_pcode.c
+++ b/drivers/gpu/drm/i915/intel_pcode.c
@@ -248,9 +248,9 @@ int snb_pcode_read_p(struct intel_uncore *uncore, u32 mbcmd, u32 p1, u32 p2, u32
 	u32 mbox;
 	int err;
 
-	mbox = REG_FIELD_PREP(GEN6_PCODE_MB_COMMAND, mbcmd)
-		| REG_FIELD_PREP(GEN6_PCODE_MB_PARAM1, p1)
-		| REG_FIELD_PREP(GEN6_PCODE_MB_PARAM2, p2);
+	mbox = REG_FIELD_PREP(GEN6_PCODE_MB_COMMAND, mbcmd) |
+		REG_FIELD_PREP(GEN6_PCODE_MB_PARAM1, p1) |
+		REG_FIELD_PREP(GEN6_PCODE_MB_PARAM2, p2);
 
 	with_intel_runtime_pm(uncore->rpm, wakeref)
 		err = snb_pcode_read(uncore, mbox, val, NULL);
@@ -264,9 +264,9 @@ int snb_pcode_write_p(struct intel_uncore *uncore, u32 mbcmd, u32 p1, u32 p2, u3
 	u32 mbox;
 	int err;
 
-	mbox = REG_FIELD_PREP(GEN6_PCODE_MB_COMMAND, mbcmd)
-		| REG_FIELD_PREP(GEN6_PCODE_MB_PARAM1, p1)
-		| REG_FIELD_PREP(GEN6_PCODE_MB_PARAM2, p2);
+	mbox = REG_FIELD_PREP(GEN6_PCODE_MB_COMMAND, mbcmd) |
+		REG_FIELD_PREP(GEN6_PCODE_MB_PARAM1, p1) |
+		REG_FIELD_PREP(GEN6_PCODE_MB_PARAM2, p2);
 
 	with_intel_runtime_pm(uncore->rpm, wakeref)
 		err = snb_pcode_write(uncore, mbox, val);
-- 
2.25.1

Re: [PATCH] drm/i915/pcode: Fix the coding style

[Andi Shyti]

Hi Nitin,

On Mon, Feb 10, 2025 at 07:39:24PM +0530, Nitin Gote wrote:
> Prefer binary operator at the end of the previous
> line instead of putting operator at the start of
> the next line as per coding style.

I'm not finding any documentation for this change, where did you
take it?

Andi

Re: [PATCH] drm/i915/pcode: Fix the coding style

[Jani Nikula]

On Mon, 10 Feb 2025, Andi Shyti <andi.shyti@linux.intel.com> wrote:
> Hi Nitin,
>
> On Mon, Feb 10, 2025 at 07:39:24PM +0530, Nitin Gote wrote:
>> Prefer binary operator at the end of the previous
>> line instead of putting operator at the start of
>> the next line as per coding style.
>
> I'm not finding any documentation for this change, where did you
> take it?

If not documented, it's the prevalent style, anyway.

BR,
Jani.


-- 
Jani Nikula, Intel

RE: [PATCH] drm/i915/pcode: Fix the coding style

[Gote, Nitin R]

Hi,

> -----Original Message-----
> From: Jani Nikula <jani.nikula@linux.intel.com>
> Sent: Tuesday, February 11, 2025 6:56 PM
> To: Andi Shyti <andi.shyti@linux.intel.com>; Gote, Nitin R
> <nitin.r.gote@intel.com>
> Cc: intel-gfx@lists.freedesktop.org
> Subject: Re: [PATCH] drm/i915/pcode: Fix the coding style
> 
> On Mon, 10 Feb 2025, Andi Shyti <andi.shyti@linux.intel.com> wrote:
> > Hi Nitin,
> >
> > On Mon, Feb 10, 2025 at 07:39:24PM +0530, Nitin Gote wrote:
> >> Prefer binary operator at the end of the previous line instead of
> >> putting operator at the start of the next line as per coding style.
> >
> > I'm not finding any documentation for this change, where did you take
> > it?
> 
> If not documented, it's the prevalent style, anyway.

Yeah, My bad I thought it is a standard coding style but it is not so.
But still, I feel the more correct way is to use binary "|" operator in continuation of first line
instead of second line.

Thanks,
Nitin
> 
> BR,
> Jani.
> 
> 
> --
> Jani Nikula, Intel

RE: [PATCH] drm/i915/pcode: Fix the coding style

[Jani Nikula]

On Wed, 12 Feb 2025, "Gote, Nitin R" <nitin.r.gote@intel.com> wrote:
> Hi,
>
>> -----Original Message-----
>> From: Jani Nikula <jani.nikula@linux.intel.com>
>> Sent: Tuesday, February 11, 2025 6:56 PM
>> To: Andi Shyti <andi.shyti@linux.intel.com>; Gote, Nitin R
>> <nitin.r.gote@intel.com>
>> Cc: intel-gfx@lists.freedesktop.org
>> Subject: Re: [PATCH] drm/i915/pcode: Fix the coding style
>> 
>> On Mon, 10 Feb 2025, Andi Shyti <andi.shyti@linux.intel.com> wrote:
>> > Hi Nitin,
>> >
>> > On Mon, Feb 10, 2025 at 07:39:24PM +0530, Nitin Gote wrote:
>> >> Prefer binary operator at the end of the previous line instead of
>> >> putting operator at the start of the next line as per coding style.
>> >
>> > I'm not finding any documentation for this change, where did you take
>> > it?
>> 
>> If not documented, it's the prevalent style, anyway.
>
> Yeah, My bad I thought it is a standard coding style but it is not so.
> But still, I feel the more correct way is to use binary "|" operator in continuation of first line
> instead of second line.

Yes, that's what I said, that's the prevalent style.

>
> Thanks,
> Nitin
>> 
>> BR,
>> Jani.
>> 
>> 
>> --
>> Jani Nikula, Intel

-- 
Jani Nikula, Intel

✗ i915.CI.BAT: failure for drm/i915/pcode: Fix the coding style

[Patchwork]

[-- Attachment #1: Type: text/plain, Size: 4952 bytes --]

== Series Details ==

Series: drm/i915/pcode: Fix the coding style
URL   : https://patchwork.freedesktop.org/series/144608/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_16098 -> Patchwork_144608v1
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with Patchwork_144608v1 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_144608v1, please notify your bug team (I915-ci-infra@lists.freedesktop.org) to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144608v1/index.html

Participating hosts (45 -> 43)
------------------------------

  Missing    (2): fi-glk-j4005 fi-snb-2520m 

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in Patchwork_144608v1:

### IGT changes ###

#### Possible regressions ####

  * igt@kms_flip@basic-flip-vs-modeset@c-dp1:
    - fi-kbl-7567u:       [PASS][1] -> [DMESG-WARN][2] +1 other test dmesg-warn
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16098/fi-kbl-7567u/igt@kms_flip@basic-flip-vs-modeset@c-dp1.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144608v1/fi-kbl-7567u/igt@kms_flip@basic-flip-vs-modeset@c-dp1.html

  
Known issues
------------

  Here are the changes found in Patchwork_144608v1 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@i915_pm_rpm@module-reload:
    - bat-dg2-11:         [PASS][3] -> [FAIL][4] ([i915#13633])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16098/bat-dg2-11/igt@i915_pm_rpm@module-reload.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144608v1/bat-dg2-11/igt@i915_pm_rpm@module-reload.html
    - bat-adls-6:         [PASS][5] -> [FAIL][6] ([i915#13633])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16098/bat-adls-6/igt@i915_pm_rpm@module-reload.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144608v1/bat-adls-6/igt@i915_pm_rpm@module-reload.html
    - fi-tgl-1115g4:      [PASS][7] -> [FAIL][8] ([i915#13633])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16098/fi-tgl-1115g4/igt@i915_pm_rpm@module-reload.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144608v1/fi-tgl-1115g4/igt@i915_pm_rpm@module-reload.html
    - fi-cfl-guc:         [PASS][9] -> [FAIL][10] ([i915#13633])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16098/fi-cfl-guc/igt@i915_pm_rpm@module-reload.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144608v1/fi-cfl-guc/igt@i915_pm_rpm@module-reload.html

  * igt@i915_selftest@live@sanitycheck:
    - bat-arlh-2:         [PASS][11] -> [INCOMPLETE][12] ([i915#12445]) +1 other test incomplete
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16098/bat-arlh-2/igt@i915_selftest@live@sanitycheck.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144608v1/bat-arlh-2/igt@i915_selftest@live@sanitycheck.html

  * igt@i915_selftest@live@workarounds:
    - bat-mtlp-9:         [PASS][13] -> [DMESG-FAIL][14] ([i915#12061])
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16098/bat-mtlp-9/igt@i915_selftest@live@workarounds.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144608v1/bat-mtlp-9/igt@i915_selftest@live@workarounds.html

  
#### Possible fixes ####

  * igt@dmabuf@all-tests:
    - bat-apl-1:          [INCOMPLETE][15] ([i915#12904]) -> [PASS][16] +1 other test pass
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16098/bat-apl-1/igt@dmabuf@all-tests.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144608v1/bat-apl-1/igt@dmabuf@all-tests.html

  * igt@i915_selftest@live@workarounds:
    - bat-arls-6:         [DMESG-FAIL][17] ([i915#12061]) -> [PASS][18] +1 other test pass
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16098/bat-arls-6/igt@i915_selftest@live@workarounds.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144608v1/bat-arls-6/igt@i915_selftest@live@workarounds.html

  
  [i915#12061]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12061
  [i915#12445]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12445
  [i915#12904]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12904
  [i915#13633]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13633


Build changes
-------------

  * Linux: CI_DRM_16098 -> Patchwork_144608v1

  CI-20190529: 20190529
  CI_DRM_16098: 656e731586e568a8633c0bd16d28dcec8d67f237 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_8227: 8227
  Patchwork_144608v1: 656e731586e568a8633c0bd16d28dcec8d67f237 @ git://anongit.freedesktop.org/gfx-ci/linux

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144608v1/index.html

[-- Attachment #2: Type: text/html, Size: 6011 bytes --]