From: Eric Anholt <eric@anholt.net>
To: intel-gfx@lists.freedesktop.org
Cc: Ben Widawsky <ben@bwidawsk.net>
Subject: Re: [PATCH v2] drm/i915: add register read IOCTL
Date: Wed, 18 Jul 2012 10:14:46 -0700 [thread overview]
Message-ID: <87pq7txa7t.fsf@eliezer.anholt.net> (raw)
In-Reply-To: <1342116066-12164-1-git-send-email-ben@bwidawsk.net>
[-- Attachment #1.1: Type: text/plain, Size: 1121 bytes --]
Ben Widawsky <ben@bwidawsk.net> writes:
> The interface's immediate purpose is to do synchronous timestamp queries
> as required by GL_TIMESTAMP. The GPU has a register for reading the
> timestamp but because that would normally require root access through
> libpciaccess, the IOCTL can provide this service instead.
>
> Currently the implementation whitelists only the render ring timestamp
> register, because that is the only thing we need to expose at this time.
>
> v2: make size implicit based on the register offset
> Add a generation check
> diff --git a/include/drm/i915_drm.h b/include/drm/i915_drm.h
> index 8cc7083..fbe7757 100644
> --- a/include/drm/i915_drm.h
> +++ b/include/drm/i915_drm.h
> @@ -203,6 +203,7 @@ typedef struct _drm_i915_sarea {
> #define DRM_I915_GEM_WAIT 0x2c
> #define DRM_I915_GEM_CONTEXT_CREATE 0x2d
> #define DRM_I915_GEM_CONTEXT_DESTROY 0x2e
> +#define DRM_I915_REG_READ 0x30
Is 0x2f some other outstanding ioctl?
Other than that,
Reviewed-by: Eric Anholt <eric@anholt.net>
Note: we have requests both by Arjan and by Valve for the functionality
that this patch will allow.
[-- Attachment #1.2: Type: application/pgp-signature, Size: 197 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2012-07-18 17:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-12 0:07 [PATCH] drm/i915: add register read IOCTL Ben Widawsky
2012-07-12 0:08 ` [PATCH] reg_read: basic register read ioctl test Ben Widawsky
2012-07-12 8:06 ` Daniel Vetter
2012-07-12 7:58 ` [PATCH] drm/i915: add register read IOCTL Daniel Vetter
2012-07-12 8:11 ` Chris Wilson
2012-07-12 18:01 ` [PATCH v2] " Ben Widawsky
2012-07-12 18:01 ` [PATCH] reg_read: basic register read ioctl test Ben Widawsky
2012-07-18 17:14 ` Eric Anholt [this message]
2012-07-18 17:22 ` [PATCH v2] drm/i915: add register read IOCTL Ben Widawsky
2012-07-18 18:12 ` Daniel Vetter
2012-07-12 19:42 ` [PATCH] " Eric Anholt
2012-07-12 20:08 ` Ben Widawsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pq7txa7t.fsf@eliezer.anholt.net \
--to=eric@anholt.net \
--cc=ben@bwidawsk.net \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox